Re: svn commit: r351472 - head/sys/fs/nullfs

2019-08-26 Thread Cy Schubert
It works for me too. Thank you. -- Cheers, Cy Schubert FreeBSD UNIX: Web: http://www.FreeBSD.org The need of the many outweighs the greed of the few. In message , Mateusz Guzik writes: > This survived light testing for me: > > https://people.freebsd.org/~mjg/unionfs-interlock.d

Re: svn commit: r351472 - head/sys/fs/nullfs

2019-08-26 Thread Mateusz Guzik
This survived light testing for me: https://people.freebsd.org/~mjg/unionfs-interlock.diff note unionfs instantly panics with DEBUG_VFS_LOCKS regardless of any of this work. On 8/27/19, Cy Schubert wrote: > In message > om> > , Mateusz Guzik writes: >> On 8/27/19, Cy Schubert wrote: >> > Maki

svn commit: r351540 - in head/sys/dev/cxgbe: . cxgbei iw_cxgbe tom

2019-08-26 Thread Navdeep Parhar
Author: np Date: Tue Aug 27 04:19:40 2019 New Revision: 351540 URL: https://svnweb.freebsd.org/changeset/base/351540 Log: cxgbe/t4_tom: Initialize all TOE connection parameters in one place. Remove now-redundant items from toepcb and synq_entry and the code to support them. Let the driv

Re: svn commit: r351472 - head/sys/fs/nullfs

2019-08-26 Thread Cy Schubert
In message , Mateusz Guzik writes: > On 8/27/19, Cy Schubert wrote: > > Making progress: > > > > Unread portion of the kernel message buffer: > > > > panic: null_unlock: LK_INTERLOCK passed > > cpuid = 2 > > time = 1566868081 > > KDB: stack backtrace: > > db_trace_self_wrapper() at db_trace_self_

Re: svn commit: r351472 - head/sys/fs/nullfs

2019-08-26 Thread Mateusz Guzik
On 8/27/19, Cy Schubert wrote: > Making progress: > > Unread portion of the kernel message buffer: > > panic: null_unlock: LK_INTERLOCK passed > cpuid = 2 > time = 1566868081 > KDB: stack backtrace: > db_trace_self_wrapper() at db_trace_self_wrapper+0x2b/frame > 0xfe0054a954e0 > vpanic() at vp

Re: svn commit: r351472 - head/sys/fs/nullfs

2019-08-26 Thread Cy Schubert
Making progress: Unread portion of the kernel message buffer: panic: null_unlock: LK_INTERLOCK passed cpuid = 2 time = 1566868081 KDB: stack backtrace: db_trace_self_wrapper() at db_trace_self_wrapper+0x2b/frame 0xfe0054a954e0 vpanic() at vpanic+0x19d/frame 0xfe0054a95530 panic() at pani

Re: svn commit: r351514 - head/sys/dev/pci

2019-08-26 Thread Alexander Motin
On 26.08.2019 18:00, Conrad Meyer wrote: > On Mon, Aug 26, 2019 at 10:27 AM Alexander Motin wrote: >> >> Author: mav >> Date: Mon Aug 26 17:27:36 2019 >> New Revision: 351514 >> ... >> - device_printf(dev, >> - "HotPlug Command Timed Out - forcing detach\n"); >> -

svn commit: r351524 - head/sys/dev/cxgbe/tom

2019-08-26 Thread Navdeep Parhar
Author: np Date: Tue Aug 27 01:16:02 2019 New Revision: 351524 URL: https://svnweb.freebsd.org/changeset/base/351524 Log: cxgbe/t4_tom: Limit work requests with immediate payload to a single descriptor. The per-tid tx credits are in demand during active Tx and it's best not to use too many

Re: svn commit: r351472 - head/sys/fs/nullfs

2019-08-26 Thread Mateusz Guzik
Sorry for the half-assed patch. I have a patch to remove the flags argument and the change above was port of it. Try this please: https://people.freebsd.org/~mjg/patches/vop_unlock-interlock2.diff On 8/27/19, Cy Schubert wrote: > It won't build. Did you intend VOP_UNLOCK(vp,LK_INTERLOCK)? > > --

Re: svn commit: r351472 - head/sys/fs/nullfs

2019-08-26 Thread Cy Schubert
It won't build. Did you intend VOP_UNLOCK(vp,LK_INTERLOCK)? --- vfs_subr.o --- /opt/src/svn-current/sys/kern/vfs_subr.c:1037:17: error: too few arguments to function call, expected 2, have 1 VOP_UNLOCK(vp); ~~ ^ ./vnode_if.h:873:1: note: '

Re: svn commit: r351522 - in head: sbin/ifconfig share/man/man4 sys/conf sys/kern sys/modules sys/modules/ktls_ocf sys/net sys/netinet sys/netinet/tcp_stacks sys/netinet6 sys/opencrypto sys/sys tools/

2019-08-26 Thread John Baldwin
On 8/26/19 5:01 PM, John Baldwin wrote: > Author: jhb > Date: Tue Aug 27 00:01:56 2019 > New Revision: 351522 > URL: https://svnweb.freebsd.org/changeset/base/351522 > > Log: > Add kernel-side support for in-kernel TLS. The length of the commit message notwithstanding, there is still quite a bi

svn commit: r351522 - in head: sbin/ifconfig share/man/man4 sys/conf sys/kern sys/modules sys/modules/ktls_ocf sys/net sys/netinet sys/netinet/tcp_stacks sys/netinet6 sys/opencrypto sys/sys tools/t...

2019-08-26 Thread John Baldwin
Author: jhb Date: Tue Aug 27 00:01:56 2019 New Revision: 351522 URL: https://svnweb.freebsd.org/changeset/base/351522 Log: Add kernel-side support for in-kernel TLS. KTLS adds support for in-kernel framing and encryption of Transport Layer Security (1.0-1.2) data on TCP sockets. KTLS onl

Re: svn commit: r351514 - head/sys/dev/pci

2019-08-26 Thread Conrad Meyer
Hi Alexander, On Mon, Aug 26, 2019 at 10:27 AM Alexander Motin wrote: > > Author: mav > Date: Mon Aug 26 17:27:36 2019 > New Revision: 351514 > ... > - device_printf(dev, > - "HotPlug Command Timed Out - forcing detach\n"); > - sc->flags &= ~(PCIB_HOT

svn commit: r351518 - head/sys/vm

2019-08-26 Thread Mark Johnston
Author: markj Date: Mon Aug 26 20:20:10 2019 New Revision: 351518 URL: https://svnweb.freebsd.org/changeset/base/351518 Log: Fix a few nits in vm_pqbatch_process_page(). - Don't bother masking off non-queue state flags when loading the page's atomic state, since it is only required for

Re: svn commit: r351472 - head/sys/fs/nullfs

2019-08-26 Thread Cy Schubert
Thanks. My lunch hour is over. I'll try this after I get home from $JOB. -- Cheers, Cy Schubert FreeBSD UNIX: Web: http://www.FreeBSD.org The need of the many outweighs the greed of the few. In message , Mateusz Guzik writes: > Does this do the trick for you? > > https://people

Re: svn commit: r351472 - head/sys/fs/nullfs

2019-08-26 Thread Cy Schubert
In message , Cy Schubert wr ites: > On August 26, 2019 8:40:50 AM PDT, Cy Schubert wr > ote: > >On August 26, 2019 7:11:22 AM PDT, Cy Schubert > > wrote: > >>In message <6c6bf3a4-dc07-4d9a-9a5f-fa075bf53...@cschubert.com>, Cy > >>Schubert wr > >>ites: > >>> On August 24, 2019 10:13:15 PM PDT, Mat

Re: svn commit: r351472 - head/sys/fs/nullfs

2019-08-26 Thread Mateusz Guzik
Does this do the trick for you? https://people.freebsd.org/~mjg/vop_unlock-interlock.diff On 8/26/19, Cy Schubert wrote: > On August 26, 2019 8:40:50 AM PDT, Cy Schubert > wrote: >>On August 26, 2019 7:11:22 AM PDT, Cy Schubert >> wrote: >>>In message <6c6bf3a4-dc07-4d9a-9a5f-fa075bf53...@cschu

Re: svn commit: r351423 - in head: . sbin/ping6 sbin/ping6/tests

2019-08-26 Thread Bjoern A. Zeeb
On 26 Aug 2019, at 16:31, John Baldwin wrote: On 8/26/19 1:59 AM, Bjoern A. Zeeb wrote: In other notes (and I keep saying that), I can see a world when ping doesn’t exist anymore as IPv4 doesn’t exist anymore (I partially already live in that world). The fact that people still do not prepare

Re: svn commit: r351472 - head/sys/fs/nullfs

2019-08-26 Thread Cy Schubert
On August 26, 2019 8:40:50 AM PDT, Cy Schubert wrote: >On August 26, 2019 7:11:22 AM PDT, Cy Schubert > wrote: >>In message <6c6bf3a4-dc07-4d9a-9a5f-fa075bf53...@cschubert.com>, Cy >>Schubert wr >>ites: >>> On August 24, 2019 10:13:15 PM PDT, Mateusz Guzik >>wrote: >>> >Author: mjg >>> >Date: Su

Re: svn commit: r351423 - in head: . sbin/ping6 sbin/ping6/tests

2019-08-26 Thread Jan Sucan
On 26. 8. 2019 1:58, Alan Somers wrote: Jan (please keep him CCed on replies) has been musing about the same thing. That might satisfy everyone. Jan, would it be straightforward to implement? -Alan I forgot to answer the question whether it would be straightforward. It depends on how fast it s

svn commit: r351516 - head/sys/dev/acpica

2019-08-26 Thread Alexander Motin
Author: mav Date: Mon Aug 26 17:54:19 2019 New Revision: 351516 URL: https://svnweb.freebsd.org/changeset/base/351516 Log: Announce PCI Segment Groups supported to PCI host _OSC. According to ACPI 6.3 specification: The OS sets this bit to 1 if it supports PCI Segment Groups as define

svn commit: r351514 - head/sys/dev/pci

2019-08-26 Thread Alexander Motin
Author: mav Date: Mon Aug 26 17:27:36 2019 New Revision: 351514 URL: https://svnweb.freebsd.org/changeset/base/351514 Log: Don't consider PCIe hot-plug command timeout fatal. According to my tests and errata to several generations of Intel CPUs, PCIe hot-plug command completion reporting

Re: svn commit: r351456 - head/sys/amd64/amd64

2019-08-26 Thread Conrad Meyer
r351456 only loosened restrictions on some of the less common thread types; it was accidentally necessary, but not sufficient. 351494, 351495, and 351496 (at least) are also necessary, once the issue was identified. Best, Conrad On Mon, Aug 26, 2019 at 9:25 AM John Baldwin wrote: > > On 8/24/19

svn commit: r351513 - in head/sys: crypto/des kgssapi/krb5 netsmb opencrypto

2019-08-26 Thread John Baldwin
Author: jhb Date: Mon Aug 26 17:25:07 2019 New Revision: 351513 URL: https://svnweb.freebsd.org/changeset/base/351513 Log: Stop using des_cblock * for arguments to DES functions. This amounts to a char ** since it is a char[8] *. Evil casts mostly resolved the fact that what was actually

Re: svn commit: r351456 - head/sys/amd64/amd64

2019-08-26 Thread Konstantin Belousov
On Mon, Aug 26, 2019 at 09:25:11AM -0700, John Baldwin wrote: > On 8/24/19 1:43 PM, Konstantin Belousov wrote: > > On Sat, Aug 24, 2019 at 11:47:52AM -0700, Conrad Meyer wrote: > >> On Sat, Aug 24, 2019 at 9:15 AM Konstantin Belousov > >> wrote: > >>> > >>> On Sat, Aug 24, 2019 at 08:49:42AM -070

Re: svn commit: r351423 - in head: . sbin/ping6 sbin/ping6/tests

2019-08-26 Thread John Baldwin
On 8/26/19 1:59 AM, Bjoern A. Zeeb wrote: > In other notes (and I keep saying that), I can see a world when ping > doesn’t exist anymore as IPv4 doesn’t exist anymore (I partially > already live in that world). The fact that people still do not prepare > themselves for this time is a bit strang

Re: svn commit: r351456 - head/sys/amd64/amd64

2019-08-26 Thread John Baldwin
On 8/24/19 1:43 PM, Konstantin Belousov wrote: > On Sat, Aug 24, 2019 at 11:47:52AM -0700, Conrad Meyer wrote: >> On Sat, Aug 24, 2019 at 9:15 AM Konstantin Belousov >> wrote: >>> >>> On Sat, Aug 24, 2019 at 08:49:42AM -0700, Conrad Meyer wrote: Hi Konstantin, What is the motivatio

svn commit: r351512 - head/sys/netinet

2019-08-26 Thread Michael Tuexen
Author: tuexen Date: Mon Aug 26 16:23:47 2019 New Revision: 351512 URL: https://svnweb.freebsd.org/changeset/base/351512 Log: Don't hold the rs_mtx lock while calling malloc(). Reviewed by: rrs@ Sponsored by: Netflix, Inc. Differential Revision:https://reviews.f

svn commit: r351511 - in head/sys/arm64: arm64 include

2019-08-26 Thread Michael Tuexen
Author: tuexen Date: Mon Aug 26 16:12:14 2019 New Revision: 351511 URL: https://svnweb.freebsd.org/changeset/base/351511 Log: Identify eMAG CPU used in Ampere Computing systems. Reviewed by: emaste@ MFC after:1 week Differential Revision:https://reviews.free

Re: svn commit: r351472 - head/sys/fs/nullfs

2019-08-26 Thread Cy Schubert
On August 26, 2019 7:11:22 AM PDT, Cy Schubert wrote: >In message <6c6bf3a4-dc07-4d9a-9a5f-fa075bf53...@cschubert.com>, Cy >Schubert wr >ites: >> On August 24, 2019 10:13:15 PM PDT, Mateusz Guzik >wrote: >> >Author: mjg >> >Date: Sun Aug 25 05:13:15 2019 >> >New Revision: 351472 >> >URL: https:/

Re: svn commit: r351472 - head/sys/fs/nullfs

2019-08-26 Thread Cy Schubert
In message <6c6bf3a4-dc07-4d9a-9a5f-fa075bf53...@cschubert.com>, Cy Schubert wr ites: > On August 24, 2019 10:13:15 PM PDT, Mateusz Guzik wrote: > >Author: mjg > >Date: Sun Aug 25 05:13:15 2019 > >New Revision: 351472 > >URL: https://svnweb.freebsd.org/changeset/base/351472 > > > >Log: > > nullfs

Re: svn commit: r351472 - head/sys/fs/nullfs

2019-08-26 Thread Cy Schubert
On August 24, 2019 10:13:15 PM PDT, Mateusz Guzik wrote: >Author: mjg >Date: Sun Aug 25 05:13:15 2019 >New Revision: 351472 >URL: https://svnweb.freebsd.org/changeset/base/351472 > >Log: > nullfs: reduce areas protected by vnode interlock > >Some places only take the interlock to hold the vnode

Re: svn commit: r351423 - in head: . sbin/ping6 sbin/ping6/tests

2019-08-26 Thread Shawn Webb
On Sun, Aug 25, 2019 at 08:50:11PM -0700, Conrad Meyer wrote: > On Sun, Aug 25, 2019 at 6:47 PM Shawn Webb wrote: > > I wonder if something like this could be done: > > Something like it could be; I suggested so two hours ago. > > > Somewhere in ping(8): > > bool ping6_compat; > > if (strcmp(arg

svn commit: r351509 - head/usr.bin/ktrace

2019-08-26 Thread Edward Tomasz Napierala
Author: trasz Date: Mon Aug 26 10:18:19 2019 New Revision: 351509 URL: https://svnweb.freebsd.org/changeset/base/351509 Log: Make it clear what the userland traces are in the ktrace(1) man page. MFC after:2 weeks Modified: head/usr.bin/ktrace/ktrace.1 Modified: head/usr.bin/ktrace/k

svn commit: r351508 - head/share/man/man7

2019-08-26 Thread Edward Tomasz Napierala
Author: trasz Date: Mon Aug 26 10:16:46 2019 New Revision: 351508 URL: https://svnweb.freebsd.org/changeset/base/351508 Log: .Xr ports(7) and development(7). MFC after:2 weeks Modified: head/share/man/man7/development.7 head/share/man/man7/ports.7 Modified: head/share/man/man7/dev

Re: svn commit: r351423 - in head: . sbin/ping6 sbin/ping6/tests

2019-08-26 Thread Bjoern A. Zeeb
On 25 Aug 2019, at 20:26, alan somers wrote: On Sun, Aug 25, 2019, 2:11 PM Hiroki Sato wrote: Alan Somers wrote in : as> On Sun, Aug 25, 2019 at 1:22 PM Hiroki Sato wrote: as> > as> > Hi, as> > as> > Alan Somers wrote as> > in <201908231522.x7nfmluj068...@repo.freebsd.org>: as> >