Hi Alexander, On Mon, Aug 26, 2019 at 10:27 AM Alexander Motin <m...@freebsd.org> wrote: > > Author: mav > Date: Mon Aug 26 17:27:36 2019 > New Revision: 351514 > ... > - device_printf(dev, > - "HotPlug Command Timed Out - forcing detach\n"); > - sc->flags &= ~(PCIB_HOTPLUG_CMD_PENDING | > PCIB_DETACH_PENDING); > - sc->flags |= PCIB_DETACHING; > - pcib_pcie_hotplug_update(sc, 0, 0, true); > + device_printf(dev, "HotPlug Command Timed Out\n"); > + sc->flags &= ~PCIB_HOTPLUG_CMD_PENDING;
If this case is expected (and it seems like it is, at least in relatively common hardware), and the kernel isn't taking an action based on it anymore (formerly, it would then cause detach), is there any reason to print a message at all? What information should a user glean from the message, or what action should be taken? It seems like Nothing and None, respectively. So perhaps it is better to not print anything in this case? Or maybe mask it behind bootverbose. Best, Conrad _______________________________________________ svn-src-head@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"
