Re: svn commit: r334708 - head/sys/kern

2018-06-07 Thread Ryan Libby
On Thu, Jun 7, 2018 at 10:03 PM, Mateusz Guzik wrote: > On Fri, Jun 8, 2018 at 6:29 AM, Ryan Libby wrote: >> >> On Thu, Jun 7, 2018 at 8:32 PM, Mark Johnston wrote: >> > On Wed, Jun 06, 2018 at 05:03:11PM +0300, Konstantin Belousov wrote: >> >> On Wed, Jun 06, 2018 at 12:57:12PM +, Justin Hi

svn commit: r334832 - head/sys/conf

2018-06-07 Thread Matt Macy
Author: mmacy Date: Fri Jun 8 05:48:36 2018 New Revision: 334832 URL: https://svnweb.freebsd.org/changeset/base/334832 Log: unbreak LINT build after r334804 Modified: head/sys/conf/NOTES Modified: head/sys/conf/NOTES ==

svn commit: r334831 - head/sys/dev/hwpmc

2018-06-07 Thread Matt Macy
Author: mmacy Date: Fri Jun 8 05:48:28 2018 New Revision: 334831 URL: https://svnweb.freebsd.org/changeset/base/334831 Log: hwpmc: fix arm64 INVARIANTS build Modified: head/sys/dev/hwpmc/hwpmc_arm64.c Modified: head/sys/dev/hwpmc/hwpmc_arm64.c ===

svn commit: r334830 - in head/sys: kern net vm

2018-06-07 Thread Mateusz Guzik
Author: mjg Date: Fri Jun 8 05:40:36 2018 New Revision: 334830 URL: https://svnweb.freebsd.org/changeset/base/334830 Log: uma: fix up r334824 Turns out there is code which ends up passing M_ZERO to counters. Since counters zero unconditionally on their own, just ignore drop the flag in

Re: svn commit: r334708 - head/sys/kern

2018-06-07 Thread Konstantin Belousov
On Fri, Jun 08, 2018 at 07:03:04AM +0200, Mateusz Guzik wrote: > Part of the problem is lack of primitives like READ_ONCE/WRITE_ONCE as > seen in the linux kernel, someone should hack up equivalents. Only replying to this statement right now. What is the semantic of the _ONCE operations ? Isn't i

svn commit: r334829 - head/sys/net

2018-06-07 Thread Matt Macy
Author: mmacy Date: Fri Jun 8 05:17:06 2018 New Revision: 334829 URL: https://svnweb.freebsd.org/changeset/base/334829 Log: rtentry_zinit: don't blindly pass through M_ZERO to counter alloc Modified: head/sys/net/route.c Modified: head/sys/net/route.c ===

Re: svn commit: r334819 - head/sys/vm

2018-06-07 Thread Kubilay Kocak
On 8/06/2018 10:15 am, Gleb Smirnoff wrote: > Author: glebius > Date: Fri Jun 8 00:15:08 2018 > New Revision: 334819 > URL: https://svnweb.freebsd.org/changeset/base/334819 > > Log: > UMA memory debugging enabled with INVARIANTS consists of two things: > trashing freed memory and checking tha

Re: svn commit: r334708 - head/sys/kern

2018-06-07 Thread Matthew Macy
> The main codepath which runs into this (... -> cache_lookup -> vhold) most > definitely does not need the fence for production operation. > > What is unclear without audit is whether there are vhold users which need > one. I think the patch is fine to go in if the other VI_FREE place gets a > com

Re: svn commit: r334708 - head/sys/kern

2018-06-07 Thread Mateusz Guzik
On Fri, Jun 8, 2018 at 6:29 AM, Ryan Libby wrote: > On Thu, Jun 7, 2018 at 8:32 PM, Mark Johnston wrote: > > On Wed, Jun 06, 2018 at 05:03:11PM +0300, Konstantin Belousov wrote: > >> On Wed, Jun 06, 2018 at 12:57:12PM +, Justin Hibbits wrote: > >> > Author: jhibbits > >> > Date: Wed Jun 6 1

svn commit: r334828 - head/sys/dev/hwpmc

2018-06-07 Thread Matt Macy
Author: mmacy Date: Fri Jun 8 05:01:09 2018 New Revision: 334828 URL: https://svnweb.freebsd.org/changeset/base/334828 Log: hwpmc: avoid undefined variable on LINT Modified: head/sys/dev/hwpmc/hwpmc_core.c Modified: head/sys/dev/hwpmc/hwpmc_core.c ===

Re: svn commit: r334617 - in head: . etc

2018-06-07 Thread Bryan Drewery
> On Jun 4, 2018, at 11:17, Brad Davis wrote: > > Author: brd > Date: Mon Jun 4 15:17:24 2018 > New Revision: 334617 > URL: https://svnweb.freebsd.org/changeset/base/334617 > > Log: > Move /sys symlink creating out of etc/Makefile. > > This is prep for etc/Makefile going away. > > Approve

svn commit: r334827 - in head/sys: amd64/amd64 arm/arm dev/hwpmc i386/i386 kern mips/atheros mips/cavium powerpc/powerpc sys

2018-06-07 Thread Matt Macy
Author: mmacy Date: Fri Jun 8 04:58:03 2018 New Revision: 334827 URL: https://svnweb.freebsd.org/changeset/base/334827 Log: hwpmc: simplify calling convention for hwpmc interrupt handling pmc_process_interrupt takes 5 arguments when only 3 are needed. cpu is always available in curcpu an

Re: svn commit: r334617 - in head: . etc

2018-06-07 Thread Bryan Drewery
> On Jun 6, 2018, at 16:35, Rodney W. Grimes > wrote: > > >> On Wed, Jun 6, 2018, at 12:33 PM, Rodney W. Grimes wrote: On Tue, Jun 5, 2018, at 1:28 PM, Konstantin Belousov wrote: >> On Wed, Jun 06, 2018 at 01:39:00AM +0700, Eugene Grosbein wrote: >> 06.06.2018 1:26, Konsta

Re: svn commit: r334617 - in head: . etc

2018-06-07 Thread Bryan Drewery
> On Jun 5, 2018, at 16:43, Brad Davis wrote: > > > On Tue, Jun 5, 2018, at 1:07 PM, Renato Botelho wrote: > > On 05/06/18 15:26, Konstantin Belousov wrote: > > > On Tue, Jun 05, 2018 at 12:13:05PM -0600, Brad Davis wrote: > > >> On Tue, Jun 5, 2018, at 10:46 AM, Konstantin Belousov wrote: > >

Re: svn commit: r334708 - head/sys/kern

2018-06-07 Thread Ryan Libby
On Thu, Jun 7, 2018 at 8:32 PM, Mark Johnston wrote: > On Wed, Jun 06, 2018 at 05:03:11PM +0300, Konstantin Belousov wrote: >> On Wed, Jun 06, 2018 at 12:57:12PM +, Justin Hibbits wrote: >> > Author: jhibbits >> > Date: Wed Jun 6 12:57:11 2018 >> > New Revision: 334708 >> > URL: https://svnwe

svn commit: r334826 - head/sys/amd64/amd64

2018-06-07 Thread Mateusz Guzik
Author: mjg Date: Fri Jun 8 04:18:42 2018 New Revision: 334826 URL: https://svnweb.freebsd.org/changeset/base/334826 Log: amd64: remove now unused bzero, bcmp and bcopy. move pagecopy higher up. Modified: head/sys/amd64/amd64/support.S Modified: head/sys/amd64/amd64/support.S ==

Re: svn commit: r334708 - head/sys/kern

2018-06-07 Thread Mark Johnston
On Wed, Jun 06, 2018 at 05:03:11PM +0300, Konstantin Belousov wrote: > On Wed, Jun 06, 2018 at 12:57:12PM +, Justin Hibbits wrote: > > Author: jhibbits > > Date: Wed Jun 6 12:57:11 2018 > > New Revision: 334708 > > URL: https://svnweb.freebsd.org/changeset/base/334708 > > > > Log: > > Add a

svn commit: r334824 - head/sys/vm

2018-06-07 Thread Mateusz Guzik
Author: mjg Date: Fri Jun 8 03:16:16 2018 New Revision: 334824 URL: https://svnweb.freebsd.org/changeset/base/334824 Log: uma: remove M_ZERO support for pcpu zones Nothing in the tree uses it and pcpu zones have a fundamentally different use case than the regular zones - they are not sup

Re: svn commit: r334804 - in head/sys: kern modules/tcp modules/tcp/rack netinet netinet/tcp_stacks sys

2018-06-07 Thread Matthew Macy
> > Okay. I believe there might be situations where we may want to still > keep the 'default' stack alive. I know Windows doesn't yet use RACK when > rtt is lesser than 10ms (or something like that), as an example. > Is there any reason RACK wouldn't work for tracking 10us RTTs? If we know we kno

Re: svn commit: r334617 - in head: . etc

2018-06-07 Thread Peter Wemm
On 6/6/18 4:06 PM, Ian Lepore wrote: On Wed, 2018-06-06 at 11:33 -0700, Rodney W. Grimes wrote: On Tue, Jun 5, 2018, at 1:28 PM, Konstantin Belousov wrote: On Wed, Jun 06, 2018 at 01:39:00AM +0700, Eugene Grosbein wrote: 06.06.2018 1:26, Konstantin Belousov wrote: I find it often very usef

Re: svn commit: r334617 - in head: . etc

2018-06-07 Thread Brooks Davis
On Thu, Jun 07, 2018 at 10:17:44PM +0700, Eugene Grosbein wrote: > 07.06.2018 22:00, Brad Davis wrote: > > >> You see, my point is that you can never know beforehand of all > >> challenges a sysadmin faces in fields. > >> And there should be really good reason to break things that work before. >

Re: svn commit: r334617 - in head: . etc

2018-06-07 Thread Eugene Grosbein
07.06.2018 22:35, Brooks Davis wrote: You see, my point is that you can never know beforehand of all challenges a sysadmin faces in fields. And there should be really good reason to break things that work before. Like, solving some significant issue we have with current setup.

Re: svn commit: r334617 - in head: . etc

2018-06-07 Thread Brooks Davis
On Fri, Jun 08, 2018 at 01:39:21AM +0700, Eugene Grosbein wrote: > 07.06.2018 22:35, Brooks Davis wrote: > > You see, my point is that you can never know beforehand of all > challenges a sysadmin faces in fields. > And there should be really good reason to break things that work be

Re: svn commit: r334617 - in head: . etc

2018-06-07 Thread Brad Davis
On Thu, Jun 7, 2018, at 12:47 PM, Peter Wemm wrote: > On 6/6/18 4:06 PM, Ian Lepore wrote: > > > On Wed, 2018-06-06 at 11:33 -0700, Rodney W. Grimes wrote: > >>> > >>> On Tue, Jun 5, 2018, at 1:28 PM, Konstantin Belousov wrote: > On Wed, Jun 06, 2018 at 01:39:00AM +0700, Eugene Grosbein wrote

svn commit: r334823 - head/usr.bin/top

2018-06-07 Thread Eitan Adler
Author: eadler Date: Fri Jun 8 02:03:51 2018 New Revision: 334823 URL: https://svnweb.freebsd.org/changeset/base/334823 Log: top(1): remove some unneeded indirection Modified: head/usr.bin/top/machine.c Modified: head/usr.bin/top/machine.c ===

Re: svn commit: r334804 - in head/sys: kern modules/tcp modules/tcp/rack netinet netinet/tcp_stacks sys

2018-06-07 Thread hiren panchasara
On 06/07/18 at 08:58P, Randall Stewart wrote: > > > > On Jun 7, 2018, at 6:01 PM, hiren panchasara > > wrote: > > > > On 06/07/18 at 06:18P, Randall Stewart wrote: > >> Author: rrs > >> Date: Thu Jun 7 18:18:13 2018 > >> New Revision: 334804 > >> URL: https://svnweb.freebsd.org/changeset/base

svn commit: r334822 - head/usr.bin/top

2018-06-07 Thread Eitan Adler
Author: eadler Date: Fri Jun 8 01:55:47 2018 New Revision: 334822 URL: https://svnweb.freebsd.org/changeset/base/334822 Log: top(1): fix several style & const related issues - use parens for return - put function names on newline - sprinkle const where possible Modified: head/usr.bi

svn commit: r334821 - head/usr.bin/grep

2018-06-07 Thread Kyle Evans
Author: kevans Date: Fri Jun 8 01:25:07 2018 New Revision: 334821 URL: https://svnweb.freebsd.org/changeset/base/334821 Log: bsdgrep(1): Slooowly peel away the chunky onion (or peel off the band-aid, whatever floats your boat) This addresses two separate issues: 1.) Nothing withi

Re: svn commit: r334804 - in head/sys: kern modules/tcp modules/tcp/rack netinet netinet/tcp_stacks sys

2018-06-07 Thread Randall Stewart via svn-src-head
> On Jun 7, 2018, at 6:01 PM, hiren panchasara > wrote: > > On 06/07/18 at 06:18P, Randall Stewart wrote: >> Author: rrs >> Date: Thu Jun 7 18:18:13 2018 >> New Revision: 334804 >> URL: https://svnweb.freebsd.org/changeset/base/334804 >> >> Log: >> This commit brings in a new refactored TC

svn commit: r334820 - head/sys/amd64/amd64

2018-06-07 Thread Mateusz Guzik
Author: mjg Date: Fri Jun 8 00:47:24 2018 New Revision: 334820 URL: https://svnweb.freebsd.org/changeset/base/334820 Log: amd64: fix a retarded bug in memset memset fills the target buffer from a byte-sized value passed in as the second argument. The fully-sized (8 bytes) register c

svn commit: r334819 - head/sys/vm

2018-06-07 Thread Gleb Smirnoff
Author: glebius Date: Fri Jun 8 00:15:08 2018 New Revision: 334819 URL: https://svnweb.freebsd.org/changeset/base/334819 Log: UMA memory debugging enabled with INVARIANTS consists of two things: trashing freed memory and checking that allocated memory is properly trashed, and also of keepin

svn commit: r334817 - in head/usr.sbin/cron: cron crontab lib

2018-06-07 Thread Gleb Smirnoff
Author: glebius Date: Thu Jun 7 22:38:40 2018 New Revision: 334817 URL: https://svnweb.freebsd.org/changeset/base/334817 Log: Add new functionality and syntax to cron(1) to allow to run jobs at a given interval, which is counted in seconds since exit of the previous invocation of the job. E

Re: svn commit: r334804 - in head/sys: kern modules/tcp modules/tcp/rack netinet netinet/tcp_stacks sys

2018-06-07 Thread hiren panchasara
On 06/07/18 at 06:18P, Randall Stewart wrote: > Author: rrs > Date: Thu Jun 7 18:18:13 2018 > New Revision: 334804 > URL: https://svnweb.freebsd.org/changeset/base/334804 > > Log: > This commit brings in a new refactored TCP stack called Rack. > Rack includes the following features: >- A

svn commit: r334816 - head/sys/powerpc/ofw

2018-06-07 Thread Breno Leitao
Author: leitao Date: Thu Jun 7 21:24:21 2018 New Revision: 334816 URL: https://svnweb.freebsd.org/changeset/base/334816 Log: Fix excise_initrd_region() to support 32- and 64-bit initrd params. Changed excise_initrd_region to support both 32- and 64-bit values for linux,initrd-start and l

Re: svn commit: r334617 - in head: . etc

2018-06-07 Thread Emmanuel Vadot
On Thu, 7 Jun 2018 07:33:29 + Alexey Dokuchaev wrote: > On Wed, Jun 06, 2018 at 11:27:20PM +0300, Konstantin Belousov wrote: > > On Wed, Jun 06, 2018 at 02:06:48PM -0600, Ian Lepore wrote: > > > ... > > > I don't understand the drama over this. rc.d startup scripts are > > > *binaries*. > >

svn commit: r334815 - head/sys/modules/tcp/rack

2018-06-07 Thread Randall Stewart
Author: rrs Date: Thu Jun 7 20:57:12 2018 New Revision: 334815 URL: https://svnweb.freebsd.org/changeset/base/334815 Log: Take out the stack alias inadvertantly added by my commit. Reported by: Peter Lei Modified: head/sys/modules/tcp/rack/Makefile Modified: head/sys/modules/tcp/rack/

svn commit: r334814 - head/sbin/dump

2018-06-07 Thread Kirk McKusick
Author: mckusick Date: Thu Jun 7 20:49:01 2018 New Revision: 334814 URL: https://svnweb.freebsd.org/changeset/base/334814 Log: Ensure proper initialization of superblock. Submitted by: Diane Bruce Modified: head/sbin/dump/main.c Modified: head/sbin/dump/main.c =

svn commit: r334813 - head/sys/sys

2018-06-07 Thread Randall Stewart
Author: rrs Date: Thu Jun 7 19:57:55 2018 New Revision: 334813 URL: https://svnweb.freebsd.org/changeset/base/334813 Log: Fix build issue with const and volatile and the myriad ways that the various compliers treat this. The only safe prefetch appears to be for AMD. The other compilers ei

Re: svn commit: r334791 - head/share/mk

2018-06-07 Thread Alexey Dokuchaev
On Thu, Jun 07, 2018 at 03:37:50PM -0400, Bryan Drewery wrote: > On 6/7/18 1:05 PM, Alexey Dokuchaev wrote: > > ... > > Actually, `sed q' is sufficient. > > I'll stick with -n 1p as I think it is more clear. Fair enough, the latter one is indeed a bit cryptic. Thanks! ./danfe __

svn commit: r334811 - head/share/mk

2018-06-07 Thread Bryan Drewery
Author: bdrewery Date: Thu Jun 7 19:39:11 2018 New Revision: 334811 URL: https://svnweb.freebsd.org/changeset/base/334811 Log: Use simpler sed invocation. X-MFC-With: r334791 MFC after:1 week Submitted by: danfe Modified: head/share/mk/bsd.linker.mk Modified: head/share/mk/bs

Re: svn commit: r334702 - head/sys/sys

2018-06-07 Thread Mark Millard via svn-src-head
Jonathan T. Looney jtl at freebsd.org wrote on Thu Jun 7 03:00:00 UTC 2018 : > I believe the theory is that the compiler (remember, this is > __builtin_memset) can optimize away portions of the zeroing, or can > optimize zeroing for small sizes. > > For example, imagine you do this: > > stru

Re: svn commit: r334791 - head/share/mk

2018-06-07 Thread Bryan Drewery
On 6/7/18 1:05 PM, Alexey Dokuchaev wrote: > On Thu, Jun 07, 2018 at 04:44:20PM +, Alexey Dokuchaev wrote: >> On Thu, Jun 07, 2018 at 04:16:22PM +, Bryan Drewery wrote: >>> New Revision: 334791 >>> URL: https://svnweb.freebsd.org/changeset/base/334791 >>> >>> Log: >>> Stop using head(1) w

svn commit: r334810 - in head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs: . sys

2018-06-07 Thread Benno Rice
Author: benno Date: Thu Jun 7 18:59:32 2018 New Revision: 334810 URL: https://svnweb.freebsd.org/changeset/base/334810 Log: Break recursion involving getnewvnode and zfs_rmnode. When we're at our vnode limit, getnewvnode will call into the vnode LRU cache to free up vnodes. If the vnode

svn commit: r334809 - head/contrib/netbsd-tests/usr.bin/grep

2018-06-07 Thread Kyle Evans
Author: kevans Date: Thu Jun 7 18:53:39 2018 New Revision: 334809 URL: https://svnweb.freebsd.org/changeset/base/334809 Log: netbsd-tests: bsdgrep(1): Add a test for -m, too Modified: head/contrib/netbsd-tests/usr.bin/grep/t_grep.sh Modified: head/contrib/netbsd-tests/usr.bin/grep/t_grep.sh

svn commit: r334808 - head/usr.bin/grep

2018-06-07 Thread Kyle Evans
Author: kevans Date: Thu Jun 7 18:38:48 2018 New Revision: 334808 URL: https://svnweb.freebsd.org/changeset/base/334808 Log: bsdgrep(1): Don't initialize fts_flags twice Admittedly, this is a clang-scan complaint... but it wasn't wrong. fts_flags is initialized by all cases in the switch

svn commit: r334807 - head/usr.bin/grep

2018-06-07 Thread Kyle Evans
Author: kevans Date: Thu Jun 7 18:36:12 2018 New Revision: 334807 URL: https://svnweb.freebsd.org/changeset/base/334807 Log: bsdgrep(1): whoops, garbage collect the now write-only variable Modified: head/usr.bin/grep/util.c Modified: head/usr.bin/grep/util.c

svn commit: r334806 - head/usr.bin/grep

2018-06-07 Thread Kyle Evans
Author: kevans Date: Thu Jun 7 18:27:58 2018 New Revision: 334806 URL: https://svnweb.freebsd.org/changeset/base/334806 Log: bsdgrep(1): Do some less dirty things with return types Neither procfile nor grep_tree return anything meaningful to their callers. None of the callers actually ca

svn commit: r334805 - head/release/amd64

2018-06-07 Thread Marius Strobl
Author: marius Date: Thu Jun 7 18:24:25 2018 New Revision: 334805 URL: https://svnweb.freebsd.org/changeset/base/334805 Log: - Once we have shifted arguments up to thrice, base-bits-dir is $1 rather than $4. Introduce $BASEBITSDIR for clarity and to avoid repeating this mistake in the f

svn commit: r334804 - in head/sys: kern modules/tcp modules/tcp/rack netinet netinet/tcp_stacks sys

2018-06-07 Thread Randall Stewart
Author: rrs Date: Thu Jun 7 18:18:13 2018 New Revision: 334804 URL: https://svnweb.freebsd.org/changeset/base/334804 Log: This commit brings in a new refactored TCP stack called Rack. Rack includes the following features: - A different SACK processing scheme (the old sack structures are no

svn commit: r334803 - head/contrib/netbsd-tests/usr.bin/grep

2018-06-07 Thread Kyle Evans
Author: kevans Date: Thu Jun 7 18:06:01 2018 New Revision: 334803 URL: https://svnweb.freebsd.org/changeset/base/334803 Log: netbsd-tests: grep(1): Add test for -c flag Someone might be inclined to accidentally break this. someone might have written said test because they broke it locall

Re: svn commit: r334791 - head/share/mk

2018-06-07 Thread Alexey Dokuchaev
On Thu, Jun 07, 2018 at 04:44:20PM +, Alexey Dokuchaev wrote: > On Thu, Jun 07, 2018 at 04:16:22PM +, Bryan Drewery wrote: > > New Revision: 334791 > > URL: https://svnweb.freebsd.org/changeset/base/334791 > > > > Log: > > Stop using head(1) which is not available in installworld. > > ..

svn commit: r334799 - head/sys/amd64/amd64

2018-06-07 Thread Konstantin Belousov
Author: kib Date: Thu Jun 7 17:04:34 2018 New Revision: 334799 URL: https://svnweb.freebsd.org/changeset/base/334799 Log: Account for dmap limit when selecting the pages for the bootstrap pagetables. physmap[] can be inconsistent with the physical memory limit due to buggy bios, or to

Re: svn commit: r334791 - head/share/mk

2018-06-07 Thread Alexey Dokuchaev
On Thu, Jun 07, 2018 at 04:16:22PM +, Bryan Drewery wrote: > New Revision: 334791 > URL: https://svnweb.freebsd.org/changeset/base/334791 > > Log: > Stop using head(1) which is not available in installworld. > ... > @@ -49,7 +49,7 @@ ${var}= ${${var}.${${X_}_ld_hash}} > > .if ${ld} ==

svn commit: r334791 - head/share/mk

2018-06-07 Thread Bryan Drewery
Author: bdrewery Date: Thu Jun 7 16:16:22 2018 New Revision: 334791 URL: https://svnweb.freebsd.org/changeset/base/334791 Log: Stop using head(1) which is not available in installworld. installworld should not be executing this anyhow but there is some obscure case doing it still. The h

svn commit: r334790 - head/sys/dev/ofw

2018-06-07 Thread Breno Leitao
Author: leitao Date: Thu Jun 7 15:59:08 2018 New Revision: 334790 URL: https://svnweb.freebsd.org/changeset/base/334790 Log: dev/ofw: Fix ofw_fdt_getprop() return values to match documentation Fix the behavior of ofw_fdt_getprop() and ofw_fdt_getprop() functions to match the documentatio

svn commit: r334788 - head/cddl/lib/libdtrace

2018-06-07 Thread Sean Bruno
Author: sbruno Date: Thu Jun 7 15:27:07 2018 New Revision: 334788 URL: https://svnweb.freebsd.org/changeset/base/334788 Log: Unbreak dtrace runtime for udp after svn r334719 SO_REUSEPORT commit. Submitted by: Johannes Lundberg Sponsored by: Limeligght Networks Modified: head/cddl/lib

Re: svn commit: r334617 - in head: . etc

2018-06-07 Thread Eugene Grosbein
07.06.2018 22:00, Brad Davis wrote: >> You see, my point is that you can never know beforehand of all >> challenges a sysadmin faces in fields. >> And there should be really good reason to break things that work before. >> Like, solving some significant issue we have with current setup. Do we >>

Re: svn commit: r334617 - in head: . etc

2018-06-07 Thread Brad Davis
On Thu, Jun 7, 2018, at 8:46 AM, Eugene Grosbein wrote: > 07.06.2018 20:17, Brad Davis wrote: > > >>> I don't understand the drama over this. rc.d startup scripts are > >>> *binaries*. > >> > >> This is plain wrong. Example: before introduction of rcNG we had /etc/ > >> rc.serial > >> supposed to

svn commit: r334786 - head/sys/x86/x86

2018-06-07 Thread Andriy Gapon
Author: avg Date: Thu Jun 7 14:46:52 2018 New Revision: 334786 URL: https://svnweb.freebsd.org/changeset/base/334786 Log: x86: reorganize code that deals with unexpected NMI-s Expected NMI-s are those than are either generated by the software (such as a CPU sending NMI to other CPU) or g

Re: svn commit: r334617 - in head: . etc

2018-06-07 Thread Eugene Grosbein
07.06.2018 20:17, Brad Davis wrote: >>> I don't understand the drama over this. rc.d startup scripts are >>> *binaries*. >> >> This is plain wrong. Example: before introduction of rcNG we had /etc/ >> rc.serial >> supposed to be user-modified to contain local settings for serial ports >> (unclud

svn commit: r334785 - head/sys/x86/x86

2018-06-07 Thread Andriy Gapon
Author: avg Date: Thu Jun 7 14:23:31 2018 New Revision: 334785 URL: https://svnweb.freebsd.org/changeset/base/334785 Log: expand descriptions of x86 panic_on_nmi and kdb_on_nmi sysctls The descriptions were as terse as the variable names and they did not explain additional conditions for

Re: svn commit: r334277 - in head: contrib/libpcap contrib/ofed/usr.lib/3 contrib/pf/pflogd contrib/wpa/src/l2_packet lib lib/libpcap share/mk usr.sbin/cxgbetool

2018-06-07 Thread John Baldwin
On 5/31/18 3:41 AM, Hans Petter Selasky wrote: > On 05/30/18 22:10, Xin LI wrote: >> This would make vendor/libpcap/dist history replace head/contrib/libpcap, >> which effectively discards all FreeBSD local changes for base purposes, and >> hides its change history. Is this intentional? If not, co

Re: svn commit: r334719 - in head: cddl/lib/libdtrace lib/libc/sys sys/kern sys/netinet sys/netinet6 sys/sys

2018-06-07 Thread Shawn Webb
On Wed, Jun 06, 2018 at 03:45:57PM +, Sean Bruno wrote: > Author: sbruno > Date: Wed Jun 6 15:45:57 2018 > New Revision: 334719 > URL: https://svnweb.freebsd.org/changeset/base/334719 > > Log: > Load balance sockets with new SO_REUSEPORT_LB option. > > This patch adds a new socket opti

Re: svn commit: r334616 - head/sys/dev/acpica

2018-06-07 Thread Mark Johnston
On Thu, Jun 07, 2018 at 09:54:01AM -0400, John Baldwin wrote: > On 6/4/18 10:56 AM, Mark Johnston wrote: > > Author: markj > > Date: Mon Jun 4 14:56:02 2018 > > New Revision: 334616 > > URL: https://svnweb.freebsd.org/changeset/base/334616 > > > > Log: > > Fix the NUMA build for non-x86 platfor

svn commit: r334784 - in head/sys: conf dev/md

2018-06-07 Thread Breno Leitao
Author: leitao Date: Thu Jun 7 13:57:34 2018 New Revision: 334784 URL: https://svnweb.freebsd.org/changeset/base/334784 Log: md: use prestaged mfs_root On PowerNV systems, the rootfs is passed through kexec, which loads the rootfs into memory and set two fdt entries to describe where the

Re: svn commit: r334616 - head/sys/dev/acpica

2018-06-07 Thread John Baldwin
On 6/4/18 10:56 AM, Mark Johnston wrote: > Author: markj > Date: Mon Jun 4 14:56:02 2018 > New Revision: 334616 > URL: https://svnweb.freebsd.org/changeset/base/334616 > > Log: > Fix the NUMA build for non-x86 platforms. > > acpi_map_pxm_to_vm_domainid() is currently implemented only on x8

Re: svn commit: r334702 - head/sys/sys

2018-06-07 Thread Ravi Pokala
-Original Message- From: Brooks Davis Date: 2018-06-07, Thursday at 09:27 To: Ravi Pokala Cc: "Jonathan T. Looney" , Mateusz Guzik , Mateusz Guzik , src-committers , , Subject: Re: svn commit: r334702 - head/sys/sys > On Thu, Jun 07, 2018 at 12:01:00AM -0400, Ravi Pokala wrote: >>> I

Re: svn commit: r334617 - in head: . etc

2018-06-07 Thread Brad Davis
On Thu, Jun 7, 2018, at 1:29 AM, Alexey Dokuchaev wrote: > On Wed, Jun 06, 2018 at 01:02:25PM -0600, Brad Davis wrote: > > On Wed, Jun 6, 2018, at 12:33 PM, Rodney W. Grimes wrote: > > > ... > > > So each installworld would wipe over the top of any localmod /etc/rc.d/ > > > and other stuff that mgh

Re: svn commit: r334702 - head/sys/sys

2018-06-07 Thread Brooks Davis
On Thu, Jun 07, 2018 at 12:01:00AM -0400, Ravi Pokala wrote: > > I believe the theory is that the compiler (remember, this is > > __builtin_memset) can optimize away portions of the zeroing, or can > > optimize zeroing for small sizes. > > Ahhh! I didn't consider that the compiler would be doing

svn commit: r334783 - head/sys/vm

2018-06-07 Thread Jonathan T. Looney
Author: jtl Date: Thu Jun 7 13:29:54 2018 New Revision: 334783 URL: https://svnweb.freebsd.org/changeset/base/334783 Log: Fix a typo in vm_domain_set(). When a domain crosses into the severe range, we need to set the domain bit from the vm_severe_domains bitset (instead of clearing it).

Re: svn commit: r334617 - in head: . etc

2018-06-07 Thread Brad Davis
On Wed, Jun 6, 2018, at 2:35 PM, Rodney W. Grimes wrote: > > > On Wed, Jun 6, 2018, at 12:33 PM, Rodney W. Grimes wrote: > > > > > > > > On Tue, Jun 5, 2018, at 1:28 PM, Konstantin Belousov wrote: > > > > > On Wed, Jun 06, 2018 at 01:39:00AM +0700, Eugene Grosbein wrote: > > > > > > 06.06.2018 1:

svn commit: r334782 - head/etc/rc.d

2018-06-07 Thread Kristof Provost
Author: kp Date: Thu Jun 7 13:16:53 2018 New Revision: 334782 URL: https://svnweb.freebsd.org/changeset/base/334782 Log: ipfw: fix status if ipfw.ko is not loaded If the ipfw module is not loaded the net.inet.ip.fw.enable OID does not exist, which leads the script to report errors and in

Re: svn commit: r334617 - in head: . etc

2018-06-07 Thread Brad Davis
On Wed, Jun 6, 2018, at 6:20 PM, Eugene Grosbein wrote: > 07.06.2018 3:06, Ian Lepore wrote: > > > I don't understand the drama over this. rc.d startup scripts are > > *binaries*. > > This is plain wrong. Example: before introduction of rcNG we had /etc/ > rc.serial > supposed to be user-modifie

svn commit: r334781 - head/etc/rc.d

2018-06-07 Thread Kristof Provost
Author: kp Date: Thu Jun 7 13:14:09 2018 New Revision: 334781 URL: https://svnweb.freebsd.org/changeset/base/334781 Log: ipfw: fix whitespace No functional changes. Modified: head/etc/rc.d/ipfw Modified: head/etc/rc.d/ipfw ===

svn commit: r334779 - head/sys/net

2018-06-07 Thread Eric Joyner
Author: erj Date: Thu Jun 7 13:03:07 2018 New Revision: 334779 URL: https://svnweb.freebsd.org/changeset/base/334779 Log: iflib: Record TCP checksum info in iflib when TCP checksum is requested ixl(4) (when it switches over to using iflib) devices need the TCP header length in order to d

svn commit: r334778 - head/sys/compat/linuxkpi/common/include/linux

2018-06-07 Thread Hans Petter Selasky
Author: hselasky Date: Thu Jun 7 11:44:11 2018 New Revision: 334778 URL: https://svnweb.freebsd.org/changeset/base/334778 Log: Define ARCH_KMALLOC_MINALIGN in the LinuxKPI. Submitted by: Johannes Lundberg MFC after:1 week Sponsored by: Mellanox Technologies Sponsored by: Limelig

svn commit: r334777 - head/sys/compat/linuxkpi/common/include/linux

2018-06-07 Thread Hans Petter Selasky
Author: hselasky Date: Thu Jun 7 11:41:42 2018 New Revision: 334777 URL: https://svnweb.freebsd.org/changeset/base/334777 Log: Wrap timespec64 into timespec in the LinuxKPI. Submitted by: Johannes Lundberg MFC after:1 week Sponsored by: Mellanox Technologies Sponsored by: Limeli

svn commit: r334774 - head/sys/compat/linuxkpi/common/include/linux

2018-06-07 Thread Hans Petter Selasky
Author: hselasky Date: Thu Jun 7 11:29:07 2018 New Revision: 334774 URL: https://svnweb.freebsd.org/changeset/base/334774 Log: Implement the dev_pm_set_driver_flags() function macro in the LinuxKPI. Submitted by: Johannes Lundberg MFC after:1 week Sponsored by: Mellanox Technologi

Re: svn commit: r334617 - in head: . etc

2018-06-07 Thread Alexey Dokuchaev
On Wed, Jun 06, 2018 at 11:27:20PM +0300, Konstantin Belousov wrote: > On Wed, Jun 06, 2018 at 02:06:48PM -0600, Ian Lepore wrote: > > ... > > I don't understand the drama over this. rc.d startup scripts are > > *binaries*. No, they are not, they are scripts. > I proposed to move them somewhere,

Re: svn commit: r334617 - in head: . etc

2018-06-07 Thread Alexey Dokuchaev
[ CC list trimmed, was too long ] On Thu, Jun 07, 2018 at 01:16:01PM +0200, Emmanuel Vadot wrote: > On Thu, 7 Jun 2018 07:33:29 + > Alexey Dokuchaev wrote: > > On Wed, Jun 06, 2018 at 11:27:20PM +0300, Konstantin Belousov wrote: > > > I proposed to move them somewhere, e.g. to /sbin/rc* or to

svn commit: r334775 - head/sys/compat/linuxkpi/common/include/linux

2018-06-07 Thread Hans Petter Selasky
Author: hselasky Date: Thu Jun 7 11:34:59 2018 New Revision: 334775 URL: https://svnweb.freebsd.org/changeset/base/334775 Log: Move the EXPORT_SYMBOL_XXX() function macros into own header file. Submitted by: Johannes Lundberg MFC after:1 week Sponsored by: Mellanox Technologies

svn commit: r334773 - in head: share/man/man4 sys/modules

2018-06-07 Thread Justin Hibbits
Author: jhibbits Date: Thu Jun 7 11:25:36 2018 New Revision: 334773 URL: https://svnweb.freebsd.org/changeset/base/334773 Log: Build nvme modules for powerpc, and install man pages NVMe builds for powerpc now, so just build modules for all powerpc targets, and install NVMe man pages for

Re: svn commit: r333744 - in head/sys: kern sys

2018-06-07 Thread Peter Holm
On Wed, Jun 06, 2018 at 10:00:48PM -0700, Matthew Macy wrote: > Try r334756 and then send me your scripts for any panics you can produce. > The datagram test now runs without issues. I ran the few (40) network test I have, without finding any problems. - Peter > -M > > On Wed, Jun 6, 2018 at 7

Re: svn commit: r334617 - in head: . etc

2018-06-07 Thread Baptiste Daroussin
On Wed, Jun 06, 2018 at 11:27:20PM +0300, Konstantin Belousov wrote: > On Wed, Jun 06, 2018 at 02:06:48PM -0600, Ian Lepore wrote: > > On Wed, 2018-06-06 at 11:33 -0700, Rodney W. Grimes wrote: > > > > > > > > > > > > On Tue, Jun 5, 2018, at 1:28 PM, Konstantin Belousov wrote: > > > > > > > > >

Re: svn commit: r334617 - in head: . etc

2018-06-07 Thread Alexey Dokuchaev
On Wed, Jun 06, 2018 at 01:02:25PM -0600, Brad Davis wrote: > On Wed, Jun 6, 2018, at 12:33 PM, Rodney W. Grimes wrote: > > ... > > So each installworld would wipe over the top of any localmod /etc/rc.d/ > > and other stuff that mght exist? > > One of the reasons that etc/Makefile is detached from

svn commit: r334769 - head/sys/kern

2018-06-07 Thread Alan Cox
Author: alc Date: Thu Jun 7 07:48:50 2018 New Revision: 334769 URL: https://svnweb.freebsd.org/changeset/base/334769 Log: When pidctrl_daemon() is called multiple times within an interval, it should use the cumulative error to calculate the output. Modified: head/sys/kern/subr_pidctrl.c M