Re: svn commit: r328430 - head/sbin/devd

2018-01-26 Thread Mark Millard via svn-src-head
Ian Lepore ian at freebsd.org wrote on Fri Jan 26 16:56:09 UTC 2018 : > Modern compilers will warn about a class with virtual functions and no > virtual dtor, so just blindly including it is more harmful than > prophylactic these days, IMO. More reliable is to have non-virtual destructors be, say

Re: svn commit: r328456 - head/share/man/man7

2018-01-26 Thread Rodney W. Grimes
[ Charset UTF-8 unsupported, converting... ] > Author: trasz > Date: Sat Jan 27 00:09:43 2018 > New Revision: 328456 > URL: https://svnweb.freebsd.org/changeset/base/328456 > > Log: > Remove mention of sys/boot/ from hier(7), it doesn't exist anymore. > > MFC after: 2 weeks I do not belie

svn commit: r328457 - head/lib/libc/mips/gen

2018-01-26 Thread John Baldwin
Author: jhb Date: Sat Jan 27 00:39:49 2018 New Revision: 328457 URL: https://svnweb.freebsd.org/changeset/base/328457 Log: Clarify some comments in the MIPS makecontext(). - N32 and N64 do not have a $a0-3 gap. - Use 'sp += 4' to skip over the gap for O32 rather than '+= i'. It doesn

Re: svn commit: r328456 - head/share/man/man7

2018-01-26 Thread Conrad Meyer
This isn't quite right — it's now located in src/stand. On Fri, Jan 26, 2018 at 4:09 PM, Edward Tomasz Napierala wrote: > Author: trasz > Date: Sat Jan 27 00:09:43 2018 > New Revision: 328456 > URL: https://svnweb.freebsd.org/changeset/base/328456 > > Log: > Remove mention of sys/boot/ from hie

svn commit: r328456 - head/share/man/man7

2018-01-26 Thread Edward Tomasz Napierala
Author: trasz Date: Sat Jan 27 00:09:43 2018 New Revision: 328456 URL: https://svnweb.freebsd.org/changeset/base/328456 Log: Remove mention of sys/boot/ from hier(7), it doesn't exist anymore. MFC after:2 weeks Modified: head/share/man/man7/hier.7 Modified: head/share/man/man7/hier.

svn commit: r328455 - in head/sys/cam: . scsi

2018-01-26 Thread Scott Long
Author: scottl Date: Fri Jan 26 23:56:07 2018 New Revision: 328455 URL: https://svnweb.freebsd.org/changeset/base/328455 Log: Move CAM_PERIPH_PRINT() to cam_periph.h Modified: head/sys/cam/cam_periph.h head/sys/cam/scsi/scsi_da.c Modified: head/sys/cam/cam_periph.h

svn commit: r328453 - head/sys/opencrypto

2018-01-26 Thread John Baldwin
Author: jhb Date: Fri Jan 26 23:21:50 2018 New Revision: 328453 URL: https://svnweb.freebsd.org/changeset/base/328453 Log: Move per-operation data out of the csession structure. Create a struct cryptop_data which contains state needed for a single symmetric crypto operation and move that

svn commit: r328452 - head/sys/cam/nvme

2018-01-26 Thread Warner Losh
Author: imp Date: Fri Jan 26 23:14:46 2018 New Revision: 328452 URL: https://svnweb.freebsd.org/changeset/base/328452 Log: Fix a sleepable malloc in ndastart. We shouldn't be sleeping here. Return ENOMEM when we can't malloc a buffer for the DSM TRIM. This should fix the WITNESS warnings sim

svn commit: r328450 - head/sys/dev/ntb

2018-01-26 Thread Alexander Motin
Author: mav Date: Fri Jan 26 22:22:26 2018 New Revision: 328450 URL: https://svnweb.freebsd.org/changeset/base/328450 Log: Use bus_dmamem_alloc(9) KPI instead of contigmalloc(9). I suppose it should make this code NUMA-aware with recent NUMA drop-in, trying to allocate shared memory buffe

svn commit: r328449 - in head/stand: i386/gptboot mips/beri/loader mips/uboot powerpc/kboot uboot/common uboot/lib

2018-01-26 Thread Warner Losh
Author: imp Date: Fri Jan 26 22:22:21 2018 New Revision: 328449 URL: https://svnweb.freebsd.org/changeset/base/328449 Log: Tag unreachable places as such. I left the while (1); in place since in this context we want to busy wait to stop. Suggested by: pfg@ Modified: head/stand/i386/gpt

Re: svn commit: r328437 - in head/stand: i386/gptboot libsa

2018-01-26 Thread Warner Losh
On Fri, Jan 26, 2018 at 2:05 PM, Ed Maste wrote: > On 26 January 2018 at 12:13, Warner Losh wrote: > > Author: imp > > Date: Fri Jan 26 17:13:00 2018 > > New Revision: 328437 > > URL: https://svnweb.freebsd.org/changeset/base/328437 > > > > Log: > > Split panic routine > ... > > -extern void

svn commit: r328448 - head/stand/powerpc/kboot

2018-01-26 Thread Warner Losh
Author: imp Date: Fri Jan 26 21:51:13 2018 New Revision: 328448 URL: https://svnweb.freebsd.org/changeset/base/328448 Log: Make exit() never return until host_exit can be written. Modified: head/stand/powerpc/kboot/main.c Modified: head/stand/powerpc/kboot/main.c

svn commit: r328447 - head/stand/mips/beri/boot2

2018-01-26 Thread Warner Losh
Author: imp Date: Fri Jan 26 21:51:09 2018 New Revision: 328447 URL: https://svnweb.freebsd.org/changeset/base/328447 Log: BERI isn't BTX, so we don't have to provide exit(). Just remove it since it's unused. Modified: head/stand/mips/beri/boot2/boot2.c Modified: head/stand/mips/beri/boot2

svn commit: r328446 - head/stand/uboot/lib

2018-01-26 Thread Warner Losh
Author: imp Date: Fri Jan 26 21:50:59 2018 New Revision: 328446 URL: https://svnweb.freebsd.org/changeset/base/328446 Log: Now that exit is __dead2, we need to tag ub_exit() as __dead2. To do that, we have to put a while (1); after the syscall that will never return to fake out the compiler.

Re: svn commit: r328437 - in head/stand: i386/gptboot libsa

2018-01-26 Thread Ed Maste
On 26 January 2018 at 12:13, Warner Losh wrote: > Author: imp > Date: Fri Jan 26 17:13:00 2018 > New Revision: 328437 > URL: https://svnweb.freebsd.org/changeset/base/328437 > > Log: > Split panic routine ... > -extern voidexit(int); > +extern voidexit(int) __dead2; MIPS

Re: svn commit: r328346 - in head/sys: fs/ext2fs ufs/ffs ufs/ufs

2018-01-26 Thread Pedro Giffuni
On 01/26/18 06:36, Bruce Evans wrote: On Thu, 25 Jan 2018, Pedro Giffuni wrote: On 25/01/2018 14:24, Bruce Evans wrote: ... This code only works because (if?) nfs is the only caller and nfs never passes insane values. I am starting to think that we should simply match uio_resid and set i

svn commit: r328445 - head/sys/cam/scsi

2018-01-26 Thread Scott Long
Author: scottl Date: Fri Jan 26 18:42:28 2018 New Revision: 328445 URL: https://svnweb.freebsd.org/changeset/base/328445 Log: Fix a cut-and-paste error in a panic message Modified: head/sys/cam/scsi/scsi_da.c Modified: head/sys/cam/scsi/scsi_da.c =

svn commit: r328444 - head/sys/kern

2018-01-26 Thread Kirk McKusick
Author: mckusick Date: Fri Jan 26 18:17:11 2018 New Revision: 328444 URL: https://svnweb.freebsd.org/changeset/base/328444 Log: For many years the message "fsync: giving up on dirty" has occationally appeared on UFS/FFS filesystems. In some cases it was promptly followed by a panic of "softd

svn commit: r328443 - head/contrib/lua/src

2018-01-26 Thread Warner Losh
Author: imp Date: Fri Jan 26 17:56:20 2018 New Revision: 328443 URL: https://svnweb.freebsd.org/changeset/base/328443 Log: Gross hack to omit printing hex floating point when the lua number type is int64. While lua is setup for the representation, it's not setup to properly print the numbers

svn commit: r328442 - head/sys/arm/freescale/imx

2018-01-26 Thread Ian Lepore
Author: ian Date: Fri Jan 26 17:55:17 2018 New Revision: 328442 URL: https://svnweb.freebsd.org/changeset/base/328442 Log: Add support to the imx5/6 watchdog for the external reset signal. Also, if the "power down" watchdog used by the ROM boot code is still active when the regular watchdog

svn commit: r328441 - head/stand/libsa

2018-01-26 Thread Warner Losh
Author: imp Date: Fri Jan 26 17:40:13 2018 New Revision: 328441 URL: https://svnweb.freebsd.org/changeset/base/328441 Log: abort() should be marked __dead2 since it won't return. Modified: head/stand/libsa/stand.h Modified: head/stand/libsa/stand.h ===

svn commit: r328440 - head/contrib/lua/src

2018-01-26 Thread Warner Losh
Author: imp Date: Fri Jan 26 17:24:25 2018 New Revision: 328440 URL: https://svnweb.freebsd.org/changeset/base/328440 Log: Preserve the original luaconf.h in a convenient place. Clients will almost certainly need to override this, so reinforce that. If that's not hte case, clients can always

svn commit: r328439 - head/stand/libsa

2018-01-26 Thread Warner Losh
Author: imp Date: Fri Jan 26 17:13:09 2018 New Revision: 328439 URL: https://svnweb.freebsd.org/changeset/base/328439 Log: Provide abs form stdlib.h. Sponsored by: Netflix Modified: head/stand/libsa/Makefile head/stand/libsa/stand.h Modified: head/stand/libsa/Makefile

svn commit: r328438 - head/stand/libsa

2018-01-26 Thread Warner Losh
Author: imp Date: Fri Jan 26 17:13:04 2018 New Revision: 328438 URL: https://svnweb.freebsd.org/changeset/base/328438 Log: Implement abort() as a call to panic. Sponsored by: Netflix Added: head/stand/libsa/abort.c (contents, props changed) Modified: head/stand/libsa/Makefile head/

svn commit: r328437 - in head/stand: i386/gptboot libsa

2018-01-26 Thread Warner Losh
Author: imp Date: Fri Jan 26 17:13:00 2018 New Revision: 328437 URL: https://svnweb.freebsd.org/changeset/base/328437 Log: Split panic routine Split panic routine so that the 'Hit Any Key to continue' behavior can be overriden. Sponsored by: Netflix Modified: head/stand/i386/gptbo

Re: svn commit: r328430 - head/sbin/devd

2018-01-26 Thread Ian Lepore
On Thu, 2018-01-25 at 22:59 -0700, Warner Losh wrote: > On Thu, Jan 25, 2018 at 10:02 PM, Matt Joras wrote: > > > > > On Thu, Jan 25, 2018 at 8:52 PM, Warner Losh wrote: > > > > > > > > > > > > On Thu, Jan 25, 2018 at 9:40 PM, Eitan Adler wrote: > > > > > > > > > > > > Author: eadler > >

Re: svn commit: r328430 - head/sbin/devd

2018-01-26 Thread Mark Millard via svn-src-head
Warner Losh imp at bsdimp.com wrote on Fri Jan 26 06:02:04 UTC 2018 : > It's a flaw in C++ that you have a choice here. All dtors should be > virtual because you never know when you'll have new derived classes and > have to hunt down a hard-to-find bug because you didn't go back and make it > vir

Re: svn commit: r328417 - in head/sys: contrib/ipfilter/netinet fs/nfs fs/nfsclient fs/nfsserver netinet nfsclient sys

2018-01-26 Thread Cy Schubert
In message <201801252225.w0pmpdvq023...@repo.freebsd.org>, Conrad Meyer writes: > Author: cem > Date: Thu Jan 25 22:25:13 2018 > New Revision: 328417 > URL: https://svnweb.freebsd.org/changeset/base/328417 > > Log: > style: Remove remaining deprecated MALLOC/FREE macros > > Mechanically rep

Re: svn commit: r328346 - in head/sys: fs/ext2fs ufs/ffs ufs/ufs

2018-01-26 Thread Bruce Evans
On Thu, 25 Jan 2018, Pedro Giffuni wrote: On 25/01/2018 14:24, Bruce Evans wrote: ... This code only works because (if?) nfs is the only caller and nfs never passes insane values. I am starting to think that we should simply match uio_resid and set it to ssize_t. Returning the value to int

Re: svn commit: r328430 - head/sbin/devd

2018-01-26 Thread Bruce Evans
On Fri, 26 Jan 2018, Ed Schouten wrote: static void usage(void) __dead2; This should be spelled: [[noreturn]] static void usage(); That would be as silly as __dead2, and has a worse syntactic style (attributes before the return type mess up the formatting). It is obvious even to lint that u

svn commit: r328436 - head/sys/compat/linuxkpi/common/src

2018-01-26 Thread Hans Petter Selasky
Author: hselasky Date: Fri Jan 26 10:49:02 2018 New Revision: 328436 URL: https://svnweb.freebsd.org/changeset/base/328436 Log: Decouple Linux files from the belonging character device right after open in the LinuxKPI. This is done by calling finit() just before returning a magic value of EN

Re: svn commit: r328430 - head/sbin/devd

2018-01-26 Thread Bruce Evans
On Thu, 25 Jan 2018, Warner Losh wrote: On Thu, Jan 25, 2018 at 9:40 PM, Eitan Adler wrote: Author: eadler Date: Fri Jan 26 04:40:41 2018 New Revision: 328430 URL: https://svnweb.freebsd.org/changeset/base/328430 Log: devd: minor nits - mark usage as noreturn - config does not need a

Re: svn commit: r328402 - head/sys/dev/usb/controller

2018-01-26 Thread Emmanuel Vadot
On Thu, 25 Jan 2018 17:14:52 + Ruslan Bukin wrote: > On Thu, Jan 25, 2018 at 06:12:04PM +0100, Emmanuel Vadot wrote: > > > Log: > > > Add basic driver for Qualcomm USB 2.0 EHCI controller. > > > This driver relies on system initialization in u-boot. > > > > > > Tested on DragonBoard

svn commit: r328435 - head/sys/powerpc/powerpc

2018-01-26 Thread Wojciech Macek
Author: wma Date: Fri Jan 26 09:38:40 2018 New Revision: 328435 URL: https://svnweb.freebsd.org/changeset/base/328435 Log: PPC: Add place for NULL chars in intrnames In a corner case we could fall into OOB error. Authored by: Patryk Duda Submitted by: Wojciech Mac

svn commit: r328434 - head/usr.sbin/daemon

2018-01-26 Thread Maxim Konovalov
Author: maxim Date: Fri Jan 26 08:52:28 2018 New Revision: 328434 URL: https://svnweb.freebsd.org/changeset/base/328434 Log: o A command line flag for the syslog_facility fixed in the SYNOPSIS. PR: 225441 Modified: head/usr.sbin/daemon/daemon.8 Modified: head/usr.sbin/daemon/d

svn commit: r328433 - head/lib/libc/sys

2018-01-26 Thread Maxim Konovalov
Author: maxim Date: Fri Jan 26 08:38:26 2018 New Revision: 328433 URL: https://svnweb.freebsd.org/changeset/base/328433 Log: o EMFILE errno documented. PR: 219209 Submitted by: yuri (with minor adjustment) Reviewed by: brooks Modified: head/lib/libc/sys/shmat.2 Modified: