svn commit: r303656 - head/sys/netinet

2016-08-01 Thread Sepherosa Ziehau
Author: sephe Date: Tue Aug 2 06:36:47 2016 New Revision: 303656 URL: https://svnweb.freebsd.org/changeset/base/303656 Log: tcp/lro: Implement hash table for LRO entries. This significantly improves HTTP workload performance and reduces HTTP workload latency. Reviewed by: rrs, gall

svn commit: r303655 - head/sys/kern

2016-08-01 Thread Mateusz Guzik
Author: mjg Date: Tue Aug 2 03:05:59 2016 New Revision: 303655 URL: https://svnweb.freebsd.org/changeset/base/303655 Log: locks: fix compilation for KDTRACE_HOOKS && !ADAPTIVE_* case Reported by: Michael Butler Modified: head/sys/kern/kern_mutex.c head/sys/kern/kern_rwlock.c head/

Re: svn commit: r303650 - head/sys/opencrypto

2016-08-01 Thread Conrad Meyer
That would be difficult, as this is completely dead code in base. It could be accessed through the /dev/crypto device by a port, however. You haven't convinced me there is a security issue. Cheers, Conrad On Mon, Aug 1, 2016 at 4:58 PM, Shawn Webb wrote: > Adding CTurt to see if he wants to tak

svn commit: r303652 - head/sys/kern

2016-08-01 Thread Mateusz Guzik
Author: mjg Date: Tue Aug 2 00:15:08 2016 New Revision: 303652 URL: https://svnweb.freebsd.org/changeset/base/303652 Log: locks: fix up ifdef guards introduced in r303643 Both sx and rwlocks had copy-pasted ADAPTIVE_MUTEXES instead of the correct define. MFC after:1 week Modifi

Re: svn commit: r303650 - head/sys/opencrypto

2016-08-01 Thread Conrad Meyer
Hey Shawn, I don't think this is security-related despite being a bug in crypto-adjacent code. At best it's a DoS, I think. Cheers, Conrad On Mon, Aug 1, 2016 at 4:15 PM, Shawn Webb wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA512 > > > > On August 1, 2016 6:57:03 PM EDT, "Conrad E.

Re: svn commit: r303650 - head/sys/opencrypto

2016-08-01 Thread Shawn Webb
Adding CTurt to see if he wants to take a stab at writing a PoC exploit. It'd be cool for an offensive researcher to determine if it's simply a DoS. But regardless, a security fix is a security fix. All currently-supported branches really should be updated. Thanks, Shawn On Mon, Aug 01, 2016 at

Re: svn commit: r303650 - head/sys/opencrypto

2016-08-01 Thread Shawn Webb
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 On August 1, 2016 6:57:03 PM EDT, "Conrad E. Meyer" wrote: >Author: cem >Date: Mon Aug 1 22:57:03 2016 >New Revision: 303650 >URL: https://svnweb.freebsd.org/changeset/base/303650 > >Log: > opencrypto AES-ICM: Fix heap corruption typo > >This er

svn commit: r303651 - head/sys/net

2016-08-01 Thread Conrad E. Meyer
Author: cem Date: Mon Aug 1 23:07:31 2016 New Revision: 303651 URL: https://svnweb.freebsd.org/changeset/base/303651 Log: rtentry: Initialize rt_mtx with MTX_NEW The "rtentry" zone does not use UMA_ZONE_ZINIT, so it is invalid to assume the mutex's memory will be zero. Without MTX_NEW,

Re: svn commit: r303643 - in head/sys: kern sys

2016-08-01 Thread Mateusz Guzik
On Mon, Aug 01, 2016 at 09:48:37PM +, Mateusz Guzik wrote: > Implement trivial backoff for locking primitives. > [..] > For simplicity, this first thouch implementation only modifies spinning > loops where the lock owner is running. spin mutexes and thread lock were > not modified. >

svn commit: r303650 - head/sys/opencrypto

2016-08-01 Thread Conrad E. Meyer
Author: cem Date: Mon Aug 1 22:57:03 2016 New Revision: 303650 URL: https://svnweb.freebsd.org/changeset/base/303650 Log: opencrypto AES-ICM: Fix heap corruption typo This error looks like it was a simple copy-paste typo in the original commit for this code (r275732). PR:

svn commit: r303648 - head/sys/ddb

2016-08-01 Thread Conrad E. Meyer
Author: cem Date: Mon Aug 1 22:41:50 2016 New Revision: 303648 URL: https://svnweb.freebsd.org/changeset/base/303648 Log: Fix ddb "show proc" to show full arguments PR: 200052 Submitted by: Chang-Hsien Tsai Modified: head/sys/ddb/db_ps.c Modified: head/sys/ddb/db_ps.c

svn commit: r303647 - in head/sys/dev/cxgbe: . iw_cxgbe

2016-08-01 Thread John Baldwin
Author: jhb Date: Mon Aug 1 22:39:51 2016 New Revision: 303647 URL: https://svnweb.freebsd.org/changeset/base/303647 Log: Store the offset of the KDOORBELL and GTS registers in the softc. VF devices use a different register layout than PF devices. Storing the offset in a value in the so

svn commit: r303646 - head/sys/ofed/drivers/infiniband/ulp/ipoib

2016-08-01 Thread Mark Johnston
Author: markj Date: Mon Aug 1 22:22:11 2016 New Revision: 303646 URL: https://svnweb.freebsd.org/changeset/base/303646 Log: ipoib: Bound the number of egress mbufs buffered during pathrec lookups. In pathological situations where the master subnet manager becomes unresponsive for an exte

svn commit: r303645 - head/sys/dev/pci

2016-08-01 Thread John Baldwin
Author: jhb Date: Mon Aug 1 22:19:23 2016 New Revision: 303645 URL: https://svnweb.freebsd.org/changeset/base/303645 Log: Disable PCI hotplug support for slots with power controllers. After further review of the spec, I do not think the current HotPlug code handles slots with power contr

svn commit: r303643 - in head/sys: kern sys

2016-08-01 Thread Mateusz Guzik
Author: mjg Date: Mon Aug 1 21:48:37 2016 New Revision: 303643 URL: https://svnweb.freebsd.org/changeset/base/303643 Log: Implement trivial backoff for locking primitives. All current spinning loops retry an atomic op the first chance they get, which leads to performance degradation unde

svn commit: r303638 - head/sys/dev/e1000

2016-08-01 Thread Sean Bruno
Author: sbruno Date: Mon Aug 1 21:19:51 2016 New Revision: 303638 URL: https://svnweb.freebsd.org/changeset/base/303638 Log: r293331 mistakingly failed to add an assignment of paddr to the rxbuf but only in the NETMAP code. This lead to the NETMAP code paths passing nothing up to userland.

svn commit: r303637 - head/sys/geom

2016-08-01 Thread Andrey V. Elsukov
Author: ae Date: Mon Aug 1 20:54:54 2016 New Revision: 303637 URL: https://svnweb.freebsd.org/changeset/base/303637 Log: Do not invoke resize event if initial disk size is zero. Some disks report the size only after first opening. And due to the events are asynchronous, some consumers can

svn commit: r303636 - head/sys/ofed/drivers/infiniband/core

2016-08-01 Thread Mark Johnston
Author: markj Date: Mon Aug 1 20:29:09 2016 New Revision: 303636 URL: https://svnweb.freebsd.org/changeset/base/303636 Log: MFV be9130cc9: "IB/cma: Check for GID on listening devices first" This is an optimization that improves IB connection setup times. Discussed with: hselasky

svn commit: r303635 - head/sys/ofed/drivers/infiniband/core

2016-08-01 Thread Mark Johnston
Author: markj Date: Mon Aug 1 20:27:11 2016 New Revision: 303635 URL: https://svnweb.freebsd.org/changeset/base/303635 Log: MFV 29f27e847: "IB/cma: Use cached gids" This addresses a regression from an earlier upstream change which caused cma_acquire_dev() to bypass the port GID cache and

svn commit: r303631 - head/usr.sbin/bsdinstall/scripts

2016-08-01 Thread Dimitry Andric
Author: dim Date: Mon Aug 1 19:49:42 2016 New Revision: 303631 URL: https://svnweb.freebsd.org/changeset/base/303631 Log: Fix non-functional bsdinstall services dialog. The most recent version of bsdinstall does not seem to respect any of the checkboxes in the "Choose the services you wo

svn commit: r303630 - in head/sys: boot/zfs cddl/boot/zfs

2016-08-01 Thread Allan Jude
Author: allanjude Date: Mon Aug 1 19:37:43 2016 New Revision: 303630 URL: https://svnweb.freebsd.org/changeset/base/303630 Log: Make boot code and loader check for unsupported ZFS feature flags OpenZFS uses feature flags instead of a zpool version number to track features since the split

svn commit: r303629 - head/usr.bin/indent

2016-08-01 Thread Pedro F. Giffuni
Author: pfg Date: Mon Aug 1 19:24:01 2016 New Revision: 303629 URL: https://svnweb.freebsd.org/changeset/base/303629 Log: indent: Avoid using values of pointers that refer to deallocated space. For now maintain the local style in this file. Reviewed by: jilles Reference: http

Re: svn commit: r303503 - head/sys/kern

2016-08-01 Thread John Baldwin
On Saturday, July 30, 2016 10:38:34 AM Bruce Evans wrote: > On Fri, 29 Jul 2016, John Baldwin wrote: > > > Log: > > Don't treat NOCPU as a valid CPU to CPU_ISSET. > > > > If a thread is created bound to a cpuset it might already be bound before > > it's very first timeslice, and td_lastcpu will

svn commit: r303627 - head/sys/vm

2016-08-01 Thread Alan Cox
Author: alc Date: Mon Aug 1 17:25:07 2016 New Revision: 303627 URL: https://svnweb.freebsd.org/changeset/base/303627 Log: Restore the historical behavior of "sysctl vm.swap_idle_enabled=1". Prior to r254304, we had separate functions for reclamation and laundering (vm_pageout_scan) versus

svn commit: r303626 - in head/sys: netinet netinet6

2016-08-01 Thread Andrew Gallatin
Author: gallatin Date: Mon Aug 1 17:02:21 2016 New Revision: 303626 URL: https://svnweb.freebsd.org/changeset/base/303626 Log: Rework IPV6 TCP path MTU discovery to match IPv4 - Re-write tcp_ctlinput6() to closely mimic the IPv4 tcp_ctlinput() - Now that tcp_ctlinput6() updates t_maxs

Re: svn commit: r303522 - head/sys/dev/cxgbe

2016-08-01 Thread Ian Lepore
On Mon, 2016-08-01 at 16:38 +0100, Bruce Simpson wrote: > "Yes, I know it's not a typewriter. Why is this command not working?" > > Perhaps this errno code should be aliased... and strerror() massaged > in > places... assuming we strictly follow the POSIX. > It's not clear just what point you'r

Re: svn commit: r303522 - head/sys/dev/cxgbe

2016-08-01 Thread Bruce Simpson
On 01/08/16 17:49, Ian Lepore wrote: ... In addition, the strerror() output for ENOTTY says nothing about a typewriter, the text is "Inappropriate ioctl for device." If that semantic gap has already been plugged, ignore my message. ___ svn-src-head@f

Re: svn commit: r303586 - head/bin/sh

2016-08-01 Thread Ian Lepore
On Sun, 2016-07-31 at 13:43 +, Alexey Dokuchaev wrote: > On Sun, Jul 31, 2016 at 01:11:34PM +, Jilles Tjoelker wrote: > > New Revision: 303586 > > URL: https://svnweb.freebsd.org/changeset/base/303586 > > > > Log: > > sh: Fix a clang warning. > > > > Submitted by: bdrewery > >

svn commit: r303625 - head/usr.bin/indent

2016-08-01 Thread Pedro F. Giffuni
Author: pfg Date: Mon Aug 1 16:40:42 2016 New Revision: 303625 URL: https://svnweb.freebsd.org/changeset/base/303625 Log: indent(1): Use a dash in the license headers. Use of the canonical dash avoids indent(1) from reformatting the license headers. Modified: head/usr.bin/indent/args.

svn commit: r303622 - in head/sys: arm/arm conf

2016-08-01 Thread Andrew Turner
Author: andrew Date: Mon Aug 1 16:29:04 2016 New Revision: 303622 URL: https://svnweb.freebsd.org/changeset/base/303622 Log: Split out the FDT parts of the GICv2 interrupt controller driver. This will allow us to add an ACPI attachment for arm64. Obtained from:ABT Systems Ltd M

svn commit: r303623 - in head/sys/mips: broadcom conf

2016-08-01 Thread Landon J. Fuller
Author: landonf Date: Mon Aug 1 16:29:32 2016 New Revision: 303623 URL: https://svnweb.freebsd.org/changeset/base/303623 Log: [mips/broadcom] Fetch UART console configuration from CFE. Relying on the boot loader console configuration allows us to use a common set of device hints for all

svn commit: r303621 - head/sys/dev/cfe

2016-08-01 Thread Landon J. Fuller
Author: landonf Date: Mon Aug 1 16:26:08 2016 New Revision: 303621 URL: https://svnweb.freebsd.org/changeset/base/303621 Log: Sync CFE interface with upstream cfe-1.4.2 release. Approved by: adrian (mentor) Obtained from: https://www.broadcom.com/support/communications-processor

Re: svn commit: r303600 - head/usr.bin/indent

2016-08-01 Thread Pedro Giffuni
On 08/01/16 01:08, Bruce Evans wrote: On Sun, 31 Jul 2016, Xin Li wrote: On 7/31/16 14:36, Pedro F. Giffuni wrote: Log: indent(1): replace function call to bzero with memset. Reference: https://github.com/pstef/freebsd_indent/commit/7422f42f80099c69d34833d7106035dc09230235 Differe

Re: svn commit: r303600 - head/usr.bin/indent

2016-08-01 Thread Pedro Giffuni
On 08/01/16 10:24, Piotr Stefaniak wrote: On 2016-08-01 08:08, Bruce Evans wrote: On Sun, 31 Jul 2016, Xin Li wrote: On 7/31/16 14:36, Pedro F. Giffuni wrote: -bzero(f, sizeof *f); +memset(f, 0, sizeof(struct fstate)); ^ This is much more e

Re: svn commit: r303522 - head/sys/dev/cxgbe

2016-08-01 Thread Bruce Simpson
"Yes, I know it's not a typewriter. Why is this command not working?" Perhaps this errno code should be aliased... and strerror() massaged in places... assuming we strictly follow the POSIX. ___ svn-src-head@freebsd.org mailing list https://lists.free

Re: svn commit: r303574 - head/sys/dev/gpio

2016-08-01 Thread Bruce Simpson
On 31/07/16 07:24, Adrian Chadd wrote: [gpioled] add support for inverting the LED polarity. No, this isn't a star trek science joke - sometimes LEDs are wired up to be active low, so this is needed. Actually, just about every bit of hardware I have interacted with on that level recently

Re: svn commit: r303600 - head/usr.bin/indent

2016-08-01 Thread Pedro Giffuni
On 08/01/16 00:28, Xin Li wrote: On 7/31/16 14:36, Pedro F. Giffuni wrote: Author: pfg Date: Sun Jul 31 21:36:40 2016 New Revision: 303600 URL: https://svnweb.freebsd.org/changeset/base/303600 Log: indent(1): replace function call to bzero with memset. Reference: https://github.com/

Re: svn commit: r303600 - head/usr.bin/indent

2016-08-01 Thread Piotr Stefaniak
On 2016-08-01 08:08, Bruce Evans wrote: > On Sun, 31 Jul 2016, Xin Li wrote: > >> On 7/31/16 14:36, Pedro F. Giffuni wrote: >>> -bzero(f, sizeof *f); >>> +memset(f, 0, sizeof(struct fstate)); >>^ This is much more error-prone >> than sizeof(*f) IMHO

svn commit: r303615 - head/sbin/ipfw

2016-08-01 Thread Andrey V. Elsukov
Author: ae Date: Mon Aug 1 13:38:48 2016 New Revision: 303615 URL: https://svnweb.freebsd.org/changeset/base/303615 Log: An old tables implementation had all tables preallocated, so when user did `ipfw table N flush` it always worked, but now when table N doesn't exist the kernel returns ES

svn commit: r303614 - in head/sys/arm64: arm64 include

2016-08-01 Thread Andrew Turner
Author: andrew Date: Mon Aug 1 12:17:44 2016 New Revision: 303614 URL: https://svnweb.freebsd.org/changeset/base/303614 Log: Add a kernel variable to let the user to select their preferred order between ACPI and FDT. This will be needed on machines with both, e.g. the SoftIron Overdrive 300

svn commit: r303613 - head/share/man/man4

2016-08-01 Thread Julian Elischer
Author: julian Date: Mon Aug 1 12:14:21 2016 New Revision: 303613 URL: https://svnweb.freebsd.org/changeset/base/303613 Log: Man page for the new checksum netgraph module. PR: 206186 Submitted by: Dmitry Vagin MFC after: 1 month Added: head/share/man/man4/ng_checksum.

svn commit: r303612 - in head/sys: modules/netgraph/checksum netgraph

2016-08-01 Thread Julian Elischer
Author: julian Date: Mon Aug 1 12:09:04 2016 New Revision: 303612 URL: https://svnweb.freebsd.org/changeset/base/303612 Log: netgraph module for reconstructing checksums PR: 206108 Submitted by: Dmitry Vagin daemon.ham...@ya.ru MFC after:1 month Added: head/sys/module

svn commit: r303611 - head/sys/netgraph

2016-08-01 Thread Julian Elischer
Author: julian Date: Mon Aug 1 11:34:12 2016 New Revision: 303611 URL: https://svnweb.freebsd.org/changeset/base/303611 Log: slite style changes. There is an incoming patch that rewrites a lot of this module and I want to get the style and whitespace changes in a separate commit (or maybe m

svn commit: r303610 - head/sys/arm64/include

2016-08-01 Thread Andrew Turner
Author: andrew Date: Mon Aug 1 10:36:58 2016 New Revision: 303610 URL: https://svnweb.freebsd.org/changeset/base/303610 Log: Add the fields for the PAR_EL1 register. This is used when performing an address lookup with the AT instructions. Obtained from:ABT Systems Ltd MFC after

Re: svn commit: r303600 - head/usr.bin/indent

2016-08-01 Thread Bruce Evans
On Sun, 31 Jul 2016, Xin Li wrote: On 7/31/16 14:36, Pedro F. Giffuni wrote: Log: indent(1): replace function call to bzero with memset. Reference: https://github.com/pstef/freebsd_indent/commit/7422f42f80099c69d34833d7106035dc09230235 Differential Revision: https://reviews.freebsd.

Re: svn commit: r303586 - head/bin/sh

2016-08-01 Thread Warner Losh
On Sun, Jul 31, 2016 at 11:51 PM, Bruce Evans wrote: > On Sun, 31 Jul 2016, Warner Losh wrote: > >> On Sun, Jul 31, 2016 at 2:16 PM, Jilles Tjoelker wrote: >>> >>> On Sun, Jul 31, 2016 at 01:43:16PM +, Alexey Dokuchaev wrote: On Sun, Jul 31, 2016 at 01:11:34PM +, Jilles Tjoelker

Re: svn commit: r303586 - head/bin/sh

2016-08-01 Thread Bruce Evans
On Sun, 31 Jul 2016, Warner Losh wrote: On Sun, Jul 31, 2016 at 2:16 PM, Jilles Tjoelker wrote: On Sun, Jul 31, 2016 at 01:43:16PM +, Alexey Dokuchaev wrote: On Sun, Jul 31, 2016 at 01:11:34PM +, Jilles Tjoelker wrote: New Revision: 303586 URL: https://svnweb.freebsd.org/changeset/ba

Re: svn commit: r303600 - head/usr.bin/indent

2016-08-01 Thread Xin Li
On 7/31/16 14:36, Pedro F. Giffuni wrote: > Author: pfg > Date: Sun Jul 31 21:36:40 2016 > New Revision: 303600 > URL: https://svnweb.freebsd.org/changeset/base/303600 > > Log: > indent(1): replace function call to bzero with memset. > > Reference: > > https://github.com/pstef/freebsd_