On Sun, 2016-07-31 at 13:43 +0000, Alexey Dokuchaev wrote: > On Sun, Jul 31, 2016 at 01:11:34PM +0000, Jilles Tjoelker wrote: > > New Revision: 303586 > > URL: https://svnweb.freebsd.org/changeset/base/303586 > > > > Log: > > sh: Fix a clang warning. > > > > Submitted by: bdrewery > > > > Modified: > > head/bin/sh/expand.c > > > > Modified: head/bin/sh/expand.c > > =================================================================== > > =========== > > --- head/bin/sh/expand.c Sun Jul 31 12:59:10 2016 (r3 > > 03585) > > +++ head/bin/sh/expand.c Sun Jul 31 13:11:34 2016 (r3 > > 03586) > > @@ -473,7 +473,8 @@ expbackq(union node *cmd, int quoted, in > > if (--in.nleft < 0) { > > if (in.fd < 0) > > break; > > - while ((i = read(in.fd, buf, sizeof buf)) > > < 0 && errno == EINTR); > > + while ((i = read(in.fd, buf, sizeof buf)) > > < 0 && errno == EINTR) > > + ; > > `continue;' would be even better; some tools might barf at stray > semicolon. > > ./danfe >
I strongly agree that the right way to do an empty loop is to use "continue;" on a line by itself. Unfortunately, what style(9) suggests by way of example is a single semicolon on a line by itself with a comment of "/* nothing */" to the right on the same line. Ick. -- Ian _______________________________________________ svn-src-head@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"
