Re: svn commit: r296025 - head/sys/netpfil/pf

On Wed, Feb 24, 2016 at 11:41 PM, Adrian Chadd wrote: > .. what's capping totlen so one doesn't run out of memory? There was a DoS vector before (user controlled io->pfrio_size) and basically the same DoS vector now (either of io->pfrio_size or io->pfrio_size2). This change isn't a regression.

Re: svn commit: r296025 - head/sys/netpfil/pf

.. what's capping totlen so one doesn't run out of memory? -a On 24 February 2016 at 23:33, Kristof Provost wrote: > Author: kp > Date: Thu Feb 25 07:33:59 2016 > New Revision: 296025 > URL: https://svnweb.freebsd.org/changeset/base/296025 > > Log: > pf: Fix possible out-of-bounds write > >

svn commit: r296025 - head/sys/netpfil/pf

Author: kp Date: Thu Feb 25 07:33:59 2016 New Revision: 296025 URL: https://svnweb.freebsd.org/changeset/base/296025 Log: pf: Fix possible out-of-bounds write In the DIOCRSETADDRS ioctl() handler we allocate a table for struct pfr_addrs, which is processed in pfr_set_addrs(). At the users

svn commit: r296024 - head/sys/dev/hyperv/netvsc

Author: sephe Date: Thu Feb 25 07:03:10 2016 New Revision: 296024 URL: https://svnweb.freebsd.org/changeset/base/296024 Log: hyperv/hn: Hold the TX ring lock then drain TX desc buf_ring Reported by: Hongxiong Xian MFC after:1 week Sponsored by: Microsoft OSTC Modified: head/sys

svn commit: r296023 - head/sys/dev/cy

Author: jhibbits Date: Thu Feb 25 04:32:17 2016 New Revision: 296023 URL: https://svnweb.freebsd.org/changeset/base/296023 Log: Fix the build. Pointy-hat to:jhibbits Spotted by: bde Modified: head/sys/dev/cy/cy_pci.c Modified: head/sys/dev/cy/cy_pci.c ===

svn commit: r296022 - head/sys/dev/hyperv/netvsc

Author: sephe Date: Thu Feb 25 03:21:25 2016 New Revision: 296022 URL: https://svnweb.freebsd.org/changeset/base/296022 Log: hyperv/hn: Implement ifnet.if_transmit method It will be turned on by default later. MFC after:1 week Sponsored by: Microsoft OSTC Differential Revision:

svn commit: r296021 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs

Author: smh Date: Thu Feb 25 03:01:24 2016 New Revision: 296021 URL: https://svnweb.freebsd.org/changeset/base/296021 Log: Removed unused label and fix mutex_exit order Remove unused done label from zfs_setacl fixing PVS-Studio V729. Fix mutex_exit order to mirror the mutex_enter order

svn commit: r296020 - head/sys/dev/mrsas

Author: smh Date: Thu Feb 25 02:46:47 2016 New Revision: 296020 URL: https://svnweb.freebsd.org/changeset/base/296020 Log: Fix NULL pointer dereferences Fix NULL pointer dereferences identified as V522 by PVS-Studio. MFC after:1 week Sponsored by: Multiplay Modified: head/sys/

svn commit: r296019 - head/sys/arm/allwinner

Author: jmcneill Date: Thu Feb 25 01:24:02 2016 New Revision: 296019 URL: https://svnweb.freebsd.org/changeset/base/296019 Log: Fix dedicated DMA transfers. For sources and destinations marked "noincr", the previous code was incorrectly programming the dedicated DMA channel control regist

svn commit: r296018 - head/sys/dev/cxgbe

Author: np Date: Thu Feb 25 01:10:56 2016 New Revision: 296018 URL: https://svnweb.freebsd.org/changeset/base/296018 Log: cxgbe(4): Add a sysctl to retrieve the maximum speed/bandwidth supported by a port. dev.cxgbe..max_speed dev.cxl..max_speed Sponsored by: Chelsio Communications

svn commit: r296017 - head/share/misc

Author: jmcneill Date: Thu Feb 25 01:03:34 2016 New Revision: 296017 URL: https://svnweb.freebsd.org/changeset/base/296017 Log: Add myself as src committer. Approved by: gonzo (mentor) Modified: head/share/misc/committers-src.dot Modified: head/share/misc/committers-src.dot ===

svn commit: r296012 - head/gnu/lib/libgcc

Author: bdrewery Date: Wed Feb 24 22:27:18 2016 New Revision: 296012 URL: https://svnweb.freebsd.org/changeset/base/296012 Log: OBJS and POBJS have not been used since r215127. r215127 disabled building of libgcc.a. MFC after:2 weeks Sponsored by: EMC / Isilon Storage Division M

svn commit: r296014 - head

Author: bdrewery Date: Wed Feb 24 22:27:25 2016 New Revision: 296014 URL: https://svnweb.freebsd.org/changeset/base/296014 Log: Add order for installworld/installkernel. MFC after:2 weeks Sponsored by: EMC / Isilon Storage Division Modified: head/Makefile Modified: head/Makefile =

svn commit: r296013 - head/share/mk

Author: bdrewery Date: Wed Feb 24 22:27:22 2016 New Revision: 296013 URL: https://svnweb.freebsd.org/changeset/base/296013 Log: Add more STANDALONE_SUBDIR_TARGETS. Sponsored by: EMC / Isilon Storage Division Modified: head/share/mk/bsd.subdir.mk Modified: head/share/mk/bsd.subdir.mk ===

svn commit: r296009 - head/sys/net

Author: kib Date: Wed Feb 24 22:00:35 2016 New Revision: 296009 URL: https://svnweb.freebsd.org/changeset/base/296009 Log: In bpf_getdltlist(), do not call copyout(9) while holding bpf lock. Copy the data into temprorary malloced buffer and drop the lock for copyout. Reported, reviewed

svn commit: r296002 - head/gnu/lib/libgcc

Author: bdrewery Date: Wed Feb 24 21:19:44 2016 New Revision: 296002 URL: https://svnweb.freebsd.org/changeset/base/296002 Log: Don't hide AR command as bsd.lib.mk's r283925 changed as well. MFC after:2 weeks Sponsored by: EMC / Isilon Storage Division Modified: head/gnu/lib/libgcc

svn commit: r296001 - head/share/man/man9

Author: kib Date: Wed Feb 24 20:32:24 2016 New Revision: 296001 URL: https://svnweb.freebsd.org/changeset/base/296001 Log: Fix year. Noted by: bdrewery MFC after:2 weeks Modified: head/share/man/man9/vrele.9 Modified: head/share/man/man9/vrele.9 ===

svn commit: r296000 - head/share/mk

Author: bdrewery Date: Wed Feb 24 20:28:48 2016 New Revision: 296000 URL: https://svnweb.freebsd.org/changeset/base/296000 Log: PROGS: Only the main process will install INCS. MFC after:2 weeks Sponsored by: EMC / Isilon Storage Division Modified: head/share/mk/bsd.progs.mk Modifi

svn commit: r295999 - head/share/mk

Author: bdrewery Date: Wed Feb 24 20:28:45 2016 New Revision: 295999 URL: https://svnweb.freebsd.org/changeset/base/295999 Log: FAST_DEPEND: Still need to remove DEPENDFILE when rebuilding. This avoids _EXTRADEPEND adding duplicate entries. Sponsored by: EMC / Isilon Storage Division

svn commit: r295998 - head/share/man/man9

Author: kib Date: Wed Feb 24 20:04:41 2016 New Revision: 295998 URL: https://svnweb.freebsd.org/changeset/base/295998 Log: Remove references to Giant in the description of vrele(9). Add notes about vnode lock and sleeping. Reported by: julian Sponsored by: The FreeBSD Foundation MFC

svn commit: r295997 - head/sys/conf

Author: bdrewery Date: Wed Feb 24 20:02:58 2016 New Revision: 295997 URL: https://svnweb.freebsd.org/changeset/base/295997 Log: Remove hack from r2408 that is no longer needed. Sponsored by: EMC / Isilon Storage Division Modified: head/sys/conf/kern.post.mk Modified: head/sys/conf/kern.

svn commit: r295996 - head/share/man/man5

Author: bdrewery Date: Wed Feb 24 19:19:25 2016 New Revision: 295996 URL: https://svnweb.freebsd.org/changeset/base/295996 Log: Regenerate Modified: head/share/man/man5/src.conf.5 Modified: head/share/man/man5/src.conf.5 ===

Re: svn commit: r293068 - in head/etc: . mtree

> On 03 Jan 2016, at 05:32, Warner Losh wrote: >> Author: imp >> Date: Sun Jan 3 04:32:05 2016 >> New Revision: 293068 >> URL: https://svnweb.freebsd.org/changeset/base/293068 >> >> Log: >> Add libsoft to the tree, just like lib32. Is this commit complete? I only see mtree extractions, but no b

svn commit: r295995 - head/share/man/man5

Author: bdrewery Date: Wed Feb 24 19:07:35 2016 New Revision: 295995 URL: https://svnweb.freebsd.org/changeset/base/295995 Log: BDECFLAGS has not been available since r82604 removed /etc/defaults/make.conf. WARNS=6 has provided BDECFLAGS since r94332 as well. MFC after:1 week Spo

Re: svn commit: r295974 - head/sys/kern

NRESET unconditionally, meaning we can simplify the code a bit. What do you think of the following patch? http://80386.nl/pub/20160224-socket-econnreset.txt Thanks, -- Ed Schouten Nuxi, 's-Hertogenbosch, the Netherlands KvK-nr.: 62051717 ___ s

svn commit: r295993 - head/share/mk

Author: bdrewery Date: Wed Feb 24 17:20:31 2016 New Revision: 295993 URL: https://svnweb.freebsd.org/changeset/base/295993 Log: Show full DIRPRFX in subdir parallel target name. For example when building, from buildworld, lib/atf/libatf-c++/tests/detail: --- all_subdir_atf --- is no

svn commit: r295994 - head/share/mk

Author: bdrewery Date: Wed Feb 24 17:20:34 2016 New Revision: 295994 URL: https://svnweb.freebsd.org/changeset/base/295994 Log: PROGS: Remove the 'build one' optimization since it breaks 'build multiple' Given PROG1 PROG2, 'make PROG1' would work but 'make PROG1 PROG2' would not. Just bui

svn commit: r295992 - head/targets

Author: bdrewery Date: Wed Feb 24 17:20:28 2016 New Revision: 295992 URL: https://svnweb.freebsd.org/changeset/base/295992 Log: DIRDEPS_BUILD: Allow destroy-(arch|host|stage) from top-level. Sponsored by: EMC / Isilon Storage Division Modified: head/targets/Makefile.xtras Modified: head

svn commit: r295991 - head/targets

Author: bdrewery Date: Wed Feb 24 17:20:25 2016 New Revision: 295991 URL: https://svnweb.freebsd.org/changeset/base/295991 Log: DIRDEPS_BUILD: Allow 'make destroy*' to work from top-level. Sponsored by: EMC / Isilon Storage Division Modified: head/targets/Makefile.xtras Modified: head/t

svn commit: r295990 - in head: . targets/pseudo/kernel

Author: bdrewery Date: Wed Feb 24 17:20:22 2016 New Revision: 295990 URL: https://svnweb.freebsd.org/changeset/base/295990 Log: FAST_DEPEND: Skip 'make depend' for buildworld and kernel since it is auto-ran now. Sponsored by: EMC / Isilon Storage Division Modified: head/Makefile.inc1

svn commit: r295989 - in head: bin/csh bin/expr bin/rmail bin/sh cddl/lib/libdtrace gnu/lib/csu gnu/lib/libgcc gnu/lib/libgcov gnu/lib/libgomp gnu/lib/libregex gnu/lib/libstdc++ gnu/lib/libsupc++ g...

Author: bdrewery Date: Wed Feb 24 17:20:11 2016 New Revision: 295989 URL: https://svnweb.freebsd.org/changeset/base/295989 Log: DIRDEPS_BUILD: Regenerate without local dependencies. These are no longer needed after the recent 'beforebuild: depend' changes and hooking DIRDEPS_BUILD into a

svn commit: r295986 - in head: share/mk sys/conf

Author: bdrewery Date: Wed Feb 24 17:19:09 2016 New Revision: 295986 URL: https://svnweb.freebsd.org/changeset/base/295986 Log: FAST_DEPEND: Don't waste time generating an empty .depend file. The .depend file will still be generated if _EXTRADEPEND is used. The target is kept with a depe

svn commit: r295988 - in head: kerberos5/lib/libasn1 kerberos5/lib/libhdb kerberos5/lib/libheimntlm kerberos5/lib/libhx509 lib/clang share/mk sys/conf

Author: bdrewery Date: Wed Feb 24 17:19:18 2016 New Revision: 295988 URL: https://svnweb.freebsd.org/changeset/base/295988 Log: FAST_DEPEND: Always run depend via beforebuild which removes many hacks. This will generate dependencies rather than depending on the previous behavior of depend

svn commit: r295983 - head/sys/conf

Author: bdrewery Date: Wed Feb 24 17:18:58 2016 New Revision: 295983 URL: https://svnweb.freebsd.org/changeset/base/295983 Log: Remove ilinks in cleandepend directly via CLEANDEPENDFILES. The 'cleanilinks' target is kept since it may still be useful as added in r200178, though never docum

svn commit: r295985 - in head: share/mk sys/conf

Author: bdrewery Date: Wed Feb 24 17:19:05 2016 New Revision: 295985 URL: https://svnweb.freebsd.org/changeset/base/295985 Log: FAST_DEPEND: Rework how guessed dependencies are handled. Rather than depend on .depend not existing, check the actual .depend.OBJ file that will be used for tha

svn commit: r295987 - in head: share/mk sys/conf

Author: bdrewery Date: Wed Feb 24 17:19:13 2016 New Revision: 295987 URL: https://svnweb.freebsd.org/changeset/base/295987 Log: Hook the meta/nofilemon build into using FAST_DEPEND. FAST_DEPEND is intended to be the "skip 'make depend' and mkdep" feature. Since DIRDEPS_BUILD does this al

svn commit: r295981 - head/tools/tools/net80211/w00t

Author: bdrewery Date: Wed Feb 24 17:18:52 2016 New Revision: 295981 URL: https://svnweb.freebsd.org/changeset/base/295981 Log: Convert to LIBADD. Sponsored by: EMC / Isilon Storage Division Modified: head/tools/tools/net80211/w00t/Makefile.inc Modified: head/tools/tools/net80211/w00t/M

svn commit: r295982 - head/share/mk

Author: bdrewery Date: Wed Feb 24 17:18:55 2016 New Revision: 295982 URL: https://svnweb.freebsd.org/changeset/base/295982 Log: Follow-up r295667 with fixes for SRCS defined. cleandepend should always remove CLEANDEPEND* if they are not empty, but bsd.dep.mk should not add the tags entrie

svn commit: r295984 - head/sys/conf

Author: bdrewery Date: Wed Feb 24 17:19:02 2016 New Revision: 295984 URL: https://svnweb.freebsd.org/changeset/base/295984 Log: Support beforebuild in the kernel. Sponsored by: EMC / Isilon Storage Division Modified: head/sys/conf/kern.post.mk Modified: head/sys/conf/kern.post.mk ==

svn commit: r295980 - head

Author: bdrewery Date: Wed Feb 24 17:18:49 2016 New Revision: 295980 URL: https://svnweb.freebsd.org/changeset/base/295980 Log: Support a WANT_MAKE_VERSION. This will be used soon for .dinclude support in FAST_DEPEND. MFC after:2 weeks Sponsored by: EMC / Isilon Storage Division

svn commit: r295979 - in head: kerberos5/lib/libasn1 kerberos5/lib/libgssapi_krb5 kerberos5/lib/libgssapi_spnego kerberos5/lib/libhdb kerberos5/lib/libheimntlm kerberos5/lib/libhx509 kerberos5/lib/...

Author: bdrewery Date: Wed Feb 24 17:18:43 2016 New Revision: 295979 URL: https://svnweb.freebsd.org/changeset/base/295979 Log: DIRDEPS_BUILD: Add some missing build dependencies for kerberos5. Sponsored by: EMC / Isilon Storage Division Modified: head/kerberos5/lib/libasn1/Makefile.depe

svn commit: r295978 - in head: lib/libcxxrt usr.bin/mkcsmapper_static usr.bin/mkesdb_static usr.bin/mkuzip

Author: bdrewery Date: Wed Feb 24 17:18:35 2016 New Revision: 295978 URL: https://svnweb.freebsd.org/changeset/base/295978 Log: DIRDEPS_BUILD: Update dependencies. Sponsored by: EMC / Isilon Storage Division Added: head/usr.bin/mkesdb_static/Makefile.depend - copied, changed from r2

svn commit: r295977 - in head/usr.bin: mkcsmapper_static mkesdb_static

Author: bdrewery Date: Wed Feb 24 17:18:31 2016 New Revision: 295977 URL: https://svnweb.freebsd.org/changeset/base/295977 Log: Properly fix these builds by adding NO_WMISSING_VARIABLE_DECLARATIONS from r249657. This reverts r284374. MFC after:2 weeks Sponsored by: EMC / Isilon

svn commit: r295976 - head/share/mk

Author: bdrewery Date: Wed Feb 24 17:18:28 2016 New Revision: 295976 URL: https://svnweb.freebsd.org/changeset/base/295976 Log: PROGS: Only recurse on called targets like done for SUBDIR in r291635. MFC after:2 weeks Sponsored by: EMC / Isilon Storage Division Modified: head/share/

Re: svn commit: r295974 - head/sys/kern

This should really be commented to this effect in the code otherwise someone reading the source will think its a mistake. On 24/02/2016 17:10, Ed Schouten wrote: Author: ed Date: Wed Feb 24 17:10:32 2016 New Revision: 295974 URL: https://svnweb.freebsd.org/changeset/base/295974 Log: Make as

svn commit: r295975 - head/lib/libc/db/recno

Author: pfg Date: Wed Feb 24 17:14:11 2016 New Revision: 295975 URL: https://svnweb.freebsd.org/changeset/base/295975 Log: db(3): Fix aliasing warnings from modern GCC. While here also drop a malloc cast. Obtained from:NetBSD (CVS Rev. 1.18 - 1.20) Modified: head/lib/libc/db

svn commit: r295974 - head/sys/kern

Author: ed Date: Wed Feb 24 17:10:32 2016 New Revision: 295974 URL: https://svnweb.freebsd.org/changeset/base/295974 Log: Make asynchronous connection failures on UNIX sockets fail with ECONNRESET. While making CloudABI work well on Linux, I discovered that I had a FreeBSD-ism in one of m

svn commit: r295973 - head/lib/libc/db/btree

Author: pfg Date: Wed Feb 24 16:52:03 2016 New Revision: 295973 URL: https://svnweb.freebsd.org/changeset/base/295973 Log: db(3): Fix aliasing warnings from modern GCC. Obtained from:NetBSD (CVS Rev. 1.20) Modified: head/lib/libc/db/btree/bt_split.c Modified: head/lib/libc/db/bt

svn commit: r295972 - in head/sys: boot/fdt/dts/riscv conf riscv/conf riscv/htif riscv/include riscv/riscv

Author: br Date: Wed Feb 24 16:50:34 2016 New Revision: 295972 URL: https://svnweb.freebsd.org/changeset/base/295972 Log: Add support for symmetric multiprocessing (SMP). Tested on Spike simulator with 2 and 16 cores (tlb enabled), so set MAXCPU to 16 at this time. This uses FDT data

svn commit: r295971 - in head/sys: kern sys

Author: kib Date: Wed Feb 24 15:15:46 2016 New Revision: 295971 URL: https://svnweb.freebsd.org/changeset/base/295971 Log: Provide more correct sizing of the KVA consumed by a vnode, used by the virtvnodes calculation. Include the size of fs-specific v_data as the nfs nclnode inline, the NF

svn commit: r295969 - in head: sbin/ipfw sys/netpfil/ipfw

Author: ae Date: Wed Feb 24 13:16:03 2016 New Revision: 295969 URL: https://svnweb.freebsd.org/changeset/base/295969 Log: Fix bug in filling and handling ipfw's O_DSCP opcode. Due to integer overflow CS4 token was handled as BE. PR: 207459 MFC after:1 week Modified: hea

Re: svn commit: r295934 - head/sys/kern

Thank you! On 24 February 2016 at 00:38, Bryan Drewery wrote: > On 2/23/2016 2:02 PM, Mariusz Zaborski wrote: > > Author: oshogbo > > Date: Tue Feb 23 22:02:25 2016 > > New Revision: 295934 > > URL: https://svnweb.freebsd.org/changeset/base/295934 > > > > Log: > > According to the sys/kern/cap

svn commit: r295967 - head/sys/netipsec

Author: ae Date: Wed Feb 24 12:28:49 2016 New Revision: 295967 URL: https://svnweb.freebsd.org/changeset/base/295967 Log: Fix useless check. m_pkthdr.len should be equal to orglen. MFC after:2 weeks Modified: head/sys/netipsec/key.c Modified: head/sys/netipsec/key.c

svn commit: r295966 - head/sys/amd64/amd64

Author: kib Date: Wed Feb 24 11:58:15 2016 New Revision: 295966 URL: https://svnweb.freebsd.org/changeset/base/295966 Log: Return dst as the result from memcpy(9) on amd64. PR: 207422 MFC after:1 week Modified: head/sys/amd64/amd64/support.S Modified: head/sys/amd64/amd64/suppor

svn commit: r295965 - head/sys/compat/cloudabi

Author: ed Date: Wed Feb 24 10:54:26 2016 New Revision: 295965 URL: https://svnweb.freebsd.org/changeset/base/295965 Log: Call cap_rights_init() properly. Even though or'ing the individual rights works in this specific case, it may not work in general. Pass them in as varargs. Modified:

svn commit: r295964 - head/sys/dev/hyperv/vmbus

Author: sephe Date: Wed Feb 24 08:54:50 2016 New Revision: 295964 URL: https://svnweb.freebsd.org/changeset/base/295964 Log: hyperv/vmbus: Use free(9) for interrupt page; it is allocated by malloc(9) MFC after:1 week Sponsored by: Microsoft OSTC Differential Revision:https:/