Author: smh
Date: Thu Feb 25 03:01:24 2016
New Revision: 296021
URL: https://svnweb.freebsd.org/changeset/base/296021

Log:
  Removed unused label and fix mutex_exit order
  
  Remove unused done label from zfs_setacl fixing PVS-Studio V729.
  
  Fix mutex_exit order to mirror the mutex_enter order.
  
  MFC after:    1 week
  Sponsored by: Multiplay

Modified:
  head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_acl.c

Modified: head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_acl.c
==============================================================================
--- head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_acl.c       Thu Feb 
25 02:46:47 2016        (r296020)
+++ head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_acl.c       Thu Feb 
25 03:01:24 2016        (r296021)
@@ -1994,8 +1994,8 @@ top:
        zfs_sa_upgrade_txholds(tx, zp);
        error = dmu_tx_assign(tx, TXG_NOWAIT);
        if (error) {
-               mutex_exit(&zp->z_acl_lock);
                mutex_exit(&zp->z_lock);
+               mutex_exit(&zp->z_acl_lock);
 
                if (error == ERESTART) {
                        dmu_tx_wait(tx);
@@ -2020,7 +2020,6 @@ top:
        if (fuidp)
                zfs_fuid_info_free(fuidp);
        dmu_tx_commit(tx);
-done:
        mutex_exit(&zp->z_lock);
        mutex_exit(&zp->z_acl_lock);
 
_______________________________________________
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

Reply via email to