Re: svn commit: r205024 - head/sys/net

2010-03-11 Thread Qing Li
> > Is there any way we can pick up via an assertion that an interface driver has > failed to implement this functionality? This has never been a historic > requirement, so I suspect there are a lot of drivers floating around that > fail to meet the requirement. Also, is this for IFT_ETHER only,

svn commit: r205074 - head/sys/dev/ata

2010-03-11 Thread Alexander Motin
Author: mav Date: Fri Mar 12 07:49:10 2010 New Revision: 205074 URL: http://svn.freebsd.org/changeset/base/205074 Log: Mask disk_idx to avoid panic because of extra bits set. PR: kern/102211 Submitted by: yoichi Modified: head/sys/dev/ata/ata-raid.c Modified: head/sys/dev/at

Re: svn commit: r205024 - head/sys/net

2010-03-11 Thread Robert N. M. Watson
On Mar 12, 2010, at 12:18 AM, Qing Li wrote: > You definitely have a very good point here. I was a bit surprised > during debugging that the link state is not consistently initialized > and by far not enforced across all of the drivers. Admittedly I checked > the most commonly deployed devic

Re: svn commit: r205024 - head/sys/net

2010-03-11 Thread Robert N. M. Watson
On Mar 11, 2010, at 11:30 PM, Qing Li wrote: > What you raised is definitely a possibility and these fixes take the > similar approach. I am going to try and go through each of these > drivers in /sys/dev/ and converting them, very soon. Is there any way we can pick up via an assertion that a

Re: svn commit: r205024 - head/sys/net

2010-03-11 Thread Qing Li
That's a good idea. I will take your approach. -- Qing On Thu, Mar 11, 2010 at 11:15 PM, Julian Elischer wrote: > Juli Mallett wrote: >> >> On Thu, Mar 11, 2010 at 15:39, Qing Li wrote: >>> >>> I guess it's a good time to clean things up. The if_link_state code has >>> been >>> around for quit

svn commit: r205073 - head/share/misc

2010-03-11 Thread Brooks Davis
Author: brooks Date: Fri Mar 12 07:26:37 2010 New Revision: 205073 URL: http://svn.freebsd.org/changeset/base/205073 Log: Regen: * Hart: rev 671 of pcidevs.txt; 22-01-2008 (D-M-Y). * Boemler:vendors.txt (2010-03126) PR: kern/133733 MFC after:1 week

Re: svn commit: r205024 - head/sys/net

2010-03-11 Thread Julian Elischer
Juli Mallett wrote: On Thu, Mar 11, 2010 at 15:39, Qing Li wrote: I guess it's a good time to clean things up. The if_link_state code has been around for quite some time, either it be fully utilized or not be there at all. The inconsistency is the root cause. Sure. There is an increasing amo

svn commit: r205072 - in head/sys/mips: include mips

2010-03-11 Thread Neel Natu
Author: neel Date: Fri Mar 12 07:08:20 2010 New Revision: 205072 URL: http://svn.freebsd.org/changeset/base/205072 Log: - Enable kernel stack guard page. - Unmap the unused kernel stack page that we cannot use because it is not aligned on a (PAGE_SIZE * 2) boundary. Modified: head/sy

svn commit: r205071 - head/usr.bin/ncal

2010-03-11 Thread Edwin Groothuis
Author: edwin Date: Fri Mar 12 06:57:53 2010 New Revision: 205071 URL: http://svn.freebsd.org/changeset/base/205071 Log: - With the introduction of -A, -B and -3, not all combinations of arguments makes sense anymore. For example, what would a combination of -3 (show three months) and -y

svn commit: r205069 - head/sys/net

2010-03-11 Thread Kip Macy
Author: kmacy Date: Fri Mar 12 06:31:19 2010 New Revision: 205069 URL: http://svn.freebsd.org/changeset/base/205069 Log: fix stats reporting sysctl Modified: head/sys/net/flowtable.c Modified: head/sys/net/flowtable.c ==

svn commit: r205066 - in head/sys: net netinet

2010-03-11 Thread Kip Macy
Author: kmacy Date: Fri Mar 12 05:03:26 2010 New Revision: 205066 URL: http://svn.freebsd.org/changeset/base/205066 Log: - restructure flowtable to support ipv6 - add a name argument to flowtable_alloc for printing with ddb commands - extend ddb commands to print destination address or 4-tup

Re: svn commit: r205024 - head/sys/net

2010-03-11 Thread John Hay
On Thu, Mar 11, 2010 at 03:35:13PM -0800, Juli Mallett wrote: > On Thu, Mar 11, 2010 at 15:30, Qing Li wrote: > >> > >> A couple of questions: > >> > >> (1) It used to be the case that quite a few interface drivers and types > >> didn't have a notion of "link up" -- especially older ethernet devic

svn commit: r205064 - in head/sys/mips: include mips

2010-03-11 Thread Neel Natu
Author: neel Date: Fri Mar 12 03:49:17 2010 New Revision: 205064 URL: http://svn.freebsd.org/changeset/base/205064 Log: Make the ddb command "show tlb" SMP friendly. It now accepts an argument to dump out the tlb of a particular cpu. Modified: head/sys/mips/include/cpuregs.h head/sys/m

svn commit: r205063 - in head/sys: amd64/amd64 i386/i386

2010-03-11 Thread John Baldwin
Author: jhb Date: Fri Mar 12 03:08:47 2010 New Revision: 205063 URL: http://svn.freebsd.org/changeset/base/205063 Log: Fix the previous attempt to fix kernel builds of HEAD on 7.x. Use the __gnu_inline__ attribute for PMAP_INLINE when using the 7.x compiler to match what 7.x uses for PMAP_I

svn commit: r205061 - head/sys/mips/cavium/dev/rgmii

2010-03-11 Thread Juli Mallett
Author: jmallett Date: Fri Mar 12 02:56:45 2010 New Revision: 205061 URL: http://svn.freebsd.org/changeset/base/205061 Log: o) Send packets being queued for transmission up to BPF if there's a listener. o) Properly configure the CAM to handle IFF_PROMISC and note where IFF_ALLMULTI handl

Re: svn commit: r205024 - head/sys/net

2010-03-11 Thread Qing Li
> > If you can think of a way to add some invariants (warn the first time > a driver receives a packet without having ever set the link state, > make sure the media status callback sets the valid flag in the > request, etc) that would probably be very helpful for people who are > writing network dr

Re: svn commit: r205024 - head/sys/net

2010-03-11 Thread Juli Mallett
On Thu, Mar 11, 2010 at 15:39, Qing Li wrote: > I guess it's a good time to clean things up. The if_link_state code has been > around for quite some time, either it be fully utilized or not be there at > all. > The inconsistency is the root cause. Sure. There is an increasing amount of stuff th

Re: svn commit: r205024 - head/sys/net

2010-03-11 Thread Qing Li
I guess it's a good time to clean things up. The if_link_state code has been around for quite some time, either it be fully utilized or not be there at all. The inconsistency is the root cause. I will try going through these tonight and hopefully the fix all take a common approach. -- Qing On T

Re: svn commit: r205024 - head/sys/net

2010-03-11 Thread Juli Mallett
On Thu, Mar 11, 2010 at 15:30, Qing Li wrote: >> >> A couple of questions: >> >> (1) It used to be the case that quite a few interface drivers and types >> didn't have a notion of "link up" -- especially older ethernet devices.  Do >> those all have the same problem?  It was probably a design over

Re: svn commit: r205024 - head/sys/net

2010-03-11 Thread Qing Li
> > A couple of questions: > > (1) It used to be the case that quite a few interface drivers and types > didn't have a notion of "link up" -- especially older ethernet devices.  Do > those all have the same problem?  It was probably a design oversight that > devices don't declare an explicit capabi

svn commit: r205050 - in head: sbin/ipfw sys/netinet/ipfw

2010-03-11 Thread Luigi Rizzo
Author: luigi Date: Thu Mar 11 22:42:33 2010 New Revision: 205050 URL: http://svn.freebsd.org/changeset/base/205050 Log: implement listing of a subset of pipes/queues/schedulers. The filtering of the output is done in the kernel instead of userland to reduce the amount of data transfered. M

svn commit: r205049 - head/sys/mips/conf

2010-03-11 Thread Juli Mallett
Author: jmallett Date: Thu Mar 11 22:29:45 2010 New Revision: 205049 URL: http://svn.freebsd.org/changeset/base/205049 Log: Add bpf and random to Octeon configurations, since they're needed to run dhclient and ssh respectively. Reviewed by: imp Modified: head/sys/mips/conf/OCTEON1 h

svn commit: r205048 - head/sys/mips/cavium

2010-03-11 Thread Juli Mallett
Author: jmallett Date: Thu Mar 11 22:25:53 2010 New Revision: 205048 URL: http://svn.freebsd.org/changeset/base/205048 Log: Don't force single user on Octeon anymore. Modified: head/sys/mips/cavium/octeon_machdep.c Modified: head/sys/mips/cavium/octeon_machdep.c =

svn commit: r205047 - head/sys/mips/cavium/dev/rgmii

2010-03-11 Thread Juli Mallett
Author: jmallett Date: Thu Mar 11 22:22:06 2010 New Revision: 205047 URL: http://svn.freebsd.org/changeset/base/205047 Log: o) Eliminate use of sc->typestr, which is always NULL. o) Inline octeon_rgmx_mark_ready into octeon_rgmx_init. o) Add a media status handler that reports link and media

svn commit: r205043 - head/sys/dev/usb

2010-03-11 Thread Andrew Thompson
Author: thompsa Date: Thu Mar 11 22:09:21 2010 New Revision: 205043 URL: http://svn.freebsd.org/changeset/base/205043 Log: Add device ID for the NATURAL4000 keyboard Modified: head/sys/dev/usb/usbdevs Modified: head/sys/dev/usb/usbdevs

svn commit: r205042 - in head/sys/dev/usb: . wlan

2010-03-11 Thread Andrew Thompson
Author: thompsa Date: Thu Mar 11 22:05:12 2010 New Revision: 205042 URL: http://svn.freebsd.org/changeset/base/205042 Log: - Integrate latest driver code from OpenBSD - Drain our tasks from the ieee80211 taskqueue - Add more IDs Submitted by: Akinori Furukoshi Modified: head/sys/dev/

Re: svn commit: r205026 - head/sys/dev/usb

2010-03-11 Thread Alexander Best
thanks. this fixes building the kernel with USB_VERBOSE [1]. [1] http://www.mail-archive.com/freebsd-...@freebsd.org/msg06581.html ___ svn-src-head@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any m

svn commit: r205040 - head/sys/dev/usb/input

2010-03-11 Thread Andrew Thompson
Author: thompsa Date: Thu Mar 11 21:57:01 2010 New Revision: 205040 URL: http://svn.freebsd.org/changeset/base/205040 Log: extend search for Apple Function Key. PR: usb/144414 Submitted by: Hans Petter Selasky Modified: head/sys/dev/usb/input/ukbd.c Modified: head/sys/dev/us

svn commit: r205039 - head/sys/dev/usb

2010-03-11 Thread Andrew Thompson
Author: thompsa Date: Thu Mar 11 21:55:25 2010 New Revision: 205039 URL: http://svn.freebsd.org/changeset/base/205039 Log: Add new device ID for the SMC 2514HUB Submitted by: Alexander Best Modified: head/sys/dev/usb/usbdevs Modified: head/sys/dev/usb/usbdevs ===

svn commit: r205038 - head/sys/dev/usb

2010-03-11 Thread Andrew Thompson
Author: thompsa Date: Thu Mar 11 21:54:23 2010 New Revision: 205038 URL: http://svn.freebsd.org/changeset/base/205038 Log: add new vendor ID for APACER Submitted by: Paul B Mahol Modified: head/sys/dev/usb/usbdevs Modified: head/sys/dev/usb/usbdevs ==

Re: svn commit: r205012 - head/sys/kern

2010-03-11 Thread Alexander Best
thanks. :) ___ svn-src-head@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

svn commit: r205036 - head/sys/dev/usb

2010-03-11 Thread Andrew Thompson
Author: thompsa Date: Thu Mar 11 21:50:36 2010 New Revision: 205036 URL: http://svn.freebsd.org/changeset/base/205036 Log: Implement USB kernel driver detach from userland. Submitted by: Hans Petter Selasky Modified: head/sys/dev/usb/usb_device.c head/sys/dev/usb/usb_device.h head/sy

svn commit: r205035 - head/sys/dev/usb

2010-03-11 Thread Andrew Thompson
Author: thompsa Date: Thu Mar 11 21:49:43 2010 New Revision: 205035 URL: http://svn.freebsd.org/changeset/base/205035 Log: Make sure there is a way to reset the endpoint FIFO on transfer errors for ISOCHRONOUS transfers Submitted by: Hans Petter Selasky Modified: head/sys/dev/usb/usb_t

svn commit: r205034 - head/sys/dev/usb/controller

2010-03-11 Thread Andrew Thompson
Author: thompsa Date: Thu Mar 11 21:49:00 2010 New Revision: 205034 URL: http://svn.freebsd.org/changeset/base/205034 Log: For USS820 driver we need to manually reset TX FIFO at each SETUP transaction because the chip doesn't do this by itself. Submitted by: Hans Petter Selasky Modified:

svn commit: r205033 - head/sys/dev/usb/template

2010-03-11 Thread Andrew Thompson
Author: thompsa Date: Thu Mar 11 21:48:10 2010 New Revision: 205033 URL: http://svn.freebsd.org/changeset/base/205033 Log: isochronous endpoint descriptors should have two more bytes which are zero by default. Submitted by: Hans Petter Selasky Modified: head/sys/dev/usb/template/usb_te

svn commit: r205032 - in head/sys/dev/usb: . serial

2010-03-11 Thread Andrew Thompson
Author: thompsa Date: Thu Mar 11 21:47:25 2010 New Revision: 205032 URL: http://svn.freebsd.org/changeset/base/205032 Log: Add new uvisor(4) device ID. PR: usb/144201 Modified: head/sys/dev/usb/serial/uvisor.c head/sys/dev/usb/usbdevs Modified: head/sys/dev/usb/serial/uvisor

svn commit: r205031 - head/sys/dev/usb/serial

2010-03-11 Thread Andrew Thompson
Author: thompsa Date: Thu Mar 11 21:46:33 2010 New Revision: 205031 URL: http://svn.freebsd.org/changeset/base/205031 Log: It appears that some UVISOR devices do not handle when the clear stall command is issued at the beginning of the initial IN/OUT data transfers. Reason unknown, probably

svn commit: r205030 - head/sys/dev/usb/template

2010-03-11 Thread Andrew Thompson
Author: thompsa Date: Thu Mar 11 21:45:31 2010 New Revision: 205030 URL: http://svn.freebsd.org/changeset/base/205030 Log: - make the usb_temp_setup() and usb_temp_unsetup() functions public so that other modules can generate USB descriptors. - extend the vendor specific request function b

svn commit: r205029 - head/sys/dev/usb/serial

2010-03-11 Thread Andrew Thompson
Author: thompsa Date: Thu Mar 11 21:42:09 2010 New Revision: 205029 URL: http://svn.freebsd.org/changeset/base/205029 Log: Use wMaxPacketSize for the uftdi input buffer size. Submitted by: Hans Petter Selasky Modified: head/sys/dev/usb/serial/uftdi.c Modified: head/sys/dev/usb/serial/uf

Re: svn commit: r205024 - head/sys/net

2010-03-11 Thread Robert Watson
On Thu, 11 Mar 2010, Qing Li wrote: The if_tap interface is of IFT_ETHERNET type, but it does not set or update the if_link_state variable. As such RT_LINK_IS_UP() fails for the if_tap interface. Also, the RT_LINK_IS_UP() needs to bypass all loopback interfaces because loopback interfaces

svn commit: r205028 - head/sys/arm/arm

2010-03-11 Thread Rafal Jaworowski
Author: raj Date: Thu Mar 11 21:16:54 2010 New Revision: 205028 URL: http://svn.freebsd.org/changeset/base/205028 Log: Fix ARM cache handling yet more. 1) vm_machdep.c: remove the dangling allocations so they do not un-necessarily turn off the cache upon consecutive access. 2) bus

svn commit: r205027 - head/sys/arm/arm

2010-03-11 Thread Rafal Jaworowski
Author: raj Date: Thu Mar 11 21:04:29 2010 New Revision: 205027 URL: http://svn.freebsd.org/changeset/base/205027 Log: Let detailed info about CPU features print on Marvell Sheeva CPU as well. Provide missing entry in the cpu_classes[]. Reported by: Maks Verver MFC after:1 week

svn commit: r205026 - head/sys/dev/usb

2010-03-11 Thread Andrew Thompson
Author: thompsa Date: Thu Mar 11 20:41:21 2010 New Revision: 205026 URL: http://svn.freebsd.org/changeset/base/205026 Log: Reapply r185998 which was overwritten at some point. Modified: head/sys/dev/usb/usbdevs Modified: head/sys/dev/usb/usbdevs ==

Re: svn commit: r205013 - in head/sys: amd64/amd64 i386/i386

2010-03-11 Thread John Baldwin
On Thursday 11 March 2010 12:01:28 pm Alexander Best wrote: > thanks for the commit. :) > > a few thoughts: > > 1) why does stepping remain to be printed in dec while family and model are in > hex? is this the way amd/intel cpu docs refer to stepping/model/family? I just left it the way it was.

svn commit: r205024 - head/sys/net

2010-03-11 Thread Qing Li
Author: qingli Date: Thu Mar 11 17:56:46 2010 New Revision: 205024 URL: http://svn.freebsd.org/changeset/base/205024 Log: The if_tap interface is of IFT_ETHERNET type, but it does not set or update the if_link_state variable. As such RT_LINK_IS_UP() fails for the if_tap interface. Also,

Re: svn commit: r205013 - in head/sys: amd64/amd64 i386/i386

2010-03-11 Thread John Baldwin
On Thursday 11 March 2010 12:01:28 pm Alexander Best wrote: > thanks for the commit. :) > > a few thoughts: > > 1) why does stepping remain to be printed in dec while family and model are in > hex? is this the way amd/intel cpu docs refer to stepping/model/family? > 2) the hex value for "Id" and

svn commit: r205021 - head/lib/libc/stdio

2010-03-11 Thread John Baldwin
Author: jhb Date: Thu Mar 11 17:03:32 2010 New Revision: 205021 URL: http://svn.freebsd.org/changeset/base/205021 Log: - Use an initializer macro to initialize fields in 'fake' FILE objects used by *sprintf(), etc. - Explicitly initialize _fl_mutex to PTHREAD_MUTEX_INITIALIZER for all FILE

Re: svn commit: r205013 - in head/sys: amd64/amd64 i386/i386

2010-03-11 Thread Alexander Best
thanks for the commit. :) a few thoughts: 1) why does stepping remain to be printed in dec while family and model are in hex? is this the way amd/intel cpu docs refer to stepping/model/family? 2) the hex value for "Id" and "(AMD) Features(2)" gets printed with an "0x" prepended to indicate it's i

svn commit: r205020 - head/lib/libc/rpc

2010-03-11 Thread John Baldwin
Author: jhb Date: Thu Mar 11 16:58:15 2010 New Revision: 205020 URL: http://svn.freebsd.org/changeset/base/205020 Log: Fix a bug in the previous change: remove function-local definition of tcp_key and udp_key that shadows the global definition. PR: threads/144558 Submitted by:

svn commit: r205018 - head/sys/dev/pci

2010-03-11 Thread John Baldwin
Author: jhb Date: Thu Mar 11 15:25:47 2010 New Revision: 205018 URL: http://svn.freebsd.org/changeset/base/205018 Log: Small whitespace fixes. Modified: head/sys/dev/pci/vga_pci.c Modified: head/sys/dev/pci/vga_pci.c ===

svn commit: r205017 - head/sys/kern

2010-03-11 Thread John Baldwin
Author: jhb Date: Thu Mar 11 15:13:55 2010 New Revision: 205017 URL: http://svn.freebsd.org/changeset/base/205017 Log: Style fixes. Submitted by: bde Modified: head/sys/kern/kern_ktr.c Modified: head/sys/kern/kern_ktr.c ===

svn commit: r205016 - head/sys/compat/freebsd32

2010-03-11 Thread Nathan Whitehorn
Author: nwhitehorn Date: Thu Mar 11 14:56:59 2010 New Revision: 205016 URL: http://svn.freebsd.org/changeset/base/205016 Log: Regen after big endian compatibility import. Modified: head/sys/compat/freebsd32/freebsd32_proto.h head/sys/compat/freebsd32/freebsd32_syscall.h head/sys/compat/fr

svn commit: r205015 - head/sys/ia64/conf

2010-03-11 Thread Nathan Whitehorn
Author: nwhitehorn Date: Thu Mar 11 14:54:54 2010 New Revision: 205015 URL: http://svn.freebsd.org/changeset/base/205015 Log: Accidentally committed test code. Remove it. Big pointy hat: me Modified: head/sys/ia64/conf/GENERIC Modified: head/sys/ia64/conf/GENERIC =

svn commit: r205014 - in head: . sys/amd64/amd64 sys/amd64/conf sys/amd64/include sys/amd64/linux32 sys/compat/freebsd32 sys/compat/ia32 sys/conf sys/fs/procfs sys/ia64/conf sys/ia64/ia64 sys/ia64/...

2010-03-11 Thread Nathan Whitehorn
. machines to maximize performance. (To disable malloc debugging, run ln -s aj /etc/malloc.conf.) +20100311: + The kernel option COMPAT_IA32 has been replaced with COMPAT_FREEBSD32 + to allow 32-bit compatibility on non-x86 platforms. All kernel + configurations on amd64

svn commit: r205013 - in head/sys: amd64/amd64 i386/i386

2010-03-11 Thread John Baldwin
Author: jhb Date: Thu Mar 11 14:17:37 2010 New Revision: 205013 URL: http://svn.freebsd.org/changeset/base/205013 Log: Print out the family and model from the cpu_id. This is especially useful given the advent of the extended family and extended model fields. The values are printed in hex

svn commit: r205012 - head/sys/kern

2010-03-11 Thread John Baldwin
Author: jhb Date: Thu Mar 11 13:16:06 2010 New Revision: 205012 URL: http://svn.freebsd.org/changeset/base/205012 Log: Fix a comment nit. Submitted by: Alexander Best Modified: head/sys/kern/vfs_syscalls.c Modified: head/sys/kern/vfs_syscalls.c ==

svn commit: r205011 - head/usr.bin/perror

2010-03-11 Thread Joerg Wunsch
Author: joerg Date: Thu Mar 11 12:18:52 2010 New Revision: 205011 URL: http://svn.freebsd.org/changeset/base/205011 Log: The number after the command is *not* optional. MFC after:1 day Modified: head/usr.bin/perror/perror.1 Modified: head/usr.bin/perror/perror.1

svn commit: r205010 - head/sys/fs/nfsserver

2010-03-11 Thread Robert Watson
Author: rwatson Date: Thu Mar 11 11:33:04 2010 New Revision: 205010 URL: http://svn.freebsd.org/changeset/base/205010 Log: Update nfsrv_getsocksndseq() for changes in TCP internals since FreeBSD 6.x: - so_pcb is now guaranteed to be non-NULL and valid if a valid socket reference is held

svn commit: r205009 - head/usr.bin/script

2010-03-11 Thread Ed Schouten
Author: ed Date: Thu Mar 11 11:28:29 2010 New Revision: 205009 URL: http://svn.freebsd.org/changeset/base/205009 Log: Improve the change made in the previous commit. doshell() never returns, so there is no need to see whether we are the parent process. Modified: head/usr.bin/script/scr

svn commit: r205008 - head/usr.bin/script

2010-03-11 Thread Ed Schouten
Author: ed Date: Thu Mar 11 11:09:58 2010 New Revision: 205008 URL: http://svn.freebsd.org/changeset/base/205008 Log: Make script(1) a little less broken. Close the file descriptor to the TTY. There is no reason why the parent process should keep track of the descriptor. This ensures that

svn commit: r205005 - head/sys/dev/usb/controller

2010-03-11 Thread Andrew Thompson
Author: thompsa Date: Thu Mar 11 08:33:39 2010 New Revision: 205005 URL: http://svn.freebsd.org/changeset/base/205005 Log: Wrap the proc wakeup special case for ddb in ifdef DDB. Submitted by: Giovanni Trematerra Modified: head/sys/dev/usb/controller/usb_controller.c Modified: head/sys/

svn commit: r205003 - head/sys/dev/siba

2010-03-11 Thread Andrew Thompson
Author: thompsa Date: Thu Mar 11 08:03:56 2010 New Revision: 205003 URL: http://svn.freebsd.org/changeset/base/205003 Log: Revert r204992 and just wrap it all in ifdef INVARIANTS to fix the debug and non-debug cases. Modified: head/sys/dev/siba/siba_core.c Modified: head/sys/dev/siba/siba_