On Thursday 11 March 2010 12:01:28 pm Alexander Best wrote:
> thanks for the commit. :)
> 
> a few thoughts:
> 
> 1) why does stepping remain to be printed in dec while family and model are in
> hex? is this the way amd/intel cpu docs refer to stepping/model/family?

I just left it the way it was.

> 2) the hex value for "Id" and "(AMD) Features(2)" gets printed with an "0x"
> prepended to indicate it's in hex. maybe this should also be the case here.

Because on a typical Intel system you overflow 80 cols if you do that. :(
Otherwise I would have.  We could maybe add an 'h' suffix as that is what
the manuals and it would only add 2 chars rather than 4.

-- 
John Baldwin
_______________________________________________
svn-src-head@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

Reply via email to