Re: svn commit: r278469 - in head/sys: kern sys

2015-02-09 Thread randall
John: See below.. On 2/9/15 3:09 PM, John Baldwin wrote: On Monday, February 09, 2015 07:19:45 PM Randall Stewart wrote: Author: rrs Date: Mon Feb 9 19:19:44 2015 New Revision: 278469 URL: https://svnweb.freebsd.org/changeset/base/278469 Log: This fixes two conditions that can incur when

Re: svn commit: r278472 - in head/sys: netinet netinet6

2015-02-09 Thread randall
On 2/9/15 3:11 PM, John Baldwin wrote: Eh, I looked at it, but I really, really don't like it. I think callout_init_*() should be preferred to CALLOUT_MPSAFE whenever possible as it is less race-prone. I think this should probably be fixed by adding Hans' callout_drain_async() instead, though

Re: svn commit: r278472 - in head/sys: netinet netinet6

2015-02-09 Thread randall
email when I get ready to MFC it. Best wishes R >Thanks for the fix, Randall. When do you plan to MFC this? It'd be nice to have this MFC'd along with D1711 changes so that we do not see panics reported in the review. Cheers, Hiren __

Re: svn commit: r278472 - in head/sys: netinet netinet6

2015-02-09 Thread randall
Peter: I am not sure what you mean.. :-) The in6_lltable_lookup() is right at the line where the code has done: LLE_WLOCK(lle); lle->la_flags |= LLE_DELETED;<- Now without seeing the registers and having a bit more details I can't say. My guess is lle is NULL or 0xdeadcode.. If so this m

svn commit: r213752 - svnadmin/conf

2010-10-12 Thread Randall Stewart
Author: rrs Date: Tue Oct 12 22:09:33 2010 New Revision: 213752 URL: http://svn.freebsd.org/changeset/base/213752 Log: This commit removes Bruce Cran from mentiship ;-) Congratulations Bruce keep up the good work. Modified: svnadmin/conf/mentors Modified: svnadmin/conf/mentors ===

svn commit: r214388 - stable/8/sys/netinet

2010-10-26 Thread Randall Stewart
Author: rrs Date: Tue Oct 26 18:56:55 2010 New Revision: 214388 URL: http://svn.freebsd.org/changeset/base/214388 Log: MFC of 209644 Log is: Fix a bug that will cause a panic. Basically a read-lock is being called to check the vtag-timewait cache. Then in two cases (where a vtag is bad i

svn commit: r214389 - stable/8/sys/netinet

2010-10-26 Thread Randall Stewart
Author: rrs Date: Tue Oct 26 18:59:36 2010 New Revision: 214389 URL: http://svn.freebsd.org/changeset/base/214389 Log: MFC of 209663 This fixes a crash in SCTP. It was possible to have a large number of packets queued to a crashing process. In a specific case you may get 2 ABORT's back (fr

svn commit: r214391 - stable/8/lib/libc/net

2010-10-26 Thread Randall Stewart
Author: rrs Date: Tue Oct 26 19:01:56 2010 New Revision: 214391 URL: http://svn.freebsd.org/changeset/base/214391 Log: MFC: 209760 If a user calls sctp_sendx() with a NULL sinfo we will crash. Instead we should provide our own temp structure to use internally. Modified: stable/8/lib/

svn commit: r214392 - stable/8/sys/netinet

2010-10-26 Thread Randall Stewart
Author: rrs Date: Tue Oct 26 19:04:05 2010 New Revision: 214392 URL: http://svn.freebsd.org/changeset/base/214392 Log: MFC:210493 When counting the number of chunks in the retransmission queue to validate the retran count, we need to include the chunks in the control send queue too. O

svn commit: r214393 - stable/8/sys/netinet

2010-10-26 Thread Randall Stewart
Author: rrs Date: Tue Oct 26 19:06:31 2010 New Revision: 214393 URL: http://svn.freebsd.org/changeset/base/214393 Log: MFC:210494 Make sure that we report chunks if a socket still exists that were not sent. In either case carefully remove the data if it does not get taken by the repor

svn commit: r214394 - stable/8/sys/netinet

2010-10-26 Thread Randall Stewart
Author: rrs Date: Tue Oct 26 19:08:26 2010 New Revision: 214394 URL: http://svn.freebsd.org/changeset/base/214394 Log: MFC:210599 PR SCTP Bugs. Basically a full sized frame of PR SCTP FWD-TSN's would not be sent and thus cause a stalled connection. Also the rwnd Calculation was also

svn commit: r214397 - stable/8/sys/netinet

2010-10-26 Thread Randall Stewart
Author: rrs Date: Tue Oct 26 19:12:37 2010 New Revision: 214397 URL: http://svn.freebsd.org/changeset/base/214397 Log: MFC:210600 Fix the comment block that has the nice table to really have the nice table :-) Modified: stable/8/sys/netinet/sctp_output.c Directory Properties: stable/

svn commit: r214466 - stable/8/sys/netinet

2010-10-28 Thread Randall Stewart
Author: rrs Date: Thu Oct 28 17:17:45 2010 New Revision: 214466 URL: http://svn.freebsd.org/changeset/base/214466 Log: MFC of 212225 Fix some CLANG warnings. One clang warning is left due to the fact that its bogus.. nam->sa_family will not change from AF_INET6 to AF_INET (but clang t

svn commit: r215110 - head/sys/netinet

2010-11-10 Thread Randall Stewart
Author: rrs Date: Thu Nov 11 05:40:39 2010 New Revision: 215110 URL: http://svn.freebsd.org/changeset/base/215110 Log: Fix so that a multicast packet can be sent even if there is no route out to that mcast address. The code in in_pcb inadvertantly would error (no route) even though the use

svn commit: r215816 - stable/8/sys/netinet

2010-11-25 Thread Randall Stewart
Author: rrs Date: Thu Nov 25 12:10:59 2010 New Revision: 215816 URL: http://svn.freebsd.org/changeset/base/215816 Log: MFC of 215110: Fix so that a multicast packet can be sent even if there is no route out to that mcast address. The code in in_pcb inadvertantly would error (no route) even

svn commit: r215817 - head/sys/netinet

2010-11-25 Thread Randall Stewart
ssthresh) /* still in SS move to CA */ net->ssthresh = net->cwnd - 1; + SDT_PROBE(sctp, cwnd, net, fr, + stcb->asoc.my_vtag, + ((stcb->sctp_ep->sctp_lport << 16) | (stcb->rport)), + net, + old_cwnd, net->cwnd)

svn commit: r196507 - head/sys/netinet

2009-08-24 Thread Randall Stewart
Author: rrs Date: Mon Aug 24 11:13:32 2009 New Revision: 196507 URL: http://svn.freebsd.org/changeset/base/196507 Log: This fixes two bugs in the NR-Sack code: 1) When calculating the table offset for sliding the sack array, the two byte values must be "ored" together in order for

svn commit: r197173 - head/sys/netinet

2009-09-13 Thread Randall Stewart
Author: rrs Date: Sun Sep 13 17:45:31 2009 New Revision: 197173 URL: http://svn.freebsd.org/changeset/base/197173 Log: Fixes two bugs: 1) A lock issue, if we ever had to try again we would double lock the INP lock. 2) We were allowing (at wrap) associd 0... which really we cannot a

svn commit: r197288 - in head/sys: netinet netinet6

2009-09-17 Thread Randall Stewart
Author: rrs Date: Thu Sep 17 15:11:12 2009 New Revision: 197288 URL: http://svn.freebsd.org/changeset/base/197288 Log: Support for VNET in SCTP (hopefully) Modified: head/sys/netinet/sctp_asconf.c head/sys/netinet/sctp_bsd_addr.c head/sys/netinet/sctp_input.c head/sys/netinet/sctp_os_bs

svn commit: r197856 - head/sys/netinet

2009-10-08 Thread Randall Stewart
Author: rrs Date: Thu Oct 8 11:36:06 2009 New Revision: 197856 URL: http://svn.freebsd.org/changeset/base/197856 Log: Fix so that round robing stream scheduling works as advertised MFC after:0 days Modified: head/sys/netinet/sctp_output.c Modified: head/sys/netinet/sctp_output.c ==

svn commit: r217592 - head/sys/netinet

2011-01-19 Thread Randall Stewart
Author: rrs Date: Wed Jan 19 19:07:16 2011 New Revision: 217592 URL: http://svn.freebsd.org/changeset/base/217592 Log: Fix a bug where Multicast packets sent from a udp endpoint may end up echoing back to the sender even with OUT joining the multi-cast group. Reviewed by: gnn, bms, bz?

svn commit: r217597 - head/sys/netinet

2011-01-19 Thread Randall Stewart
Author: rrs Date: Wed Jan 19 20:57:08 2011 New Revision: 217597 URL: http://svn.freebsd.org/changeset/base/217597 Log: Fix style 9 nit that snuck in when I grabbed the wrong patch ;-0 (thanks Daniel) MFC after:1 week Modified: head/sys/netinet/udp_usrreq.c Modified: head/sys/netin

svn commit: r217635 - head/sys/netinet

2011-01-20 Thread Randall Stewart
Author: rrs Date: Thu Jan 20 12:40:09 2011 New Revision: 217635 URL: http://svn.freebsd.org/changeset/base/217635 Log: Fix it so we align with new socket API draft for state's in destination (i.e. ACTIVE/INACTIVE/UNCONFIRMED) MFC after:1 week Modified: head/sys/netinet/sctp_constan

svn commit: r218037 - head/sys/netinet

2011-01-28 Thread Randall Stewart
Author: rrs Date: Fri Jan 28 20:49:15 2011 New Revision: 218037 URL: http://svn.freebsd.org/changeset/base/218037 Log: Fix a bug in the way ECN-Echo chunk sends were being accounted for. The counting was such that we counted only when we queued a chunk, not when we sent it. Now keep an a

svn commit: r218039 - head/sys/netinet

2011-01-28 Thread Randall Stewart
Author: rrs Date: Fri Jan 28 21:05:21 2011 New Revision: 218039 URL: http://svn.freebsd.org/changeset/base/218039 Log: Keep track of the real last RTT on each net. This will be used for Data Center congestion control, we won't want to engage it in the ECN code unless we KNOW that the RTT i

svn commit: r218072 - head/sys/netinet

2011-01-29 Thread Randall Stewart
Author: rrs Date: Sat Jan 29 19:55:29 2011 New Revision: 218072 URL: http://svn.freebsd.org/changeset/base/218072 Log: Fixes to ECN in SCTP. 1) ECN was on an association basis, this is incorrect and will not work with CMT or for that matter if the user is sending to multiple addresse

svn commit: r218129 - head/sys/netinet

2011-01-31 Thread Randall Stewart
Author: rrs Date: Mon Jan 31 11:50:11 2011 New Revision: 218129 URL: http://svn.freebsd.org/changeset/base/218129 Log: More ECN fixes: 1) We now remove ECN-Nonce since it will no longer continue as a I-D 2) Eliminate last_tsn_echo, this tied us to an assoc not the net and thus we were n

svn commit: r218186 - head/sys/netinet

2011-02-02 Thread Randall Stewart
Author: rrs Date: Wed Feb 2 11:13:23 2011 New Revision: 218186 URL: http://svn.freebsd.org/changeset/base/218186 Log: 1) Allow a chunk to track the cwnd it was at when sent. 2) Add separate max-bursts for retransmit and hb. These are set to sysctlable values but not settable via the

svn commit: r218211 - in head/sys: conf netinet

2011-02-03 Thread Randall Stewart
Author: rrs Date: Thu Feb 3 10:05:30 2011 New Revision: 218211 URL: http://svn.freebsd.org/changeset/base/218211 Log: Adds an experimental option to create a pool of threads. These serve as input threads and are queued packets based on the V-tag number. This is similar to what a modern ca

svn commit: r218219 - head/sys/netinet

2011-02-03 Thread Randall Stewart
Feb 3 11:39:49 2011(r218218) +++ head/sys/netinet/sctp_pcb.c Thu Feb 3 11:52:22 2011(r218219) @@ -1,5 +1,8 @@ /*- * Copyright (c) 2001-2008, by Cisco Systems, Inc. All rights reserved. + * Copyright (c) 2008-2011, by Randall Stewart, r...@lakerest.net and + *

Re: svn commit: r218219 - head/sys/netinet

2011-02-03 Thread Randall Stewart
John: Ahh.. thanks for the information .. I did not know that. I will change it to use it.. Before it was using the define.. which as Julian said a while ago was a bad idea. R On Feb 3, 2011, at 7:45 AM, John Baldwin wrote: > On Thursday, February 03, 2011 6:52:22 am Randall Stewart wr

svn commit: r218232 - head/sys/netinet

2011-02-03 Thread Randall Stewart
-2007, by Cisco Systems, Inc. All rights reserved. + * Copyright (c) 2008-2011, by Randall Stewart, r...@lakerest.net and + * Michael Tuexen, tue...@fh-muenster.de + * All rights reserved. * * Redistribution and use in source and binary forms, with

Re: svn commit: r218211 - in head/sys: conf netinet

2011-02-04 Thread Randall Stewart
On Feb 4, 2011, at 1:40 AM, Robert Watson wrote: > > On Thu, 3 Feb 2011, Randall Stewart wrote: > >> Author: rrs >> Date: Thu Feb 3 10:05:30 2011 >> New Revision: 218211 >> URL: http://svn.freebsd.org/changeset/base/218211 >> >> Log: >&

svn commit: r218269 - head/sys/netinet

2011-02-04 Thread Randall Stewart
(r218269) @@ -1,8 +1,7 @@ /*- * Copyright (c) 2001-2008, by Cisco Systems, Inc. All rights reserved. - * Copyright (c) 2008-2011, by Randall Stewart, r...@lakerest.net and - * Michael Tuexen, tue...@fh-muenster.de - * All rights reserved. +

svn commit: r218319 - in head/sys: netinet netinet6

2011-02-05 Thread Randall Stewart
@@ /*- * Copyright (c) 2001-2008, by Cisco Systems, Inc. All rights reserved. + * Copyright (c) 2008-2011, by Randall Stewart. All rights reserved. + * Copyright (c) 2008-2011, by Michael Tuexen. All rights reserved. * * Redistribution and use in source and binary forms, with or without * modification

svn commit: r218371 - head/sys/netinet

2011-02-06 Thread Randall Stewart
Author: rrs Date: Sun Feb 6 13:17:40 2011 New Revision: 218371 URL: http://svn.freebsd.org/changeset/base/218371 Log: 1) Use same scheme Michael and I discussed for a selected for a flowid 2) If flowid is not set, arrange so it is stored. 3) If flowid is set by lower layer, use it. MFC

svn commit: r218392 - head/sys/netinet

2011-02-07 Thread Randall Stewart
Author: rrs Date: Mon Feb 7 08:10:29 2011 New Revision: 218392 URL: http://svn.freebsd.org/changeset/base/218392 Log: 1) Track when flowid does get set. MFC after:3 months Modified: head/sys/netinet/sctp_input.c head/sys/netinet/sctp_pcb.c head/sys/netinet/sctp_structs.h Modified:

svn commit: r218393 - head/sys/netinet

2011-02-07 Thread Randall Stewart
Author: rrs Date: Mon Feb 7 08:12:24 2011 New Revision: 218393 URL: http://svn.freebsd.org/changeset/base/218393 Log: If not set (due to some error Michael is working on fixing) set it for the net. MFC after:3 months Modified: head/sys/netinet/sctp_output.c Modified: head/sys/net

svn commit: r218641 - head/sys/netinet

2011-02-13 Thread Randall Stewart
Author: rrs Date: Sun Feb 13 14:48:11 2011 New Revision: 218641 URL: http://svn.freebsd.org/changeset/base/218641 Log: Fix a bug reported by Jonathan Leighton in his web-sctp testing at the Univ-of-Del. Basically when a 1-to-1 socket did a socket/bind/send(data)/close. If the timing was righ

svn commit: r219057 - head/sys/netinet

2011-02-26 Thread Randall Stewart
Author: rrs Date: Sat Feb 26 15:23:46 2011 New Revision: 219057 URL: http://svn.freebsd.org/changeset/base/219057 Log: Improvements to CC modules: 1) Add four new points that allow you to get more information to cc algo's 2) Fix the case where user changes module on a existing TCB, in

svn commit: r219120 - head/sys/netinet

2011-02-28 Thread Randall Stewart
Author: rrs Date: Tue Mar 1 00:37:46 2011 New Revision: 219120 URL: http://svn.freebsd.org/changeset/base/219120 Log: Adds a new Congestion Control that helps reduce the RTT that a flow will build up in buffers in transit. It is a slight modification to RFC2581 but is more friendly i.e. l

svn commit: r219397 - head/sys/netinet

2011-03-08 Thread Randall Stewart
Author: rrs Date: Tue Mar 8 11:58:25 2011 New Revision: 219397 URL: http://svn.freebsd.org/changeset/base/219397 Log: Tunes and fixes the new DC-CC to seem to hit the right mix. Still may need some tweaks but it appears to almost not give away too much to an RFC2581 flow, but can really

Re: svn commit: r217592 - head/sys/netinet

2011-03-30 Thread Randall Stewart
> On Wednesday, January 19, 2011 2:07:16 pm Randall Stewart wrote: >> Author: rrs >> Date: Wed Jan 19 19:07:16 2011 >> New Revision: 217592 >> URL: http://svn.freebsd.org/changeset/base/217592 >> >> Log: >> Fix a bug where Multicast packets sent from a >

Re: svn commit: r217592 - head/sys/netinet

2011-03-31 Thread Randall Stewart
is correct. R On Mar 29, 2011, at 2:01 PM, John Baldwin wrote: > On Wednesday, January 19, 2011 2:07:16 pm Randall Stewart wrote: >> Author: rrs >> Date: Wed Jan 19 19:07:16 2011 >> New Revision: 217592 >> URL: http://svn.freebsd.org/changeset/base/217592 >> >

svn commit: r190689 - head/sys/netinet

2009-04-04 Thread Randall Stewart
Author: rrs Date: Sat Apr 4 11:43:32 2009 New Revision: 190689 URL: http://svn.freebsd.org/changeset/base/190689 Log: Many bug fixes (from the IETF hack-fest): - PR-SCTP had major issues when skipping through a multi-part message. o Did not look at socket buffer. o Did not properly ha

svn commit: r190758 - head/sbin/route

2009-04-06 Thread Randall Stewart
Author: rrs Date: Mon Apr 6 10:09:20 2009 New Revision: 190758 URL: http://svn.freebsd.org/changeset/base/190758 Log: Class based addressing went out in the early 90's. Basically if a entry is not route add -net xxx/bits then we should use the addr (xxx) to establish the number of bits by l

Re: svn commit: r190758 - head/sbin/route

2009-04-06 Thread Randall Stewart
past commits and I can't see what broke it. R On Apr 6, 2009, at 6:39 AM, Robert Watson wrote: On Mon, 6 Apr 2009, Randall Stewart wrote: Author: rrs Date: Mon Apr 6 10:09:20 2009 New Revision: 190758 URL: http://svn.freebsd.org/changeset/base/190758 Log: Class based addressing went o

Re: svn commit: r190758 - head/sbin/route

2009-04-06 Thread Randall Stewart
Hmm. On Apr 6, 2009, at 6:39 AM, Alexander Motin wrote: Randall Stewart wrote: Author: rrs Date: Mon Apr 6 10:09:20 2009 New Revision: 190758 URL: http://svn.freebsd.org/changeset/base/190758 Log: Class based addressing went out in the early 90's. Basically if a entry is not rout

svn commit: r190775 - head/sbin/route

2009-04-06 Thread Randall Stewart
Author: rrs Date: Mon Apr 6 14:27:28 2009 New Revision: 190775 URL: http://svn.freebsd.org/changeset/base/190775 Log: Ok, looking at the solution a bit closer, the level calculation was too agressive. Instead we should only look at each nibble. This makes it so we make 10.2.0.0 become 10.

Re: svn commit: r190775 - head/sbin/route

2009-04-06 Thread Randall Stewart
On Apr 6, 2009, at 11:07 AM, Coleman Kane wrote: On Mon, 2009-04-06 at 14:27 +, Randall Stewart wrote: Author: rrs Date: Mon Apr 6 14:27:28 2009 New Revision: 190775 URL: http://svn.freebsd.org/changeset/base/190775 Log: Ok, looking at the solution a bit closer, the level calculation

svn commit: r190842 - head/sys/netinet

2009-04-08 Thread Randall Stewart
Author: rrs Date: Wed Apr 8 12:49:36 2009 New Revision: 190842 URL: http://svn.freebsd.org/changeset/base/190842 Log: Add more padding and a new variable. This will help us be able to keep ABI compatibility between 8 and 9. MFC after:Never Modified: head/sys/netinet/sctp_sysctl.c

svn commit: r190843 - head/sys/netinet

2009-04-08 Thread Randall Stewart
Author: rrs Date: Wed Apr 8 12:52:05 2009 New Revision: 190843 URL: http://svn.freebsd.org/changeset/base/190843 Log: Fix a FR bug. When doing PR-SCTP with number rtx set to a low number. The check for skipping was in the incorrect place. Which meant we would FR chunks we should not. MF

Re: sctp files location

2009-04-08 Thread Randall Stewart
2009, at 9:03 AM, Luigi Rizzo wrote: Randall, there is now a total of 36 sctp files under sys/netinet (22 headers, 12 source). Wouldn't it be the case to move them (except for the userland headers) under netinet/sctp/ ? cheers luigi ------ Randall S

svn commit: r190913 - head/sbin/route

2009-04-11 Thread Randall Stewart
Author: rrs Date: Sat Apr 11 10:08:26 2009 New Revision: 190913 URL: http://svn.freebsd.org/changeset/base/190913 Log: Fix broken case where caused by last patch where a user uses 0.0.0.0/0 as an alias for default. Obtained from:Mykola Dzham (free...@levsha.org.ua) Modified: head/

svn commit: r191049 - head/sys/netinet

2009-04-14 Thread Randall Stewart
Author: rrs Date: Tue Apr 14 07:50:29 2009 New Revision: 191049 URL: http://svn.freebsd.org/changeset/base/191049 Log: Move the flight size reduction to right after we recognize its a retransmit, ahead of the PR-SCTP work. Without this fix, we end up NOT reducing flight size and causing an

svn commit: r191073 - head/sys/netinet

2009-04-14 Thread Randall Stewart
Author: rrs Date: Tue Apr 14 19:20:27 2009 New Revision: 191073 URL: http://svn.freebsd.org/changeset/base/191073 Log: Add missing address lock when we look at the ifa list Modified: head/sys/netinet/sctp_bsd_addr.c Modified: head/sys/netinet/sctp_bsd_addr.c =

svn commit: r191890 - head/sys/netinet

2009-05-07 Thread Randall Stewart
Author: rrs Date: Thu May 7 16:42:45 2009 New Revision: 191890 URL: http://svn.freebsd.org/changeset/base/191890 Log: ABI expansions to hopefully future-proof our MIB/netstat code for 8.0 Modified: head/sys/netinet/sctp_uio.h Modified: head/sys/netinet/sctp_uio.h ===

svn commit: r191891 - head/sys/netinet

2009-05-07 Thread Randall Stewart
Author: rrs Date: Thu May 7 16:43:49 2009 New Revision: 191891 URL: http://svn.freebsd.org/changeset/base/191891 Log: repository sync to multi-OS repo ... spaceing change Modified: head/sys/netinet/sctp_crc32.c Modified: head/sys/netinet/sctp_crc32.c

svn commit: r249848 - head/sys/netinet

2013-04-24 Thread Randall Stewart
Author: rrs Date: Wed Apr 24 18:30:32 2013 New Revision: 249848 URL: http://svnweb.freebsd.org/changeset/base/249848 Log: This fixes the issue with the "randomly changing" default route. What it was is there are two places in ip_output.c where we do a goto again. One place was fine, it cop

Re: svn commit: r249848 - head/sys/netinet

2013-04-25 Thread Randall Stewart
I like the idea Gleb.. I myself had been thinking that it was rather strange that we used dst for both the gateway and destination.. this is a much cleaner (and safer) solution. R On Apr 25, 2013, at 4:24 AM, Gleb Smirnoff wrote: > -- Randall Stewart 803-317-4

svn commit: r249891 - stable/8/sys/netinet

2013-04-25 Thread Randall Stewart
Author: rrs Date: Thu Apr 25 11:24:40 2013 New Revision: 249891 URL: http://svnweb.freebsd.org/changeset/base/249891 Log: MFC of PR r249848. PR: 174749, 157796 Modified: stable/8/sys/netinet/ip_output.c Directory Properties: stable/8/sys/ (props changed) stable/8/sys/neti

svn commit: r249892 - stable/9/sys/netinet

2013-04-25 Thread Randall Stewart
Author: rrs Date: Thu Apr 25 11:25:24 2013 New Revision: 249892 URL: http://svnweb.freebsd.org/changeset/base/249892 Log: MFC of r249848 PR: 174749, 157796 Modified: stable/9/sys/netinet/ip_output.c Directory Properties: stable/9/sys/ (props changed) Modified: stable/9/sys/netinet

svn commit: r249907 - releng/8.4/sys/netinet

2013-04-25 Thread Randall Stewart
Author: rrs Date: Thu Apr 25 21:55:29 2013 New Revision: 249907 URL: http://svnweb.freebsd.org/changeset/base/249907 Log: MFC of r249848: This fixes the issue with the "randomly changing" default route. What it was is there are two places in ip_output.c where we do a goto again. One place

svn commit: r256760 - head/sys/arm/mv

2013-10-18 Thread Randall Stewart
Author: rrs Date: Sat Oct 19 06:47:02 2013 New Revision: 256760 URL: http://svnweb.freebsd.org/changeset/base/256760 Log: Corrects the Kirkwood dreamplug to use the right register for power managment. It was incorrectly using the clock register which also caused the status to be the oppo

svn commit: r257326 - head/sys/dev/cesa

2013-10-29 Thread Randall Stewart
Author: rrs Date: Tue Oct 29 11:28:11 2013 New Revision: 257326 URL: http://svnweb.freebsd.org/changeset/base/257326 Log: Opps, my kirkwood fix for the dreamplug missed this. Modified: head/sys/dev/cesa/cesa.c Modified: head/sys/dev/cesa/cesa.c ===

svn commit: r232866 - head/sys/netinet

2012-03-12 Thread Randall Stewart
Author: rrs Date: Mon Mar 12 15:05:17 2012 New Revision: 232866 URL: http://svn.freebsd.org/changeset/base/232866 Log: This fixes PR 165210. Basically we just add in the netgraph interface to the list of acceptable interfaces. A todo at the next IETF code blitz, though is we need to review

svn commit: r236951 - head/sys/net

2012-06-12 Thread Randall Stewart
Author: rrs Date: Tue Jun 12 10:44:09 2012 New Revision: 236951 URL: http://svn.freebsd.org/changeset/base/236951 Log: Allow a gif tunnel to be used with ALTq. Reviewed by: gnn Modified: head/sys/net/if_gif.c Modified: head/sys/net/if_gif.c =

svn commit: r236954 - head/sys/net

2012-06-12 Thread Randall Stewart
Author: rrs Date: Tue Jun 12 12:40:15 2012 New Revision: 236954 URL: http://svn.freebsd.org/changeset/base/236954 Log: Opps forgot to commit the flag. Modified: head/sys/net/if.h Modified: head/sys/net/if.h == --- he

svn commit: r236955 - head/sys/net

2012-06-12 Thread Randall Stewart
Author: rrs Date: Tue Jun 12 12:44:17 2012 New Revision: 236955 URL: http://svn.freebsd.org/changeset/base/236955 Log: Note to self. Have morning coffee *before* committing things. There is no mac_addr in the mbuf for BSD.. cheat like we are supposed to and use the csum field since our frien

Re: svn commit: r236955 - head/sys/net

2012-06-12 Thread Randall Stewart
That actually will not effect things. Since the packet is on the way out. If the csum_data field gets set on the way in (not out)… so reusing it here I think is safe. R On Jun 12, 2012, at 8:53 AM, Bjoern A. Zeeb wrote: > > On 12. Jun 2012, at 12:44 , Randall Stewart wrote: > >&

svn commit: r236957 - head/sys/net

2012-06-12 Thread Randall Stewart
Author: rrs Date: Tue Jun 12 13:31:32 2012 New Revision: 236957 URL: http://svn.freebsd.org/changeset/base/236957 Log: Fix comment to better reflect how we are cheating and using the csum_data. Also fix style issues with the comments. Modified: head/sys/net/if_gif.c Modified: head/sys/ne

svn commit: r233660 - head/sys/netinet

2012-03-29 Thread Randall Stewart
Author: rrs Date: Thu Mar 29 13:36:53 2012 New Revision: 233660 URL: http://svn.freebsd.org/changeset/base/233660 Log: Make stream our stream reset implementation compliant to RFC6525. MFC after:1 month Modified: head/sys/netinet/sctp.h head/sys/netinet/sctp_constants.h head/sy

svn commit: r246482 - in head/sys: dev/bxe dev/e1000 dev/ixgbe dev/oce net ofed/drivers/net/mlx4 sys

2013-02-07 Thread Randall Stewart
Author: rrs Date: Thu Feb 7 15:20:54 2013 New Revision: 246482 URL: http://svnweb.freebsd.org/changeset/base/246482 Log: This fixes a out-of-order problem with several of the newer drivers. The basic problem was that the driver was pulling the mbuf off the drbr ring and then when sending

svn commit: r239334 - head/sys/netinet

2012-08-16 Thread Randall Stewart
Author: rrs Date: Thu Aug 16 17:55:16 2012 New Revision: 239334 URL: http://svn.freebsd.org/changeset/base/239334 Log: Its never a good idea to double free the same address. MFC after:1 week (after the other commits ahead of this gets MFC'd) Modified: head/sys/netinet/in.c Modifie

Re: svn commit: r239334 - head/sys/netinet

2012-08-16 Thread Randall Stewart
On Aug 16, 2012, at 3:34 PM, John Baldwin wrote: > On Thursday, August 16, 2012 1:55:17 pm Randall Stewart wrote: >> Author: rrs >> Date: Thu Aug 16 17:55:16 2012 >> New Revision: 239334 >> URL: http://svn.freebsd.org/changeset/base/239334 >> >> Log: >&

svn commit: r239353 - head/sys/netinet

2012-08-16 Thread Randall Stewart
Author: rrs Date: Fri Aug 17 05:51:46 2012 New Revision: 239353 URL: http://svn.freebsd.org/changeset/base/239353 Log: Ok jhb, lets move the ifa_free() down to the bottom to assure that *all* tables and such are removed before we start to free. This won't protect the Hash in ip_input.c but

Re: svn commit: r239353 - head/sys/netinet

2012-08-18 Thread Randall Stewart
On Aug 17, 2012, at 8:26 AM, John Baldwin wrote: > On Friday, August 17, 2012 1:51:46 am Randall Stewart wrote: >> Author: rrs >> Date: Fri Aug 17 05:51:46 2012 >> New Revision: 239353 >> URL: http://svn.freebsd.org/changeset/base/239353 >> >> Log: >&

svn commit: r239395 - head/sys/netinet

2012-08-19 Thread Randall Stewart
Author: rrs Date: Sun Aug 19 11:54:02 2012 New Revision: 239395 URL: http://svn.freebsd.org/changeset/base/239395 Log: Though I disagree, I conceed to jhb & Rui. Note that we still have a problem with this whole structure of locks and in_input.c [it does not lock which it should not, but t

svn commit: r239672 - head/sys/netinet

2012-08-25 Thread Randall Stewart
Author: rrs Date: Sat Aug 25 09:26:37 2012 New Revision: 239672 URL: http://svn.freebsd.org/changeset/base/239672 Log: This small change takes care of a race condition that can occur when both sides close at the same time. If that occurs, without this fix the connection enters FIN1 on both

svn commit: r188066 - in head/sys: dev/xen/netback net netinet

2009-02-03 Thread Randall Stewart
Author: rrs Date: Tue Feb 3 11:00:43 2009 New Revision: 188066 URL: http://svn.freebsd.org/changeset/base/188066 Log: Adds support for SCTP checksum offload. This means we, like TCP and UDP, move the checksum calculation into the IP routines when there is no hardware support we call into

svn commit: r188067 - in head/sys: netinet netinet6

2009-02-03 Thread Randall Stewart
Author: rrs Date: Tue Feb 3 11:04:03 2009 New Revision: 188067 URL: http://svn.freebsd.org/changeset/base/188067 Log: - Cleanup checksum code. - Prepare for CRC offloading, add MIB counters (RS/MT). - Bugfix: Disable CRC computation for IPv6 addresses with local scope (MT). - Bugfix: Hand

svn commit: r188100 - head/sys/netinet

2009-02-03 Thread Randall Stewart
Author: rrs Date: Tue Feb 3 20:33:28 2009 New Revision: 188100 URL: http://svn.freebsd.org/changeset/base/188100 Log: LOR fix - Lock only when calling the actual code that is messing with the UDP tunnel. This means that if two users actually tried to change the

svn commit: r188387 - head/sys/netinet

2009-02-09 Thread Randall Stewart
Author: rrs Date: Mon Feb 9 11:41:54 2009 New Revision: 188387 URL: http://svn.freebsd.org/changeset/base/188387 Log: Fix INET only build breakage with SCTP - pointy hat to me :-) Modified: head/sys/netinet/sctputil.c Modified: head/sys/netinet/sctputil.c ===

svn commit: r188388 - head/sys/netinet

2009-02-09 Thread Randall Stewart
Author: rrs Date: Mon Feb 9 11:42:23 2009 New Revision: 188388 URL: http://svn.freebsd.org/changeset/base/188388 Log: Fix minor spacing problem found by s9indent from last commit. Modified: head/sys/netinet/sctp_crc32.c Modified: head/sys/netinet/sctp_crc32.c =

Re: svn commit: r188388 - head/sys/netinet

2009-02-09 Thread Randall Stewart
the csum calls int crc32?? R On Feb 9, 2009, at 7:41 AM, Chagin Dmitry wrote: On Mon, Feb 09, 2009 at 11:42:23AM +, Randall Stewart wrote: Author: rrs Date: Mon Feb 9 11:42:23 2009 New Revision: 188388 URL: http://svn.freebsd.org/changeset/base/188388 Log: Fix minor spacing problem found

svn commit: r188398 - head/sys/netinet

2009-02-09 Thread Randall Stewart
Author: rrs Date: Mon Feb 9 17:37:17 2009 New Revision: 188398 URL: http://svn.freebsd.org/changeset/base/188398 Log: Add padding to then end of the xsctp_xxx structures to allow future changes to be able to maintain ABI compatibility Modified: head/sys/netinet/sctp_uio.h Modified: head/s

svn commit: r188521 - in stable/7/sys: . netinet

2009-02-12 Thread Randall Stewart
Author: rrs Date: Thu Feb 12 16:40:48 2009 New Revision: 188521 URL: http://svn.freebsd.org/changeset/base/188521 Log: Merges in 182268 from head close bug where we failed to NULL the sctp_socket. Modified: stable/7/sys/ (props changed) stable/7/sys/netinet/sctp_pcb.c Modified: stable/

svn commit: r188522 - in stable/7/sys: . netinet

2009-02-12 Thread Randall Stewart
Author: rrs Date: Thu Feb 12 17:26:16 2009 New Revision: 188522 URL: http://svn.freebsd.org/changeset/base/188522 Log: MFC of 184030 - socket accept inherit bug. Basically accepted sockets were not inheriting the proper sock buf size. Modified: stable/7/sys

svn commit: r188523 - in stable/7/sys: . netinet

2009-02-12 Thread Randall Stewart
Author: rrs Date: Thu Feb 12 17:31:39 2009 New Revision: 188523 URL: http://svn.freebsd.org/changeset/base/188523 Log: MFC of 184336: Two inter-related bugs. - If we send EXACTLY the size left in the send buffer and then send again, we end up with exactly 0 bytes and don't h

svn commit: r188524 - in stable/7/sys: . netinet

2009-02-12 Thread Randall Stewart
Author: rrs Date: Thu Feb 12 17:57:28 2009 New Revision: 188524 URL: http://svn.freebsd.org/changeset/base/188524 Log: MFC of 182367 and 182403 - Make strict-sacks be the default. - Change it so that without INVARIANTs there are no panics in SCTP. - sctp_timer changes so that we hav

svn commit: r188525 - in stable/7/sys: . netinet

2009-02-12 Thread Randall Stewart
Author: rrs Date: Thu Feb 12 18:02:46 2009 New Revision: 188525 URL: http://svn.freebsd.org/changeset/base/188525 Log: MFC of 184027: Reported by Yehuda Weinraub (yehud...@gamil.com) - CRC32C algorithm uses incorrect init_bytes value. It SHOULD have the number of bytes to get to a 4 byt

svn commit: r188526 - in stable/7/sys: . netinet

2009-02-12 Thread Randall Stewart
Author: rrs Date: Thu Feb 12 18:22:11 2009 New Revision: 188526 URL: http://svn.freebsd.org/changeset/base/188526 Log: MFC of 184031: The flags value was not always being copied out in the recv routine like it should be. Obtained from: Michael Tuexen Modified: stable/7/sys/ (props

svn commit: r188527 - in stable/7/sys: . netinet

2009-02-12 Thread Randall Stewart
Author: rrs Date: Thu Feb 12 18:24:54 2009 New Revision: 188527 URL: http://svn.freebsd.org/changeset/base/188527 Log: MFC 184333 Invariants changes that make more sense. Modified: stable/7/sys/ (props changed) stable/7/sys/netinet/sctp_timer.c stable/7/sys/netinet/sctp_timer.h Mo

svn commit: r188528 - in stable/7/sys: . netinet

2009-02-12 Thread Randall Stewart
Author: rrs Date: Thu Feb 12 18:28:42 2009 New Revision: 188528 URL: http://svn.freebsd.org/changeset/base/188528 Log: MFC of 184340 More issues with pre-blocking: a) Need for EEOR mode to take the min of the socket buffer size and the add more threshold, otherwise if you are so si

svn commit: r188530 - in stable/7/sys: . netinet

2009-02-12 Thread Randall Stewart
Author: rrs Date: Thu Feb 12 18:33:26 2009 New Revision: 188530 URL: http://svn.freebsd.org/changeset/base/188530 Log: MFC 184883 - a pack of bug fixes and misc adjustments: -Improvement: Add '\n' on debug output in sctp_lower_sosend(). -Improvement: panic() on INVARIANTS kernels if memor

svn commit: r188532 - in stable/7/sys: . netinet netinet6

2009-02-12 Thread Randall Stewart
Author: rrs Date: Thu Feb 12 18:50:27 2009 New Revision: 188532 URL: http://svn.freebsd.org/changeset/base/188532 Log: MFC of 185694 - The IETF hack session: Code from the hack-session known as the IETF (and a bit of debugging afterwards): - Fix protection code for notification generation.

svn commit: r188577 - head/sys/netinet

2009-02-13 Thread Randall Stewart
Author: rrs Date: Fri Feb 13 14:43:46 2009 New Revision: 188577 URL: http://svn.freebsd.org/changeset/base/188577 Log: Move the new rwnd field down to the very end of the xsctp structure. This is where all new fields belong (not that we will be ABI compatiable with 7.x anyway.. sigh). Mod

svn commit: r188590 - head/sys/netinet

2009-02-13 Thread Randall Stewart
Author: rrs Date: Fri Feb 13 18:44:30 2009 New Revision: 188590 URL: http://svn.freebsd.org/changeset/base/188590 Log: Have the jail code use the error returned to pass not constant errors. Obtained from:ja...@freebsd.org Modified: head/sys/netinet/sctp_pcb.c head/sys/netinet/sc

svn commit: r188605 - in head/sys: dev/iscsi/initiator libkern netinet netinet/libalias sys

2009-02-14 Thread Randall Stewart
Author: rrs Date: Sat Feb 14 11:34:57 2009 New Revision: 188605 URL: http://svn.freebsd.org/changeset/base/188605 Log: This commit fixes the issue with alias_sctp.c. No longer do we require SCTP to be in the kernel for the lib to be able to handle SCTP. We do this by moving the CRC32c chec

svn commit: r188852 - head/sys/netinet

2009-02-20 Thread Randall Stewart
Author: rrs Date: Fri Feb 20 14:33:45 2009 New Revision: 188852 URL: http://svn.freebsd.org/changeset/base/188852 Log: Fix a bug. The sending was being restricted improperly by the max_burst. It should only be gated by cwnd in the lower level send. Obtained from:Michael Tuexen

  1   2   3   4   5   >