Author: mjg
Date: Fri Mar 21 01:30:33 2014
New Revision: 263458
URL: http://svnweb.freebsd.org/changeset/base/263458
Log:
audit: plug FILEDESC_LOCK leak in audit_canon_path.
MFC after:3 days
Modified:
head/sys/security/audit/audit_bsm_klib.c
Modified: head/sys/security/audit/audit_b
Author: mjg
Date: Fri Mar 21 01:34:19 2014
New Revision: 263460
URL: http://svnweb.freebsd.org/changeset/base/263460
Log:
Take filedesc lock only for reading when allocating new fdtable.
Code populating the table does this already.
MFC after:1 week
Modified:
head/sys/kern/kern_d
Author: mjg
Date: Fri Mar 21 19:12:05 2014
New Revision: 263530
URL: http://svnweb.freebsd.org/changeset/base/263530
Log:
Mark the following sysctls as MPSAFE:
kern.file
kern.proc.filedesc
kern.proc.ofiledesc
MFC after:7 days
Modified:
head/sys/kern/kern_descrip.c
Modified: he
Author: mjg
Date: Tue Mar 25 03:28:58 2014
New Revision: 263704
URL: http://svnweb.freebsd.org/changeset/base/263704
Log:
Make /dev/devctl mpsafe.
MFC after:1 week
Modified:
head/sys/kern/subr_bus.c
Modified: head/sys/kern/subr_bus.c
=
Author: mjg
Date: Tue Mar 25 23:13:46 2014
New Revision: 263753
URL: http://svnweb.freebsd.org/changeset/base/263753
Log:
Remove lockless check in devopen, while correct it does not make much sense.
Suggested by: imp
MFC after:6 days
Modified:
head/sys/kern/subr_bus.c
Modified: he
Author: mjg
Date: Tue Mar 25 23:19:45 2014
New Revision: 263754
URL: http://svnweb.freebsd.org/changeset/base/263754
Log:
Remove long obsolete sysctl hw.bus.devctl_disable.
Suggested by: imp
Relnotes: yes
Modified:
head/sys/kern/subr_bus.c
Modified: head/sys/kern/subr_bus.c
==
On Tue, Mar 25, 2014 at 08:03:13AM -0600, Warner Losh wrote:
> On Mar 24, 2014, at 9:28 PM, Mateusz Guzik wrote:
> > Author: mjg
> > Date: Tue Mar 25 03:28:58 2014
> > New Revision: 263704
> > URL: http://svnweb.freebsd.org/changeset/base/263704
> >
>
Author: mjg
Date: Tue Mar 25 23:30:35 2014
New Revision: 263755
URL: http://svnweb.freebsd.org/changeset/base/263755
Log:
Document a known problem with handling the process intended to receive
SIGIO in /dev/devctl.
Suggested by: adrian
MFC after:6 days
Modified:
head/sys/kern/sub
Author: mjg
Date: Wed Mar 26 02:25:40 2014
New Revision: 263758
URL: http://svnweb.freebsd.org/changeset/base/263758
Log:
Update userspace users of hw.bus.devctl_disable.
This fixes breakage resulting from r263754.
Reported by: AN
Reviewed by: imp
Pointy hat to:me
Modif
Then it could be used to
provide a "call this function when process p exits", amongst other things.
--
Mateusz Guzik
___
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail
On Thu, Mar 27, 2014 at 04:46:57PM +0800, David Xu wrote:
> On 2014/03/27 16:37, Mateusz Guzik wrote:
> >On Thu, Mar 27, 2014 at 03:45:17PM +0800, David Xu wrote:
> >>I think the async process pointer can be cleared when a process exits
> >>by registering an event h
On Thu, Mar 27, 2014 at 03:58:19PM +0100, Mateusz Guzik wrote:
> On Thu, Mar 27, 2014 at 04:46:57PM +0800, David Xu wrote:
> > On 2014/03/27 16:37, Mateusz Guzik wrote:
> > >On Thu, Mar 27, 2014 at 03:45:17PM +0800, David Xu wrote:
> > >>I think the async process
On Thu, Mar 27, 2014 at 11:08:34AM -0600, Warner Losh wrote:
>
> On Mar 27, 2014, at 2:37 AM, Mateusz Guzik wrote:
>
> > On Thu, Mar 27, 2014 at 03:45:17PM +0800, David Xu wrote:
> >> I think the async process pointer can be cleared when a process exits
> >>
gopen() in subr_log.c unconditionally calls fsetown(), which
> would avoid the need for an extra syscall. That also avoids the direct
> manipulation of the pointer in your patch, which makes me nervous about
> the possibility of a leak.
>
> I wonder if FIOASYNC should f
On Sat, Mar 29, 2014 at 11:09:34AM +0800, David Xu wrote:
> On 2014/03/29 10:56, Mateusz Guzik wrote:
> >But this patch would mean that current consumers (if any) would break -
> >just calling FIOASYNC would not result in receiving SIGIO.
> The old behavior is inconsistent with o
This thread is too long already, so I'm stepping down on this one in
case there are some futher concerns.
--
Mateusz Guzik
___
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
Author: mjg
Date: Mon Mar 31 02:17:58 2014
New Revision: 263958
URL: http://svnweb.freebsd.org/changeset/base/263958
Log:
MFC r263460:
Take filedesc lock only for reading when allocating new fdtable.
Code populating the table does this already.
Modified:
stable/10/sys/kern/kern_descrip
Author: mjg
Date: Mon Mar 31 02:19:57 2014
New Revision: 263959
URL: http://svnweb.freebsd.org/changeset/base/263959
Log:
MFC r263530:
Mark the following sysctls as MPSAFE:
kern.file
kern.proc.filedesc
kern.proc.ofiledesc
Modified:
stable/10/sys/kern/kern_descrip.c
Directory Propertie
Author: mjg
Date: Mon Mar 31 02:24:29 2014
New Revision: 263960
URL: http://svnweb.freebsd.org/changeset/base/263960
Log:
MFC r263458:
audit: plug FILEDESC_LOCK leak in audit_canon_path.
Modified:
stable/10/sys/security/audit/audit_bsm_klib.c
Directory Properties:
stable/10/ (props chan
Author: mjg
Date: Mon Mar 31 02:30:55 2014
New Revision: 263961
URL: http://svnweb.freebsd.org/changeset/base/263961
Log:
MFC r263704:
Make /dev/devctl mpsafe.
MFC r263753:
Remove lockless check in devopen, while correct it does not make much sense.
Modified:
stable/10/sys/kern/subr_
Author: mjg
Date: Mon Mar 31 02:44:43 2014
New Revision: 263962
URL: http://svnweb.freebsd.org/changeset/base/263962
Log:
MFC r263755:
Document a known problem with handling the process intended to receive
SIGIO in /dev/devctl.
Modified:
stable/10/sys/kern/subr_bus.c
Directory Properties:
Author: mjg
Date: Mon Mar 31 02:53:15 2014
New Revision: 263963
URL: http://svnweb.freebsd.org/changeset/base/263963
Log:
MFC r263758:
Update userspace users of hw.bus.devctl_disable.
This switches the code to use hw.bus.devctl_queue instead.
Modified:
stable/10/etc/rc.d/devd
stable/
Author: mjg
Date: Tue Apr 1 03:20:35 2014
New Revision: 263981
URL: http://svnweb.freebsd.org/changeset/base/263981
Log:
Add a new errno: EMACS - Editor too big.
Make a best-effort to detect that Emacs is about to executed and return
the error.
MFC after:1 week
Modified:
head/li
Author: mjg
Date: Fri Apr 4 05:07:36 2014
New Revision: 264104
URL: http://svnweb.freebsd.org/changeset/base/264104
Log:
Garbage collect fdavail.
It rarely returns an error and fdallocn handles the failure of fdalloc
just fine.
Modified:
head/sys/kern/kern_descrip.c
head/sys/sys/fil
Author: mjg
Date: Fri May 2 00:52:13 2014
New Revision: 265206
URL: http://svnweb.freebsd.org/changeset/base/265206
Log:
Ignore the error from pipespace_new when creating a pipe.
It can fail if pipe map is exhausted (as a result of too many pipes created),
but it is not fatal and could b
On Fri, May 02, 2014 at 10:37:05PM +0400, Chagin Dmitry wrote:
> On Wed, Sep 18, 2013 at 08:46:48PM +0200, Mateusz Guzik wrote:
> > On Wed, Sep 18, 2013 at 05:56:04PM +, Roman Divacky wrote:
> > > Author: rdivacky
> > > Date: Wed Sep 18 17:56:04 2013
> > >
Author: mjg
Date: Fri May 2 21:41:35 2014
New Revision: 265245
URL: http://svnweb.freebsd.org/changeset/base/265245
Log:
Fix typo in KF_FD_TYPE_TRACE comment: ptrace -> ktrace
Modified:
head/sys/sys/user.h
Modified: head/sys/sys/user.h
===
Author: mjg
Date: Fri May 2 21:55:09 2014
New Revision: 265247
URL: http://svnweb.freebsd.org/changeset/base/265247
Log:
Request a non-exiting process in sysctl_kern_proc_{o,}filedesc
This fixes a race with exit1 freeing p_textvp.
Suggested by: kib
MFC after:1 week
Modified:
Author: mjg
Date: Thu Jun 27 02:27:13 2013
New Revision: 252288
URL: http://svnweb.freebsd.org/changeset/base/252288
Log:
MFC r249480:
Add fdallocn function and use it when passing fds over unix socket.
This gets rid of "unp_externalize fdalloc failed" panic.
Modified:
stable/9/sys/ker
this really ok? What prevents given fd from going away during
export_fd_to_sb execution? Both DTYPE_VNODE and DTYPE_FIFO pass down
a vrefed vnode so these are safe. But for example DTYPE_SOCKET goes with
fp->f_data, which can go away in the meantime (or I'm misreading the code).
I suggest obtainn
Author: mjg
Date: Fri Jun 28 18:32:46 2013
New Revision: 252351
URL: http://svnweb.freebsd.org/changeset/base/252351
Log:
Remove duplicate NULL check in kern_proc_filedesc_out.
No functional changes.
MFC after:1 week
Modified:
head/sys/kern/kern_descrip.c
Modified: head/sys/kern/k
Author: mjg
Date: Sun Jun 30 13:14:46 2013
New Revision: 252414
URL: http://svnweb.freebsd.org/changeset/base/252414
Log:
truss: recognize O_DIRECTORY, O_EXEC, O_TTY_INIT and O_CLOEXEC
MFC after:3 days
Modified:
head/usr.bin/truss/syscalls.c
Modified: head/usr.bin/truss/syscalls.c
=
Author: mjg
Date: Sun Jun 30 13:17:37 2013
New Revision: 252415
URL: http://svnweb.freebsd.org/changeset/base/252415
Log:
acct: reduce code duplication by using acct_disable as cleanup for
failed kproc_create
MFC after:1 week
Modified:
head/sys/kern/kern_acct.c
Modified: head/sys/
Author: mjg
Date: Sun Jun 30 19:08:06 2013
New Revision: 252422
URL: http://svnweb.freebsd.org/changeset/base/252422
Log:
acct: create a special plimit object and set it for exiting processes
instead of allocating new one each time
All limits are set to RLIM_INFINITY which sould be ok (ev
Author: mjg
Date: Sun Jun 30 20:27:31 2013
New Revision: 252428
URL: http://svnweb.freebsd.org/changeset/base/252428
Log:
killall: add -q flag to suppress error message when no processes are matched
Man-page text provided by wblock.
PR: bin/30542
Submitted by: Tony Finch (
Author: mjg
Date: Tue Jul 2 07:36:04 2013
New Revision: 252502
URL: http://svnweb.freebsd.org/changeset/base/252502
Log:
Fix receiving fd over unix socket broken in r247740.
If n fds were passed, it would receive the first one n times.
Reported by: Shawn Webb , koobs, gleb
Tested b
Author: mjg
Date: Wed Jul 3 20:24:37 2013
New Revision: 252595
URL: http://svnweb.freebsd.org/changeset/base/252595
Log:
MFC r252414:
truss: recognize O_DIRECTORY, O_EXEC, O_TTY_INIT and O_CLOEXEC
Modified:
stable/9/usr.bin/truss/syscalls.c
Directory Properties:
stable/9/usr.bin/truss/
Author: mjg
Date: Sat Jul 6 12:56:30 2013
New Revision: 252886
URL: http://svnweb.freebsd.org/changeset/base/252886
Log:
MFC r252415, r252422:
acct: reduce code duplication by using acct_disable as cleanup for
failed kproc_create
acct: create a special plimit object and set it for e
Author: mjg
Date: Mon Jul 22 00:44:37 2013
New Revision: 253537
URL: http://svnweb.freebsd.org/changeset/base/253537
Log:
Remove duplicate assertion from tdsendsignal.
MFC after:2 weeks
Modified:
head/sys/kern/kern_sig.c
Modified: head/sys/kern/kern_sig.c
===
Author: mjg
Date: Mon Jul 22 02:07:15 2013
New Revision: 253538
URL: http://svnweb.freebsd.org/changeset/base/253538
Log:
Remove cr_prison NULL check from proc_to_reap.
Userspace processes always have a prison.
MFC after:2 weeks
Modified:
head/sys/kern/kern_exit.c
Modified: hea
Author: mjg
Date: Sun Apr 14 17:08:34 2013
New Revision: 249480
URL: http://svnweb.freebsd.org/changeset/base/249480
Log:
Add fdallocn function and use it when passing fds over unix socket.
This gets rid of "unp_externalize fdalloc failed" panic.
Reviewed by: pjd
MFC after:1 wee
Author: mjg
Date: Thu Feb 20 21:36:05 2014
New Revision: 262259
URL: http://svnweb.freebsd.org/changeset/base/262259
Log:
MFC r260233:
Plug a memory leak in dup2 when both old and new fd have ioctl caps.
Modified:
stable/10/sys/kern/kern_descrip.c
Modified: stable/10/sys/kern/kern_descr
Author: mjg
Date: Thu Feb 20 21:52:39 2014
New Revision: 262260
URL: http://svnweb.freebsd.org/changeset/base/262260
Log:
MFC r259330,r259331:
rlimit: add and utilize lim_shared
rlimit: avoid unnecessary copying of rlimits
If refcount is 1 just modify rlimits in place.
Modified:
Author: mjg
Date: Fri Feb 21 22:29:09 2014
New Revision: 262309
URL: http://svnweb.freebsd.org/changeset/base/262309
Log:
Fix a race between kern_proc_{o,}filedesc_out and fdescfree leading
to use-after-free.
fdescfree proceeds to free file pointers once fd_refcnt reaches 0, but
kern_pr
Author: mjg
Date: Mon Feb 24 21:03:38 2014
New Revision: 262458
URL: http://svnweb.freebsd.org/changeset/base/262458
Log:
MFC r262309:
Fix a race between kern_proc_{o,}filedesc_out and fdescfree leading
to use-after-free.
fdescfree proceeds to free file pointers once fd_refcnt reache
On Tue, Feb 25, 2014 at 01:08:43PM -0500, John Baldwin wrote:
> On Friday, February 21, 2014 5:29:09 pm Mateusz Guzik wrote:
> > Author: mjg
> > Date: Fri Feb 21 22:29:09 2014
> > New Revision: 262309
> > URL: http://svnweb.freebsd.org/changeset/base/262309
> >
On Wed, Feb 26, 2014 at 03:29:31PM -0500, John Baldwin wrote:
> On Wednesday, February 26, 2014 2:23:48 pm Mateusz Guzik wrote:
> > On Tue, Feb 25, 2014 at 01:08:43PM -0500, John Baldwin wrote:
> > > On Friday, February 21, 2014 5:29:09 pm Mateusz Guzik wrote:
> > > >
On Thu, Feb 27, 2014 at 09:06:31AM -0500, John Baldwin wrote:
> On Wednesday, February 26, 2014 4:22:00 pm Mateusz Guzik wrote:
> > On Wed, Feb 26, 2014 at 03:29:31PM -0500, John Baldwin wrote:
> > > On Wednesday, February 26, 2014 2:23:48 pm Mateusz Guzik wrote:
> > >
gt; +
> + return (fp);
> +}
> +
Callers pass arbitrary fd here (provided by the user), yet this panics
if fd is bad.
> int
> +kern_kqueue(struct thread *td)
> +{
> + struct file *fp;
> + int error;
> +
> + error = kern_kqueue_locked(td, &fp);
>
Author: mjg
Date: Fri Jan 3 16:34:16 2014
New Revision: 260232
URL: http://svnweb.freebsd.org/changeset/base/260232
Log:
Don't check for fd limits in fdgrowtable_exp.
Callers do that already and additional check races with process
decreasing limits and can result in not growing the table
Author: mjg
Date: Fri Jan 3 16:36:55 2014
New Revision: 260233
URL: http://svnweb.freebsd.org/changeset/base/260233
Log:
Plug a memory leak in dup2 when both old and new fd have ioctl caps.
Reviewed by: pjd
MFC after:3 days
Modified:
head/sys/kern/kern_descrip.c
Modified: head/s
Author: mjg
Date: Tue Jan 7 19:28:10 2014
New Revision: 260400
URL: http://svnweb.freebsd.org/changeset/base/260400
Log:
MFC r260232:
Don't check for fd limits in fdgrowtable_exp.
Callers do that already and additional check races with process
decreasing limits and can result in not gr
Author: mjg
Date: Tue Jan 7 20:36:15 2014
New Revision: 260409
URL: http://svnweb.freebsd.org/changeset/base/260409
Log:
MFC r260232:
Don't check for fd limits in fdgrowtable_exp.
Callers do that already and additional check races with process
decreasing limits and can result in not gr
r, ptr, len);
> if (!req->nerror)
> return (ptr);
> if (ptr != NULL)
Is not this if (ptr != NULL) unnecesary?
--
Mateusz Guzik
___
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-s
) == -1) {
> + if ((fd = open(name, flags|O_RDONLY|O_EXLOCK|flags, 0666)) == -1) {
> if (errno == EAGAIN || errno == EINTR)
> return (-1);
> err(EX_CANTCREAT, "cannot open %s", name);
EX_UNAVAILABLE is never returned.
--
Author: mjg
Date: Tue May 21 21:58:00 2013
New Revision: 250890
URL: http://svnweb.freebsd.org/changeset/base/250890
Log:
passing fd over unix socket: fix a corner case where caller
wants to pass no descriptors.
Previously the kernel would leak memory and try to free a potentially
arbit
On Wed, May 22, 2013 at 01:21:48PM +0400, Gleb Smirnoff wrote:
> On Tue, May 21, 2013 at 09:58:01PM +0000, Mateusz Guzik wrote:
> M> Author: mjg
> M> Date: Tue May 21 21:58:00 2013
> M> New Revision: 250890
> M> URL: http://svnweb.freebsd.org/changeset/base/250890
> M
Author: mjg
Date: Sat Nov 23 23:54:38 2013
New Revision: 258505
URL: http://svnweb.freebsd.org/changeset/base/258505
Log:
MFC r256951:
gnop: make sure that newly allocated memory for softc is zeroed
This prevents mtx_init from encountering non-zeros and panicking
the kernel as a result.
ctly what the name
> suggests, and is somewhat useful for benchmarking.
>
There is already a 'geom zero' module which I believe provides
equivalent functionality.
--
Mateusz Guzik
___
svn-src-all@freebsd.org mailing list
http://li
Author: mjg
Date: Fri Dec 13 20:53:31 2013
New Revision: 259330
URL: http://svnweb.freebsd.org/changeset/base/259330
Log:
rlimit: add and utilize lim_shared
MFC after:2 weeks
Modified:
head/sys/kern/kern_resource.c
Modified: head/sys/kern/kern_resource.c
Author: mjg
Date: Fri Dec 13 20:54:45 2013
New Revision: 259331
URL: http://svnweb.freebsd.org/changeset/base/259331
Log:
rlimit: avoid unnecessary copying of rlimits
If refcount is 1 just modify rlimits in place.
MFC after:2 weeks
Modified:
head/sys/kern/kern_resource.c
Modifi
Author: mjg
Date: Sun Dec 15 04:11:43 2013
New Revision: 259407
URL: http://svnweb.freebsd.org/changeset/base/259407
Log:
proc exit: don't take PROC_LOCK while freeing rlimits
Code wishing to check rlimits of some process should check whether it
is exiting first, which current consumers d
On Tue, Dec 17, 2013 at 11:41:49AM -0500, John Baldwin wrote:
> On Saturday, December 14, 2013 11:11:43 pm Mateusz Guzik wrote:
> > Author: mjg
> > Date: Sun Dec 15 04:11:43 2013
> > New Revision: 259407
> > URL: http://svnweb.freebsd.org/changeset/base/259407
> >
On Tue, Dec 17, 2013 at 02:34:01PM -0500, John Baldwin wrote:
> On Tuesday, December 17, 2013 1:17:45 pm Mateusz Guzik wrote:
> > On Tue, Dec 17, 2013 at 11:41:49AM -0500, John Baldwin wrote:
> > > On Saturday, December 14, 2013 11:11:43 pm Mateusz Guzik wrote:
> > >
Author: mjg
Date: Wed Oct 23 01:34:18 2013
New Revision: 256951
URL: http://svnweb.freebsd.org/changeset/base/256951
Log:
gnop: make sure that newly allocated memory for softc is zeroed
This prevents mtx_init from encountering non-zeros and panicking
the kernel as a result.
Reported
Author: mjg
Date: Sun Nov 18 15:48:34 2012
New Revision: 243234
URL: http://svnweb.freebsd.org/changeset/base/243234
Log:
Fix possible fp reference leak in posix_openpt
Reviewed by: ed
Approved by: trasz (mentor)
MFC after:3 days
Modified:
head/sys/kern/tty_pts.c
Modified: hea
Author: mjg
Date: Tue Nov 27 01:28:35 2012
New Revision: 243582
URL: http://svnweb.freebsd.org/changeset/base/243582
Log:
MFC r243007:
enterpgrp: get rid of pgrp2 variable and use KASSERT directly on pgfind
result.
pgrp2 was used only for debugging, but pgrp2 = pgfind(..) was present in
Author: mjg
Date: Tue Nov 27 01:30:12 2012
New Revision: 243583
URL: http://svnweb.freebsd.org/changeset/base/243583
Log:
MFC r243007:
enterpgrp: get rid of pgrp2 variable and use KASSERT directly on pgfind
result.
pgrp2 was used only for debugging, but pgrp2 = pgfind(..) was present in
Author: mjg
Date: Tue Nov 27 01:33:23 2012
New Revision: 243584
URL: http://svnweb.freebsd.org/changeset/base/243584
Log:
MFC r243234:
Fix possible fp reference leak in posix_openpt
Modified:
stable/9/sys/kern/tty_pts.c
Directory Properties:
stable/9/sys/ (props changed)
Modified: s
Author: mjg
Date: Tue Nov 27 01:35:29 2012
New Revision: 243585
URL: http://svnweb.freebsd.org/changeset/base/243585
Log:
MFC r243234:
Fix possible fp reference leak in posix_openpt
Modified:
stable/8/sys/kern/tty_pts.c
Directory Properties:
stable/8/sys/ (props changed)
stable/8/s
is
trustful:
[..]
if (args) {
nfsrv_pool->sp_minthreads = args->minthreads;
nfsrv_pool->sp_maxthreads = args->maxthreads;
} else {
nfsrv_pool->sp_minthreads = 4;
nfsrv_pool->sp_maxthreads = 4;
}
[..]
--
Mateusz Guzik
__
On Wed, Nov 28, 2012 at 07:14:23PM -0500, Rick Macklem wrote:
> Mateusz Guzik wrote:
> > On Wed, Nov 28, 2012 at 02:47:32AM +, Alfred Perlstein wrote:
> > > Author: alfred
> > > Date: Wed Nov 28 02:47:31 2012
> > > New Revision: 243645
> > > URL: ht
+
+ grpath = strdup(dir);
if (grpath == NULL)
return -1;
Also the only consumer does not check for errors, but after cursory look
I'm not sure if it is ok to just exit.
--
Mateusz Guzik
___
svn-src-all@freebsd.
= size;
- xs->offset = offset;
+ xs->offset = 0;
xs->rcvd = offset;
xs->lastrcvd = offset;
if (v_tty && v_level > 0)
--
Mateusz Guzik
___
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
On Sun, Dec 09, 2012 at 07:42:02PM +0100, Florian Smeets wrote:
> On 09.12.12 19:27, Mateusz Guzik wrote:
> > On Sun, Dec 09, 2012 at 07:06:22PM +0100, Florian Smeets wrote:
> >> On 16.11.12 13:05, Andre Oppermann wrote:
> >>> Author: andre
> >>> Date: F
Author: mjg
Date: Tue Dec 18 18:34:36 2012
New Revision: 244404
URL: http://svnweb.freebsd.org/changeset/base/244404
Log:
prison_racct_detach can be called for not fully initialized jail, so make it
check that the jail has racct before doing anything
PR: kern/174436
Reviewed by
Author: mjg
Date: Fri Dec 21 21:40:51 2012
New Revision: 244566
URL: http://svnweb.freebsd.org/changeset/base/244566
Log:
MFC r244404:
prison_racct_detach can be called for not fully initialized jail, so make
it check that the jail has racct before doing anything
PR: kern/1
; this prevents kernel data from being leaked.
>
I think it would be better to teach strlcpy to zero-pad as well.
--
Mateusz Guzik
___
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, se
Author: mjg
Date: Sun Jan 6 21:47:59 2013
New Revision: 245113
URL: http://svnweb.freebsd.org/changeset/base/245113
Log:
lockmgr: unlock interlock (if requested) when dealing with upgrade/downgrade
requests for LK_NOSHARE locks, just like for shared locks.
PR: kern/174969
Rev
Author: mjg
Date: Sun Jan 6 21:56:58 2013
New Revision: 245114
URL: http://svnweb.freebsd.org/changeset/base/245114
Log:
pw: free group returned by gr_add
Modified:
head/usr.sbin/pw/pw_user.c
Modified: head/usr.sbin/pw/pw_user.c
==
Author: mjg
Date: Sat Jan 12 22:20:37 2013
New Revision: 245345
URL: http://svnweb.freebsd.org/changeset/base/245345
Log:
procstat: only one mode flag can be specified, but required check for 'i'
and 'j' modes was missing. Fix that.
MFC after:3 days
Modified:
head/usr.bin/procstat/
Author: mjg
Date: Sun Jan 13 00:32:07 2013
New Revision: 245351
URL: http://svnweb.freebsd.org/changeset/base/245351
Log:
MFC r245113:
lockmgr: unlock interlock (if requested) when dealing with upgrade/downgrade
requests for LK_NOSHARE locks, just like for shared locks.
PR: ke
Author: mjg
Date: Sun Jan 13 21:25:43 2013
New Revision: 245385
URL: http://svnweb.freebsd.org/changeset/base/245385
Log:
libutil: eliminate 'found' variable in gr_equal
Submitted by: Christoph Mallon
Modified:
head/lib/libutil/gr_util.c
Modified: head/lib/libutil/gr_util.c
===
Author: mjg
Date: Sun Jan 13 21:26:57 2013
New Revision: 245386
URL: http://svnweb.freebsd.org/changeset/base/245386
Log:
libutil: move group_line_format into the scop of its only user.
Submitted by: Christoph Mallon
Modified:
head/lib/libutil/gr_util.c
Modified: head/lib/libutil/gr_ut
Author: mjg
Date: Sun Jan 13 21:28:47 2013
New Revision: 245387
URL: http://svnweb.freebsd.org/changeset/base/245387
Log:
libutil: utilize strsep instead of strcat in a loop in gr_make
Submitted by: Christoph Mallon
Modified:
head/lib/libutil/gr_util.c
Modified: head/lib/libutil/gr_uti
Author: mjg
Date: Sun Jan 13 22:08:18 2013
New Revision: 245390
URL: http://svnweb.freebsd.org/changeset/base/245390
Log:
libutil: fix typo in comment for gr_fini.
Submitted by: Christoph Mallon
Modified:
head/lib/libutil/gr_util.c
Modified: head/lib/libutil/gr_util.c
=
Author: mjg
Date: Thu Jan 17 02:42:08 2013
New Revision: 245530
URL: http://svnweb.freebsd.org/changeset/base/245530
Log:
MFC r245345:
procstat: only one mode flag can be specified, but required check for 'i'
and 'j' modes was missing. Fix that.
Modified:
stable/9/usr.bin/procstat/procsta
Author: mjg
Date: Tue Oct 30 19:46:00 2012
New Revision: 242372
URL: http://svn.freebsd.org/changeset/base/242372
Log:
atrun(8): scale default load average limit with the number of CPUs
Previously atrun refused to run jobs if load average was not below fixed
limit of 1.5.
PR:
Author: mjg
Date: Tue Nov 6 23:04:23 2012
New Revision: 242680
URL: http://svnweb.freebsd.org/changeset/base/242680
Log:
Fix possible spurious sbunlock in sctp_sorecvmsg.
Reviewed by: tuexen
Approved by: trasz (mentor)
MFC after:3 days
Modified:
head/sys/netinet/sctputil.c
Mo
Author: mjg
Date: Fri Nov 9 19:31:31 2012
New Revision: 242836
URL: http://svnweb.freebsd.org/changeset/base/242836
Log:
MFC r242680:
Fix possible spurious sbunlock in sctp_sorecvmsg.
Approved by: trasz (mentor)
Modified:
stable/9/sys/netinet/sctputil.c
Directory Properties:
sta
Author: mjg
Date: Fri Nov 9 19:45:17 2012
New Revision: 242839
URL: http://svnweb.freebsd.org/changeset/base/242839
Log:
MFC r242680:
Fix possible spurious sbunlock in sctp_sorecvmsg.
Approved by: trasz (mentor)
Modified:
stable/8/sys/netinet/sctputil.c
Directory Properties:
sta
for easier testing:
http://people.freebsd.org/~mjg/patches/stable9-pipe2-full.diff
--
Mateusz Guzik
___
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
Author: mjg
Date: Tue Nov 13 19:17:21 2012
New Revision: 242990
URL: http://svnweb.freebsd.org/changeset/base/242990
Log:
MFC r242372:
atrun(8): scale default load average limit with the number of CPUs
Previously atrun refused to run jobs if load average was not below fixed
limit of 1.5.
Author: mjg
Date: Tue Nov 13 19:20:57 2012
New Revision: 242991
URL: http://svnweb.freebsd.org/changeset/base/242991
Log:
MFC r242372:
atrun(8): scale default load average limit with the number of CPUs
Previously atrun refused to run jobs if load average was not below fixed
limit of 1.5.
Author: mjg
Date: Tue Nov 13 22:01:25 2012
New Revision: 243007
URL: http://svnweb.freebsd.org/changeset/base/243007
Log:
enterpgrp: get rid of pgrp2 variable and use KASSERT directly on pgfind
result.
pgrp2 was used only for debugging, but pgrp2 = pgfind(..) was present in
compiled code
Author: mjg
Date: Sun Jul 8 00:51:38 2012
New Revision: 238220
URL: http://svn.freebsd.org/changeset/base/238220
Log:
Unbreak handling of descriptors opened with O_EXEC by fexecve(2).
While here return EBADF for descriptors opened for writing (previously it was
ETXTBSY).
Add fgetvp_e
Author: mjg
Date: Mon Jul 9 05:39:31 2012
New Revision: 238272
URL: http://svn.freebsd.org/changeset/base/238272
Log:
Follow-up commit to r238220:
Pass only FEXEC (instead of FREAD|FEXEC) in fgetvp_exec. _fget has to check
for
!FWRITE anyway and may as well know about FREAD.
Make _
used?
While here some style(9) fixes.
http://people.freebsd.org/~mjg/patches/smbfs_node-malloc.patch
Completely untested (even compile-time); I guess the idea is clear. :)
--
Mateusz Guzik
___
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
On Sun, Jul 15, 2012 at 06:23:50PM +0200, Christian Brueffer wrote:
> On 7/15/12 18:04 , Mateusz Guzik wrote:
> > On Sun, Jul 15, 2012 at 03:50:12PM +, Christian Brueffer wrote:
> >> Author: brueffer
> >> Date: Sun Jul 15 15:50:12 2012
> >> New Revision: 238
Author: mjg
Date: Wed Jul 18 04:52:37 2012
New Revision: 238560
URL: http://svn.freebsd.org/changeset/base/238560
Log:
MFC r238220, r238272:
Unbreak handling of descriptors opened with O_EXEC by fexecve(2).
While here return EBADF for descriptors opened for writing (previously it was
1 - 100 of 2069 matches
Mail list logo
