Re: svn commit: r226536 - head/sys/contrib/pf/net

2011-10-21 Thread Ermal Luçi
On Wed, Oct 19, 2011 at 1:04 PM, Bjoern A. Zeeb wrote: > Author: bz > Date: Wed Oct 19 11:04:49 2011 > New Revision: 226536 > URL: http://svn.freebsd.org/changeset/base/226536 > > Log: >  De-virtualize the pf_task_mtx lock.  At the current state of pf locking >  and virtualization it is not helpfu

Re: svn commit: r262196 - head/sys/netpfil/pf

2014-02-19 Thread Ermal Luçi
On Wed, Feb 19, 2014 at 4:32 PM, Gleb Smirnoff wrote: > Martin, > > M> > On Tue, Feb 18, 2014 at 10:17:12PM +, Martin Matuska wrote: > M> > M> Author: mm > M> > M> Date: Tue Feb 18 22:17:12 2014 > M> > M> New Revision: 262196 > M> > M> URL: http://svnweb.freebsd.org/changeset/base/262196 >

Re: svn commit: r229850 - in head: etc/rc.d sys/contrib/pf/net sys/netinet

2012-01-13 Thread Ermal Luçi
You ARE testing this right? Since you removed code that you do not actually mention at all in the commit message!!! On Mon, Jan 9, 2012 at 9:50 AM, Gleb Smirnoff wrote: > Author: glebius > Date: Mon Jan 9 08:50:22 2012 > New Revision: 229850 > URL: http://svn.freebsd.org/changeset/base/229850 >

Re: svn commit: r230265 - head/sys/contrib/pf/net

2012-01-17 Thread Ermal Luçi
Maybe it does not hurt in general to keep the V_ Some work was done to add it, no?! On Tue, Jan 17, 2012 at 1:14 PM, Gleb Smirnoff wrote: > Author: glebius > Date: Tue Jan 17 12:14:26 2012 > New Revision: 230265 > URL: http://svn.freebsd.org/changeset/base/230265 > > Log: > Allocate our mbuf w

Re: svn commit: r230265 - head/sys/contrib/pf/net

2012-01-17 Thread Ermal Luçi
2012/1/17 Gleb Smirnoff > On Tue, Jan 17, 2012 at 05:48:10PM +0100, Ermal Lu?i wrote: > E> Maybe it does not hurt in general to keep the V_ > E> Some work was done to add it, no?! > > The V_ has been left under __FreeBSD__. > > E> On Tue, Jan 17, 2012 at 1:14 PM, Gleb Smirnoff > wrote: > E> > E>

Re: svn commit: r238600 - stable/9/sys/contrib/pf/net

2012-07-19 Thread Ermal Luçi
I would prefer to be in CC for this or at least asked! On Wed, Jul 18, 2012 at 6:13 PM, Gleb Smirnoff wrote: > Author: glebius > Date: Wed Jul 18 16:13:03 2012 > New Revision: 238600 > URL: http://svn.freebsd.org/changeset/base/238600 > > Log: > Merge r230119, r238498 from head: > > -

Re: svn commit: r233846 - head/sys/contrib/pf/net

2012-04-03 Thread Ermal Luçi
You are sure that the defer feature is linked only to active-active? 2012/4/3 Gleb Smirnoff : > On Tue, Apr 03, 2012 at 06:09:21PM +, Gleb Smirnoff wrote: > T> Author: glebius > T> Date: Tue Apr  3 18:09:20 2012 > T> New Revision: 233846 > T> URL: http://svn.freebsd.org/changeset/base/233846 >

Re: svn commit: r234711 - in head/usr.sbin/wpa: . hostapd

2012-04-26 Thread Ermal Luçi
Thanks, i actually forgot to submit this. On Thu, Apr 26, 2012 at 7:35 PM, Bernhard Schmidt wrote: > Author: bschmidt > Date: Thu Apr 26 17:35:11 2012 > New Revision: 234711 > URL: http://svn.freebsd.org/changeset/base/234711 > > Log: >  fix EAP server support after the 0.7.3 import: >  - eap_xxx

Re: svn commit: r200183 - head/sbin/ipfw

2009-12-07 Thread Ermal Luçi
On Mon, Dec 7, 2009 at 5:31 AM, Max Laier wrote: > On Sunday 06 December 2009 19:04:27 Luigi Rizzo wrote: > > Author: luigi > > Date: Sun Dec 6 18:04:26 2009 > > New Revision: 200183 > > URL: http://svn.freebsd.org/changeset/base/200183 > > > > Log: > > restore setting of sin_len (was removed

Re: svn commit: r200183 - head/sbin/ipfw

2009-12-07 Thread Ermal Luçi
On Mon, Dec 7, 2009 at 8:45 PM, Lytochkin Boris wrote: > Hi! > > On Mon, Dec 7, 2009 at 10:29 PM, Max Laier wrote: > [cut] > > I just tested an install of r197983 (9.0-CURRENT) that I had on a > test-box and > > route-to works as it is supposed to - AFAICT. FWIW, pf sets sin_len for > every > >

Re: svn commit: r208766 - stable/8/sys/netinet

2010-06-03 Thread Ermal Luçi
On Thu, Jun 3, 2010 at 10:55 AM, Robert Watson wrote: > Author: rwatson > Date: Thu Jun  3 08:55:45 2010 > New Revision: 208766 > URL: http://svn.freebsd.org/changeset/base/208766 > > Log: >  Merge r204810 from head to stable/8: > >    Remove unnecessary locking of divcbinfo lock from div_output()

Re: svn commit: r208766 - stable/8/sys/netinet

2010-06-04 Thread Ermal Luçi
On Fri, Jun 4, 2010 at 11:11 AM, Robert N. M. Watson wrote: > > On 3 Jun 2010, at 14:09, Ermal Luçi wrote: > >> Would it make sense to remove even passing the interface name up and >> actually send the >> interface index? >> >> That is what we are doing at p

svn commit: r274709 - head/sys/netpfil/pf

2014-11-19 Thread Ermal Luçi
Author: eri Date: Wed Nov 19 13:31:08 2014 New Revision: 274709 URL: https://svnweb.freebsd.org/changeset/base/274709 Log: pf(4) needs to have a correct checksum during its processing. Calculate checksums for the IPv6 path when needed before delving into pf(4) code as required. PR:

Re: svn commit: r274709 - head/sys/netpfil/pf

2014-11-25 Thread Ermal Luçi
Hello Dag, if its working for you i have no issues. For me these changes are taken into consideration during policy routing on pf(4). If you check the pf_route() call it does the same checks as outgoing processing of the modules. If they need to be considered after pf(4) does it internal processin

Re: svn commit: r274709 - head/sys/netpfil/pf

2014-11-26 Thread Ermal Luçi
On Tue, Nov 25, 2014 at 3:14 PM, Dag-Erling Smørgrav wrote: > Ermal Luçi writes: > > Also this only affects the traffic sourced by the host itself and not > > forwarded traffic and I think this patch will provide a regression for > > the issues that the committed patch does

Re: svn commit: r276747 - head/sys/netpfil/pf

2015-01-08 Thread Ermal Luçi
On Thu, Jan 8, 2015 at 1:21 AM, Bjoern A. Zeeb < bzeeb-li...@lists.zabbadoz.net> wrote: > > > On 07 Jan 2015, at 20:46 , Gleb Smirnoff wrote: > > > > On Tue, Jan 06, 2015 at 09:03:04AM +, Craig Rodrigues wrote: > > C> Author: rodrigc > > C> Date: Tue Jan 6 09:03:03 2015 > > C> New Revision:

Re: svn commit: r282132 - head/sys/netipsec

2015-05-12 Thread Ermal Luçi
Hello Andrey, do you plan to MFC this one? On Tue, Apr 28, 2015 at 11:29 AM, Andrey V. Elsukov wrote: > Author: ae > Date: Tue Apr 28 09:29:28 2015 > New Revision: 282132 > URL: https://svnweb.freebsd.org/changeset/base/282132 > > Log: > Since PFIL can change mbuf pointer, we should update po

Re: svn commit: r285050 - in head: lib/libutil usr.sbin/pwd_mkdb

2015-07-02 Thread Ermal Luçi
On Thu, Jul 2, 2015 at 7:31 PM, Renato Botelho wrote: > Author: garga (ports committer) > Date: Thu Jul 2 17:30:59 2015 > New Revision: 285050 > URL: https://svnweb.freebsd.org/changeset/base/285050 > > Log: > When passwd or group information is changed (by pw, vipw, chpass, ...) > temporary

svn commit: r285051 - head/sys/netinet

2015-07-02 Thread Ermal Luçi
Author: eri Date: Thu Jul 2 18:10:41 2015 New Revision: 285051 URL: https://svnweb.freebsd.org/changeset/base/285051 Log: Avoid doing multiple route lookups for the same destination IP during forwarding ip_forward() does a route lookup for testing this packet can be sent to a known desti

svn commit: r285096 - head/sys/netipsec

2015-07-03 Thread Ermal Luçi
Author: eri Date: Fri Jul 3 15:31:56 2015 New Revision: 285096 URL: https://svnweb.freebsd.org/changeset/base/285096 Log: Reduce overhead of IPSEC for traffic generated from host When IPSEC is enabled on the kernel the forwarding path has an optimization to not enter the code paths for

svn commit: r285325 - head/sys/netinet

2015-07-09 Thread Ermal Luçi
Author: eri Date: Thu Jul 9 16:28:36 2015 New Revision: 285325 URL: https://svnweb.freebsd.org/changeset/base/285325 Log: Correct issue presented in r285051, apparently neither clang nor gcc complain about this. But clang intis the var to NULL correctly while gcc on at least mips does not.

svn commit: r285770 - in head/sys: netinet netipsec

2015-07-21 Thread Ermal Luçi
Author: eri Date: Tue Jul 21 21:46:24 2015 New Revision: 285770 URL: https://svnweb.freebsd.org/changeset/base/285770 Log: IPSEC, remove variable argument function its already due. Differential Revision:https://reviews.freebsd.org/D3080 Reviewed by: gnn, ae Approved by:

Re: svn commit: r286000 - head/sys/netipsec

2015-07-29 Thread Ermal Luçi
Hello John-Mark, this was forgotten part on my patches merge from gnn@. Can it be fixed by correcting the patches rather than re-introducing this? Most probably the constant definition is wrong on the transforms and also some part of code removal was missed. On Wed, Jul 29, 2015 at 9:15 AM, J

Re: svn commit: r285051 - head/sys/netinet

2015-07-29 Thread Ermal Luçi
On Tue, Jul 28, 2015 at 2:42 PM, Gleb Smirnoff wrote: > Ermal, > > see comments inlined, > > On Thu, Jul 02, 2015 at 06:10:42PM +0000, Ermal Luçi wrote: > E> Author: eri > E> Date: Thu Jul 2 18:10:41 2015 > E> New Revision: 285051 > E> URL: https://s

Re: svn commit: r285051 - head/sys/netinet

2015-07-29 Thread Ermal Luçi
On Wed, Jul 29, 2015 at 6:48 PM, George Neville-Neil wrote: > > > On 29 Jul 2015, at 11:05, Gleb Smirnoff wrote: > > Ermal, >> >> On Wed, Jul 29, 2015 at 03:00:59PM +0200, Ermal Luçi wrote: >> E> > E> @@ -934,6 +950,7 @@ ip_forward(struct mbuf *m

Re: svn commit: r286000 - head/sys/netipsec

2015-07-29 Thread Ermal Luçi
On Wed, Jul 29, 2015 at 5:40 PM, John-Mark Gurney wrote: > Ermal Lui wrote this message on Wed, Jul 29, 2015 at 14:53 +0200: > > this was forgotten part on my patches merge from gnn@. > > Can it be fixed by correcting the patches rather than re-introducing > this? > > > > Most probably the consta

svn commit: r286025 - stable/10/sys/netinet

2015-07-29 Thread Ermal Luçi
Author: eri Date: Wed Jul 29 17:46:16 2015 New Revision: 286025 URL: https://svnweb.freebsd.org/changeset/base/286025 Log: MFC r285051 Avoid doing multiple route lookups for the same destination IP during forwarding. Differential Revision:https://reviews.freebsd.org/D2964 Modifi

svn commit: r286026 - stable/10/sys/netinet

2015-07-29 Thread Ermal Luçi
Author: eri Date: Wed Jul 29 17:50:14 2015 New Revision: 286026 URL: https://svnweb.freebsd.org/changeset/base/286026 Log: MFC 285325 Correct issue presented in r285051 by properly initializing variable. Differential Revision: https://reviews.freebsd.org/D3036 Modified: stable/

svn commit: r286028 - head/sys/netinet

2015-07-29 Thread Ermal Luçi
Author: eri Date: Wed Jul 29 18:04:01 2015 New Revision: 286028 URL: https://svnweb.freebsd.org/changeset/base/286028 Log: ip_output normalization and fixes ip_output has a big chunk of code used to handle special cases with pfil consumers which also forces a reloop on it. Gather all thi

svn commit: r286037 - head/sys/netinet

2015-07-29 Thread Ermal Luçi
Author: eri Date: Wed Jul 29 20:10:36 2015 New Revision: 286037 URL: https://svnweb.freebsd.org/changeset/base/286037 Log: Avoid double reference decrement when firewalls force relooping of packets When firewalls force a reloop of packets and the caller supplied a route the reference to th

svn commit: r286095 - head/sys/netipsec

2015-07-30 Thread Ermal Luçi
Author: eri Date: Thu Jul 30 20:56:27 2015 New Revision: 286095 URL: https://svnweb.freebsd.org/changeset/base/286095 Log: Correct IPSec SA statistic keeping The IPsec SA statistic keeping is used even for decision making on expiry/rekeying SAs. When there are multiple transformations be

Re: svn commit: r286028 - head/sys/netinet

2015-08-02 Thread Ermal Luçi
On Sun, Aug 2, 2015 at 8:40 PM, Mark Johnston wrote: > On Wed, Jul 29, 2015 at 06:04:02PM +0000, Ermal Luçi wrote: > > Author: eri > > Date: Wed Jul 29 18:04:01 2015 > > New Revision: 286028 > > URL: https://svnweb.freebsd.org/changeset/base/286028 > > > >

Re: svn commit: r285051 - head/sys/netinet

2015-08-03 Thread Ermal Luçi
Hello Olivier, its strange seeing so much contention on the arp tables on your PMC stats. Do you run ping(to prepopulate arp) or static arp to remove the noise from that interaction? Also do you run with flowtable active? On Mon, Aug 3, 2015 at 3:06 PM, Olivier Cochard-Labbé wrote: > On Tue, J

Re: svn commit: r285051 - head/sys/netinet

2015-08-03 Thread Ermal Luçi
On Mon, Aug 3, 2015 at 5:18 PM, Olivier Cochard-Labbé wrote: > On Mon, Aug 3, 2015 at 5:05 PM, Ermal Luçi wrote: > >> Hello Olivier, >> >> its strange seeing so much contention on the arp tables on your PMC stats. >> Do you run ping(to prepopulate arp) or static a

Re: svn commit: r286337 - head/sys/contrib/dev/ath/ath_hal/ar9300

2015-08-06 Thread Ermal Luçi
I did the port for pfSense and the whole stack works from HEAD into 10-STABLE. Just minor modifications were required. If you want i can try to send the diff. On Wed, Aug 5, 2015 at 11:55 PM, Oliver Pinter < oliver.pin...@hardenedbsd.org> wrote: > Yup. :) If you need testers with the backport, t

svn commit: r315877 - head/sys/net

2017-03-23 Thread Ermal Luçi
Author: eri Date: Fri Mar 24 00:55:16 2017 New Revision: 315877 URL: https://svnweb.freebsd.org/changeset/base/315877 Log: Correct handling of ALTQ with epair(4) interfaces but presenting that ALTQ(9) is supported. Approved by: ae MFC after:2 weeks Modified: head/sys/net/if_epair

svn commit: r313524 - in head/sys: netinet netinet6

2017-02-09 Thread Ermal Luçi
Author: eri Date: Fri Feb 10 05:16:14 2017 New Revision: 313524 URL: https://svnweb.freebsd.org/changeset/base/313524 Log: The patch provides the same socket option as Linux IP_ORIGDSTADDR. Unfortunately they will have different integer value due to Linux value being already assigned in FreeB

svn commit: r313527 - in head/sys: netinet netinet6

2017-02-09 Thread Ermal Luçi
Author: eri Date: Fri Feb 10 05:51:39 2017 New Revision: 313527 URL: https://svnweb.freebsd.org/changeset/base/313527 Log: Correct missed variable name. Reported-by: ohartm...@walstatt.org Modified: head/sys/netinet/in_pcb.c head/sys/netinet/in_pcb.h head/sys/netinet/tcp_usrreq.c h

svn commit: r313528 - in head/sys: netinet netinet6

2017-02-09 Thread Ermal Luçi
Author: eri Date: Fri Feb 10 05:58:16 2017 New Revision: 313528 URL: https://svnweb.freebsd.org/changeset/base/313528 Log: Revert r313527 Heh svn is not git Modified: head/sys/netinet/in_pcb.c head/sys/netinet/in_pcb.h head/sys/netinet/tcp_usrreq.c head/sys/netinet/udp_usrreq.c h

svn commit: r313529 - head/sys/netinet

2017-02-09 Thread Ermal Luçi
Author: eri Date: Fri Feb 10 06:01:47 2017 New Revision: 313529 URL: https://svnweb.freebsd.org/changeset/base/313529 Log: Fix build after r313524 Reported-by: ohartm...@walstatt.org Modified: head/sys/netinet/udp_usrreq.c Modified: head/sys/netinet/udp_usrreq.c

svn commit: r313530 - head/sys/netinet6

2017-02-09 Thread Ermal Luçi
Author: eri Date: Fri Feb 10 06:20:27 2017 New Revision: 313530 URL: https://svnweb.freebsd.org/changeset/base/313530 Log: Use proper value for socket option on IPv6 Reported-by: ohartm...@walstatt.org Modified: head/sys/netinet6/in6.h Modified: head/sys/netinet6/in6.h ===

svn commit: r313675 - in head/sys: netinet netinet6

2017-02-11 Thread Ermal Luçi
Author: eri Date: Sun Feb 12 06:56:33 2017 New Revision: 313675 URL: https://svnweb.freebsd.org/changeset/base/313675 Log: Committed without approval from mentor. Reported by: gnn Modified: head/sys/netinet/in.h head/sys/netinet/in_pcb.c head/sys/netinet/in_pcb.h head/sys/netinet/

svn commit: r314722 - in head: share/man/man4 sys/netinet sys/netinet6

2017-03-05 Thread Ermal Luçi
Author: eri Date: Mon Mar 6 04:01:58 2017 New Revision: 314722 URL: https://svnweb.freebsd.org/changeset/base/314722 Log: The patch provides the same socket option as Linux IP_ORIGDSTADDR. Unfortunately they will have different integer value due to Linux value being already assigned in FreeB

Re: svn commit: r315136 - head/sys/netpfil/pf

2017-03-14 Thread Ermal Luçi
On Tue, Mar 14, 2017 at 2:57 PM, Gleb Smirnoff wrote: > Kristof, > > On Sun, Mar 12, 2017 at 05:42:57AM +, Kristof Provost wrote: > K> Log: > K> pf: Fix incorrect rw_sleep() in pf_unload() > K> > K> When we unload we don't hold the pf_rules_lock, so we cannot call > rw_sleep() > K> wi

Re: svn commit: r286337 - head/sys/contrib/dev/ath/ath_hal/ar9300

2015-08-19 Thread Ermal Luçi
-a > > > On 6 August 2015 at 00:21, Ermal Luçi wrote: > > I did the port for pfSense and the whole stack works from HEAD into > > 10-STABLE. > > > > Just minor modifications were required. > > If you want i can try to send the diff. > > >

Re: svn commit: r287009 - in head: sbin/pfctl share/man/man4 sys/conf sys/net/altq sys/netpfil/pf

2015-08-22 Thread Ermal Luçi
On Sat, Aug 22, 2015 at 12:02 AM, Luiz Otavio O Souza wrote: > Author: loos > Date: Fri Aug 21 22:02:22 2015 > New Revision: 287009 > URL: https://svnweb.freebsd.org/changeset/base/287009 > > Log: > Add ALTQ(9) support for the CoDel algorithm. > > CoDel is a parameterless queue discipline tha

Re: svn commit: r287009 - in head: sbin/pfctl share/man/man4 sys/conf sys/net/altq sys/netpfil/pf

2015-08-24 Thread Ermal Luçi
On Sun, Aug 23, 2015 at 12:34 AM, Luiz Otavio O Souza wrote: > On Sat, Aug 22, 2015 at 6:18 AM, Ermal Luçi wrote: > > > > > > On Sat, Aug 22, 2015 at 12:02 AM, Luiz Otavio O Souza > > wrote: > >> > >> Author: loos > >> Date: Fri Aug 21 2

svn commit: r284512 - head/sys/netinet

2015-06-17 Thread Ermal Luçi
Author: eri Date: Wed Jun 17 12:23:04 2015 New Revision: 284512 URL: https://svnweb.freebsd.org/changeset/base/284512 Log: If there is a system with a bpf consumer running and a packet is wanted to be transmitted but the arp cache entry expired, which triggers an arp request to be sent, the

svn commit: r284776 - stable/10/sys/netinet

2015-06-24 Thread Ermal Luçi
Author: eri Date: Wed Jun 24 19:06:54 2015 New Revision: 284776 URL: https://svnweb.freebsd.org/changeset/base/284776 Log: MFC r284512: Properly handle locking on the ARP protocol request sending. Modified: stable/10/sys/netinet/if_ether.c Directory Properties: stable/10/ (props changed)

svn commit: r284777 - in head: sbin/pfctl share/man/man4 sys/conf sys/net/altq sys/netpfil/pf

2015-06-24 Thread Ermal Luçi
Author: eri Date: Wed Jun 24 19:16:41 2015 New Revision: 284777 URL: https://svnweb.freebsd.org/changeset/base/284777 Log: ALTQ FAIRQ discipline import from DragonFLY Differential Revision: https://reviews.freebsd.org/D2847 Reviewed by:glebius, wblock(manpage) Approved by:gnn(m

Re: svn commit: r284777 - in head: sbin/pfctl share/man/man4 sys/conf sys/net/altq sys/netpfil/pf

2015-06-25 Thread Ermal Luçi
On Thu, Jun 25, 2015 at 10:42 AM, Bjoern A. Zeeb wrote: > > > On 24 Jun 2015, at 19:16 , Ermal Luçi wrote: > > > > Author: eri > > Date: Wed Jun 24 19:16:41 2015 > > New Revision: 284777 > > URL: https://svnweb.freebsd.org/changeset/base/284777 > &g

Re: svn commit: r284777 - in head: sbin/pfctl share/man/man4 sys/conf sys/net/altq sys/netpfil/pf

2015-06-25 Thread Ermal Luçi
Fixed. On Thu, Jun 25, 2015 at 11:00 AM, Ermal Luçi wrote: > > On Thu, Jun 25, 2015 at 10:42 AM, Bjoern A. Zeeb wrote: > >> >> > On 24 Jun 2015, at 19:16 , Ermal Luçi wrote: >> > >> > Author: eri >> > Date: Wed Jun 24 19:1

svn commit: r284814 - head/sys/net/altq

2015-06-25 Thread Ermal Luçi
Author: eri Date: Thu Jun 25 15:05:58 2015 New Revision: 284814 URL: https://svnweb.freebsd.org/changeset/base/284814 Log: Correct r284777 to use proper includes and remove dead code to unbreak kernel builds. Differential Revision:https://reviews.freebsd.org/D2847 Modified: head

Re: svn commit: r284863 - head/sys/net/altq

2015-06-25 Thread Ermal Luçi
On Fri, Jun 26, 2015 at 1:16 AM, Bjoern A. Zeeb wrote: > Author: bz > Date: Thu Jun 25 23:16:01 2015 > New Revision: 284863 > URL: https://svnweb.freebsd.org/changeset/base/284863 > > Log: > Another attempt to make this compile on more architectures after r284777. > > Modified: > head/sys/net

Re: svn commit: r298091 - in stable/10: sbin/pfctl share/man/man4 sys/conf sys/contrib/altq/altq sys/netpfil/pf

2016-04-18 Thread Ermal Luçi
Careful with things you should credit to me :) Your boss likes to play games do not get in the middle as well. On Sat, Apr 16, 2016 at 4:11 AM, Luiz Otavio O Souza wrote: > Author: loos > Date: Sat Apr 16 02:11:04 2016 > New Revision: 298091 > URL: https://svnweb.freebsd.org/changeset/base/298