svn commit: r264388 - in head/sys: kern sys

2014-04-12 Thread Davide Italiano
Author: davide Date: Sat Apr 12 23:29:29 2014 New Revision: 264388 URL: http://svnweb.freebsd.org/changeset/base/264388 Log: Hide internal details of sbintime_t implementation wrapping INT64_MAX into SBT_MAX, to make it more robust in case internal type representation will change in the futu

svn commit: r264392 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs

2014-04-12 Thread Davide Italiano
Author: davide Date: Sun Apr 13 01:15:37 2014 New Revision: 264392 URL: http://svnweb.freebsd.org/changeset/base/264392 Log: Fix a panic in zfs_rename(). this is due to a wrong dereference of a vnode when it's not locked and can be (potentially) recycled. 'sdvp' cannot be locked on zfs_renam

Re: svn commit: r264392 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs

2014-04-12 Thread Davide Italiano
On Sat, Apr 12, 2014 at 6:43 PM, Steven Hartland wrote: > Interesting, I'd be curious to know what the panic for this looks like? > It's more like a 'trap 12: page fault while in kernel mode'. Post-mortem analysis with kgdb shows the vnode fields filled with garbage (e.g. 0xdeadc0de), if you're l

svn commit: r252352 - head/sys/fs/smbfs

2013-06-28 Thread Davide Italiano
Author: davide Date: Fri Jun 28 20:07:24 2013 New Revision: 252352 URL: http://svnweb.freebsd.org/changeset/base/252352 Log: Plug a couple of leakages in smbfs_lookup(). Modified: head/sys/fs/smbfs/smbfs_vnops.c Modified: head/sys/fs/smbfs/smbfs_vnops.c ==

svn commit: r252353 - head/sys/fs/smbfs

2013-06-28 Thread Davide Italiano
Author: davide Date: Fri Jun 28 20:14:30 2013 New Revision: 252353 URL: http://svnweb.freebsd.org/changeset/base/252353 Log: Garbage collect an useless check. smp should be never NULL. Modified: head/sys/fs/smbfs/smbfs_vfsops.c Modified: head/sys/fs/smbfs/smbfs_vfsops.c =

svn commit: r252354 - head/sys/netsmb

2013-06-28 Thread Davide Italiano
Author: davide Date: Fri Jun 28 20:21:13 2013 New Revision: 252354 URL: http://svnweb.freebsd.org/changeset/base/252354 Log: Remove a reference to LK_DRAIN now that lockmgr(9) is gone from this piece of code. Reported by: attilio Modified: head/sys/netsmb/smb_conn.c Modified: head/sy

svn commit: r252355 - head/sys/fs/smbfs

2013-06-28 Thread Davide Italiano
Author: davide Date: Fri Jun 28 20:32:48 2013 New Revision: 252355 URL: http://svnweb.freebsd.org/changeset/base/252355 Log: Properly use v_data field. This magically worked (even if wrong) until now because v_data is the first field of the structure, but it's not something we should rely on

svn commit: r252356 - in head: contrib/smbfs/mount_smbfs etc/defaults etc/mtree include lib lib/libprocstat rescue/rescue sbin/mount share/examples share/examples/etc share/mk sys/conf sys/kern sys...

2013-06-28 Thread Davide Italiano
Author: davide Date: Fri Jun 28 21:00:08 2013 New Revision: 252356 URL: http://svnweb.freebsd.org/changeset/base/252356 Log: - Trim an unused and bogus Makefile for mount_smbfs. - Reconnect with some minor modifications, in particular now selsocket() internals are adapted to use sbintime uni

svn commit: r252357 - head/sys/kern

2013-06-28 Thread Davide Italiano
Author: davide Date: Fri Jun 28 21:04:15 2013 New Revision: 252357 URL: http://svnweb.freebsd.org/changeset/base/252357 Log: Correct the comment above _sleep() function which still mentions 'timo' instead of 'sbintime_t'. Reported by: kan Modified: head/sys/kern/kern_synch.c Modified

svn commit: r252358 - head/sys/vm

2013-06-28 Thread Davide Italiano
Author: davide Date: Fri Jun 28 21:13:19 2013 New Revision: 252358 URL: http://svnweb.freebsd.org/changeset/base/252358 Log: Remove a spurious keg lock acquisition. Modified: head/sys/vm/uma_core.c Modified: head/sys/vm/uma_core.c =

svn commit: r252558 - head/sys/fs/smbfs

2013-07-03 Thread Davide Italiano
Author: davide Date: Wed Jul 3 10:31:45 2013 New Revision: 252558 URL: http://svnweb.freebsd.org/changeset/base/252558 Log: - Fix double frees/user after free. - Allocate using smb_rq_alloc() instead of inlining it. Reported by: uqs Found with: Coverity Scan Modified: head/sys/fs

Re: svn commit: r252356 - in head: contrib/smbfs/mount_smbfs etc/defaults etc/mtree include lib lib/libprocstat rescue/rescue sbin/mount share/examples share/examples/etc share/mk sys/conf sys/kern sy

2013-07-03 Thread Davide Italiano
On Wed, Jul 3, 2013 at 11:28 AM, Ulrich Spörlein wrote: > On Fri, 2013-06-28 at 21:00:08 +0000, Davide Italiano wrote: >> Author: davide >> Date: Fri Jun 28 21:00:08 2013 >> New Revision: 252356 >> URL: http://svnweb.freebsd.org/changeset/base/252356 >> >&g

svn commit: r248099 - head/sys/fs/smbfs

2013-03-09 Thread Davide Italiano
Author: davide Date: Sat Mar 9 13:05:21 2013 New Revision: 248099 URL: http://svnweb.freebsd.org/changeset/base/248099 Log: - Initialize variable in smbfs_rename() to silent compiler warning - Fix smbfs_mkdir() return value (in case of error). Reported by: pho Modified: head/sys/fs/s

svn commit: r248101 - head/sys/fs/smbfs

2013-03-09 Thread Davide Italiano
Author: davide Date: Sat Mar 9 13:25:45 2013 New Revision: 248101 URL: http://svnweb.freebsd.org/changeset/base/248101 Log: smbfs_lookup() in the DOTDOT case operates on dvp->n_parent without proper locking. This doesn't prevent in any case reclaim of the vnode. Avoid this not going over-th

Re: svn commit: r248097 - in head: . lib/libncp lib/libprocstat share/examples/nwclient sys/fs/nwfs sys/modules/ncp sys/modules/nwfs sys/netncp usr.bin/ncplist usr.bin/ncplogin usr.sbin/mount_nwfs

2013-03-09 Thread Davide Italiano
On Sat, Mar 9, 2013 at 5:29 PM, Joel Dahl wrote: > On Sat, Mar 09, 2013 at 04:17:56PM +0100, Attilio Rao wrote: >> On Sat, Mar 9, 2013 at 4:02 PM, Robert Watson wrote: >> > Hi Attilio: >> > >> > It's really great to see the continued progress towards the goal >> > entirely-MPSAFE VFS in 10.x -- w

svn commit: r248109 - head/sys/netsmb

2013-03-09 Thread Davide Italiano
Author: davide Date: Sat Mar 9 16:58:19 2013 New Revision: 248109 URL: http://svnweb.freebsd.org/changeset/base/248109 Log: Call make_dev_credf() rather than using the couple make_dev()/dev_ref(). This closes a race with clone_cleanup(). Modified: head/sys/netsmb/smb_dev.c Modified: head/

svn commit: r248113 - head/sys/kern

2013-03-09 Thread Davide Italiano
Author: davide Date: Sat Mar 9 20:03:10 2013 New Revision: 248113 URL: http://svnweb.freebsd.org/changeset/base/248113 Log: Fixup r248032: Change size requested to malloc(9) now that callwheel buckets are callout_list and not callout_tailq anymore. This change was already there but it see

svn commit: r248699 - head/sys/kern

2013-03-25 Thread Davide Italiano
Author: davide Date: Mon Mar 25 09:43:50 2013 New Revision: 248699 URL: http://svnweb.freebsd.org/changeset/base/248699 Log: Cache the callout precision argument as part of the informations required for migrating callouts to new CPU. This value is passed to callout_cc_add() in order to updat

Re: svn commit: r254309 - in head: share/man/man9 sys/cddl/contrib/opensolaris/uts/common/dtrace sys/cddl/dev/dtrace sys/cddl/dev/sdt sys/kern sys/sys

2013-08-16 Thread Davide Italiano
[trim old mails] > diff --git a/sys/sys/pmckern.h b/sys/sys/pmckern.h > index e3e18a6..90585de 100644 > --- a/sys/sys/pmckern.h > +++ b/sys/sys/pmckern.h > @@ -51,13 +51,11 @@ > #definePMC_FN_CSW_IN 2 > #definePMC_FN_CSW_OUT 3 > #define

Re: svn commit: r254520 - in head/sys: kern sys

2013-08-19 Thread Davide Italiano
On Mon, Aug 19, 2013 at 1:16 PM, Andre Oppermann wrote: > Author: andre > Date: Mon Aug 19 11:16:53 2013 > New Revision: 254520 > URL: http://svnweb.freebsd.org/changeset/base/254520 > > Log: > Remove the unused M_NOFREE mbuf flag. It didn't have any in-tree users > for a very long time, if e

Re: svn commit: r254524 - head/sys/sys

2013-08-20 Thread Davide Italiano
On Tue, Aug 20, 2013 at 7:42 PM, Andre Oppermann wrote: > On 19.08.2013 19:37, Navdeep Parhar wrote: >> >> On 08/19/13 06:56, Andre Oppermann wrote: >>> >>> Author: andre >>> Date: Mon Aug 19 13:56:14 2013 >>> New Revision: 254524 >>> URL: http://svnweb.freebsd.org/changeset/base/254524 >>> >>> Lo

Re: svn commit: r254524 - head/sys/sys

2013-08-21 Thread Davide Italiano
On Wed, Aug 21, 2013 at 5:30 PM, Andre Oppermann wrote: > On 20.08.2013 20:13, Davide Italiano wrote: >> >> On Tue, Aug 20, 2013 at 7:42 PM, Andre Oppermann >> wrote: >>> >>> On 19.08.2013 19:37, Navdeep Parhar wrote: >>>> >>>> Why

Re: svn commit: r254524 - head/sys/sys

2013-08-21 Thread Davide Italiano
On Wed, Aug 21, 2013 at 6:18 PM, Andre Oppermann wrote: > On 21.08.2013 17:59, Davide Italiano wrote: >> >> On Wed, Aug 21, 2013 at 5:30 PM, Andre Oppermann >> wrote: >>> >>> On 20.08.2013 20:13, Davide Italiano wrote: >>>> >>>> &g

Re: svn commit: r254616 - head/sys/dev/hwpmc

2013-08-21 Thread Davide Italiano
On Wed, Aug 21, 2013 at 2:47 PM, Adrian Chadd wrote: > Author: adrian > Date: Wed Aug 21 21:47:56 2013 > New Revision: 254616 > URL: http://svnweb.freebsd.org/changeset/base/254616 > > Log: > Change the name of this particular event to reflect the name used in > Linux and Intel examples. > >

Re: svn commit: r254616 - head/sys/dev/hwpmc

2013-08-21 Thread Davide Italiano
On Wed, Aug 21, 2013 at 2:52 PM, Davide Italiano wrote: > On Wed, Aug 21, 2013 at 2:47 PM, Adrian Chadd wrote: >> Author: adrian >> Date: Wed Aug 21 21:47:56 2013 >> New Revision: 254616 >> URL: http://svnweb.freebsd.org/changeset/base/254616 >> >> Log:

svn commit: r254703 - in head: share/man/man9 sys/sys

2013-08-23 Thread Davide Italiano
Author: davide Date: Fri Aug 23 14:12:39 2013 New Revision: 254703 URL: http://svnweb.freebsd.org/changeset/base/254703 Log: Introduce callout_init_rm() so that callouts can be used in conjunction with rmlocks. This works only with non-sleepable rm because handlers run in SWI context. While

svn commit: r254710 - head/share/man/man9

2013-08-23 Thread Davide Italiano
Author: davide Date: Fri Aug 23 14:33:56 2013 New Revision: 254710 URL: http://svnweb.freebsd.org/changeset/base/254710 Log: - Bump date. - Small mdoc fix. Submitted by: pluknet Modified: head/share/man/man9/timeout.9 Modified: head/share/man/man9/timeout.9 ===

svn commit: r254712 - head/sys/sys

2013-08-23 Thread Davide Italiano
Author: davide Date: Fri Aug 23 14:40:17 2013 New Revision: 254712 URL: http://svnweb.freebsd.org/changeset/base/254712 Log: Fix the build and fix style. Pointy-hat to:davide Modified: head/sys/sys/callout.h Modified: head/sys/sys/callout.h ==

Re: svn commit: r254703 - in head: share/man/man9 sys/sys

2013-08-23 Thread Davide Italiano
On Fri, Aug 23, 2013 at 4:51 PM, John Baldwin wrote: > On Friday, August 23, 2013 10:12:39 am Davide Italiano wrote: >> Author: davide >> Date: Fri Aug 23 14:12:39 2013 >> New Revision: 254703 >> URL: http://svnweb.freebsd.org/changeset/base/254703 >> >> L

Re: svn commit: r254703 - in head: share/man/man9 sys/sys

2013-08-26 Thread Davide Italiano
On Fri, Aug 23, 2013 at 9:58 AM, John Baldwin wrote: > On Friday, August 23, 2013 11:29:45 am Davide Italiano wrote: >> On Fri, Aug 23, 2013 at 4:51 PM, John Baldwin wrote: >> > On Friday, August 23, 2013 10:12:39 am Davide Italiano wrote: >> >> Author: davide &

Re: svn commit: r254585 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs

2013-08-27 Thread Davide Italiano
o the same vnode), then there is nothing to do. > >>> - VOP_REALVP is a glorified nop on FreeBSD >> >> It's not clear to me what was the intention for having a macro instead >> of just ifdef'ing the code out -- maybe to prevent unwanted conflict >>

Re: svn commit: r254585 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs

2013-08-28 Thread Davide Italiano
On Wed, Aug 28, 2013 at 3:02 AM, Xin Li wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA512 [snip] > > On 08/27/13 01:59, Davide Italiano wrote: >> I've written a patch that attempts to fix the second problem. >> http://people.freebsd.org/~davide/revi

Re: svn commit: r254986 - head/sys/ufs/ufs

2013-08-28 Thread Davide Italiano
On Wed, Aug 28, 2013 at 12:06 PM, Ivan Voras wrote: > Author: ivoras > Date: Wed Aug 28 10:06:20 2013 > New Revision: 254986 > URL: http://svnweb.freebsd.org/changeset/base/254986 > > Log: > Take a very small step toward the Century of the Anchovy by increasing the > time dirhash entries stay

Re: svn commit: r254986 - head/sys/ufs/ufs

2013-08-28 Thread Davide Italiano
On Wed, Aug 28, 2013 at 12:31 PM, Ivan Voras wrote: > On 28 August 2013 12:25, Davide Italiano wrote: > >> do you have any evidence that this change impacts positively (or >> negatively) performances for some workloads? If yes, can you share? > > Yes, observation of my o

Re: svn commit: r254986 - head/sys/ufs/ufs

2013-08-28 Thread Davide Italiano
On Wed, Aug 28, 2013 at 12:53 PM, Ivan Voras wrote: > On 28 August 2013 12:44, Davide Italiano wrote: > >> Do you realize that this is a driven by commit change, right? And >> there's no technical motivatiion about this or experimental data that >> confirms you'

svn commit: r255133 - head/sys/dev/hwpmc

2013-09-01 Thread Davide Italiano
Author: davide Date: Sun Sep 1 21:44:43 2013 New Revision: 255133 URL: http://svnweb.freebsd.org/changeset/base/255133 Log: Complete r250105. Do not zero fields if M_ZERO flag is specified to malloc(9). Reported by: pluknet, glebius Modified: head/sys/dev/hwpmc/hwpmc_mod.c Modified:

svn commit: r255135 - head/sys/sys

2013-09-01 Thread Davide Italiano
Author: davide Date: Sun Sep 1 22:30:24 2013 New Revision: 255135 URL: http://svnweb.freebsd.org/changeset/base/255135 Log: Use single underscore for all parameters name and local variables in bintime_* related functions. This commit completes what was already done by theraven@ for bintime_

Re: svn commit: r255135 - head/sys/sys

2013-09-01 Thread Davide Italiano
On Mon, Sep 2, 2013 at 12:30 AM, Davide Italiano wrote: > Author: davide > Date: Sun Sep 1 22:30:24 2013 > New Revision: 255135 > URL: http://svnweb.freebsd.org/changeset/base/255135 > > Log: > Use single underscore for all parameters name and local variables in > bin

svn commit: r255138 - in head/sys: kern sys

2013-09-01 Thread Davide Italiano
Author: davide Date: Sun Sep 1 23:34:53 2013 New Revision: 255138 URL: http://svnweb.freebsd.org/changeset/base/255138 Log: Fix socket buffer timeouts precision using the new sbintime_t KPI instead of relying on the tvtohz() workaround. The latter has been introduced lately by jhb@ (r254699

svn commit: r255329 - head/sys/net

2013-09-06 Thread Davide Italiano
Author: davide Date: Fri Sep 6 21:02:43 2013 New Revision: 255329 URL: http://svnweb.freebsd.org/changeset/base/255329 Log: Retire netisr.netisr_direct and netisr.netisr_direct_force sysctls. These were used to control/export dispatch policy but they're not anymore. This commit cannot be MF

Re: svn commit: r255329 - head/sys/net

2013-09-06 Thread Davide Italiano
On Fri, Sep 6, 2013 at 11:02 PM, Davide Italiano wrote: > Author: davide > Date: Fri Sep 6 21:02:43 2013 > New Revision: 255329 > URL: http://svnweb.freebsd.org/changeset/base/255329 > > Log: > Retire netisr.netisr_direct and netisr.netisr_direct_force sysctls. > Th

svn commit: r255359 - in head/sys: cddl/dev/dtrace dev/firewire dev/vkbd security/audit

2013-09-07 Thread Davide Italiano
Author: davide Date: Sat Sep 7 13:45:44 2013 New Revision: 255359 URL: http://svnweb.freebsd.org/changeset/base/255359 Log: - Use make_dev_credf(MAKEDEV_REF) instead of the race-prone make_dev()+ dev_ref() in the clone handlers that still use it. - Don't set SI_CHEAPCLONE flag, it's not use

svn commit: r255360 - head/sys/net

2013-09-07 Thread Davide Italiano
Author: davide Date: Sat Sep 7 13:50:13 2013 New Revision: 255360 URL: http://svnweb.freebsd.org/changeset/base/255360 Log: Don't clear the unused SI_CHEAPCLONE flag in tap_create()/tuncreate(). Reviewed by: kib Modified: head/sys/net/if_tap.c head/sys/net/if_tun.c Modified: head/sy

Re: svn commit: r255359 - in head/sys: cddl/dev/dtrace dev/firewire dev/vkbd security/audit

2013-09-08 Thread Davide Italiano
On Sun, Sep 8, 2013 at 6:24 PM, Ed Schouten wrote: > 2013/9/7 Davide Italiano : >> Log: >> - Use make_dev_credf(MAKEDEV_REF) instead of the race-prone make_dev()+ >> dev_ref() in the clone handlers that still use it. >> - Don't set SI_CHEAPCLONE flag, it'

Re: svn commit: r255360 - head/sys/net

2013-09-08 Thread Davide Italiano
On Sun, Sep 8, 2013 at 6:26 PM, Ed Schouten wrote: > 2013/9/7 Davide Italiano : >> Log: >> Don't clear the unused SI_CHEAPCLONE flag in tap_create()/tuncreate(). > > Both the tun and the tap driver still use clonelists, right? I'm not > sure this fix is all ri

Re: svn commit: r255437 - in head: cddl/contrib/opensolaris/lib/libzpool/common cddl/contrib/opensolaris/lib/libzpool/common/sys sys/cddl/compat/opensolaris/sys sys/cddl/contrib/opensolaris/uts/common

2013-09-10 Thread Davide Italiano
On Tue, Sep 10, 2013 at 3:46 AM, Xin LI wrote: [snip] > +static clock_t > +cv_timedwait_hires(kcondvar_t *cvp, kmutex_t *mp, hrtime_t tim, hrtime_t res, > +int flag) > +{ > + sbintime_t sbt; > + sbintime_t pr; > + > + sbt = tim * SBT_1NS; > + pr = res * SBT_1NS; > + >

Re: svn commit: r255067 - head/sys/kern

2013-09-10 Thread Davide Italiano
> == > --- head/sys/kern/kern_synch.c Fri Aug 30 10:10:22 2013(r255066) > +++ head/sys/kern/kern_synch.c Fri Aug 30 10:39:56 2013(r255067) > @@ -356,10 +356,7 @@ msleep_spin_sbt(void *ident, struct mtx >

Re: svn commit: r255067 - head/sys/kern

2013-09-10 Thread Davide Italiano
On Tue, Sep 10, 2013 at 11:16 PM, Davide Italiano wrote: >> == >> --- head/sys/kern/kern_synch.c Fri Aug 30 10:10:22 2013(r255066) >> +++ head/sys/kern/kern_synch.c Fri Aug 30 10:39:56 20

Re: svn commit: r254703 - in head: share/man/man9 sys/sys

2013-09-11 Thread Davide Italiano
[snip] > Well, I've thought about changing lc_lock/unlock to return a uintptr_t or > void * instead of an int and then I could make rm_sleep work fine. However, > that still doesn't solve the callout case. The callout case can't be fixed > easily without explicitly allocating storage in the soft

Re: svn commit: r254703 - in head: share/man/man9 sys/sys

2013-09-18 Thread Davide Italiano
On Thu, Sep 12, 2013 at 4:08 PM, John Baldwin wrote: > Hmm, I think I had envisioned something a bit simpler. Namely, I would > change lc_lock/lc_unlock to return a uintptr_t instead of an int, and > I would then change lc_unlock for an rm lock to return a pointer to the > current thread's tracke

svn commit: r250096 - head/sys/dev/hwpmc

2013-04-30 Thread Davide Italiano
Author: davide Date: Tue Apr 30 08:18:08 2013 New Revision: 250096 URL: http://svnweb.freebsd.org/changeset/base/250096 Log: Fixup Westmere hwpmc(4) support: add missing CPU flag so that intrucion-retired, llc-misses and llc-reference events can now be allocated. Reviewed by: jimharris

svn commit: r250097 - head/sys/dev/hwpmc

2013-04-30 Thread Davide Italiano
Author: davide Date: Tue Apr 30 08:33:38 2013 New Revision: 250097 URL: http://svnweb.freebsd.org/changeset/base/250097 Log: When hwpmc(4) module is unloaded it reports a double leakage. This happens at least if FreeBSD is ran under VirtualBox. In order to avoid the leakage, properly dealloc

svn commit: r250101 - head/sys/dev/hwpmc

2013-04-30 Thread Davide Italiano
Author: davide Date: Tue Apr 30 14:56:41 2013 New Revision: 250101 URL: http://svnweb.freebsd.org/changeset/base/250101 Log: Complete r250097: Do not change the initialization order in pmc_intel_initialize(). Modified: head/sys/dev/hwpmc/hwpmc_intel.c Modified: head/sys/dev/hwpmc/hwpmc_int

svn commit: r250103 - head/sys/dev/hwpmc

2013-04-30 Thread Davide Italiano
Author: davide Date: Tue Apr 30 15:31:45 2013 New Revision: 250103 URL: http://svnweb.freebsd.org/changeset/base/250103 Log: The Intel PMC architectural events have encodings which are identical to those of some non-architectural core events. This is not a problem in the general case as long

svn commit: r250105 - head/sys/dev/hwpmc

2013-04-30 Thread Davide Italiano
Author: davide Date: Tue Apr 30 15:59:22 2013 New Revision: 250105 URL: http://svnweb.freebsd.org/changeset/base/250105 Log: malloc(9) cannot return NULL if M_WAITOK flag is specified. Modified: head/sys/dev/hwpmc/hwpmc_mod.c head/sys/dev/hwpmc/hwpmc_soft.c Modified: head/sys/dev/hwpmc/hwp

svn commit: r250149 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs

2013-05-01 Thread Davide Italiano
Author: davide Date: Wed May 1 17:34:44 2013 New Revision: 250149 URL: http://svnweb.freebsd.org/changeset/base/250149 Log: In case ZFS doesn't use UMA for buffers there's no need to waste memory creating zones that will remain empty. Reviewed by: pjd Modified: head/sys/cddl/contrib/

svn commit: r250182 - head/sys/dev/hwpmc

2013-05-02 Thread Davide Italiano
Author: davide Date: Thu May 2 14:55:21 2013 New Revision: 250182 URL: http://svnweb.freebsd.org/changeset/base/250182 Log: Suppress a GCC warning. This warning is actually bogus and newer GCC versions than the one in base (dim@ mentioned he tried on 4.7.3 and 4.8.1) do not whine about it,

svn commit: r250236 - in head: contrib/smbfs/lib/smb contrib/smbfs/mount_smbfs sys/fs/smbfs sys/netsmb

2013-05-04 Thread Davide Italiano
Author: davide Date: Sat May 4 14:03:18 2013 New Revision: 250236 URL: http://svnweb.freebsd.org/changeset/base/250236 Log: Completely rewrite the interface to smbdev switching from dev_clone to cdevpriv(9). This commit changes the semantic of mount_smbfs in userland as well, which now pass

svn commit: r250237 - in head/sys: fs/smbfs netsmb

2013-05-04 Thread Davide Italiano
Author: davide Date: Sat May 4 14:18:10 2013 New Revision: 250237 URL: http://svnweb.freebsd.org/changeset/base/250237 Log: Overhaul locking in netsmb, getting rid of the obsolete lockmgr() primitive. This solves a long standing LOR between smb_conn and smb_vc. Tested by:martymac, ph

svn commit: r250238 - head/sys/fs/smbfs

2013-05-04 Thread Davide Italiano
Author: davide Date: Sat May 4 14:27:28 2013 New Revision: 250238 URL: http://svnweb.freebsd.org/changeset/base/250238 Log: Change VM_OBJECT_LOCK/UNLOCK() -> VM_OBJECT_WLOCK/WUNLOCK() to reflect the recent switch of the vm object lock to a rwlock. Reported by: attilio Modified: head/

svn commit: r250243 - head/sys/netsmb

2013-05-04 Thread Davide Italiano
Author: davide Date: Sat May 4 16:55:48 2013 New Revision: 250243 URL: http://svnweb.freebsd.org/changeset/base/250243 Log: If the kernel is compiled with VMIMAGE support, the first attempt of mounting smbfs share will cause a panic. Fix setting setting/restoring vnet context when needed.

svn commit: r255745 - in head/sys: dev/hwpmc kern sys

2013-09-20 Thread Davide Italiano
Author: davide Date: Fri Sep 20 23:06:21 2013 New Revision: 255745 URL: http://svnweb.freebsd.org/changeset/base/255745 Log: Fix lc_lock/lc_unlock() support for rmlocks held in shared mode. With current lock classes KPI it was really difficult because there was no way to pass an rmtracker ob

svn commit: r255746 - head/sys/dev/hwpmc

2013-09-20 Thread Davide Italiano
Author: davide Date: Fri Sep 20 23:10:52 2013 New Revision: 255746 URL: http://svnweb.freebsd.org/changeset/base/255746 Log: Remove local change leftover, this should never have been part of r255745. Pointy-hat to:davide Approved by: re (implicit) Modified: head/sys/dev/hwpm

svn commit: r255747 - head/sys/kern

2013-09-20 Thread Davide Italiano
Author: davide Date: Fri Sep 20 23:16:15 2013 New Revision: 255747 URL: http://svnweb.freebsd.org/changeset/base/255747 Log: Fix callout_init_rm() in the shared case, allocating storage for 'struct rm_priotracker' directly in the softclock thread. Now consumers can pass CALLOUT_SHAREDLOCK fl

svn commit: r255748 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs

2013-09-20 Thread Davide Italiano
Author: davide Date: Fri Sep 20 23:22:00 2013 New Revision: 255748 URL: http://svnweb.freebsd.org/changeset/base/255748 Log: Fixup cross-device rename checks in ZFS. Add a check for the case where 'fdvp' is a directory, 'tvp' is an already existing directory and they have different mount poi

svn commit: r255788 - head/sys/kern

2013-09-22 Thread Davide Italiano
Author: davide Date: Sun Sep 22 14:09:07 2013 New Revision: 255788 URL: http://svnweb.freebsd.org/changeset/base/255788 Log: Consistently use the same value to indicate exclusively-held and shared-held locks for all the primitives in lc_lock/lc_unlock routines. This fixes the problems introd

Re: svn commit: r255437 - in head: cddl/contrib/opensolaris/lib/libzpool/common cddl/contrib/opensolaris/lib/libzpool/common/sys sys/cddl/compat/opensolaris/sys sys/cddl/contrib/opensolaris/uts/common

2013-09-23 Thread Davide Italiano
On Mon, Sep 23, 2013 at 9:14 AM, Andriy Gapon wrote: > on 10/09/2013 15:03 Davide Italiano said the following: >> The Illumos cv_timedwait_hires() doesn't use 'res' argument so if you >> want to be consistent with their behaviour you should pass '0' as &

svn commit: r255877 - head/sys/kern

2013-09-26 Thread Davide Italiano
Author: davide Date: Thu Sep 26 10:06:50 2013 New Revision: 255877 URL: http://svnweb.freebsd.org/changeset/base/255877 Log: Make the callout arithmetic more robust adding checks for overflow. Without these, if the timeout value passed is "large enough", the value of the sum of it and other

svn commit: r232353 - head/usr.bin/calendar/calendars

2012-03-01 Thread Davide Italiano
(r232353) @@ -217,7 +217,7 @@ 07/11 Jesus R. Camou born in Hermosillo, Sonora, Mexico, 1983 07/15 Gary Jennejohn born in Rochester, New York, United States, 1950 07/16 Suleiman Souhlal born in Roma, Italy, 1983 -07/16 Davide Italiano born in Milazzo, Italy, 1989 +07/16 Davide

svn commit: r232366 - in head: lib/libpmc sys/dev/hwpmc sys/sys

2012-03-01 Thread Davide Italiano
mc/pmc.sandybridge.3 == --- /dev/null 00:00:00 1970 (empty, because file is newly added) +++ head/lib/libpmc/pmc.sandybridge.3 Thu Mar 1 21:23:26 2012 (r232366) @@ -0,0 +1,932 @@ +.\" Copyright (c) 2012 Davide Italiano

svn commit: r233045 - in head/sys: conf kern

2012-03-16 Thread Davide Italiano
Author: davide Date: Fri Mar 16 20:32:11 2012 New Revision: 233045 URL: http://svn.freebsd.org/changeset/base/233045 Log: Add rudimentary profiling of the hash table used in the in the umtx code to hold active lock queues. Reviewed by: attilio Approved by: davidxu, gnn (mentor) MFC

Re: svn commit: r233045 - in head/sys: conf kern

2012-03-19 Thread Davide Italiano
2012/3/19 Gleb Smirnoff : >  Davide, > > On Fri, Mar 16, 2012 at 08:32:11PM +0000, Davide Italiano wrote: > D> Author: davide > D> Date: Fri Mar 16 20:32:11 2012 > D> New Revision: 233045 > D> URL: http://svn.freebsd.org/changeset/base/233045 > D> > D>

Re: svn commit: r233045 - in head/sys: conf kern

2012-03-19 Thread Davide Italiano
On Mon, Mar 19, 2012 at 8:54 PM, Davide Italiano wrote: > 2012/3/19 Gleb Smirnoff : >>  Davide, >> >> On Fri, Mar 16, 2012 at 08:32:11PM +, Davide Italiano wrote: >> D> Author: davide >> D> Date: Fri Mar 16 20:32:11 2012 >> D> New Revision: 23

Re: svn commit: r233045 - in head/sys: conf kern

2012-03-20 Thread Davide Italiano
2012/3/20 Gleb Smirnoff : > On Mon, Mar 19, 2012 at 09:06:36PM +0100, Davide Italiano wrote: > D> >> These indented ifdefs look like a major violation of style used > throughout > D> >> the FreeBSD kernel code. Can you please keep with common style? > D> >

svn commit: r230876 - in head: share/misc usr.bin/calendar/calendars

2012-02-01 Thread Davide Italiano
+118,7 @@ cokane [label="Coleman Kane\ncokane@Free cperciva [label="Colin Percival\ncperc...@freebsd.org\n2004/01/20"] csjp [label="Christian S.J. Peron\nc...@freebsd.org\n2004/05/04"] das [label="David Schultz\n...@freebsd.org\n2003/02/21"] +davide [label="D

Re: svn commit: r243307 - head/sys/kern

2012-11-19 Thread Davide Italiano
On Mon, Nov 19, 2012 at 9:43 PM, Attilio Rao wrote: > Author: attilio > Date: Mon Nov 19 20:43:19 2012 > New Revision: 243307 > URL: http://svnweb.freebsd.org/changeset/base/243307 > > Log: > insmntque() is always called with the lock held in exclusive mode, > then: > - assume the lock is he

Re: svn commit: r243307 - head/sys/kern

2012-11-19 Thread Davide Italiano
On Mon, Nov 19, 2012 at 9:55 PM, Attilio Rao wrote: > On Mon, Nov 19, 2012 at 8:53 PM, Davide Italiano wrote: >> On Mon, Nov 19, 2012 at 9:43 PM, Attilio Rao wrote: >>> Author: attilio >>> Date: Mon Nov 19 20:43:19 2012 >>> New Revision: 243307 >>>

svn commit: r243396 - head/sys/fs/smbfs

2012-11-22 Thread Davide Italiano
Author: davide Date: Thu Nov 22 08:58:29 2012 New Revision: 243396 URL: http://svnweb.freebsd.org/changeset/base/243396 Log: Until now, smbfs_fullpath() computed the full path starting from the vnode and following back the chain of n_parent pointers up to the root, without acquiring the lock

svn commit: r243397 - head/sys/fs/smbfs

2012-11-22 Thread Davide Italiano
Author: davide Date: Thu Nov 22 09:13:45 2012 New Revision: 243397 URL: http://svnweb.freebsd.org/changeset/base/243397 Log: - Remove reset of vpp pointer in some places as long as it's not really useful and has the side effect of obfuscating the code a bit. - Remove spurious references to s

svn commit: r243548 - head/sys/fs/smbfs

2012-11-25 Thread Davide Italiano
Author: davide Date: Mon Nov 26 04:29:47 2012 New Revision: 243548 URL: http://svnweb.freebsd.org/changeset/base/243548 Log: - smbfs_rename() might return an error value without correctly upgrading the vnode use count, and this might cause the kernel to panic if compiled with WITNESS enable.

Re: svn commit: r238539 - head/sys/fs/smbfs

2012-10-10 Thread Davide Italiano
On Wed, Jul 18, 2012 at 2:11 PM, Christian Brueffer wrote: > On 7/17/12 0:10 , Attilio Rao wrote: >> 2012/7/16 Christian Brueffer : >>> Author: brueffer >>> Date: Mon Jul 16 22:07:29 2012 >>> New Revision: 238539 >>> URL: http://svn.freebsd.org/changeset/base/238539 >>> >>> Log: >>> Simply error

svn commit: r242092 - head/sys/fs/smbfs

2012-10-25 Thread Davide Italiano
Author: davide Date: Thu Oct 25 20:23:04 2012 New Revision: 242092 URL: http://svn.freebsd.org/changeset/base/242092 Log: - Remove the references to the deprecated zalloc kernel interface - Use M_ZERO flag in malloc() rather than bzero() - malloc() with M_NOWAIT can't return NULL so there's

svn commit: r242097 - head/sys/fs/smbfs

2012-10-25 Thread Davide Italiano
Author: davide Date: Thu Oct 25 21:08:02 2012 New Revision: 242097 URL: http://svn.freebsd.org/changeset/base/242097 Log: Fix build in case we have SMBVDEBUG turned on. Reviewed by: gnn Approved by: gnn Sponsored by: iXsystems inc. Modified: head/sys/fs/smbfs/smbfs_io.c head/sys/

svn commit: r242196 - stable/9/sys/dev/bce

2012-10-27 Thread Davide Italiano
Author: davide Date: Sat Oct 27 23:12:05 2012 New Revision: 242196 URL: http://svn.freebsd.org/changeset/base/242196 Log: MFC r239110: Remove a spurious brace which causes build fail in case BCE_DEBUG option is turned on. Modified: stable/9/sys/dev/bce/if_bce.c Directory Properties: sta

svn commit: r242198 - stable/8/sys/dev/bce

2012-10-27 Thread Davide Italiano
Author: davide Date: Sat Oct 27 23:17:22 2012 New Revision: 242198 URL: http://svn.freebsd.org/changeset/base/242198 Log: MFC r239110: Remove a spurious brace which causes build fail in case BCE_DEBUG option is turned on. Modified: stable/8/sys/dev/bce/if_bce.c Directory Properties: sta

svn commit: r242199 - in stable/9/sys: conf kern

2012-10-27 Thread Davide Italiano
Author: davide Date: Sat Oct 27 23:30:46 2012 New Revision: 242199 URL: http://svn.freebsd.org/changeset/base/242199 Log: MFCr238925: Until now KTR_ENTRIES, which defines the size of circular buffer used in ktr(4), was constrained to be a power of two. Remove this constraint and update sys

svn commit: r242200 - in stable/8/sys: conf kern

2012-10-27 Thread Davide Italiano
Author: davide Date: Sat Oct 27 23:34:18 2012 New Revision: 242200 URL: http://svn.freebsd.org/changeset/base/242200 Log: MFC r238925: Until now KTR_ENTRIES, which defines the size of circular buffer used in ktr(4), was constrained to be a power of two. Remove this constraint and update sy

svn commit: r242202 - head/sys/kern

2012-10-27 Thread Davide Italiano
Author: davide Date: Sat Oct 27 23:42:41 2012 New Revision: 242202 URL: http://svn.freebsd.org/changeset/base/242202 Log: The fields of struct timespec32 should be int32_t and not uint32_t. Make this change. Reviewed by: bde, davidxu Tested by:pho MFC after:1 week Modified:

svn commit: r242384 - head/sys/fs/smbfs

2012-10-30 Thread Davide Italiano
Author: davide Date: Wed Oct 31 02:54:44 2012 New Revision: 242384 URL: http://svn.freebsd.org/changeset/base/242384 Log: Change the code to use %jd as printf() placeholder for uio_offset and cast to intmax_t. Suggested by: pjd Sponsored by: iXsystems inc. Modified: head/sys/fs/smbfs

svn commit: r242386 - in head/sys: fs/smbfs netsmb

2012-10-30 Thread Davide Italiano
Author: davide Date: Wed Oct 31 03:34:07 2012 New Revision: 242386 URL: http://svn.freebsd.org/changeset/base/242386 Log: Fix panic due to page faults while in kernel mode, under conditions of VM pressure. The reason is that in some codepaths pointers to stack variables were passed from one

svn commit: r242387 - head/sys/fs/smbfs

2012-10-30 Thread Davide Italiano
Author: davide Date: Wed Oct 31 03:55:33 2012 New Revision: 242387 URL: http://svn.freebsd.org/changeset/base/242387 Log: - Do not put in the mntqueue half-constructed vnodes. - Change the code so that it relies on vfs_hash rather than on a home-made hashtable. - There's no need to inlin

Re: svn commit: r242387 - head/sys/fs/smbfs

2012-10-30 Thread Davide Italiano
On Wed, Oct 31, 2012 at 4:55 AM, Davide Italiano wrote: > Author: davide > Date: Wed Oct 31 03:55:33 2012 > New Revision: 242387 > URL: http://svn.freebsd.org/changeset/base/242387 > > Log: > - Do not put in the mntqueue half-constructed vnodes. > - Change the c

Re: svn commit: r242387 - head/sys/fs/smbfs

2012-10-30 Thread Davide Italiano
On Wed, Oct 31, 2012 at 4:57 AM, Davide Italiano wrote: > On Wed, Oct 31, 2012 at 4:55 AM, Davide Italiano wrote: >> Author: davide >> Date: Wed Oct 31 03:55:33 2012 >> New Revision: 242387 >> URL: http://svn.freebsd.org/changeset/base/242387 >> >> Log:

svn commit: r242516 - stable/9/sys/kern

2012-11-03 Thread Davide Italiano
Author: davide Date: Sat Nov 3 16:06:14 2012 New Revision: 242516 URL: http://svn.freebsd.org/changeset/base/242516 Log: MFC r242202: The fields of struct timespec32 should be int32_t and not uint32_t. Make this change. Modified: stable/9/sys/kern/kern_umtx.c Directory Properties: stab

svn commit: r243033 - head/sys/fs/smbfs

2012-11-14 Thread Davide Italiano
Author: davide Date: Wed Nov 14 18:43:58 2012 New Revision: 243033 URL: http://svnweb.freebsd.org/changeset/base/243033 Log: Fix the lookup in the DOTDOT case in the same way as other filesystems do, i.e. inlining the vn_vget_ino() algorithm. Sponsored by: iXsystems inc. Modified: head

svn commit: r243038 - head/sys/fs/smbfs

2012-11-14 Thread Davide Italiano
Author: davide Date: Wed Nov 14 19:10:50 2012 New Revision: 243038 URL: http://svnweb.freebsd.org/changeset/base/243038 Log: Get rid of some old debug code. It provides checks similar to the one offered by RedZone so there's no need to keep it. Sponsored by: iXsystems inc. Modified: he

svn commit: r237485 - stable/9/sys/kern

2012-06-23 Thread Davide Italiano
Author: davide Date: Sat Jun 23 17:39:40 2012 New Revision: 237485 URL: http://svn.freebsd.org/changeset/base/237485 Log: MFC r237195: The variable 'error' in sys_poll() is initialized in declaration to value zero but in any case is overwritten by successive copyin(), making the previou

svn commit: r237486 - stable/8/sys/kern

2012-06-23 Thread Davide Italiano
Author: davide Date: Sat Jun 23 17:42:37 2012 New Revision: 237486 URL: http://svn.freebsd.org/changeset/base/237486 Log: MFC r237195: The variable 'error' in sys_poll() is initialized in declaration to value zero but in any case is overwritten by successive copyin(), making the previou

svn commit: r237487 - stable/9/sys/dev/hwpmc

2012-06-23 Thread Davide Italiano
Author: davide Date: Sat Jun 23 17:46:42 2012 New Revision: 237487 URL: http://svn.freebsd.org/changeset/base/237487 Log: MFC r237196: Disable hwpmc(4) support for Intel Xeon Sandy Bridge (Model 0x2D). Due to some differences in MSRs between Xeon Sandy Bridge and Core Sandy Bridge (Mode

svn commit: r238925 - in head/sys: conf kern

2012-07-30 Thread Davide Italiano
Author: davide Date: Mon Jul 30 22:46:42 2012 New Revision: 238925 URL: http://svn.freebsd.org/changeset/base/238925 Log: Until now KTR_ENTRIES, which defines the size of circular buffer used in ktr(4), was constrained to be a power of two. Remove this constraint and update sys/conf/NOTES ac

  1   2   >