Re: svn commit: r328486 - head/usr.bin/fortune/fortune

2018-01-27 Thread Pedro Giffuni
On 01/27/18 18:08, Ian Lepore wrote: On Sat, 2018-01-27 at 22:56 +, Conrad Meyer wrote: I donļæ½t think dragonfly has anything to do with this?ļæ½ļæ½If youļæ½re converting bool increments to setting true values in FreeBSD, use ļæ½true.ļæ½ļæ½ļæ½Thatļæ½s all there is to it. Best, Conrad st

Re: svn commit: r328486 - head/usr.bin/fortune/fortune

2018-01-27 Thread Bruce Evans
On Sat, 27 Jan 2018, Ian Lepore wrote: On Sat, 2018-01-27 at 22:56 +, Conrad Meyer wrote: I don?t think dragonfly has anything to do with this???If you?re converting bool increments to setting true values in FreeBSD, use ?true.???That?s all there is to it. style(9) emphasizes internal con

Re: svn commit: r328486 - head/usr.bin/fortune/fortune

2018-01-27 Thread Ian Lepore
On Sat, 2018-01-27 at 22:56 +, Conrad Meyer wrote: > I don’t think dragonfly has anything to do with this?  If you’re > converting > bool increments to setting true values in FreeBSD, use > “true.”  That’s all > there is to it. > > Best, > Conrad style(9) emphasizes internal consistancy in se

Re: svn commit: r328486 - head/usr.bin/fortune/fortune

2018-01-27 Thread Pedro Giffuni
On 01/27/18 17:56, Conrad Meyer wrote: I don’t think dragonfly has anything to do with this?  If you’re converting bool increments to setting true values in FreeBSD, use “true.”  That’s all there is to it. s/TRUE/true/ s/FALSE/false/ Then remove the two #defines for TRUE and FALSE, but I

Re: svn commit: r328486 - head/usr.bin/fortune/fortune

2018-01-27 Thread Conrad Meyer
I don’t think dragonfly has anything to do with this? If you’re converting bool increments to setting true values in FreeBSD, use “true.” That’s all there is to it. Best, Conrad On Sat, Jan 27, 2018 at 1:44 PM Pedro Giffuni wrote: > Hi; > > > On 01/27/18 14:56, Conrad Meyer wrote: > > We can

Re: svn commit: r328486 - head/usr.bin/fortune/fortune

2018-01-27 Thread Pedro Giffuni
Hi; On 01/27/18 14:56, Conrad Meyer wrote: We can use 'true' and 'false' now. (style(9) also suggests using the C99 names instead of TRUE/FALSE.) Yes, I noticed that change in DragonflyBSD but it is conceptually a different change and it deserves a different commit. Pedro. On Sat, Jan 2

Re: svn commit: r328486 - head/usr.bin/fortune/fortune

2018-01-27 Thread Conrad Meyer
We can use 'true' and 'false' now. (style(9) also suggests using the C99 names instead of TRUE/FALSE.) On Sat, Jan 27, 2018 at 9:43 AM, Pedro F. Giffuni wrote: > Author: pfg > Date: Sat Jan 27 17:43:09 2018 > New Revision: 328486 > URL: https://svnweb.freebsd.org/changeset/base/328486 > > Log: >

svn commit: r328486 - head/usr.bin/fortune/fortune

2018-01-27 Thread Pedro F. Giffuni
Author: pfg Date: Sat Jan 27 17:43:09 2018 New Revision: 328486 URL: https://svnweb.freebsd.org/changeset/base/328486 Log: fortune(6): Fix gcc80 -Wbool-operation warnings. Hinted by:Dragonfly (git 4d1086765752f0569497d06460d95117c74f33ac) Modified: head/usr.bin/fortune/fortune/fortun