On 01/27/18 18:08, Ian Lepore wrote:
On Sat, 2018-01-27 at 22:56 +0000, Conrad Meyer wrote:
I donļæ½t think dragonfly has anything to do with this?ļæ½ļæ½If youļæ½re
converting
bool increments to setting true values in FreeBSD, use
ļæ½true.ļæ½ļæ½ļæ½Thatļæ½s all
there is to it.
Best,
Conrad
style(9) emphasizes internal consistancy in several places. ļæ½The
uppercase TRUE/FALSE is currently the style within that code, so it
makes sense to stick with it. ļæ½If a (somewhat gratuitous) conversion to
the new style is made, it should be a separate commit just for that,
emphasizing that it changes just style and not functionality.
Indeed. I didn't want to mix FALSE with false and TRUE with true so I
did the change as is to make the diff smaller and still have everything
look consistent.
Further cleanups (DragonFly already did it) should be done in a
different commit. I personally don't feel it's something important though.
Pedro.
_______________________________________________
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
