Re: svn commit: r310354 - in head/usr.sbin: . prometheus_sysctl_exporter

2016-12-22 Thread Brooks Davis
On Thu, Dec 22, 2016 at 08:42:24PM +0100, Ed Schouten wrote: > Hey! > > 2016-12-21 20:53 GMT+01:00 Edward Tomasz Napiera??a : > > That's a very good reason; it could also be fixed by moving > > it from sbin/ to libexec/. > > I'm not sure that doing that is a good idea. You can also invoke this >

Re: svn commit: r310354 - in head/usr.sbin: . prometheus_sysctl_exporter

2016-12-22 Thread Ed Schouten
Hey! 2016-12-21 20:53 GMT+01:00 Edward Tomasz Napierała : > That's a very good reason; it could also be fixed by moving > it from sbin/ to libexec/. I'm not sure that doing that is a good idea. You can also invoke this exporter through cron(8), so that it can be collected by the Prometheus node e

Re: svn commit: r310354 - in head/usr.sbin: . prometheus_sysctl_exporter

2016-12-21 Thread Warner Losh
On Wed, Dec 21, 2016 at 12:06 PM, Ed Schouten wrote: > Hi Adrian, > > 2016-12-21 18:32 GMT+01:00 Adrian Chadd : >> Maybe just "sysctl_export" would be fine. > > Good point. Almost all Prometheus metrics exporters use this naming scheme: > > ~80%: ${foo}_exporter > ~20%: prometheus_${foo}_exporter

Re: svn commit: r310354 - in head/usr.sbin: . prometheus_sysctl_exporter

2016-12-21 Thread Edward Tomasz Napierała
On 1221T2006, Ed Schouten wrote: > Hi Adrian, > > 2016-12-21 18:32 GMT+01:00 Adrian Chadd : > > Maybe just "sysctl_export" would be fine. > > Good point. Almost all Prometheus metrics exporters use this naming scheme: > > ~80%: ${foo}_exporter > ~20%: prometheus_${foo}_exporter > > Examples; >

Re: svn commit: r310354 - in head/usr.sbin: . prometheus_sysctl_exporter

2016-12-21 Thread Adrian Chadd
My suggestion is "let's flesh out the toolsets a bit first, we can rename them before 12.0". If you really want a namespace that you can tabcomplete, then my bikeshed is painted "stats_export_XXX". I have other comments, like "should this really be doing HTTP / gzip output?" instead of say, using

Re: svn commit: r310354 - in head/usr.sbin: . prometheus_sysctl_exporter

2016-12-21 Thread Ed Schouten
Hi Adrian, 2016-12-21 18:32 GMT+01:00 Adrian Chadd : > Maybe just "sysctl_export" would be fine. Good point. Almost all Prometheus metrics exporters use this naming scheme: ~80%: ${foo}_exporter ~20%: prometheus_${foo}_exporter Examples; - https://github.com/prometheus/node_exporter - https://

Re: svn commit: r310354 - in head/usr.sbin: . prometheus_sysctl_exporter

2016-12-21 Thread Alexandre Biancalana
+1 On Wed, Dec 21, 2016 at 3:32 PM, Adrian Chadd wrote: > heh, > > in an ideal world we'd not call this "prometheus", it'd just be the > way we export sysctl data via 'sysctl' in a machine parsable format. > Ok, since it's HTTP/gzip, maybe a separate standalone program is cool, > but it doesn't

Re: svn commit: r310354 - in head/usr.sbin: . prometheus_sysctl_exporter

2016-12-21 Thread Adrian Chadd
heh, in an ideal world we'd not call this "prometheus", it'd just be the way we export sysctl data via 'sysctl' in a machine parsable format. Ok, since it's HTTP/gzip, maybe a separate standalone program is cool, but it doesn't have to be specific to prometheus. :-) That way anyone wanting to wri

svn commit: r310354 - in head/usr.sbin: . prometheus_sysctl_exporter

2016-12-21 Thread Ed Schouten
Author: ed Date: Wed Dec 21 08:29:44 2016 New Revision: 310354 URL: https://svnweb.freebsd.org/changeset/base/310354 Log: Add a Prometheus exporter for sysctl values. Now that we have our sysctl tree annotated with aggregation labels, let's go ahead and provide a very simple utility for e