Re: svn commit: r304070 - svnadmin/conf

2016-08-16 Thread Bryan Drewery
On 8/16/16 9:14 AM, Glen Barber wrote: > On Tue, Aug 16, 2016 at 09:00:34AM +0100, Bruce Simpson wrote: >> On 14/08/16 05:35, Glen Barber wrote: >>> Author: gjb >>> Date: Sun Aug 14 04:35:04 2016 >>> New Revision: 304070 >>> URL: https://svnweb.freebsd.org/changeset/base/304070 >>> >>> Log: >>> Do

Re: svn commit: r304070 - svnadmin/conf

2016-08-16 Thread Glen Barber
On Tue, Aug 16, 2016 at 09:00:34AM +0100, Bruce Simpson wrote: > On 14/08/16 05:35, Glen Barber wrote: > >Author: gjb > >Date: Sun Aug 14 04:35:04 2016 > >New Revision: 304070 > >URL: https://svnweb.freebsd.org/changeset/base/304070 > > > >Log: > > Do not include C function changes by default in s

Re: svn commit: r304070 - svnadmin/conf

2016-08-16 Thread Bruce Simpson
On 14/08/16 05:35, Glen Barber wrote: Author: gjb Date: Sun Aug 14 04:35:04 2016 New Revision: 304070 URL: https://svnweb.freebsd.org/changeset/base/304070 Log: Do not include C function changes by default in svn commit email. Please back out -- this makes the diff output much less useful.

Re: svn commit: r304070 - svnadmin/conf

2016-08-13 Thread Glen Barber
On Sat, Aug 13, 2016 at 10:51:59PM -0700, Conrad Meyer wrote: > On Sat, Aug 13, 2016 at 10:48 PM, Juli Mallett > wrote: > > On Sat, Aug 13, 2016 at 9:47 PM, Glen Barber wrote: > >> Quoting the original request to remove this, which I tend to agree: > >> > >> -- begin quot

Re: svn commit: r304070 - svnadmin/conf

2016-08-13 Thread Conrad Meyer
On Sat, Aug 13, 2016 at 10:48 PM, Juli Mallett wrote: > On Sat, Aug 13, 2016 at 9:47 PM, Glen Barber wrote: >> Quoting the original request to remove this, which I tend to agree: >> >> -- begin quoted text --- >> The svn commit mail script uses som

Re: svn commit: r304070 - svnadmin/conf

2016-08-13 Thread Juli Mallett
On Sat, Aug 13, 2016 at 9:47 PM, Glen Barber wrote: > Quoting the original request to remove this, which I tend to agree: > > -- begin quoted text --- > The svn commit mail script uses some form of 'diff -p' (or 'svn diff > -x-p') to include functi

Re: svn commit: r304070 - svnadmin/conf

2016-08-13 Thread Glen Barber
Quoting the original request to remove this, which I tend to agree: -- begin quoted text --- The svn commit mail script uses some form of 'diff -p' (or 'svn diff -x-p') to include function names at the top of each hunk. The problem is that diff g

Re: svn commit: r304070 - svnadmin/conf

2016-08-13 Thread Conrad Meyer
Wait, what? Why not? This option provides useful context for reviewing changes. Best, Conrad On Sat, Aug 13, 2016 at 9:35 PM, Glen Barber wrote: > Author: gjb > Date: Sun Aug 14 04:35:04 2016 > New Revision: 304070 > URL: https://svnweb.freebsd.org/changeset/base/304070 > > Log: > Do not inc

svn commit: r304070 - svnadmin/conf

2016-08-13 Thread Glen Barber
Author: gjb Date: Sun Aug 14 04:35:04 2016 New Revision: 304070 URL: https://svnweb.freebsd.org/changeset/base/304070 Log: Do not include C function changes by default in svn commit email. No objection: svnadmin Submitted by: des Sponsored by: The FreeBSD Foundation Modified: svnad