Quoting the original request to remove this, which I tend to agree: -------------------------- begin quoted text --------------------------- The svn commit mail script uses some form of 'diff -p' (or 'svn diff -x-p') to include function names at the top of each hunk. The problem is that diff gets it wrong more often than not, especially (but not only) when functions are added or renamed, or outside a funciton, or in headers, or in code that makes heavy use of macros, or in files that aren't C-like source code: shell scripts, man pages, Makefiles... All it really does is clutter up the patch and mislead the reader. --------------------------- end quoted text ----------------------------
Glen On Sat, Aug 13, 2016 at 09:39:14PM -0700, Conrad Meyer wrote: > Wait, what? Why not? This option provides useful context for > reviewing changes. > > Best, > Conrad > > On Sat, Aug 13, 2016 at 9:35 PM, Glen Barber <g...@freebsd.org> wrote: > > Author: gjb > > Date: Sun Aug 14 04:35:04 2016 > > New Revision: 304070 > > URL: https://svnweb.freebsd.org/changeset/base/304070 > > > > Log: > > Do not include C function changes by default in svn commit > > email. > > > > No objection: svnadmin > > Submitted by: des > > Sponsored by: The FreeBSD Foundation > > > > Modified: > > svnadmin/conf/mailer.conf > > > > Modified: svnadmin/conf/mailer.conf > > ============================================================================== > > --- svnadmin/conf/mailer.conf Sun Aug 14 04:11:36 2016 (r304069) > > +++ svnadmin/conf/mailer.conf Sun Aug 14 04:35:04 2016 (r304070) > > @@ -143,7 +143,7 @@ > > # This is not passed to the shell, so do not use shell metacharacters. > > # The command is split around whitespace, so if you want to include > > # whitespace in the command, then ### something ###. > > -diff = /usr/bin/diff -up -L %(label_from)s -L %(label_to)s %(from)s %(to)s > > +diff = /usr/bin/diff -u -L %(label_from)s -L %(label_to)s %(from)s %(to)s > > > > # The default prefix for the Subject: header for commits. > > commit_subject_prefix = svn commit: > > >
signature.asc
Description: PGP signature
