Re: svn commit: r277841 - head/contrib/amd/hlfsd

2015-01-28 Thread Pedro Giffuni
On 01/28/15 14:25, Dimitry Andric wrote: On 28 Jan 2015, at 20:04, Roman Divacky wrote: On Wed, Jan 28, 2015 at 06:19:26PM +, Dimitry Andric wrote: Author: dim Date: Wed Jan 28 18:19:25 2015 New Revision: 277841 URL: https://svnweb.freebsd.org/changeset/base/277841 Log: Fix the followi

Re: svn commit: r277841 - head/contrib/amd/hlfsd

2015-01-28 Thread Dimitry Andric
On 28 Jan 2015, at 20:04, Roman Divacky wrote: > On Wed, Jan 28, 2015 at 06:19:26PM +, Dimitry Andric wrote: >> Author: dim >> Date: Wed Jan 28 18:19:25 2015 >> New Revision: 277841 >> URL: https://svnweb.freebsd.org/changeset/base/277841 >> >> Log: >> Fix the following clang 3.6.0 warning i

Re: svn commit: r277841 - head/contrib/amd/hlfsd

2015-01-28 Thread Roman Divacky
Given that this is a contributed code - have you sent the fix upstream? Also, upstream seems to have newer versions of this... On Wed, Jan 28, 2015 at 06:19:26PM +, Dimitry Andric wrote: > Author: dim > Date: Wed Jan 28 18:19:25 2015 > New Revision: 277841 > URL: https://svnweb.freebsd.org/cha

svn commit: r277841 - head/contrib/amd/hlfsd

2015-01-28 Thread Dimitry Andric
Author: dim Date: Wed Jan 28 18:19:25 2015 New Revision: 277841 URL: https://svnweb.freebsd.org/changeset/base/277841 Log: Fix the following clang 3.6.0 warning in contrib/amd/hlfsd/homedir.c: contrib/amd/hlfsd/homedir.c:497:8: error: address of array 'buf' will always evaluate to 'true'