On 28 Jan 2015, at 20:04, Roman Divacky <rdiva...@freebsd.org> wrote: > On Wed, Jan 28, 2015 at 06:19:26PM +0000, Dimitry Andric wrote: >> Author: dim >> Date: Wed Jan 28 18:19:25 2015 >> New Revision: 277841 >> URL: https://svnweb.freebsd.org/changeset/base/277841 >> >> Log: >> Fix the following clang 3.6.0 warning in contrib/amd/hlfsd/homedir.c: >> >> contrib/amd/hlfsd/homedir.c:497:8: error: address of array 'buf' will >> always evaluate to 'true' [-Werror,-Wpointer-bool-conversion] >> if (!buf || buf[0] == '\0') >> ~^~~ >> >> In the affected function, 'buf' is declared as an array of char, so it >> can never be null. Remove the unecessary check. ... > Given that this is a contributed code - have you sent the fix > upstream? Also, upstream seems to have newer versions of this...
Apparently upstream fixed this about six years ago: http://git.fsl.cs.sunysb.edu/?p=am-utils-6.2.git;a=commitdiff;h=e6301006ef97d31745f9ffbb17c58cb39d18c6aa#patch9 The last real import for am-utils was about 7 year ago. Maybe it's time for an update, if it is still actively used. -Dimitry
signature.asc
Description: Message signed with OpenPGP using GPGMail
