Re: svn commit: r232181 - in head/sys: kern sys

2012-03-01 Thread Julian Elischer
On 2/29/12 7:33 AM, Konstantin Belousov wrote: On Wed, Feb 29, 2012 at 09:36:02AM -0500, John Baldwin wrote: On Wednesday, February 29, 2012 8:25:07 am Konstantin Belousov wrote: On Wed, Feb 29, 2012 at 02:37:25PM +0200, Mikolaj Golub wrote: On Wed, 29 Feb 2012 12:03:00 + Robert N. M. Wats

Re: svn commit: r232181 - in head/sys: kern sys

2012-02-29 Thread Konstantin Belousov
On Wed, Feb 29, 2012 at 09:36:02AM -0500, John Baldwin wrote: > On Wednesday, February 29, 2012 8:25:07 am Konstantin Belousov wrote: > > On Wed, Feb 29, 2012 at 02:37:25PM +0200, Mikolaj Golub wrote: > > > > > > On Wed, 29 Feb 2012 12:03:00 + Robert N. M. Watson wrote: > > > > > > RNMW> I t

Re: svn commit: r232181 - in head/sys: kern sys

2012-02-29 Thread John Baldwin
On Wednesday, February 29, 2012 8:25:07 am Konstantin Belousov wrote: > On Wed, Feb 29, 2012 at 02:37:25PM +0200, Mikolaj Golub wrote: > > > > On Wed, 29 Feb 2012 12:03:00 + Robert N. M. Watson wrote: > > > > RNMW> I think the monitoring aspect of the patch is fine. > > > > RNMW> The bit I

Re: svn commit: r232181 - in head/sys: kern sys

2012-02-29 Thread Konstantin Belousov
On Wed, Feb 29, 2012 at 02:37:25PM +0200, Mikolaj Golub wrote: > > On Wed, 29 Feb 2012 12:03:00 + Robert N. M. Watson wrote: > > RNMW> I think the monitoring aspect of the patch is fine. > > RNMW> The bit I was worried about was external umask changes. This can cause > RNMW> race conditio

Re: svn commit: r232181 - in head/sys: kern sys

2012-02-29 Thread Mikolaj Golub
On Wed, 29 Feb 2012 12:03:00 + Robert N. M. Watson wrote: RNMW> I think the monitoring aspect of the patch is fine. RNMW> The bit I was worried about was external umask changes. This can cause RNMW> race conditions for applications that manage their umask -- for RNMW> example, bsdtar, if

Re: svn commit: r232181 - in head/sys: kern sys

2012-02-29 Thread Robert N. M. Watson
On 29 Feb 2012, at 07:50, Mikolaj Golub wrote: > JE> well that's exactly what I AM questioning.. how often will this be used? > JE> one person using this once in all of history isn't a real requirement > JE> for inclusion. > > This information may be very useful when troubleshooting unexpected

Re: svn commit: r232181 - in head/sys: kern sys

2012-02-28 Thread Mikolaj Golub
On Tue, 28 Feb 2012 16:00:36 -0800 Julian Elischer wrote: JE> On 2/27/12 11:29 PM, Mikolaj Golub wrote: >> On Mon, 27 Feb 2012 22:34:25 -0800 Julian Elischer wrote: >> >> JE> I don't think this belongs in the kernel by default. It's not exactl >> a >> JE> call for backout but It's te

Re: svn commit: r232181 - in head/sys: kern sys

2012-02-28 Thread Julian Elischer
On 2/27/12 11:29 PM, Mikolaj Golub wrote: On Mon, 27 Feb 2012 22:34:25 -0800 Julian Elischer wrote: JE> I don't think this belongs in the kernel by default. It's not exactl a JE> call for backout but It's teh next thing short of that. a call for "do JE> you REALLY think we need this par

Re: svn commit: r232181 - in head/sys: kern sys

2012-02-28 Thread John Baldwin
On Tuesday, February 28, 2012 1:34:25 am Julian Elischer wrote: > On 2/27/12 1:29 AM, Konstantin Belousov wrote: > > On Mon, Feb 27, 2012 at 10:49:59AM +0200, Mikolaj Golub wrote: > >> On Mon, 27 Feb 2012 09:28:11 +0100 Pawel Jakub Dawidek wrote: > >> > >> PJD> On Sun, Feb 26, 2012 at 02:25:48PM

Re: svn commit: r232181 - in head/sys: kern sys

2012-02-27 Thread Mikolaj Golub
On Mon, 27 Feb 2012 22:34:25 -0800 Julian Elischer wrote: JE> On 2/27/12 1:29 AM, Konstantin Belousov wrote: >> On Mon, Feb 27, 2012 at 10:49:59AM +0200, Mikolaj Golub wrote: >>> On Mon, 27 Feb 2012 09:28:11 +0100 Pawel Jakub Dawidek wrote: >>> >>> PJD> On Sun, Feb 26, 2012 at 02:25:48PM

Re: svn commit: r232181 - in head/sys: kern sys

2012-02-27 Thread Julian Elischer
On 2/27/12 1:29 AM, Konstantin Belousov wrote: On Mon, Feb 27, 2012 at 10:49:59AM +0200, Mikolaj Golub wrote: On Mon, 27 Feb 2012 09:28:11 +0100 Pawel Jakub Dawidek wrote: PJD> On Sun, Feb 26, 2012 at 02:25:48PM +, Mikolaj Golub wrote: >> Author: trociny >> Date: Sun Feb 26 14:25:4

Re: svn commit: r232181 - in head/sys: kern sys

2012-02-27 Thread Julian Elischer
On 2/27/12 12:28 AM, Pawel Jakub Dawidek wrote: On Sun, Feb 26, 2012 at 02:25:48PM +, Mikolaj Golub wrote: Author: trociny Date: Sun Feb 26 14:25:48 2012 New Revision: 232181 URL: http://svn.freebsd.org/changeset/base/232181 Log: Add sysctl to retrieve or set umask of another process. "

Re: svn commit: r232181 - in head/sys: kern sys

2012-02-27 Thread Konstantin Belousov
On Mon, Feb 27, 2012 at 10:49:59AM +0200, Mikolaj Golub wrote: > > On Mon, 27 Feb 2012 09:28:11 +0100 Pawel Jakub Dawidek wrote: > > PJD> On Sun, Feb 26, 2012 at 02:25:48PM +, Mikolaj Golub wrote: > >> Author: trociny > >> Date: Sun Feb 26 14:25:48 2012 > >> New Revision: 232181 > >> URL

Re: svn commit: r232181 - in head/sys: kern sys

2012-02-27 Thread Pawel Jakub Dawidek
On Mon, Feb 27, 2012 at 10:49:59AM +0200, Mikolaj Golub wrote: > > On Mon, 27 Feb 2012 09:28:11 +0100 Pawel Jakub Dawidek wrote: > > PJD> On Sun, Feb 26, 2012 at 02:25:48PM +, Mikolaj Golub wrote: > >> Author: trociny > >> Date: Sun Feb 26 14:25:48 2012 > >> New Revision: 232181 > >> URL

Re: svn commit: r232181 - in head/sys: kern sys

2012-02-27 Thread Mikolaj Golub
On Mon, 27 Feb 2012 09:28:11 +0100 Pawel Jakub Dawidek wrote: PJD> On Sun, Feb 26, 2012 at 02:25:48PM +, Mikolaj Golub wrote: >> Author: trociny >> Date: Sun Feb 26 14:25:48 2012 >> New Revision: 232181 >> URL: http://svn.freebsd.org/changeset/base/232181 >> >> Log: >> Add sysctl t

Re: svn commit: r232181 - in head/sys: kern sys

2012-02-27 Thread Pawel Jakub Dawidek
On Sun, Feb 26, 2012 at 02:25:48PM +, Mikolaj Golub wrote: > Author: trociny > Date: Sun Feb 26 14:25:48 2012 > New Revision: 232181 > URL: http://svn.freebsd.org/changeset/base/232181 > > Log: > Add sysctl to retrieve or set umask of another process. "set umask of another process"? This se

svn commit: r232181 - in head/sys: kern sys

2012-02-26 Thread Mikolaj Golub
Author: trociny Date: Sun Feb 26 14:25:48 2012 New Revision: 232181 URL: http://svn.freebsd.org/changeset/base/232181 Log: Add sysctl to retrieve or set umask of another process. Submitted by: Dmitry Banschikov Discussed with: kib, rwatson Reviewed by: kib MFC after:2 week