Re: svn commit: r206043 - in head/usr.sbin/pkg_install: add delete lib version

2010-04-03 Thread Garrett Cooper
On Sat, Apr 3, 2010 at 4:40 AM, Joerg Sonnenberger wrote: > On Sat, Apr 03, 2010 at 04:32:15AM -0700, Garrett Cooper wrote: >>    I'm sorry but I'm a little bit confused by this statement: do you >> mean that you're replacing PATH_MAX sized buffers to FILENAME_MAX >> sized buffers? If so this may

Re: svn commit: r206043 - in head/usr.sbin/pkg_install: add delete lib version

2010-04-03 Thread Joerg Sonnenberger
On Sat, Apr 03, 2010 at 04:32:15AM -0700, Garrett Cooper wrote: >I'm sorry but I'm a little bit confused by this statement: do you > mean that you're replacing PATH_MAX sized buffers to FILENAME_MAX > sized buffers? If so this may cause an issue because several of the > variables used in constr

Re: svn commit: r206043 - in head/usr.sbin/pkg_install: add delete lib version

2010-04-03 Thread Garrett Cooper
On Thu, Apr 1, 2010 at 5:12 PM, Joerg Sonnenberger wrote: > On Thu, Apr 01, 2010 at 05:02:34PM -0700, Garrett Cooper wrote: >>     1. FILENAME_MAX could be less than PATH_MAX, and actually is on >> the BSDs (256 vs 1024). PATH_MAX allows for duplicate slashes and all >> sorts of whacky path crud a

Re: svn commit: r206043 - in head/usr.sbin/pkg_install: add delete lib version

2010-04-01 Thread Joerg Sonnenberger
On Thu, Apr 01, 2010 at 05:02:34PM -0700, Garrett Cooper wrote: > 1. FILENAME_MAX could be less than PATH_MAX, and actually is on > the BSDs (256 vs 1024). PATH_MAX allows for duplicate slashes and all > sorts of whacky path crud and probably should be used more liberally > in the pkg_install c

Re: svn commit: r206043 - in head/usr.sbin/pkg_install: add delete lib version

2010-04-01 Thread Garrett Cooper
Hi Florent and Robert, On Thu, Apr 1, 2010 at 7:27 AM, Florent Thoumie wrote: > Author: flz > Date: Thu Apr  1 14:27:29 2010 > New Revision: 206043 > URL: http://svn.freebsd.org/changeset/base/206043 > > Log: >  Various fixes. > >  - Replace hardcoded INDEX version. [1] >  - Fix a buffer overlap.

Re: svn commit: r206043 - in head/usr.sbin/pkg_install: add delete lib version

2010-04-01 Thread pluknet
On 1 April 2010 18:27, Florent Thoumie wrote: > Author: flz > Date: Thu Apr  1 14:27:29 2010 > New Revision: 206043 > URL: http://svn.freebsd.org/changeset/base/206043 > > Log: >  Various fixes. > >  - Replace hardcoded INDEX version. [1] >  - Fix a buffer overlap. [2] >  - Remove empty package wh

svn commit: r206043 - in head/usr.sbin/pkg_install: add delete lib version

2010-04-01 Thread Florent Thoumie
Author: flz Date: Thu Apr 1 14:27:29 2010 New Revision: 206043 URL: http://svn.freebsd.org/changeset/base/206043 Log: Various fixes. - Replace hardcoded INDEX version. [1] - Fix a buffer overlap. [2] - Remove empty package when fetching fails and -K is used. [3] - Remove useless chmo