Re: svn commit: r194789 - head/usr.bin/usbhidctl

2009-07-01 Thread Dag-Erling Smørgrav
Bruce Evans writes: > "Dag-Erling Smørgrav" writes: > > BTW, there are numerous style issues in sbin/reboot/reboot.c. > Really? According to knfom, it is 94.772% knf (up from 94.520% in > ~5.2 and 92.896% in Lite2). It is a small program so it is easy to > get right, but anything above 90% is a

Re: svn commit: r194789 - head/usr.bin/usbhidctl

2009-07-01 Thread Bruce Evans
On Tue, 30 Jun 2009, [utf-8] Dag-Erling Sm??rgrav wrote: Bruce Evans writes: Actually, it is OK to use it in FreeBSD iff the system supports the same program having different names, like reboot/halt/etc. I don't see the point - you would still need different usage messages for each version.

Re: svn commit: r194789 - head/usr.bin/usbhidctl

2009-06-30 Thread Dag-Erling Smørgrav
Bruce Evans writes: > Actually, it is OK to use it in FreeBSD iff the system supports the > same program having different names, like reboot/halt/etc. I don't see the point - you would still need different usage messages for each version. Using your example: % reboot -h reboot: illegal option -

Re: svn commit: r194789 - head/usr.bin/usbhidctl

2009-06-26 Thread Bruce Evans
On Thu, 25 Jun 2009, Xin LI wrote: Bruce Evans wrote: On Tue, 23 Jun 2009, Xin LI wrote: Log: Use getprogname() instead of referencing __progname. Neither is permitted in FreeBSD in usage(). I didn't see references about this? If this is discouraged, perhaps we should mention it in styl

Re: svn commit: r194789 - head/usr.bin/usbhidctl

2009-06-25 Thread Xin LI
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi, Bruce, Bruce Evans wrote: > On Tue, 23 Jun 2009, Xin LI wrote: > >> Log: >> Use getprogname() instead of referencing __progname. > > Neither is permitted in FreeBSD in usage(). I didn't see references about this? If this is discouraged, perha

Re: svn commit: r194789 - head/usr.bin/usbhidctl

2009-06-24 Thread Bruce Evans
On Tue, 23 Jun 2009, Xin LI wrote: Log: Use getprogname() instead of referencing __progname. Neither is permitted in FreeBSD in usage(). Modified: head/usr.bin/usbhidctl/usbhid.c This was obtained from NetBSD, which requires using getprogname() in usage(). Bruce

svn commit: r194789 - head/usr.bin/usbhidctl

2009-06-23 Thread Xin LI
Author: delphij Date: Tue Jun 23 23:16:00 2009 New Revision: 194789 URL: http://svn.freebsd.org/changeset/base/194789 Log: Use getprogname() instead of referencing __progname. Modified: head/usr.bin/usbhidctl/usbhid.c Modified: head/usr.bin/usbhidctl/usbhid.c