Re: svn commit: r194681 - head/usr.sbin/wpa/ndis_events

2009-07-01 Thread Dag-Erling Smørgrav
Maxim Konovalov writes: > From style(9): > > static void > usage() > ... > > Apart from the empty line, what's wrong? Missing void. I wasn't aware that style(9) was incorrect in that respect. DES -- Dag-Erling Smørgrav - d...@des.no ___ svn-src-all@f

Re: svn commit: r194681 - head/usr.sbin/wpa/ndis_events

2009-07-01 Thread Bruce Evans
On Wed, 1 Jul 2009, Maxim Konovalov wrote: On Tue, 30 Jun 2009, 16:38+0200, Dag-Erling Smrgrav wrote: Maxim Konovalov writes: fixed, thanks. It still says static void usage() I know this is allowed by C99, but it's not allowed by style(9). From style(9): static void usage() {

Re: svn commit: r194681 - head/usr.sbin/wpa/ndis_events

2009-07-01 Thread Joerg Sonnenberger
On Wed, Jul 01, 2009 at 03:25:33PM +0400, Maxim Konovalov wrote: > static void > usage() > { > /* Insert an empty line if the function has no local variables. */ > ... > > Apart from the empty line, what's wrong? It is K&R style. It should be static void usage(void) { ... Joerg __

Re: svn commit: r194681 - head/usr.sbin/wpa/ndis_events

2009-07-01 Thread Maxim Konovalov
On Tue, 30 Jun 2009, 16:38+0200, Dag-Erling Smrgrav wrote: > Maxim Konovalov writes: > > fixed, thanks. > > It still says > > static void > usage() > > I know this is allowed by C99, but it's not allowed by style(9). > >From style(9): static void usage() { /* Insert an empty line if the

Re: svn commit: r194681 - head/usr.sbin/wpa/ndis_events

2009-06-30 Thread Dag-Erling Smørgrav
Maxim Konovalov writes: > fixed, thanks. It still says static void usage() I know this is allowed by C99, but it's not allowed by style(9). DES -- Dag-Erling Smørgrav - d...@des.no ___ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/ma

Re: svn commit: r194681 - head/usr.sbin/wpa/ndis_events

2009-06-23 Thread Maxim Konovalov
On Tue, 23 Jun 2009, 10:00+0200, Ed Schouten wrote: > Hi Maxim, > > * Maxim Konovalov wrote: > > +static void usage(); > ... > > +usage() > > That should probably read: > > static void usage(void); > > Right? > fixed, thanks. -- Maxim Konovalov

Re: svn commit: r194681 - head/usr.sbin/wpa/ndis_events

2009-06-23 Thread Ed Schouten
Hi Maxim, * Maxim Konovalov wrote: > +static void usage(); ... > +usage() That should probably read: static void usage(void); Right? -- Ed Schouten WWW: http://80386.nl/ pgp2CbwhNsSVO.pgp Description: PGP signature

svn commit: r194681 - head/usr.sbin/wpa/ndis_events

2009-06-22 Thread Maxim Konovalov
Author: maxim Date: Tue Jun 23 05:55:56 2009 New Revision: 194681 URL: http://svn.freebsd.org/changeset/base/194681 Log: o style(9) usage() definition: it doesn't need an argument. Modified: head/usr.sbin/wpa/ndis_events/ndis_events.c Modified: head/usr.sbin/wpa/ndis_events/ndis_events.c ===