Re: svn commit: r186504 - head/sbin/mount

2009-01-12 Thread Christoph Mallon
David O'Brien schrieb: On Mon, Jan 12, 2009 at 10:44:25AM +0100, Christoph Mallon wrote: David O'Brien schrieb: On Sun, Jan 11, 2009 at 08:56:22AM +0100, Christoph Mallon wrote: David O'Brien schrieb: On Sun, Jan 04, 2009 at 07:06:18PM +0100, Christoph Mallon wrote: I'm pretty sure $SUPERNATU

Re: svn commit: r186504 - head/sbin/mount

2009-01-12 Thread David O'Brien
On Mon, Jan 12, 2009 at 10:44:25AM +0100, Christoph Mallon wrote: > Alternatively I would have gladly reviewed your solution. Feel free to review the below. > Actually this version doesn't work either. > tron# ./mount -a > usage: mount [-t fstype] [-o options] target_fs mount_point > tron# ./mou

Re: svn commit: r186504 - head/sbin/mount

2009-01-12 Thread David O'Brien
On Mon, Jan 12, 2009 at 10:44:25AM +0100, Christoph Mallon wrote: > David O'Brien schrieb: >> On Sun, Jan 11, 2009 at 08:56:22AM +0100, Christoph Mallon wrote: >>> David O'Brien schrieb: On Sun, Jan 04, 2009 at 07:06:18PM +0100, Christoph Mallon wrote: > I'm pretty sure $SUPERNATURAL_BEING

Re: svn commit: r186504 - head/sbin/mount

2009-01-12 Thread Christoph Mallon
David O'Brien schrieb: On Sun, Jan 11, 2009 at 08:56:22AM +0100, Christoph Mallon wrote: David O'Brien schrieb: On Sun, Jan 04, 2009 at 07:06:18PM +0100, Christoph Mallon wrote: I'm pretty sure $SUPERNATURAL_BEING_OF_YOUR_CHOICE killed a kitten for the ugly hack you added to mount. The moment

Re: svn commit: r186504 - head/sbin/mount

2009-01-12 Thread David O'Brien
On Sun, Jan 11, 2009 at 08:56:22AM +0100, Christoph Mallon wrote: > David O'Brien schrieb: >> On Sun, Jan 04, 2009 at 07:06:18PM +0100, Christoph Mallon wrote: >>> I'm pretty sure $SUPERNATURAL_BEING_OF_YOUR_CHOICE killed a kitten for >>> the ugly hack you added to mount. The moment you overflow a

Re: svn commit: r186504 - head/sbin/mount

2009-01-10 Thread Christoph Mallon
David O'Brien schrieb: On Sun, Jan 04, 2009 at 07:06:18PM +0100, Christoph Mallon wrote: I'm pretty sure $SUPERNATURAL_BEING_OF_YOUR_CHOICE killed a kitten for the ugly hack you added to mount. The moment you overflow a buffer, you are in no man's land and there's no escape. I appended a patch,

Re: svn commit: r186504 - head/sbin/mount

2009-01-10 Thread David O'Brien
On Sun, Jan 04, 2009 at 07:06:18PM +0100, Christoph Mallon wrote: > I'm pretty sure $SUPERNATURAL_BEING_OF_YOUR_CHOICE killed a kitten for the > ugly hack you added to mount. The moment you overflow a buffer, you are in > no man's land and there's no escape. I appended a patch, which solves this

Re: svn commit: r186504 - head/sbin/mount

2009-01-04 Thread Christoph Mallon
Hi David, I'm pretty sure $SUPERNATURAL_BEING_OF_YOUR_CHOICE killed a kitten for the ugly hack you added to mount. The moment you overflow a buffer, you are in no man's land and there's no escape. I appended a patch, which solves this issue once and for all: The argv array gets dynamically ex

svn commit: r186504 - head/sbin/mount

2008-12-26 Thread David E. O'Brien
Author: obrien Date: Fri Dec 26 22:54:53 2008 New Revision: 186504 URL: http://svn.freebsd.org/changeset/base/186504 Log: Make the sub-'argc' static to make it harder to overwrite thru a buffer overflow. Modified: head/sbin/mount/mount.c Modified: head/sbin/mount/mount.c ==