> On 19. Jul 2018, at 16:27, Alexey Dokuchaev wrote:
>
> On Thu, Jul 19, 2018 at 04:23:27PM -0400, Michael Tuexen wrote:
>>> On 19. Jul 2018, at 16:11, Conrad Meyer wrote:
>>> These changes mostly seem like style regressions, rather than
>>> improvements. (Not to mention, largescale churn like
> On Jul 19, 2018, at 1:18 PM, Ian Lepore wrote:
>
> On Thu, 2018-07-19 at 13:12 -0700, Devin Teske wrote:
>>>
>>> On Jul 19, 2018, at 12:59 PM, Ian Lepore wrote:
>>>
>>> On Thu, 2018-07-19 at 19:53 +, Alexey Dokuchaev wrote:
>
> +++ head/sys/netinet/sctp_asconf.cThu J
> On 19. Jul 2018, at 16:12, Devin Teske wrote:
>
>
>> On Jul 19, 2018, at 12:59 PM, Ian Lepore wrote:
>>
>> On Thu, 2018-07-19 at 19:53 +, Alexey Dokuchaev wrote:
+++ head/sys/netinet/sctp_asconf.cThu Jul 19 19:33:42 2018
(r336503)
static struct mbuf *
-sc
On Thu, Jul 19, 2018 at 04:23:27PM -0400, Michael Tuexen wrote:
> > On 19. Jul 2018, at 16:11, Conrad Meyer wrote:
> > These changes mostly seem like style regressions, rather than
> > improvements. (Not to mention, largescale churn like this makes it
> > more difficult for future readers to rese
> On 19. Jul 2018, at 16:11, Conrad Meyer wrote:
>
> These changes mostly seem like style regressions, rather than
> improvements. (Not to mention, largescale churn like this makes it
> more difficult for future readers to research history (confusing tools
> like "git/svn blame").)
We have upstr
On Thu, Jul 19, 2018 at 01:12:19PM -0700, Devin Teske wrote:
> > On Jul 19, 2018, at 12:59 PM, Ian Lepore wrote:
> > ...
> > "usually" may be true of freebsd, but most places I've worked consider
> > the * (and & in c++) to be more associated with the type being declared
> > than with the variable
On Thu, 2018-07-19 at 13:12 -0700, Devin Teske wrote:
> >
> > On Jul 19, 2018, at 12:59 PM, Ian Lepore wrote:
> >
> > On Thu, 2018-07-19 at 19:53 +, Alexey Dokuchaev wrote:
> > >
> > > >
> > > > +++ head/sys/netinet/sctp_asconf.cThu Jul 19 19:33:42 2018
> > > > (r336503)
> > >
These changes mostly seem like style regressions, rather than
improvements. (Not to mention, largescale churn like this makes it
more difficult for future readers to research history (confusing tools
like "git/svn blame").)
On Thu, Jul 19, 2018 at 12:33 PM, Michael Tuexen wrote:
> Author: tuexen
> On Jul 19, 2018, at 12:59 PM, Ian Lepore wrote:
>
> On Thu, 2018-07-19 at 19:53 +, Alexey Dokuchaev wrote:
>>> +++ head/sys/netinet/sctp_asconf.cThu Jul 19 19:33:42 2018
>>> (r336503)
>>> static struct mbuf *
>>> -sctp_asconf_error_response(uint32_t id, uint16_t cause, uint8
On Thu, 2018-07-19 at 19:53 +, Alexey Dokuchaev wrote:
> > +++ head/sys/netinet/sctp_asconf.cThu Jul 19 19:33:42 2018
> > (r336503)
> > static struct mbuf *
> > -sctp_asconf_error_response(uint32_t id, uint16_t cause, uint8_t *error_tlv,
> > +sctp_asconf_error_response(uint32_t id,
On Thu, Jul 19, 2018 at 07:33:43PM +, Michael Tuexen wrote:
> New Revision: 336503
> URL: https://svnweb.freebsd.org/changeset/base/336503
>
> Log:
> Whitespace changes due to change if ident.
Was it reviewed? Commit log does not answer this not does it explain
why these changes are good.
11 matches
Mail list logo
