> On 19. Jul 2018, at 16:27, Alexey Dokuchaev <da...@freebsd.org> wrote: > > On Thu, Jul 19, 2018 at 04:23:27PM -0400, Michael Tuexen wrote: >>> On 19. Jul 2018, at 16:11, Conrad Meyer <c...@freebsd.org> wrote: >>> These changes mostly seem like style regressions, rather than >>> improvements. (Not to mention, largescale churn like this makes it >>> more difficult for future readers to research history (confusing tools >>> like "git/svn blame").) >> >> We have upstream code and run this to an formatter tool which depends >> on ident, which has been changed recently. Unfortunately, I also ran >> an older version of the script, so I reverted this in >> https://svnweb.freebsd.org/changeset/base/336508 >> and committed a version really only showing the differences related to >> the ident changes in >> https://svnweb.freebsd.org/changeset/base/336511 > > Thanks for fixing, but you might find doing "svn diff" prior to commit > very handy next time (no offense). I did actually making sure the there are only whitespace changes. However, I just take what the tool produces (for years). Only after doing svn diff for a functional change, where no whitespace changes should be, but actually were, I realised my usage error and reverted...
Best regards Michael > > ./danfe _______________________________________________ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
