Re: svn commit: r262972 - head/sys/dev/usb/input

2014-03-15 Thread Bruce Evans
On Sat, 15 Mar 2014, Hans Petter Selasky wrote: On 03/15/14 00:26, Bruce Evans wrote: LED toggling has to work in critical sections too. Then the LED code itself is not being reentered (unless parts of it are locked by critical sections), but there are other complications. Of course, the LED

Re: svn commit: r262972 - head/sys/dev/usb/input

2014-03-15 Thread Hans Petter Selasky
On 03/15/14 00:26, Bruce Evans wrote: LED toggling has to work in critical sections too. Then the LED code itself is not being reentered (unless parts of it are locked by critical sections), but there are other complications. Of course, the LED code must not use any interrupts or do any context

Re: svn commit: r262972 - head/sys/dev/usb/input

2014-03-14 Thread Bruce Evans
On Fri, 14 Mar 2014, Rui Paulo wrote: On 14 Mar 2014, at 02:32, Hans Petter Selasky wrote: On 03/14/14 03:15, Rui Paulo wrote: On 10 Mar 2014, at 01:52, Hans Petter Selasky wrote: [>* excessive quoting deleted] Modified: head/sys/dev/usb/input/ukbd.c

Re: svn commit: r262972 - head/sys/dev/usb/input

2014-03-14 Thread Rui Paulo
On 14 Mar 2014, at 02:32, Hans Petter Selasky wrote: > On 03/14/14 03:15, Rui Paulo wrote: >> On 10 Mar 2014, at 01:52, Hans Petter Selasky wrote: >> >>> Author: hselasky >>> Date: Mon Mar 10 08:52:30 2014 >>> New Revision: 262972 >>> URL: http://svnweb.freebsd.org/changeset/base/262972 >>> >>

Re: svn commit: r262972 - head/sys/dev/usb/input

2014-03-14 Thread Hans Petter Selasky
On 03/14/14 03:15, Rui Paulo wrote: On 10 Mar 2014, at 01:52, Hans Petter Selasky wrote: Author: hselasky Date: Mon Mar 10 08:52:30 2014 New Revision: 262972 URL: http://svnweb.freebsd.org/changeset/base/262972 Log: Ignore USB keyboard driver calls from critical sections. Reported by: O

Re: svn commit: r262972 - head/sys/dev/usb/input

2014-03-13 Thread Rui Paulo
On 10 Mar 2014, at 01:52, Hans Petter Selasky wrote: > Author: hselasky > Date: Mon Mar 10 08:52:30 2014 > New Revision: 262972 > URL: http://svnweb.freebsd.org/changeset/base/262972 > > Log: > Ignore USB keyboard driver calls from critical sections. > > Reported by: Oliver Pinter > MFC aft