On 14 Mar 2014, at 02:32, Hans Petter Selasky <h...@bitfrost.no> wrote:
> On 03/14/14 03:15, Rui Paulo wrote: >> On 10 Mar 2014, at 01:52, Hans Petter Selasky <hsela...@freebsd.org> wrote: >> >>> Author: hselasky >>> Date: Mon Mar 10 08:52:30 2014 >>> New Revision: 262972 >>> URL: http://svnweb.freebsd.org/changeset/base/262972 >>> >>> Log: >>> Ignore USB keyboard driver calls from critical sections. >>> >>> Reported by: Oliver Pinter <oliver.p...@gmail.com> >>> MFC after: 1 week >>> >>> Modified: >>> head/sys/dev/usb/input/ukbd.c >>> >>> Modified: head/sys/dev/usb/input/ukbd.c >>> ============================================================================== >>> --- head/sys/dev/usb/input/ukbd.c Mon Mar 10 06:41:48 2014 >>> (r262971) >>> +++ head/sys/dev/usb/input/ukbd.c Mon Mar 10 08:52:30 2014 >>> (r262972) >>> @@ -1909,6 +1909,12 @@ ukbd_ioctl(keyboard_t *kbd, u_long cmd, >>> int result; >>> >>> /* >>> + * XXX Check of someone is calling us from a critical section: >>> + */ >>> + if (curthread->td_critnest != 0) >>> + return (EDEADLK); >> >> Shouldn't this panic? >> >> -- >> Rui Paulo >> > > Hi, > > This happens on shutdown, in some special case. Not sure if panic at shutdown > is appropriate? I thought this was a programming error. Do we know the special cases and why it happens? -- Rui Paulo _______________________________________________ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
