Re: svn commit: r187251 - head/sys/mips/malta

2009-01-16 Thread Stanislav Sedov
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Thu, 15 Jan 2009 17:55:00 -0700 (MST) "M. Warner Losh" mentioned: > In message: <496fc32f.3040...@freebsd.org> > Maxim Sobolev writes: > : Christoph Mallon wrote: > : > Alexey Dokuchaev schrieb: > : >> On Wed, Jan 14, 2009 at 07:05:27

Re: svn commit: r187251 - head/sys/mips/malta

2009-01-15 Thread M. Warner Losh
In message: <496fc32f.3040...@freebsd.org> Maxim Sobolev writes: : Christoph Mallon wrote: : > Alexey Dokuchaev schrieb: : >> On Wed, Jan 14, 2009 at 07:05:27PM -0700, M. Warner Losh wrote: : >>> In message: <20090115020752.52566769.s...@freebsd.org> : >>> Stanislav Sedov

Re: svn commit: r187251 - head/sys/mips/malta

2009-01-15 Thread Maxim Sobolev
Christoph Mallon wrote: Alexey Dokuchaev schrieb: On Wed, Jan 14, 2009 at 07:05:27PM -0700, M. Warner Losh wrote: In message: <20090115020752.52566769.s...@freebsd.org> Stanislav Sedov writes: : > +shift = 8 * (reg & 3); : > : : Would it make sense to replace this with : >

Re: svn commit: r187251 - head/sys/mips/malta

2009-01-15 Thread Christoph Mallon
Alexey Dokuchaev schrieb: On Wed, Jan 14, 2009 at 07:05:27PM -0700, M. Warner Losh wrote: In message: <20090115020752.52566769.s...@freebsd.org> Stanislav Sedov writes: : > +shift = 8 * (reg & 3); : > : : Would it make sense to replace this with : > +

Re: svn commit: r187251 - head/sys/mips/malta

2009-01-15 Thread Alexey Dokuchaev
On Wed, Jan 14, 2009 at 07:05:27PM -0700, M. Warner Losh wrote: > In message: <20090115020752.52566769.s...@freebsd.org> > Stanislav Sedov writes: > : > + shift = 8 * (reg & 3); > : > > : > : Would it make sense to replace this with > : > + shift = (reg & 3) << 3; >

Re: svn commit: r187251 - head/sys/mips/malta

2009-01-14 Thread M. Warner Losh
In message: <20090115020752.52566769.s...@freebsd.org> Stanislav Sedov writes: : > + shift = 8 * (reg & 3); : > : : Would it make sense to replace this with : > + shift = (reg & 3) << 3; : : to not rely on possible compiler optimizations? I don't think that it

Re: svn commit: r187251 - head/sys/mips/malta

2009-01-14 Thread Stanislav Sedov
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Wed, 14 Jan 2009 22:32:43 + (UTC) Oleksandr Tymoshenko mentioned: > Author: gonzo > Date: Wed Jan 14 22:32:43 2009 > New Revision: 187251 > URL: http://svn.freebsd.org/changeset/base/187251 > > Log: > o Simplify code: trade 15 lines of case