Re: svn commit: r326792 - head/stand/uboot/common

2017-12-12 Thread Niclas Zeising
On 12/12/17 20:27, Cy Schubert wrote: PR 224080??? Yes please. Regards -- Niclas ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

RE: svn commit: r326792 - head/stand/uboot/common

2017-12-12 Thread Cy Schubert
: Warner Losh Cc: Antoine Brodin; svn-src-h...@freebsd.org; svn-src-all@freebsd.org; src-committers Subject: Re: svn commit: r326792 - head/stand/uboot/common How about you both close one PR as a punishment and we pretend this did not happen. The thing to do was to reply to the offending

Re: svn commit: r326792 - head/stand/uboot/common

2017-12-12 Thread Warner Losh
On Tue, Dec 12, 2017 at 12:13 PM, Mateusz Guzik wrote: > How about you both close one PR as a punishment and we pretend this did > not happen. > I'll fix 6 CIDs as punishment. Warner > The thing to do was to reply to the offending commit or contact the > committer > on irc. Only in case of no

Re: svn commit: r326792 - head/stand/uboot/common

2017-12-12 Thread Mateusz Guzik
How about you both close one PR as a punishment and we pretend this did not happen. The thing to do was to reply to the offending commit or contact the committer on irc. Only in case of no timely response fixing on your own is the right thing to do. On Tue, Dec 12, 2017 at 8:03 PM, Warner Losh

Re: svn commit: r326792 - head/stand/uboot/common

2017-12-12 Thread Warner Losh
The email I wrote here also sucks. It was unduly harsh. While the commit message should have been better, I was too harsh in trying to express this and giving a better example. Warner On Tue, Dec 12, 2017 at 5:49 AM, Warner Losh wrote: > This commit message sucks. Please use a more descriptive

Re: svn commit: r326792 - head/stand/uboot/common

2017-12-12 Thread Warner Losh
This commit message sucks. Please use a more descriptive one in the future like "catch up to change rX that remove the argument from interact." If you want to be snarky, add 'pounty hat to imp' to it. Thats infornative. Your message is utterly useless. It doesn't even say what arch is broken.