The email I wrote here also sucks. It was unduly harsh. While the commit message should have been better, I was too harsh in trying to express this and giving a better example.
Warner On Tue, Dec 12, 2017 at 5:49 AM, Warner Losh <i...@bsdimp.com> wrote: > This commit message sucks. Please use a more descriptive one in the future > like "catch up to change rXXXXX that remove the argument from interact." If > you want to be snarky, add 'pounty hat to imp' to it. Thats infornative. > Your message is utterly useless. It doesn't even say what arch is broken. > > Warner > > Warner > > On Dec 12, 2017 1:47 AM, "Antoine Brodin" <anto...@freebsd.org> wrote: > >> Author: antoine >> Date: Tue Dec 12 09:46:53 2017 >> New Revision: 326792 >> URL: https://svnweb.freebsd.org/changeset/base/326792 >> >> Log: >> Attempt to unbreak buildworld >> >> Modified: >> head/stand/uboot/common/main.c >> >> Modified: head/stand/uboot/common/main.c >> ============================================================ >> ================== >> --- head/stand/uboot/common/main.c Tue Dec 12 06:56:21 2017 >> (r326791) >> +++ head/stand/uboot/common/main.c Tue Dec 12 09:46:53 2017 >> (r326792) >> @@ -500,7 +500,7 @@ main(int argc, char **argv) >> archsw.arch_readin = uboot_readin; >> archsw.arch_autoload = uboot_autoload; >> >> - interact(NULL); /* doesn't return */ >> + interact(); /* doesn't return */ >> >> return (0); >> } >> >> _______________________________________________ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
