maybe boot and run-time configurable.
It's a pity that there doesn't seem to be any documentation on what the
numbers represent (or what the "default" value is) - which means that
actually adjusting the delay numbers would be very time consuming.
--
Peter Jeremy
signature.asc
Description: PGP signature
On 2020-Jul-01 18:57:47 +1000, Peter Jeremy wrote:
>On 2020-Jun-28 21:11:10 +, Oleksandr Tymoshenko wrote:
>>Log:
>> Configure rx_delay/tx_delay values for RK3399/RK3328 GMAC
>>
>> For 1000Mb mode to work reliably TX/RX delays need to be configured
>>
ect the network is dead.
Normally, it runs 1000baseT .
--
Peter Jeremy
signature.asc
Description: PGP signature
On 2020-Jun-26 10:25:36 +1000, Peter Jeremy wrote:
>On 2020-Jun-24 17:54:25 +, John Baldwin wrote:
>>Author: jhb
>>Date: Wed Jun 24 17:54:24 2020
>>New Revision: 362589
>>URL: https://svnweb.freebsd.org/changeset/base/362589
>>
>>Log:
>> Alway
r362580 and trying to buildworld r352310 on arm64.
--
Peter Jeremy
signature.asc
Description: PGP signature
tions this
commit adds to ffs_subr.c would be moved to a different file (though
it's not immediately clear which file that would be.
--
Peter Jeremy
signature.asc
Description: PGP signature
es are only relevant to a subset
of Broadcom SoCs and (IMO) should not be included merely with "options FDT",
rather they should be conditional on the relevant Broadcom SoCs.
--
Peter Jeremy
signature.asc
Description: PGP signature
read "loader_envp" instead of "static_kenv" -- as written,
>it stomps over the kenv provided by loader.
Which breaks diskless booting and NFS root. Changing static_kenv to
loader_envp unbreaks the kernel.
--
Peter Jeremy
signature.asc
Description: PGP signature
Author: peterj
Date: Fri Oct 25 19:38:02 2019
New Revision: 354094
URL: https://svnweb.freebsd.org/changeset/base/354094
Log:
Fix use of uninitialised variable.
The RK805 regs array was being allocated before it's required size was
known, causing the driver to use memory it didn't own. T
byte value to
> 16 bytes with 4 bytes of padding. When copying one of these structs the
> compiler is free to copy the padding if it wishes.
Are there any other structs passed from kernel to userland that include
padding?
--
Peter Jeremy
signature.asc
Description: PGP signature
:typedef int ___wchar_t;
sys/sparc64/include/_types.h:typedefint ___wchar_t;
sys/x86/include/_types.h:typedefint ___wchar_t;
Looking back into history, it looks like the "unsigned" is part
of the ARM EABI.
--
Peter Jeremy
signature.asc
Description: PGP signature
Author: peterj
Date: Tue Apr 16 09:44:46 2019
New Revision: 346266
URL: https://svnweb.freebsd.org/changeset/base/346266
Log:
Specify correct Ethernet phy for RPI-B
Correct a typo in the RPI-B ethernet config - the RPi-B includes a
SMC LAN9512 USB bridge and Ethernet 10/100 NIC/phy. The
Author: peterj
Date: Tue Apr 16 09:42:42 2019
New Revision: 346265
URL: https://svnweb.freebsd.org/changeset/base/346265
Log:
Fix cpufreq(4) on RPI-B
Since r324184 the root node compatible for the original Raspberry Pi
is "brcm,bcm2835", add it to the compatible list of bcm2835_cpufreq.
nweb.freebsd.org/changeset/base/345625
>>>
>> Seems like this and the other hunk belongs to a different patch.
>Indeed. It broke the build for me
No, r345638 broke the build by only reverting one of the two extraneous hunks
from this commit.
--
Peter Jeremy
signature.asc
Description: PGP signature
On 2019-Aug-27 11:56:38 +0200, Michal Meloun wrote:
>
>
>On 25.08.2019 9:28, Peter Jeremy wrote:
>> On 2019-Aug-18 09:19:33 +, Michal Meloun
>> wrote:
>>> Improve rk_pinctrl driver:
>>
>> Sorry for the late notice but this breaks my Rock64 (RK3328).
ff2300ff irq 53 on
rk_pinctrl0
gpiobus2: on gpio2
gpio3: mem 0xff24-0xff2400ff irq 54 on
rk_pinctrl0
gpiobus3: on gpio3
rk805_pmu0: at addr 0x30 irq 55 on iicbus0
...
I haven't dug into this further yet.
--
Peter Jeremy
signature.asc
Description: PGP signature
On 2019-Jun-22 17:17:03 +1000, Peter Jeremy wrote:
>On 2019-Jun-17 19:49:09 +, Xin LI wrote:
>>Author: delphij
>>Date: Mon Jun 17 19:49:08 2019
>>New Revision: 349151
>>URL: https://svnweb.freebsd.org/changeset/base/349151
>>
>>Log:
>> Sepa
sp = 0x00010b50 fp = 0xffff00010bb0
...
--
Peter Jeremy
signature.asc
Description: PGP signature
error: implicit
declaration of function 'EVENTHANDLER_REGISTER' is invalid in C99
[-Werror,-Wimplicit-function-declaration]
nd_detach_cookie = EVENTHANDLER_REGISTER(ifnet_departure_event,
^
--
Peter Jeremy
signature.asc
Description: PGP signature
ommits because these devices
have 64-bit issues - the commit log should document this.
--
Peter Jeremy
signature.asc
Description: PGP signature
On 2019-May-06 12:09:20 +0300, Konstantin Belousov wrote:
>On Mon, May 06, 2019 at 06:56:41PM +1000, Peter Jeremy wrote:
>> On 2019-May-05 11:20:44 +, Konstantin Belousov wrote:
>> >Log:
>> > Switch to use shared vnode locks for text files during image activation
533200 lr = 0x00221420
sp = 0x56b1dba0 fp = 0xe760
KDB: enter: panic
[ thread pid 1 tid 12 ]
Stopped at 0x28d598: undefined 54000042
db>
--
Peter Jeremy
signature.asc
Description: PGP signature
Author: peterj
Date: Fri May 3 23:06:35 2019
New Revision: 347071
URL: https://svnweb.freebsd.org/changeset/base/347071
Log:
MFC: r346266
Specify correct Ethernet phy for RPI-B
Approved by: grog, jhb (mentors)
Modified:
stable/12/sys/arm/conf/RPI-B
Directory Properties:
stable/12/
Author: peterj
Date: Fri May 3 23:07:07 2019
New Revision: 347072
URL: https://svnweb.freebsd.org/changeset/base/347072
Log:
MFC: r346266
Specify correct Ethernet phy for RPI-B
Approved by: grog, jhb (mentors)
Modified:
stable/11/sys/arm/conf/RPI-B
Directory Properties:
stable/11/
Author: peterj
Date: Fri May 3 23:02:15 2019
New Revision: 347069
URL: https://svnweb.freebsd.org/changeset/base/347069
Log:
MFC: r346265
Fix cpufreq(4) on RPI-B
Approved by: grog, jhb (mentors)
Modified:
stable/12/sys/arm/broadcom/bcm2835/bcm2835_cpufreq.c
Directory Properties:
st
Author: peterj
Date: Fri May 3 23:02:55 2019
New Revision: 347070
URL: https://svnweb.freebsd.org/changeset/base/347070
Log:
MFC: r346265
Fix cpufreq(4) on RPI-B
Approved by: grog, jhb (mentors)
Modified:
stable/11/sys/arm/broadcom/bcm2835/bcm2835_cpufreq.c
Directory Properties:
st
Author: peterj
Date: Fri May 3 22:56:50 2019
New Revision: 347068
URL: https://svnweb.freebsd.org/changeset/base/347068
Log:
MFC r343953:
Replace calls to sin(x) and cos(x) with a single call to sincos().
Replace calls to sinf(x) and cosf(x) with a single call to sincosf().
Approved by
Author: peterj
Date: Fri May 3 22:54:56 2019
New Revision: 347067
URL: https://svnweb.freebsd.org/changeset/base/347067
Log:
MFC r343953:
Replace calls to sin(x) and cos(x) with a single call to sincos().
Replace calls to sinf(x) and cosf(x) with a single call to sincosf().
Approved by
Author: peterj
Date: Tue Apr 16 09:44:46 2019
New Revision: 346266
URL: https://svnweb.freebsd.org/changeset/base/346266
Log:
Specify correct Ethernet phy for RPI-B
Correct a typo in the RPI-B ethernet config - the RPi-B includes a
SMC LAN9512 USB bridge and Ethernet 10/100 NIC/phy. The
Author: peterj
Date: Tue Apr 16 09:42:42 2019
New Revision: 346265
URL: https://svnweb.freebsd.org/changeset/base/346265
Log:
Fix cpufreq(4) on RPI-B
Since r324184 the root node compatible for the original Raspberry Pi
is "brcm,bcm2835", add it to the compatible list of bcm2835_cpufreq.
nweb.freebsd.org/changeset/base/345625
>>>
>> Seems like this and the other hunk belongs to a different patch.
>Indeed. It broke the build for me
No, r345638 broke the build by only reverting one of the two extraneous hunks
from this commit.
--
Peter Jeremy
signature.asc
Description: PGP signature
lines of:
"A GENERIC kernel will include suitable compatibility options to run
binaries from older branches. Note that the ability to run binaries
from unsupported branches is not guaranteed."
--
Peter Jeremy
signature.asc
Description: PGP signature
Author: peterj
Date: Sun Feb 10 08:46:07 2019
New Revision: 343953
URL: https://svnweb.freebsd.org/changeset/base/343953
Log:
Replace calls to sin(x) and cos(x) with a single call to sincos().
Replace calls to sinf(x) and cosf(x) with a single call to sincosf().
Submitted by: Steve Kargl
DATING and stable/x/UPDATING. Note that the stable/10 branch-
point was already in head/UPDATING.
Do you have a quick way to find branch points? The best I've found is
"svn log -r 1:HEAD --limit 1 --stop-on-copy" within a branch and that
is quite resource intensive on the SVN server.
--
Peter Jeremy
signature.asc
Description: PGP signature
Author: peterj
Date: Wed Jul 18 09:32:43 2018
New Revision: 336448
URL: https://svnweb.freebsd.org/changeset/base/336448
Log:
Retrospectively document SVN branch point for stable-10 and its releases.
This is a direct commit to stable/10 because the releases are taken
from the stable/10 br
Author: peterj
Date: Tue Jul 17 11:44:04 2018
New Revision: 336409
URL: https://svnweb.freebsd.org/changeset/base/336409
Log:
Retrospectively document SVN branch points for stable-11 and its releases.
This is a direct commit to stable/11 because the releases are taken
from this branch.
Author: peterj
Date: Tue Jul 17 11:35:40 2018
New Revision: 336406
URL: https://svnweb.freebsd.org/changeset/base/336406
Log:
Retrospectively document SVN branch point for stable-11
Approved by: jhb (mentor)
Differential Revision:https://reviews.freebsd.org/D16262
Modified:
he
o inlining SMP versions of atomic operations in modules is probably
the correct decision now.
--
Peter Jeremy
signature.asc
Description: PGP signature
ith a different compiler could completely
change the behaviour.
--
Peter Jeremy
signature.asc
Description: PGP signature
On 2017-Dec-19 15:15:38 +0100, Baptiste Daroussin wrote:
>On Thu, Dec 14, 2017 at 05:52:15AM +1100, Peter Jeremy wrote:
>> On 2017-Dec-06 10:01:02 +, Baptiste Daroussin wrote:
>> >Author: bapt
>> >Date: Wed Dec 6 10:01:02 2017
>> >New Revision: 326619
On 2017-Dec-19 14:50:57 +0200, Andriy Gapon wrote:
>On 13/12/2017 20:52, Peter Jeremy wrote:
>> This change appears to break the backpressure mechanism that forces
>> ARC to release wired memory. Running FreeBSD/amd64 r326743, I found
...
>could you please try to monitor
red (including 19GB ARC, 7GB VBox guests). Running a tool
that just allocates and dirties a large amount of memory had no effect
on the ARC size. Reverting this change only restores normal behaviour
where ARC will shrink under pressure.
My ZFS boot tunables are:
vfs.zfs.arc_max="24G&qu
YSCTL_ADD_UQUAD(ctx, queue_list, OID_AUTO, "no_tx_dma_setup",
^~
@/sys/sysctl.h:413:12: note: expanded from macro 'SYSCTL_ADD_UQUAD'
uint64_t *__ptr = (ptr); \
^ ~
1 error generated.
--
Peter Jeremy
signature.asc
Description: PGP signature
ITH_PKGNG=yes/PKGSUFFIX=.txz.
And you are doing so in the clear knowledge that what you are doing is
not supported by the FreeBSD Project.
--
Peter Jeremy
signature.asc
Description: PGP signature
Author: peterj
Date: Mon Jan 30 08:38:32 2017
New Revision: 312984
URL: https://svnweb.freebsd.org/changeset/base/312984
Log:
Extend LD_UTRACE by also generating utrace(2) log events for runtime linker
errors.
Reviewed by: kib, jhb
Approved by: jhb(mentor)
MFC after:1 week
Dif
to leave
> sio(4), but the other disconnected drivers are candidates I think.
I have digi(4) patches but no longer have any digi cards. Judging by the
time since they were disconnected, I think they can be deleted.
--
Peter Jeremy
signature.asc
Description: PGP signature
talk to a server using 1024-bit DSA.
Note that the handbook still talks about using DSA - that needs updating as
well.
--
Peter Jeremy
signature.asc
Description: PGP signature
st 2 accessible bytes beyond the address), the
following has the added advantage of only referencing (addr) once. (I'm
not suggesting it as a replacement though).
#define ETHER_IS_BROADCAST(addr) \
((*(const long *)(addr) & 0x00ffl) == 0x00ffl)
--
Peter Jeremy
signature.asc
Description: PGP signature
r/local/bin/svn or
/usr/bin/svnlite (in that order) but a non-standard configuration could
result in different results.
--
Peter Jeremy
signature.asc
Description: PGP signature
sizeof(WalIndexHdr));
If the compiler complained about that, the compiler is broken. 'const'
is a promise to the caller that the given parameter will not be modified
by the callee. There's no requirement that the passed argument be const.
As bde commented, the casts are all spurious.
--
Peter Jeremy
pgp22xHy3wS8C.pgp
Description: PGP signature
a multiple of RANDOM_BLOCKSIZE, this will
pad it by an additional RANDOM_BLOCKSIZE. I don't think this matters but
it's not what the comment implies. (The comment also goes over 80 columns).
--
Peter Jeremy
pgpgWwSc_VJgi.pgp
Description: PGP signature
d have been capitalized if it was an acronym.
It's not an acronym. I've only ever seen it written as 'iff'.
--
Peter Jeremy
pgpHYR1_7H5Wg.pgp
Description: PGP signature
A.
As linimon pointed out, FreeBSD no longer supports Alpha.
>FreeBSD support Digi EISA card.
The digi(4) driver was removed from FreeBSD because it wasn't adapted
for TTYng. I had some patches for PCI digi cards (see pr/152253 and
pr/158086) but no longer have access to the hard
On 2015-Mar-15 14:35:23 -0700, Adrian Chadd wrote:
>.. promise I'm done for now.
69 commits (68 to the same file) and the perfect sequence only broken
by pav@ and jilles@. I think you deserve some sort of reward.
--
Peter Jeremy
pgpDi7kkBl62y.pgp
Description: PGP signature
there are a few specific modules that aren't good for arm, we should
>be fixing that in the modules makefiles.
For the most popular ARM SoCs, I'd suggest that about half of the
modules don't make sense: There's no ISA or PCI bus available so
there's no point i
VM do write as 'root'. root maped to
>nobody. When this is created -- host 9.1, VM -- 6.x.
I can reproduce this with FreeBSD 10/r276177 client and server running
NFSv3 using the "new" NFS code. It appears to be due to the (broken)
initialisation of def_anon in mountd(8) with '(uid_t)-2' - as noted by
bde. It's nothing to do with ZFS.
--
Peter Jeremy
pgpsRbtrCXkEA.pgp
Description: PGP signature
2012 tcl-8.5.11.tbz ->
>../All/tcl-8.5.11.tbz
>lrwxr-xr-x 1 4294967294 wheel 29 Mar 17 2012 tcl-modules-8.5.11.tbz ->
>../All/tcl-modules-8.5.11.tbz
All this means is that you have some files with that uid. It's not
clear how they were created.
--
Peter Jeremy
pgpFyGSGmlSY_.pgp
Description: PGP signature
Author: peterj
Date: Wed Dec 31 00:08:37 2014
New Revision: 276434
URL: https://svnweb.freebsd.org/changeset/base/276434
Log:
MFH r230580:
Don't mention no longer supported ioctl commands.
MFH r274083:
convert .Nm to proper .Xr's...
MFH r275298:
Cross reference tap(4) and tun(4)
Author: peterj
Date: Tue Dec 30 23:52:48 2014
New Revision: 276433
URL: https://svnweb.freebsd.org/changeset/base/276433
Log:
MFH r274083:
convert .Nm to proper .Xr's...
MFH r275298:
Cross reference tap(4) and tun(4) and include a short explanation as
to how they differ. This will as
Author: peterj
Date: Sun Dec 28 07:16:48 2014
New Revision: 276328
URL: https://svnweb.freebsd.org/changeset/base/276328
Log:
MFH r275941:
Adjust the test of a KASSERT to better match the intent.
This assertion was added in r246213 as a guard against corrupted mbufs
arriving from driver
Author: peterj
Date: Sun Dec 28 07:14:38 2014
New Revision: 276327
URL: https://svnweb.freebsd.org/changeset/base/276327
Log:
MFH r275941:
Adjust the test of a KASSERT to better match the intent.
This assertion was added in r246213 as a guard against corrupted mbufs
arriving from driver
Author: peterj
Date: Sun Nov 30 04:50:13 2014
New Revision: 275298
URL: https://svnweb.freebsd.org/changeset/base/275298
Log:
Cross reference tap(4) and tun(4) and include a short explanation as
to how they differ. This will assist users in selecting which interface
is more appropriate for
On 2014-Feb-22 13:14:38 +0100, Baptiste Daroussin wrote:
>On Sat, Feb 22, 2014 at 07:23:50PM +1100, Peter Jeremy wrote:
>> I'd also query the reason for including Debian-specific code in the
>> FreeBSD base.
>Where have you seen debian specific code?
/usr/src/contrib/d
loading to also refer to a MTA is not
going to end well.
I'd also query the reason for including Debian-specific code in the
FreeBSD base.
--
Peter Jeremy
pgpEJGBY8QYJI.pgp
Description: PGP signature
ay). And, whilst it's _really_
late in the 10.0 release cycle, I'm not sure we want to roll a release
with broken multicast.
--
Peter Jeremy
pgpTdMTJGpfUV.pgp
Description: PGP signature
d_fetch_4 is supposed to be
a gcc builtin so I'm not sure why it's being emitted without a definition.
--
Peter Jeremy
pgpXL4FQEHwEX.pgp
Description: PGP signature
27;s a reason for not getting rid of one copy of SQLite).
(I'm concerned in general at the duplication of code in base - we already
have about 4 copies of gzip and 2 different IEEE floating point emulators).
--
Peter Jeremy
pgp1O5K5uJkhG.pgp
Description: PGP signature
ers).
I don't see why base needs to grow an ugly symlink to support a couple
of ports. Surely if ports rely on an undocumented features of the
toolchain, the correct solution is to fix the ports.
--
Peter Jeremy
pgp8WrV6lGSB7.pgp
Description: PGP signature
ree the other sleep(1)s should be able to be replaced with
touch(1) but I ran into problems with my initial efforts to do
everything using touch(1). I will revisit it.
--
Peter Jeremy
pgpbZiacaTyV6.pgp
Description: PGP signature
Author: peterj
Date: Mon Feb 25 19:05:40 2013
New Revision: 247274
URL: http://svnweb.freebsd.org/changeset/base/247274
Log:
Enhance test(1) by adding provision to compare any combination of the
access, birth, change and modify times of two files, instead of only
being able to compare modify
rm/busdma_machdep-v6.c
Do you have any plans to make similar changes to the other busdma_machdep.c
files?
--
Peter Jeremy
pgpR1uFwMi0LM.pgp
Description: PGP signature
ple.freebsd.org/~pjd/patches/savecore.patch
Adding a "maxdumps" parameter seems a good idea. The behaviour when
it hits the limit is less clear - throwing away the latest crashdump
is probably as easy to justify as throwing away the oldest one.
A further downside to enabling crashdumps is the time overhead -
initially writing the dump, copying it to /var/crash and running
crashinfo. This all directly increases the length of the outage.
--
Peter Jeremy
pgppyBJYUZC4e.pgp
Description: PGP signature
locate all the space in the jemalloc arenas,
this dominates the runtime - in the case of /bin/echo, I measured
87 page faults with MALLOC_PRODUCTION and 2133 without.
--
Peter Jeremy
pgpCEY8jxCTmb.pgp
Description: PGP signature
Author: peterj
Date: Tue Nov 27 19:35:21 2012
New Revision: 243626
URL: http://svnweb.freebsd.org/changeset/base/243626
Log:
MFC r241708: Explicitly specify 'np' so that getty(8) does not
simulate even parity on local.9600.
PR: 76226
Approved by: jhb (mentor)
Modified:
st
Author: peterj
Date: Tue Nov 27 19:33:25 2012
New Revision: 243625
URL: http://svnweb.freebsd.org/changeset/base/243625
Log:
MFC r241708: Explicitly specify 'np' so that getty(8) does not
simulate even parity on local.9600.
PR: 76226
Approved by: jhb (mentor)
Modified:
st
Author: peterj
Date: Tue Nov 27 19:23:54 2012
New Revision: 243623
URL: http://svnweb.freebsd.org/changeset/base/243623
Log:
MFC r241708: Explicitly specify 'np' so that getty(8) does not
simulate even parity on local.9600.
PR: 76226
Approved by: jhb (mentor)
Modified:
st
something that a maintainer is actively working on,
they need to take the time to work out if the change is still relevant
and whether it impacts the testing they have done.
--
Peter Jeremy
pgpfjbYP0tlUr.pgp
Description: PGP signature
ory usage may override ABI compatibility in an embedded environment.
>All that assuming you can actually prove a real performance loss even
>in the new cases.
The issue with padding on embedded systems is memory utilisation rather
than performance.
--
Peter Jeremy
pgpXpfkUISFui.pgp
Description: PGP signature
Author: peterj
Date: Thu Oct 18 22:20:02 2012
New Revision: 241708
URL: http://svn.freebsd.org/changeset/base/241708
Log:
Explicitly specify 'np' so that getty(8) does not simulate even parity on
local.9600. Whilst the actual binary termios(4) definitions and preceeding
comments for local.9
al interface like Ethernet.
You might like to look at bin/124825 as well.
--
Peter Jeremy
pgpUCqX1y1Sw3.pgp
Description: PGP signature
[label="Peter Wemm\npe...@freebsd.org\n/??/??"]
+peterj [label="Peter Jeremy\npet...@freebsd.org\n2012/09/14"]
pfg [label="Pedro Giffuni\n...@freebsd.org\n2011/12/01"]
philip [label="Philip Paeps\nphi...@freebsd.org\n2004/01/21"]
phk [label="Poul-Henning K
t;+"Maximum allowed pid");
I don't see anything in this code that would prevent setting max_pid
to an unusably low (as in making the system unusable) or even negative
value
>+ TUNABLE_INT_FETCH("kern.pid_max", &pid_max);
>+ if (pid_max > PID_MAX)
>+ pid_max = PID_MAX;
> }
Likewise, this needs a lower bounds check.
--
Peter Jeremy
pgp4HtfHr6Zd7.pgp
Description: PGP signature
if you intend to
MFC this (and hopefully r238456) soon. I've had a quick try at
merging this back to 8.x but it relies on vm_pageout_page_lock()
and vm_page_unlock() which were added in r207694 and I'm not sure
about the impact of merging that.
--
Peter Jeremy
pgpnQFqEqO0WK.pgp
Description: PGP signature
ions of zlib (1.2.3 & 1.0.4, respectively) and the original files
have been munged is different ways. (And there's a third inflate(9)
based on unzip-5.12 in sys/kern/inflate.c, as well as another complete
zlib-1.2.7 in lib/libz)
--
Peter Jeremy
pgpe3zgXf4fZa.pgp
Description: PGP signature
we bump OSVERSION for this, we are probably
looking at another half-dozen or so bumps. Do any ports actually have
a hard-wired decision for expl() (or other libm functions)? I would
hope most ports that are interested in complex and/or long double
functions have some sort of configure-time test
1) resizing for me (and appears to be the problem
underlying kern/169603). Reverting this commit makes the problem go
away. I have added more details to that PR.
--
Peter Jeremy
pgpdltWphZ3nN.pgp
Description: PGP signature
you have any plans to MFC this? I've had a quick look but there
are non-trivial conflicts in kern/sys_pipe.c on both 8.x & 9.x and
I don't want to spend time resolving them if you have already done so.
--
Peter Jeremy
pgp230ETLgHJC.pgp
Description: PGP signature
This expired some time ago, do you intend to MFC these changes in
the near future?
--
Peter Jeremy
pgpxt0J9Pd2po.pgp
Description: PGP signature
fix is to move
the "wsp = ws;" outside the loop.
> It's remarkable that the
> patch that introduced the bug was never tested, but even more
> remarkable that nobody noticed for over two years.
It took me a while to work out that the problem was libc and not my code.
you which variable was NULL
without needing to trawl through the crashdump to find what caused the
NULL pointer dereference trap.
--
Peter Jeremy
pgpjL14t5VkbC.pgp
Description: PGP signature
web.
Is it possible that the pf code was checked out of an OpenBSD repo
without the correct $OpenBSD$ tag expansion?
This caused me a degree of confusion whilst trying to correlate the
FreeBSD code with the OpenBSD code to try and update bin/124825
--
Peter Jeremy
pgpbc129oOVJn.pgp
Description: PGP signature
t I've just found the following preprocessor
conditionals in sys/contrib/pf/net/pfvar.h as a result of this
commit (covering lines 214..282):
#ifdef __FreeBSD__
...
#ifdef __FreeBSD__
...
#else
...
#endif /* __FreeBSD__ */
...
#endif /* __FreeBSD__ */
Was there a mismerge here?
--
Peter Jeremy
ine SIG_ATOMIC_MIN INT64_MIN
#define SIG_ATOMIC_MAX INT64_MAX
--
Peter Jeremy
pgp6RUwhjEkTa.pgp
Description: PGP signature
*);
>
>-extern int lflag, sflag, xflag;
>+extern int lflag, sflag, xflag, zflag;
That's an interesting spelling of "static". I presume this is a
general cleanup of identifier visibility to prevent unexpected
aliasing - in which case a more general log message may have nicer.
--
Peter Jeremy
pgpuH8LPxKoLE.pgp
Description: PGP signature
each group. Using both authorized_keys and
authorized_keys2 substantially simplifies the overall key management.
--
Peter Jeremy
pgpcCk3NoEtPC.pgp
Description: PGP signature
ust lack of time or oversight?
--
Peter Jeremy
pgpZcTjgwyBvr.pgp
Description: PGP signature
it somewhere but I don't see the version bump anywhere.
SVN reports this commit only affects UPDATING.
--
Peter Jeremy
pgpZx5ol4fFEY.pgp
Description: PGP signature
tydevsw
fields that aren't defined by the driver, with results that won't be
pretty.
--
Peter Jeremy
pgphpfvkXQK8n.pgp
Description: PGP signature
s it virtually impossible to measure short periods.
Luckily, AMD seem to have gotten this right.
--
Peter Jeremy
pgp3NkrtDxZA1.pgp
Description: PGP signature
t
was useful for recovering hard disks
--
Peter Jeremy
pgpECucxAP89M.pgp
Description: PGP signature
1 - 100 of 142 matches
Mail list logo