svn commit: r356666 - in head/usr.bin: factor primes

2020-01-12 Thread Garance A Drosehn
Author: gad Date: Sun Jan 12 20:25:11 2020 New Revision: 35 URL: https://svnweb.freebsd.org/changeset/base/35 Log: Fix the way 'factor' behaves when using OpenSSL to match the description of how it works when not compiled with OpenSSL. Also, allow users to specify a hexadecimal nu

svn commit: r330787 - head/usr.sbin/lpr/common_source

2018-03-11 Thread Garance A Drosehn
Author: gad Date: Mon Mar 12 01:41:16 2018 New Revision: 330787 URL: https://svnweb.freebsd.org/changeset/base/330787 Log: Fix the resource leak of a 'FILE *' which could happen in routine ctl_readcf() if a call to malloc failed. PR: 204955 Reported by: David Binderman Modif

Re: ps output line length (was: svn commit: r314685 - head/bin/ps)

2018-01-29 Thread Garance A Drosehn
On 28 Jan 2018, at 11:22, Mike Karels wrote: > The rationale for the original code was that, for interactive uses, the > output line length should be the same for "ps ...", "ps ...|more", and > "ps ... |grep". The -w option exists to make the line longer; there is > no option to use the terminal

svn commit: r315655 - head/usr.sbin/lpr/chkprintcap

2017-03-20 Thread Garance A Drosehn
Author: gad Date: Mon Mar 20 22:36:28 2017 New Revision: 315655 URL: https://svnweb.freebsd.org/changeset/base/315655 Log: Fixes to chkprintcap: - Check the return from a call to malloc() in skim_printcap(), and return a NULL if that fails. - Fix a small memory leak in main() that happen

Re: svn commit: r314654 - in head/cddl: lib/drti lib/libavl lib/libctf lib/libdtrace lib/libnvpair lib/libumem lib/libuutil lib/libzfs lib/libzfs_core lib/libzpool sbin/zfs sbin/zpool usr.bin/ctfconve

2017-03-05 Thread Garance A Drosehn
On 5 Mar 2017, at 20:43, Ngie Cooper wrote: >> On Mar 5, 2017, at 17:05, Garance A Drosehn wrote: >> >> FWIW, here was my method to fix the "slows down output" issue. >> I wrote a wrapper around 'make' which I called "wcmake", and >&g

Re: svn commit: r314654 - in head/cddl: lib/drti lib/libavl lib/libctf lib/libdtrace lib/libnvpair lib/libumem lib/libuutil lib/libzfs lib/libzfs_core lib/libzpool sbin/zfs sbin/zpool usr.bin/ctfconve

2017-03-05 Thread Garance A Drosehn
On 4 Mar 2017, at 15:42, Ngie Cooper (yaneurabeya) wrote: On Mar 4, 2017, at 12:39, Rodney W. Grimes wrote: On 4 Mar 2017, at 15:13, Bryan Drewery wrote: Where is this discussion? The only one I can find is https://reviews.freebsd.org/D9207 which seems to have a consensus of moving to SRCTOP

Re: svn commit: r303716 - head/crypto/openssh

2016-08-08 Thread Garance A Drosehn
On 7 Aug 2016, at 7:40, Bruce Simpson wrote: > On 07/08/16 11:58, Bruce Simpson wrote: >> Is there a way to revert this change, at least on an ongoing >> operational basis (e.g. configuration file) for those of us who >> use FreeBSD to connect directly to such devices? > > I was able to override t

svn commit: r298592 - head/usr.sbin/lpr/lpd

2016-04-25 Thread Garance A Drosehn
Author: gad Date: Mon Apr 25 20:58:54 2016 New Revision: 298592 URL: https://svnweb.freebsd.org/changeset/base/298592 Log: Remove a variable and three lines of code which I should have removed as part of revision 98776 back on June 24/2002. Noticed by pfg@ trying coccinelle for checking cod

svn commit: r290951 - head

2015-11-16 Thread Garance A Drosehn
Author: gad Date: Mon Nov 16 22:08:49 2015 New Revision: 290951 URL: https://svnweb.freebsd.org/changeset/base/290951 Log: I'm still interested in reviewing any code changes to lpr & friends (lpc, lpd, lpq, etc). Modified: head/MAINTAINERS Modified: head/MAINTAINERS ===

Re: svn commit: r263351 - in head: bin/pkill bin/pkill/tests etc/mtree tools/regression/usr.bin/pkill

2014-03-19 Thread Garance A Drosehn
On 19 Mar 2014, at 8:46, Julio Merino wrote: > Author: jmmv > Date: Wed Mar 19 12:46:04 2014 > New Revision: 263351 > URL: http://svnweb.freebsd.org/changeset/base/263351 > > Log: > Migrate tools/regression/usr.bin/pkill to the new tests layout. > > Interestingly, the pkill tool lives in bin, not

Re: svn commit: r253002 - head

2013-07-08 Thread Garance A Drosehn
On 7/7/13 4:39 PM, Alfred Perlstein wrote: Log: Document tip on how to build all kernels quickly. Modified: head/Makefile == --- head/Makefile Sun Jul 7 19:58:14 2013(r253001) +++ head/Makefile

Re: svn commit: r251886 - in head: contrib/apr contrib/apr-util contrib/serf contrib/sqlite3 contrib/subversion share/mk usr.bin usr.bin/svn usr.bin/svn/lib usr.bin/svn/lib/libapr usr.bin/svn/lib/liba

2013-06-22 Thread Garance A Drosehn
On 6/22/13 2:38 PM, Tijl Coosemans wrote: > On 2013-06-20 21:34, Warner Losh wrote: >> >> I think insisting on a definitive statement on svn lite's mission >> statement is a way to obstruct progress. Sometimes you just need to >> things because they feel right, not because they have been through a

Re: svn commit: r251886 - in head: contrib/apr contrib/apr-util contrib/serf contrib/sqlite3 contrib/subversion share/mk usr.bin usr.bin/svn usr.bin/svn/lib usr.bin/svn/lib/libapr usr.bin/svn/lib/liba

2013-06-18 Thread Garance A Drosehn
On 6/18/13 12:40 PM, Tijl Coosemans wrote: > On 2013-06-18 04:53, Peter Wemm wrote: >> Author: peter >> Date: Tue Jun 18 02:53:45 2013 >> New Revision: 251886 >> URL: http://svnweb.freebsd.org/changeset/base/251886 >> >> Log: >>Introduce svnlite so that we can check out our source code again.

svn commit: r251044 - head/usr.sbin/lpr/common_source

2013-05-27 Thread Garance A Drosehn
Author: gad Date: Mon May 27 22:19:01 2013 New Revision: 251044 URL: http://svnweb.freebsd.org/changeset/base/251044 Log: Change the closeallfds() routine to use closefrom() when it is available (closefrom() was added to FreeBSD in 8.0-release). The selection is made at compile-time, as I st

svn commit: r250731 - head

2013-05-16 Thread Garance A Drosehn
Author: gad Date: Fri May 17 03:14:55 2013 New Revision: 250731 URL: http://svnweb.freebsd.org/changeset/base/250731 Log: Drop any connection to newsyslog. I haven't worked on it for quite some time. Note that I do want to keep the pre-commit review for usr.sbin/lpr. I am actively working

Re: svn commit: r235601 - head/include/protocols

2012-05-21 Thread Garance A Drosehn
On 5/21/12 11:27 AM, John Baldwin wrote: On Friday, May 18, 2012 11:24:36 am Gleb Kurtsou wrote: On (18/05/2012 09:41), John Baldwin wrote: A question about your stat changes: did you expand dev_t to 32 bits for the AFS folks, or did you leave it as 16 bits? dev_t is already 32-bit.

svn commit: r234826 - head/usr.sbin/lpr/lpc

2012-04-29 Thread Garance A Drosehn
Author: gad Date: Mon Apr 30 01:10:13 2012 New Revision: 234826 URL: http://svn.freebsd.org/changeset/base/234826 Log: Print out a warning message if a `lpc setstatus' is done when the queue is not 'lpc stop'-ed. In that situation `lpq' will not display the status message to the user, and t

svn commit: r234824 - head/usr.sbin/lpr/lpc

2012-04-29 Thread Garance A Drosehn
Author: gad Date: Mon Apr 30 00:54:10 2012 New Revision: 234824 URL: http://svn.freebsd.org/changeset/base/234824 Log: Catch the user-error when no queue name was specified on an lpc-command which supports '-msg' (e.g.: setstatus). Print out a helpful error message instead hitting a seg-fau

svn commit: r220586 - head/usr.sbin/lpr/common_source

2011-04-12 Thread Garance A Drosehn
Author: gad Date: Wed Apr 13 00:36:19 2011 New Revision: 220586 URL: http://svn.freebsd.org/changeset/base/220586 Log: - Fix the code that matches userids in match_jobspec(). It needs to check the username-for-accounting field (P), not the username-for-headerpage (L). These are usually

svn commit: r216039 - stable/8/usr.sbin/lpr/lpd

2010-11-28 Thread Garance A Drosehn
Author: gad Date: Mon Nov 29 04:57:46 2010 New Revision: 216039 URL: http://svn.freebsd.org/changeset/base/216039 Log: = MFC of r211190: - Improve the wait4data() routine so it behaves better when checking print-jobs which have last-modification times that are in the future. This shoul

svn commit: r211190 - head/usr.sbin/lpr/lpd

2010-08-11 Thread Garance A Drosehn
Author: gad Date: Wed Aug 11 19:32:49 2010 New Revision: 211190 URL: http://svn.freebsd.org/changeset/base/211190 Log: - Improve the wait4data() routine so it behaves better when checking print-jobs which have last-modification times that are in the future. This shouldn't happen, of cour

Re: INCLUDE_CONFIG_FILE in GENERIC

2010-01-15 Thread Garance A Drosehn
At the risk of sounding overly simplistic, how hard is it to just go ahead and include both versions? In my current /boot/kernel/kernel , it looks like there's 2675 bytes of CONFIG_AUTOGENERATED lines. My original config file is 13540 bytes. I don't see that there's all that much pain in inclu

svn commit: r195855 - in stable/7/usr.sbin/lpr: . common_source

2009-07-24 Thread Garance A Drosehn
Author: gad Date: Fri Jul 24 20:35:44 2009 New Revision: 195855 URL: http://svn.freebsd.org/changeset/base/195855 Log: MFC: Fix end-of-line issues that can come up when `lpq' reads information about a queue from a remote host. PR: bin/104731 Modified: stable/7/usr.sbin/lpr/

Re: AW: svn commit: r195200 - in head/usr.sbin: . wake

2009-07-01 Thread Garance A Drosehn
At 7:04 AM +0200 7/1/09, Blapp, Martin wrote: Hi folks, I really was not my or Marcs intention to skip any discussions. Rwatson told us that if we like to see it in 8.0, we need to approve it by RE and commit it before the 1. of july, and that's what I've done. Sorry if I've upset anyone. Perso

Re: svn commit: r195200 - in head/usr.sbin: . wake

2009-06-30 Thread Garance A Drosehn
At 2:09 PM -0700 6/30/09, Sam Leffler wrote: I have yet to hear a compelling argument for why wake was chosen over an existing tool that's been successfully used for a while. OTOH this isn't something that'll keep me up at night; it just seems like an ill-advised rush job that completely viol

svn commit: r194859 - head/usr.sbin/lpr/common_source

2009-06-24 Thread Garance A Drosehn
Author: gad Date: Wed Jun 24 16:57:33 2009 New Revision: 194859 URL: http://svn.freebsd.org/changeset/base/194859 Log: Fix end-of-line issues that can come up when `lpq' reads information about a queue from a remote host. That remote host may use \r, \r\n, or \n\r as the line-ending charact

Re: svn commit: r187132 - head/usr.bin/make

2009-01-30 Thread Garance A Drosehn
At 10:57 AM -0700 1/30/09, M. Warner Losh wrote: In message: <20090130173956.ga9...@dragon.nuxi.org> "David O'Brien" writes: : : 100,000 of things change within FreeBSD without discission that : displeases some set of folks. That's nothing new, but I'm : restoring compatibility and