Re: svn commit: r316591 - head/sys/dev/tpm

2017-04-08 Thread David O'Brien
On Fri, Apr 07, 2017 at 11:02:06AM -0700, Ngie Cooper wrote: > Bah. I missed the nested FreeBSD in OpenBSD comment.. nevermind the part > about enabling power support. It's too early for me to be thinking critically > I guess.. But you are helping support my case for https://reviews.freebsd.org/D1

Re: svn commit: r316591 - head/sys/dev/tpm

2017-04-08 Thread David O'Brien
On Thu, Apr 06, 2017 at 10:19:48PM -0700, Ngie Cooper (yaneurabeya) wrote: > > On Apr 6, 2017, at 15:21, David E. O'Brien wrote: > Hi David, > I think you meant to delete the other piece of code (__FreeBSD__ is > always defined). Hi Ngie, I removed 100% dead code. This was a block of

Re: svn commit: r255187 - in head/sys: conf crypto/aesni modules/aesni

2013-09-10 Thread David O'Brien
On Mon, Sep 09, 2013 at 11:41:49PM -0700, John-Mark Gurney wrote: > David O'Brien wrote this message on Mon, Sep 09, 2013 at 23:01 -0700: > Please back that out until you have an understand of what the real > problem is... Folks use FreeBSD for real work -- I have a window of

Re: svn commit: r255187 - in head/sys: conf crypto/aesni modules/aesni

2013-09-09 Thread David O'Brien
On Tue, Sep 03, 2013 at 06:31:23PM +, John-Mark Gurney wrote: > Log: > Use the fact that the AES-NI instructions can be pipelined to improve > performance... Use SSE2 instructions for calculating the XTS tweek > factor... Let the compiler do more work and handle register allocation > b

Re: svn commit: r253996 - in head: . sys/cddl/compat/opensolaris/sys sys/cddl/dev/dtrace sys/conf sys/modules/cyclic sys/modules/dtrace/dtio sys/modules/dtrace/dtmalloc sys/modules/dtrace/dtnfscl sys/

2013-08-09 Thread David O'Brien
On Tue, Aug 06, 2013 at 03:51:56PM +, Andriy Gapon wrote: > Log: .. > Also, meaning of DEBUG was overloaded to enable WITNESS support for some > OpenSolaris (primarily ZFS) locks. Now this overloading is removed and > that use of DEBUG is replaced with a new option OPENSOLARIS_WITNESS.

Re: svn commit: r253786 - in head/sys: dev/random modules/padlock_rng modules/rdrand_rng modules/yarrow_rng

2013-07-31 Thread David O'Brien
On Wed, Jul 31, 2013 at 05:58:43AM +0400, Andrey Chernov wrote: > On 31.07.2013 4:07, David O'Brien wrote: > > I believe you're talking about this code in > > sys/libkern/arc4random.c:arc4rand() > > > > if (atomic_cmpset_int(&arc4rand_iniseed_state, A

Re: svn commit: r253786 - in head/sys: dev/random modules/padlock_rng modules/rdrand_rng modules/yarrow_rng

2013-07-30 Thread David O'Brien
On Tue, Jul 30, 2013 at 05:07:46PM -0700, David O'Brien (@FreeBSD) wrote: > I believe you're talking about this code in > sys/libkern/arc4random.c:arc4rand() > > if (atomic_cmpset_int(&arc4rand_iniseed_state, ARC4_ENTR_HAVE, > ARC4_ENTR_SEED) || resee

Re: svn commit: r253786 - in head/sys: dev/random modules/padlock_rng modules/rdrand_rng modules/yarrow_rng

2013-07-30 Thread David O'Brien
On Tue, Jul 30, 2013 at 01:37:47AM +0400, Andrey Chernov wrote: > On 30.07.2013 0:58, David E. O'Brien wrote: > > Decouple yarrow from random(4) device. .. > > We currently have 3 random_adaptors: > > + yarrow > > + rdrand (ivy.c) > > + nehemeiah > > After this commit we again ha

Re: svn commit: r253786 - in head/sys: dev/random modules/padlock_rng modules/rdrand_rng modules/yarrow_rng

2013-07-30 Thread David O'Brien
On Tue, Jul 30, 2013 at 11:24:00PM +0400, Andrey Chernov wrote: > > Do you have any specific concerns? > > What about arc4rand_iniseed_state code dead without yarrow loaded? I am look at that now. -- -- David (obr...@freebsd.org) ___ svn-src-all@free

Re: svn commit: r253786 - in head/sys: dev/random modules/padlock_rng modules/rdrand_rng modules/yarrow_rng

2013-07-30 Thread David O'Brien
On Tue, Jul 30, 2013 at 11:50:34AM -0700, David O'Brien (@FreeBSD) wrote: > Please see if you cannot review the code within the tree with doing > a whiplash backout-recommit. s/with/without/ Please let me know if you're OK with taking this route. -- -- David (ob

Re: svn commit: r253618 - head/sys/dev/usb/gadget

2013-07-30 Thread David O'Brien
On Wed, Jul 24, 2013 at 03:29:34PM -0400, John Baldwin wrote: > On Wednesday, July 24, 2013 2:32:15 pm David E. O'Brien wrote: > > per style(9): > > Kernel include files (i.e. sys/*.h) come first; normally, include > > OR , but not both. includes > > , and it is okay to depend o

Re: svn commit: r253786 - in head/sys: dev/random modules/padlock_rng modules/rdrand_rng modules/yarrow_rng

2013-07-30 Thread David O'Brien
On Mon, Jul 29, 2013 at 02:43:15PM -0700, Steve Kargl wrote: > On Mon, Jul 29, 2013 at 08:58:10PM +, David E. O'Brien wrote: > > Author: obrien > > Date: Mon Jul 29 20:58:09 2013 > > New Revision: 253786 > > URL: http://svnweb.freebsd.org/changeset/base/253786 > > > > Log: > > > > * If th

Re: svn commit: r253786 - in head/sys: dev/random modules/padlock_rng modules/rdrand_rng modules/yarrow_rng

2013-07-30 Thread David O'Brien
On Tue, Jul 30, 2013 at 02:23:53PM +0200, Dag-Erling Smrgrav wrote: > "David E. O'Brien" writes: > > Log: > > Decouple yarrow from random(4) device. > > We've had a policy for several years now that all changes to the PRNG > code in the kernel and libc must be reviewed by so@. Hi DES, Where wa

Re: svn commit: r242102 - in head: contrib/bmake usr.bin/bmake

2012-11-14 Thread David O'Brien
On Thu, Oct 25, 2012 at 11:18:06PM +, Simon J. Gerraty wrote: > Log: > Merge bmake-20121010 Hi Simon, I was kicking the tires on this and noticed bmake is dynamically linked. Can you change it to being statically linked? This issue most recently came up in freebsd-current. See thread pie

Re: svn commit: r240494 - in head: contrib/pf/man contrib/pf/pfctl include sbin/pfctl sbin/pfctl/missing share/man/man4 share/man/man5 sys/conf sys/contrib/pf sys/modules/dummynet sys/modules/ipfw sys

2012-11-12 Thread David O'Brien
On Fri, Sep 14, 2012 at 11:51:51AM +, Gleb Smirnoff wrote: > Log: > o Create directory sys/netpfil, where all packet filters should > reside, and move there ipfw(4) and pf(4). > o Move most modified parts of pf out of contrib. Why didn't contrib/ipfilter/ move to sys/netpfil/ as well?

Re: svn commit: r241933 - head/sys/conf

2012-11-12 Thread David O'Brien
On Mon, Nov 12, 2012 at 04:29:07PM -0800, David O'Brien (@FreeBSD) wrote: > $ diff -Bbw files.mips.r241680,sorted files.mips.r241933,sorted | egrep -v > '^(\+|-|@@)' | wc -l > 43 Sorry, should have better ensured all input lines appeared in the output. $ diff -u999

Re: svn commit: r241933 - head/sys/conf

2012-11-12 Thread David O'Brien
On Tue, Oct 23, 2012 at 02:58:25PM +, Warner Losh wrote: > Log: > Start a clean-room implementation of files.mips. This is sufficient > for SWARM64 and SWARM64_SMP to compile. Other kernels will be layered > in. > Modified: > head/sys/conf/files.mips ... > -# Copyright (c) 2001, 2004-

Re: svn commit: r242142 - in stable/9: sys/dev/filemon tools/regression/filemon

2012-10-26 Thread David O'Brien
On Fri, Oct 26, 2012 at 09:20:39AM -0700, Juli Mallett wrote: > Under half an hour of MFC time seems rather too quick. If this was > being insta-MFC'd because of some kind of security concern, then it > would be nice to have seen it signed off by SO, and treated like a > security issue. It panice

Re: svn commit: r240116 - in vendor/atf: . atf-0.16 atf-0.16/admin atf-0.16/atf-c atf-0.16/atf-c++ atf-0.16/atf-c++/detail atf-0.16/atf-c/detail atf-0.16/atf-config atf-0.16/atf-report atf-0.16/atf-ru

2012-09-11 Thread David O'Brien
On Tue, Sep 04, 2012 at 11:07:34PM +, Marcel Moolenaar wrote: > Author: marcel > Date: Tue Sep 4 23:07:32 2012 > New Revision: 240116 > URL: http://svn.freebsd.org/changeset/base/240116 > Log: > Import ATF version 0,16 Please back this out. I already had it imported in r236635. > Discus

Re: svn commit: r239730 - head/sys/i386/include

2012-08-28 Thread David O'Brien
On Mon, Aug 27, 2012 at 01:22:28PM +, Dag-Erling Smrgrav wrote: > Author: des > Date: Mon Aug 27 13:22:27 2012 > New Revision: 239730 > URL: http://svn.freebsd.org/changeset/base/239730 > > Log: > Parly revert r239255: reinstate a default maxswzone on i386, where KVA is > scarce, but set it

Re: svn commit: r239568 - head/etc/rc.d

2012-08-22 Thread David O'Brien
On Wed, Aug 22, 2012 at 02:37:37PM -0700, Doug Barton wrote: > Were these changes discussed somewhere and I missed it? They were not discussed. I did not see the need. This is simple functionality. If securelevel is raised > 0, one cannot start up a firewall nor make major changes to time. Thus

Re: svn commit: r237624 - in head: cddl/contrib/opensolaris/cmd/dtrace/test/tst/common/llquantize cddl/contrib/opensolaris/lib/libdtrace/common sys/cddl/contrib/opensolaris/uts/common/dtrace sys/cddl/

2012-07-02 Thread David O'Brien
On Mon, Jul 02, 2012 at 04:10:26PM -0700, Pedro Giffuni wrote: > --- Lun 2/7/12, David O'Brien ha scritto: > I tend to agree with the Illumos community on that however > we may still be seeing some movement in that area. Oracle > has a linux distribution and commercial inter

Re: svn commit: r237624 - in head: cddl/contrib/opensolaris/cmd/dtrace/test/tst/common/llquantize cddl/contrib/opensolaris/lib/libdtrace/common sys/cddl/contrib/opensolaris/uts/common/dtrace sys/cddl/

2012-07-02 Thread David O'Brien
On Sun, Jul 01, 2012 at 08:32:41PM -0700, Doug Barton wrote: > On 06/29/2012 10:58, Pedro Giffuni wrote: > > Now .. David pointed out I am not respecting the code > > provenance since I didn't add them to the opensolaris > > vendor area, but these files are copyrighted Joyent > > Inc (not even Illu

Re: svn commit: r237624 - in head: cddl/contrib/opensolaris/cmd/dtrace/test/tst/common/llquantize cddl/contrib/opensolaris/lib/libdtrace/common sys/cddl/contrib/opensolaris/uts/common/dtrace sys/cddl/

2012-07-02 Thread David O'Brien
On Fri, Jun 29, 2012 at 10:09:08AM -0700, Pedro Giffuni wrote: > You are absolutely right. However I am not sure we should > bring Illumos enhancements under the opensolaris vendor > branch. The reason is that this files are CDDL'd but are > there was no property assignment done to the OpenSolaris

Re: svn commit: r237624 - in head: cddl/contrib/opensolaris/cmd/dtrace/test/tst/common/llquantize cddl/contrib/opensolaris/lib/libdtrace/common sys/cddl/contrib/opensolaris/uts/common/dtrace sys/cddl/

2012-06-29 Thread David O'Brien
On Wed, Jun 27, 2012 at 04:39:30AM +, Pedro F. Giffuni wrote: > Log: > Bring llquantize support into Dtrace. > Bryan Cantrill implemented the equivalent of semi-log graph > paper for Dtrace so llquantize will use one logarithmic and > one linear scale. ... > Obtained from: Illumo

Re: svn commit: r236593 - head/share/man/man4

2012-06-05 Thread David O'Brien
On Tue, Jun 05, 2012 at 11:07:48AM +1200, Andrew Thompson wrote: > Does the race have to be managed between the parent SET_PID ioctl and > the child doing something? Thank you for catching that. I committed an older version of that. (had copies of this on multiple machines...) -- -- David (obr

Re: svn commit: r236338 - head/usr.bin/make

2012-06-01 Thread David O'Brien
On Thu, May 31, 2012 at 08:35:54PM -0600, Warner Losh wrote: > What are your MFC plans for 9.x and 8.x? I'd like to commit to both 8 and 9 for the next release of each. > > .It Cm :L > > Converts variable to lower-case letters. > > +(deprecated) ... > > +The use of the > > +.Cm :L > > +and > > +.

Re: svn commit: r236255 - head/contrib/groff/tmac

2012-05-30 Thread David O'Brien
On Wed, May 30, 2012 at 07:34:33AM +0400, Sergey Kandaurov wrote: > On 29 May 2012 23:49, David E. O'Brien wrote: ... > > Modified: head/contrib/groff/tmac/doc-common ... > > +.ds doc-operating-system-FreeBSD-8.3 ? ? 8.3 > > +.ds doc-operating-system-FreeBSD-9.1 ? ? 9.1 > > +.ds doc-operating-syst

Re: svn commit: r235797 - head/contrib/gcc

2012-05-23 Thread David O'Brien
On Tue, May 22, 2012 at 02:07:22PM -0700, m...@freebsd.org wrote: > We run with the following at Isilon, which is somewhat bogus because > it allows a bit of sloppiness in types, but is also terribly > convenient since it means no casting on printf arguments is needed: ... > If there's no objectio

Re: svn commit: r235797 - head/contrib/gcc

2012-05-23 Thread David O'Brien
On Wed, May 23, 2012 at 01:49:45PM +0200, Dimitry Andric wrote: > On 2012-05-22 20:18, David E. O'Brien wrote: > > Log: > > Do not incorrectly warn when printing a quad_t using "%qd" on 64-bit > > platforms. ... > Until all the additional warnings this causes have been fixed, can this > commit p

Re: svn commit: r235623 - in head/contrib/gcc: . config/rs6000 config/sparc

2012-05-22 Thread David O'Brien
On Fri, May 18, 2012 at 07:02:40PM +, Pedro F. Giffuni wrote: > Log: > Bring in a subset of gcc fixes that were back ported to > the GCC 4.1 branch and are available under GPLv2. I do not understand this -- We're using GCC 4.2.1 @r127959, but you are bringing in patches that are against 4.

Re: svn commit: r228196 - in head: share/mk tools/build/options

2011-12-02 Thread David O'Brien
On Fri, Dec 02, 2011 at 09:09:54AM +, Max Khon wrote: > Log: > Revert to conservative defaults. WITH_PROFILE is a default now. Thank you. > NO_PROFILE overrides in Makefile.inc1 and bsd.own.m are left intact > so that the reversal to the WITHOUT_PROFILE will be easier in future. As I m

Re: svn commit: r228153 - head/usr.sbin/config

2011-12-02 Thread David O'Brien
On Wed, Nov 30, 2011 at 01:33:09PM +, Max Khon wrote: > Log: > Generate ${NORMAL_CTFCONVERT} invocation without '@' modifier: > - ${NORMAL_CC} is also invoked without '@' > - Userland CTF support was changed previously to echo ctfconvert > invocations too Thank you for your work on cle

Re: svn commit: r226090 - head/sys/sys

2011-10-08 Thread David O'Brien
On Fri, Oct 07, 2011 at 02:14:46PM +0300, Andriy Gapon wrote: > > Increase MSGBUF_SIZE. > > The previous size lead to truncated /var/run/dmesg.boot when booted with > > "-v". ... > Heck, I am going to five! :-) Do you know of a machine that needs "* 5"? I went with the miniumum increase that

Re: svn commit: r226089 - in head: share/man/man7 sys/kern

2011-10-08 Thread David O'Brien
On Fri, Oct 07, 2011 at 02:14:08PM +0300, Andriy Gapon wrote: > > Log: > > Disallow various debug.kdb sysctl's when securelevel is raised. .. > Maybe the same would also be a good idea for sysctls defined at the top of > sys/kern/kern_shutdown.c? Thanks for pointing those out. I'll take a look.

Re: svn commit: r225617 - in head/sys: amd64/amd64 amd64/linux32 arm/arm cddl/contrib/opensolaris/uts/common/dtrace cddl/contrib/opensolaris/uts/sparc/dtrace compat/freebsd32 compat/linux compat/svr4

2011-10-05 Thread David O'Brien
On Fri, Sep 16, 2011 at 01:58:51PM +, Kip Macy wrote: > Author: kmacy > Date: Fri Sep 16 13:58:51 2011 > New Revision: 225617 > Log: > In order to maximize the re-usability of kernel code in user space this > patch modifies makesyscalls.sh to prefix all of the non-compatibility > calls (e

Re: svn commit: r225868 - head/bin/ps

2011-10-05 Thread David O'Brien
On Sat, Oct 01, 2011 at 12:43:23PM +, Alexander Best wrote: > we could then add an envar $PS, so users can set PS=-k to restore the Should be spelled "PS_OPTIONS" please. Many of us likely have "export PS=_" in order to have dot files that support multiple OS's. This is also in-line with

Re: svn commit: r221071 - in head: . sys/amd64/conf sys/arm/conf sys/cam sys/cam/ata sys/conf sys/geom sys/i386/conf sys/mips/conf sys/modules/cam sys/pc98/conf

2011-08-15 Thread David O'Brien
On Tue, Apr 26, 2011 at 05:01:49PM +, Alexander Motin wrote: > Log: >- Add shim to simplify migration to the CAM-based ATA. For each new adaX > device in /dev/ create symbolic link with adY name, trying to mimic old ATA > numbering. Imitation is not complete, but should be enough in mos

Re: svn commit: r220954 - head

2011-05-04 Thread David O'Brien
On Tue, May 03, 2011 at 02:41:10PM +0700, Vadim Goncharov wrote: > > PR: 156579 > > Submitted by: dhw [..] > I have lines like the following in /etc/make.conf on some hosts: > > # build specified kernels by default and install first of them > KERNCONF?=ROUTER GENERIC > and d

Re: svn commit: r221053 - head/usr.bin/rlogin

2011-04-27 Thread David O'Brien
On Tue, Apr 26, 2011 at 07:27:11AM -0600, Warner Losh wrote: > I read the test log as "not really tested, feel free to back it out if > it fails on a different architecture" Irregardless of the reasons for a build break -- one should feel free to fix or back the change out until the change can be

Re: svn commit: r221053 - head/usr.bin/rlogin

2011-04-27 Thread David O'Brien
On Wed, Apr 27, 2011 at 10:48:33AM -0400, John Baldwin wrote: > For changing WARNS, 'make universe' works well I have to disagree. Due to its silent failing, it is only suitable for what PHK added it for -- "what if" changes. [Message-ID: <13101.1227520...@critter.freebsd.dk>] One has to do all

Re: svn commit: r221053 - head/usr.bin/rlogin

2011-04-26 Thread David O'Brien
On Tue, Apr 26, 2011 at 09:32:44AM -0400, John Baldwin wrote: > On Tuesday, April 26, 2011 12:09:20 am David E. O'Brien wrote: > > Author: obrien > > Date: Tue Apr 26 04:09:20 2011 > > New Revision: 221053 > > URL: http://svn.freebsd.org/changeset/base/221053 > > > > Log: > > This builds OK usin

Re: svn commit: r220497 - head/lib/libcrypt

2011-04-25 Thread David O'Brien
On Sat, Apr 09, 2011 at 02:02:04PM +, Mark Murray wrote: > Log: > Add SHA256/512 ($5$ and $6$) to crypt(3). Used in linux-world, doesn't > hurt us. Would you mind if I committed this to be a more consistent with the existing naming? Index: crypt.c =

Re: svn commit: r220982 - in head: . sys/amd64/conf sys/arm/conf sys/conf sys/i386/conf sys/ia64/conf sys/mips/conf sys/mips/malta sys/pc98/conf sys/powerpc/conf sys/sparc64/conf sys/sun4v/conf

2011-04-25 Thread David O'Brien
On Sun, Apr 24, 2011 at 08:58:58AM +, Alexander Motin wrote: > Log: > Switch the GENERIC kernels for all architectures to the new CAM-based ATA > stack. It means that all legacy ATA drivers are disabled and replaced by > respective CAM drivers. If you are using ATA device names in /etc/fs

Re: svn commit: r220370 - in head: etc/mtree include lib/libedit lib/libedit/edit lib/libedit/edit/readline sbin/gvinum usr.sbin/ntp/ntpdc usr.sbin/ntp/ntpq usr.sbin/wpa/wpa_cli

2011-04-05 Thread David O'Brien
On Tue, Apr 05, 2011 at 03:47:56PM -0400, John Baldwin wrote: > On Tuesday, April 05, 2011 2:41:01 pm David E. O'Brien wrote: > > URL: http://svn.freebsd.org/changeset/base/220370 > > Log: > > * Add the readline(3) API to libedit. The libedit versions of [..] > > Obtained from:NetBSD > >

Re: svn commit: r216473 - head/sbin/geom/class/eli

2010-12-16 Thread David O'Brien
On Thu, Dec 16, 2010 at 12:27:04PM -0800, Xin LI wrote: > On 12/16/10 12:23, Ulrich Sp??rlein wrote: > > Shamless plug: the attached, crude expect(1) script allows you to do > > $ cd /usr/src && universe-build sbin/geom WARNS=6 > > > > with the minimal amount of compilation (you have to build the

Re: svn commit: r216473 - head/sbin/geom/class/eli

2010-12-16 Thread David O'Brien
On Thu, Dec 16, 2010 at 12:25:31PM -0500, John Baldwin wrote: > On Wednesday, December 15, 2010 7:36:10 pm David E. O'Brien wrote: > > Author: obrien > > Date: Thu Dec 16 00:36:10 2010 > > New Revision: 216473 > > URL: http://svn.freebsd.org/changeset/base/216473 > > > > Log: > > Bump WARNS to 6

Re: svn commit: r214045 - in stable/8/tools/regression/bin/sh: builtins errors execution expansion set-e

2010-11-08 Thread David O'Brien
On Sat, Oct 23, 2010 at 11:20:24PM +0200, Jilles Tjoelker wrote: > On Mon, Oct 18, 2010 at 11:10:32PM +, David E. O'Brien wrote: > > +++ stable/8/tools/regression/bin/sh/builtins/command10.0 Mon Oct 18 > > 23:10:32 2010(r214045, copy of r204802, > > head/tools/regression/bin/sh/buil

Re: svn commit: r214961 - head/usr.bin/yacc

2010-11-08 Thread David O'Brien
On Sun, Nov 07, 2010 at 05:54:20PM -0800, Juli Mallett wrote: > On Sun, Nov 7, 2010 at 15:22, David E. O'Brien wrote: > > Author: obrien > > Date: Sun Nov ?7 23:22:42 2010 > > New Revision: 214961 > > URL: http://svn.freebsd.org/changeset/base/214961 > > > > Log: > > ?Directly use memory allocatio

Re: svn commit: r214123 - stable/8/bin/sh

2010-10-21 Thread David O'Brien
On Thu, Oct 21, 2010 at 10:51:16PM +0200, Jilles Tjoelker wrote: > On Thu, Oct 21, 2010 at 01:13:41AM +, David E. O'Brien wrote: > > MFC > > r213925: use rather than > > Hmm, it looks like this was not merged except for adding the mergeinfo. Hi Jilles, You are correct. Doing a merge

Re: svn commit: r213744 - head/bin/sh

2010-10-13 Thread David O'Brien
On Wed, Oct 13, 2010 at 09:07:59AM -0400, John Baldwin wrote: > To be honest, I think changing STATIC is excessive churn. At this point I'm just making everything consistently "static" so that folks that add to ash won't need to realize that "STATIC" exists. Some of the folks making various FreeB

Re: svn commit: r213744 - head/bin/sh

2010-10-13 Thread David O'Brien
On Wed, Oct 13, 2010 at 03:29:27PM +1100, Bruce Evans wrote: > Add __noinline or whatever attributes to STATIC (but keep static in > it) for the DEBUG >= 3 case if you are going that far. __noinline > should be a syntax error for variables, so this should also find any > STATICs still on variables

Re: svn commit: r213744 - head/bin/sh

2010-10-12 Thread David O'Brien
On Wed, Oct 13, 2010 at 02:18:33PM +1100, Bruce Evans wrote: > On Tue, 12 Oct 2010, David E. O'Brien wrote: >> Log: >> If DEBUG is 3 or greater, disable STATICization of functions. >> Also correct the documented location of the trace file. > > Private functions should always be static, which no

Re: svn commit: r212904 - in head: contrib/llvm contrib/llvm/autoconf contrib/llvm/autoconf/m4 contrib/llvm/bindings/ada/llvm contrib/llvm/bindings/ocaml/llvm contrib/llvm/include/llvm contrib/llvm/in

2010-10-02 Thread David O'Brien
On Mon, Sep 20, 2010 at 04:43:19PM +, Dimitry Andric wrote: > Author: dim > Date: Mon Sep 20 16:43:17 2010 > New Revision: 212904 > Log: > Upgrade our Clang in base to r114020, from upstream's release_28 branch. .. > head/contrib/llvm/tools/llvmc/examples/ > - copied from r212799, vend

Re: svn commit: r212374 - head/usr.bin/printf

2010-09-16 Thread David O'Brien
On Thu, Sep 16, 2010 at 09:36:43PM +1000, Bruce Evans wrote: > On Thu, 16 Sep 2010, David O'Brien wrote: >> Is a sentence or two a burden to the man page vs. saving someone the time >> I spent trying to figure out why printf(1) kept throwing up errors? > > WHat ab

Re: svn commit: r212374 - head/usr.bin/printf

2010-09-16 Thread David O'Brien
On Thu, Sep 09, 2010 at 09:53:02PM +0200, Jilles Tjoelker wrote: > On Thu, Sep 09, 2010 at 07:27:40PM +, David E. O'Brien wrote: > > +.Pp > > +Trying to print a dash ("-") as the first character causes > > +.Nm > > +to interpet the dash as a program argument. > > +.Nm -- > > +must be used befor

Re: svn commit: r212374 - head/usr.bin/printf

2010-09-16 Thread David O'Brien
On Thu, Sep 09, 2010 at 12:51:11PM -0700, Juli Mallett wrote: > On Thu, Sep 9, 2010 at 12:27, David E. O'Brien wrote: > > Author: obrien > > Date: Thu Sep ?9 19:27:40 2010 > > New Revision: 212374 > > URL: http://svn.freebsd.org/changeset/base/212374 > > > > Log: > > ?Note bug in trying to printf(

Re: svn commit: r205014 - in head: . sys/amd64/amd64 sys/amd64/conf sys/amd64/include sys/amd64/linux32 sys/compat/freebsd32 sys/compat/ia32 sys/conf sys/fs/procfs sys/ia64/conf sys/ia64/ia64 sys/ia64

2010-03-12 Thread David O'Brien
On Fri, Mar 12, 2010 at 10:52:27PM +0900, Rui Paulo wrote: > On 12 Mar 2010, at 21:36, Carlos A. M. dos Santos wrote: >> On Thu, Mar 11, 2010 at 11:49 AM, Nathan Whitehorn >> wrote: >>> Author: nwhitehorn >>> Date: Thu Mar 11 14:49:06 2010 >>> New Revision: 205014 >>> URL: http://svn.freebsd.org/c

Re: svn commit: r204902 - in head/sys: net netinet

2010-03-10 Thread David O'Brien
On Wed, Mar 10, 2010 at 01:01:06PM -0500, John Baldwin wrote: > On Wednesday 10 March 2010 11:08:58 am David O'Brien wrote: > > On Wed, Mar 10, 2010 at 10:50:46AM -0500, John Baldwin wrote: > > > On Wednesday 10 March 2010 10:23:39 am David O'Brien wrote: > > &g

Re: svn commit: r204902 - in head/sys: net netinet

2010-03-10 Thread David O'Brien
On Wed, Mar 10, 2010 at 09:46:49AM -0800, Qing Li wrote: > > > > I looked at it, and at the diff of his original commit. ?The changes were > > large enough that I don't want to assume his patch takes care of all the > > issues given that patch hasn't been committed verbatim. > > The change itself

Re: svn commit: r204902 - in head/sys: net netinet

2010-03-10 Thread David O'Brien
On Wed, Mar 10, 2010 at 10:50:46AM -0500, John Baldwin wrote: > On Wednesday 10 March 2010 10:23:39 am David O'Brien wrote: > > Hi Qing, > > > > This change doesn't seem to work in the common case, and has made the > > kernel toxic - with folks unable

Re: svn commit: r204902 - in head/sys: net netinet

2010-03-10 Thread David O'Brien
Hi Qing, This change doesn't seem to work in the common case, and has made the kernel toxic - with folks unable to connect to 127.0.0.1. Please back this out or adjust the change. thanks, -- -- David (obr...@freebsd.org) ___ svn-src-all@freebsd.org m

Re: svn commit: r204824 - head/sys/conf

2010-03-09 Thread David O'Brien
On Tue, Mar 09, 2010 at 08:18:25PM -0700, M. Warner Losh wrote: > In message: <20100310024553.ga13...@dragon.nuxi.org> > "David O'Brien" writes: .. > PLEASE DO NOT CHANGE newvers.sh FROM WHAT IT IS NOW. Please talk > about your proposed changes in -h

Re: svn commit: r204824 - head/sys/conf

2010-03-09 Thread David O'Brien
On Tue, Mar 09, 2010 at 07:35:12PM -0700, M. Warner Losh wrote: > > I'd recommend something similar to the following change: > Index: newvers.sh .. > +S=sys .. > -*/sys/*) > +*/$S/*) > SRCDIR=${d##*obj} > if [ -n "$MACHINE" ]; then > SRCDIR=${SRCDIR##/$MACHINE} > fi

Re: svn commit: r204824 - head/sys/conf

2010-03-09 Thread David O'Brien
On Mon, Mar 08, 2010 at 09:06:59AM -0700, M. Warner Losh wrote: > In message: <20100308010125.ga6...@dragon.nuxi.org> > "David O'Brien" writes: > : On Sun, Mar 07, 2010 at 02:36:19PM -0700, M. Warner Losh wrote: > : > Please back out

Re: svn commit: r204824 - head/sys/conf

2010-03-09 Thread David O'Brien
On Sun, Mar 07, 2010 at 06:10:52PM -0800, Doug Barton wrote: > On 03/07/10 17:01, David O'Brien wrote: > > > +*/sys/*|*/compile/*) > > Please revert your previous change, and feel free to add this one instead. This alone will not work - it doesn't fix the calculatio

Re: svn commit: r204824 - head/sys/conf

2010-03-09 Thread David O'Brien
On Sun, Mar 07, 2010 at 06:10:52PM -0800, Doug Barton wrote: > On 03/07/10 17:01, David O'Brien wrote: > > +*/sys/*|*/compile/*) > > Please revert your previous change, and feel free to add this one instead. > > I'm a little aggravated because this question of

Re: svn commit: r204824 - head/sys/conf

2010-03-07 Thread David O'Brien
On Sun, Mar 07, 2010 at 02:36:19PM -0700, M. Warner Losh wrote: > Please back out this change. It is unwise, I think. Instead I'd rather fix it for the use case you mention. >%>%>%>%>%>%>%>%>%>%>%>% Index: newvers.sh ===

Re: SPAM(3.9) Re: svn commit: r201494 - stable/7/usr.sbin/fifolog/fifolog_create

2010-01-06 Thread David O'Brien
On Mon, Jan 04, 2010 at 01:18:20PM +, Bjoern A. Zeeb wrote: >> Log: >> Spell the full word "February". >> >> Submitted by: pluk...@gmail.com > > Is there reason not to ask ru@ to MFC 178068 and/or 190693 insetad? Nope. Just trying to [quickly] respond to a reasonable request from a

Re: svn commit: r195696 - in stable/7: crypto/openssh secure/lib/libssh

2009-07-20 Thread David O'Brien
On Tue, Jul 14, 2009 at 08:46:19PM +, John Baldwin wrote: > Date: Tue Jul 14 20:46:19 2009 > New Revision: 195696 > URL: http://svn.freebsd.org/changeset/base/195696 > Log: > MFC: Use the closefrom(2) system call. > Modified: > stable/7/crypto/openssh/ (props changed) > stable/7/crypto/

Re: svn commit: r190357 - in stable/7: gnu/usr.bin/grep include lib/libelf sbin/fsck sbin/fsck_ffs sbin/mount usr.bin/gprof usr.bin/make usr.sbin/crunch usr.sbin/sade usr.sbin/sysinstall

2009-03-23 Thread David O'Brien
On Mon, Mar 23, 2009 at 07:25:41PM -0700, Sam Leffler wrote: > David E. O'Brien wrote: >> Author: obrien >> Date: Tue Mar 24 01:51:42 2009 >> New Revision: 190357 >> URL: http://svn.freebsd.org/changeset/base/190357 >> >> Log: >> MFC: r186581: Sound less scary about errorousous disk geometry. ..

Re: svn commit: r190098 - in head/sys/sparc64: fhc sparc64

2009-03-23 Thread David O'Brien
On Sun, Mar 22, 2009 at 09:54:34AM +0100, Christoph Mallon wrote: > I'm ok with 80 columns. But at the same time having tab stops every 8 > spaces - I consider this silly. You may be missing the beauty of KNF's statement continuations. e.g.: if (foo || bar || baz || other_really_long_va

Re: svn commit: r187948 - in head/sys: amd64/amd64 amd64/ia32 amd64/include amd64/linux32 compat/ndis i386/i386 i386/include i386/linux i386/svr4

2009-01-31 Thread David O'Brien
On Sat, Jan 31, 2009 at 11:37:21AM +, David O'Brien (@FreeBSD) wrote: > Author: obrien > Date: Sat Jan 31 11:37:21 2009 > New Revision: 187948 > URL: http://svn.freebsd.org/changeset/base/187948 > > Log: > Change some movl's to mov's. Newer GAS no longe

Re: svn commit: r187132 - head/usr.bin/make

2009-01-30 Thread David O'Brien
On Fri, Jan 30, 2009 at 09:36:51PM +, Dmitry Marakasov wrote: > due to multiple cores usage. And sideeffects of SMP of course, like > garbled kernel output (kernel: seScyonncdisn)g fdoirs kssy,s tvenmo > dperso > creesmsa i`nsiynngc.e.r.' to3 stop...0 0 done) :) > Which should be of course fi

Re: svn commit: r187132 - head/usr.bin/make

2009-01-30 Thread David O'Brien
On Fri, Jan 30, 2009 at 10:51:00AM -0700, M. Warner Losh wrote: > In message: <20090130173953.ga9...@dragon.nuxi.org> > "David O'Brien" writes: > : On Fri, Jan 30, 2009 at 08:54:34AM -0700, M. Warner Losh wrote: > : > Also, I'm pretty sure that

Re: svn commit: r187435 - stable/6/sys/amd64/conf

2009-01-30 Thread David O'Brien
On Fri, Jan 30, 2009 at 03:10:29AM -0800, Maxim Sobolev wrote: > David O'Brien wrote: >> On Mon, Jan 19, 2009 at 08:54:30AM -0800, David O'Brien (@FreeBSD) wrote: >>> On Mon, Jan 19, 2009 at 03:38:26PM +, Maxim Sobolev wrote: >>>> Author: sobomax >

Re: svn commit: r187132 - head/usr.bin/make

2009-01-30 Thread David O'Brien
On Fri, Jan 30, 2009 at 05:56:27PM +, Dmitry Marakasov wrote: > * David O'Brien (obr...@freebsd.org) wrote: > > I'm sorry I disagree. You're complaining about something that is > > a feature of FreeBSD 1.x, 2.0 - 3.0, 4.4BSD, all NetBSD versions, > > all Op

Re: svn commit: r187132 - head/usr.bin/make

2009-01-30 Thread David O'Brien
On Fri, Jan 30, 2009 at 08:51:30AM -0700, M. Warner Losh wrote: > In message: <20090130015518.ga20...@hades.panopticon> > Dmitry Marakasov writes: > : * David E. O'Brien (obr...@freebsd.org) wrote: > : I think this should be backed out. Those verbose messages: > : - Are completely unex

Re: svn commit: r187132 - head/usr.bin/make

2009-01-30 Thread David O'Brien
On Fri, Jan 30, 2009 at 08:54:34AM -0700, M. Warner Losh wrote: > Also, I'm pretty sure that you've misread the NetBSD sources, since I > never see that output when I build NetBSD. Since I work with one of the NetBSD make maintainers, I'll ask him if there is something I've missed, or something he

Re: svn commit: r187132 - head/usr.bin/make

2009-01-30 Thread David O'Brien
On Fri, Jan 30, 2009 at 01:55:18AM +, Dmitry Marakasov wrote: > * David E. O'Brien (obr...@freebsd.org) wrote: > > I think this should be backed out. Those verbose messages: > - Are completely unexpected, this violates POLA. Dmitry, I'm sorry I disagree. You're complaining about something th

Re: svn commit: r187435 - stable/6/sys/amd64/conf

2009-01-29 Thread David O'Brien
On Mon, Jan 19, 2009 at 08:54:30AM -0800, David O'Brien (@FreeBSD) wrote: > On Mon, Jan 19, 2009 at 03:38:26PM +, Maxim Sobolev wrote: > > Author: sobomax > > Date: Mon Jan 19 15:38:26 2009 > > New Revision: 187435 > > URL: http://svn.freebsd.org/changeset/bas

Re: svn commit: r187580 - head/tools/sched

2009-01-26 Thread David O'Brien
On Mon, Jan 26, 2009 at 10:27:49AM -0700, M. Warner Losh wrote: > In message: <20090126083518.gb87...@dragon.nuxi.org> > "David O'Brien" writes: > : On Thu, Jan 22, 2009 at 10:41:14AM -0700, M. Warner Losh wrote: > : > In message: <2009

Re: svn commit: r187069 - stable/7/sbin/fsck_ffs

2009-01-26 Thread David O'Brien
On Mon, Jan 26, 2009 at 12:41:47AM -0800, Xin LI wrote: > Just a ping on this. Please let me know if you think it's Ok to MFC the > 'C' to 'D' change to avoid the upcoming conflict against your changeset. Sounds OK to me. ___ svn-src-all@freebsd.org mai

Re: svn commit: r187580 - head/tools/sched

2009-01-26 Thread David O'Brien
On Thu, Jan 22, 2009 at 10:41:14AM -0700, M. Warner Losh wrote: > In message: <200901220621.n0m6lu5v002...@svn.freebsd.org> > Jeff Roberson writes: > : Author: jeff > : Date: Thu Jan 22 06:21:30 2009 > : New Revision: 187580 > : URL: http://svn.freebsd.org/changeset/base/187580 > : >

Re: svn commit: r187332 - head/tools/regression/usr.bin/jot

2009-01-25 Thread David O'Brien
On Mon, Jan 19, 2009 at 07:12:38PM -0700, M. Warner Losh wrote: > I'm > glad JUNOS can build inside its own VM. Kudos. But given that the > world is much more than a tightly controlled development environment > at a well funded company, I think that we need to be more > accommodating. Especially

Re: svn commit: r187332 - head/tools/regression/usr.bin/jot

2009-01-25 Thread David O'Brien
On Mon, Jan 19, 2009 at 07:12:38PM -0700, M. Warner Losh wrote: > In message: <20090120012256.gb29...@dragon.nuxi.org> "David O'Brien" > writes: > : On Mon, Jan 19, 2009 at 06:14:35PM -0700, M. Warner Losh wrote: > : > In message: <20090119165030.

Re: svn commit: r187332 - head/tools/regression/usr.bin/jot

2009-01-19 Thread David O'Brien
On Mon, Jan 19, 2009 at 04:55:04PM +, Robert Watson wrote: > On Mon, 19 Jan 2009, David O'Brien wrote: >> For changes like this to be reasoned because of building FreeBSD on >> Windows there should consensus. For MacOS X - there is a case sensitive >> FS. > &

Re: svn commit: r187332 - head/tools/regression/usr.bin/jot

2009-01-19 Thread David O'Brien
On Mon, Jan 19, 2009 at 06:14:35PM -0700, M. Warner Losh wrote: > In message: <20090119165030.ga18...@dragon.nuxi.org> > "David O'Brien" writes: > : On Sat, Jan 17, 2009 at 02:00:55PM +, Robert Watson wrote: > : > > : >

Re: svn commit: r187435 - stable/6/sys/amd64/conf

2009-01-19 Thread David O'Brien
On Mon, Jan 19, 2009 at 03:38:26PM +, Maxim Sobolev wrote: > Author: sobomax > Date: Mon Jan 19 15:38:26 2009 > New Revision: 187435 > URL: http://svn.freebsd.org/changeset/base/187435 > > Log: > MFC: take NTFS out to match i386 GENERIC. > > Modified: > stable/6/sys/amd64/conf/GENERIC ..

Re: svn commit: r187332 - head/tools/regression/usr.bin/jot

2009-01-19 Thread David O'Brien
On Sat, Jan 17, 2009 at 02:00:55PM +, Robert Watson wrote: > > On Sat, 17 Jan 2009, Stanislav Sedov wrote: > >> Was this discussed somewhere? I don't understand why we should restrict >> our filesystem naming because of limitation of auxilary filesystems. >> There're even more restrictive f

Re: svn commit: r186504 - head/sbin/mount

2009-01-12 Thread David O'Brien
On Mon, Jan 12, 2009 at 10:44:25AM +0100, Christoph Mallon wrote: > Alternatively I would have gladly reviewed your solution. Feel free to review the below. > Actually this version doesn't work either. > tron# ./mount -a > usage: mount [-t fstype] [-o options] target_fs mount_point > tron# ./mou

Re: svn commit: r186504 - head/sbin/mount

2009-01-12 Thread David O'Brien
On Mon, Jan 12, 2009 at 10:44:25AM +0100, Christoph Mallon wrote: > David O'Brien schrieb: >> On Sun, Jan 11, 2009 at 08:56:22AM +0100, Christoph Mallon wrote: >>> David O'Brien schrieb: >>>> On Sun, Jan 04, 2009 at 07:06:18PM +0100, Chris

Re: svn commit: r187069 - stable/7/sbin/fsck_ffs

2009-01-12 Thread David O'Brien
On Mon, Jan 12, 2009 at 12:39:22AM +, Xin LI wrote: > Author: delphij > Date: Mon Jan 12 00:39:22 2009 > New Revision: 187069 > URL: http://svn.freebsd.org/changeset/base/187069 > > Log: > MFC revisions 178088 and 179656: Catastrophic recovery mode. Hi Xin, I guess you missed my email to yo

Re: svn commit: r186504 - head/sbin/mount

2009-01-12 Thread David O'Brien
On Sun, Jan 11, 2009 at 08:56:22AM +0100, Christoph Mallon wrote: > David O'Brien schrieb: >> On Sun, Jan 04, 2009 at 07:06:18PM +0100, Christoph Mallon wrote: >>> I'm pretty sure $SUPERNATURAL_BEING_OF_YOUR_CHOICE killed a kitten for >>> the ugly hack you ad

Re: svn commit: r186504 - head/sbin/mount

2009-01-10 Thread David O'Brien
On Sun, Jan 04, 2009 at 07:06:18PM +0100, Christoph Mallon wrote: > I'm pretty sure $SUPERNATURAL_BEING_OF_YOUR_CHOICE killed a kitten for the > ugly hack you added to mount. The moment you overflow a buffer, you are in > no man's land and there's no escape. I appended a patch, which solves this

Re: svn: head/usr.sbin/mergemaster

2009-01-06 Thread David O'Brien
On Mon, Jan 05, 2009 at 02:46:43PM -0800, Doug Barton wrote: > A few more specifics in no particular order: .. > You don't have to page through the whole diff if you use less as your PAGER. You do thought have to hit 'q' don't you? > Matt Dillon's change to the PAGER was the single thing I got t

Re: svn commit: r186713 - head/usr.bin/make

2009-01-06 Thread David O'Brien
On Sun, Jan 04, 2009 at 10:07:55AM -0700, M. Warner Losh wrote: > In message: <200901031014.n03ae1la022...@svn.freebsd.org> > "David E. O'Brien" writes: > : Author: obrien > : Date: Sat Jan 3 10:14:01 2009 > : New Revision: 186713 > : URL: http://svn.freebsd.org/changeset/base/186713

Re: svn commit: r186731 - head/sys/dev/syscons/teken

2009-01-05 Thread David O'Brien
On Mon, Jan 05, 2009 at 06:22:43PM +0100, Ed Schouten wrote: > Hello David, > * David O'Brien wrote: > > Why xterm and not vt100? > > The reason I'm proposing xterm, is because it is the best supported > terminal type out there. Example: if we would use TERM=v

Re: svn commit: r186731 - head/sys/dev/syscons/teken

2009-01-05 Thread David O'Brien
On Sun, Jan 04, 2009 at 01:13:31PM +0100, Ed Schouten wrote: > * Kostik Belousov wrote: > > IMHO, it would be much easier to try and use the new code if the > > TEKEN_XXX defines would be implemented as both sysctl and kernel > > tunables. > > Yes. Eventually we should add tunables, but first I w

Re: svn commit: r186337 - head/usr.sbin/burncd

2009-01-05 Thread David O'Brien
On Sun, Jan 04, 2009 at 08:43:23PM +, Kris Kennaway wrote: > David O'Brien wrote: >> On Sun, Dec 21, 2008 at 10:15:21AM -0200, Carlos A. M. dos Santos wrote: >>> On Fri, Dec 19, 2008 at 6:20 PM, David E. O'Brien >>> wrote: >>>> Author: ob

  1   2   >