svn commit: r357204 - head/lib/geom/part

2020-01-28 Thread David Malone
Author: dwmalone Date: Tue Jan 28 15:34:00 2020 New Revision: 357204 URL: https://svnweb.freebsd.org/changeset/base/357204 Log: Add some missing articles. Use .Nm to format the utility name. Get the name of the GEOM class right. MFC after:2 weeks Modified: head/lib/geom/part/gpar

Re: svn commit: r299954 - stable/10/sbin/restore

2016-06-06 Thread David Malone
Hi Pedro, The OpenBSD commit message said off_t, but you commit and commit message says size_t, which won't be bigger than a long on some of our platforms. Should it have been off_t, or did I misunderstand something? David. > Author: pfg > Date: Mon May 16 16:29:56 2016 > New Revision: 29

svn commit: r296431 - in releng/10.3: lib/libc/db/hash usr.bin/cap_mkdb usr.sbin/pwd_mkdb usr.sbin/services_mkdb

2016-03-06 Thread David Malone
Author: dwmalone Date: Sun Mar 6 18:22:24 2016 New Revision: 296431 URL: https://svnweb.freebsd.org/changeset/base/296431 Log: Merge 296424 from stable/10 - contains the following changes to -current: r295924: Make sure that hash-based db files fsync befor closing/syncing. r295925: We no

svn commit: r296424 - in stable/10: lib/libc/db/hash usr.bin/cap_mkdb usr.sbin/pwd_mkdb usr.sbin/services_mkdb

2016-03-06 Thread David Malone
Author: dwmalone Date: Sun Mar 6 08:40:21 2016 New Revision: 296424 URL: https://svnweb.freebsd.org/changeset/base/296424 Log: MFC: r295924: Make sure that hash-based db files fsync befor closing/syncing. r295925: We no longer need O_SYNC pwd_mkd r295465: We no longer need O_SYNC on servi

svn commit: r295925 - head/usr.sbin/pwd_mkdb

2016-02-23 Thread David Malone
Author: dwmalone Date: Tue Feb 23 15:28:13 2016 New Revision: 295925 URL: https://svnweb.freebsd.org/changeset/base/295925 Log: Following revision r295924, the changes to a db file should be fsynced before the file is closed. Consequently, it shouldn't be necessary to open the file with O_SY

svn commit: r295924 - head/lib/libc/db/hash

2016-02-23 Thread David Malone
Author: dwmalone Date: Tue Feb 23 15:21:13 2016 New Revision: 295924 URL: https://svnweb.freebsd.org/changeset/base/295924 Log: If we close or sync a hash-based db file, make sure to call fsync to make sure the changes are on disk. The people at pfSense noticed that it didn't always make it

Re: svn commit: r295465 - head/usr.sbin/services_mkdb

2016-02-11 Thread David Malone
On Wed, Feb 10, 2016 at 09:40:45AM +, Stefan Esser wrote: > Author: se > Date: Wed Feb 10 09:40:45 2016 > New Revision: 295465 > URL: https://svnweb.freebsd.org/changeset/base/295465 > > Log: > Remove O_SYNC from the options passed to dbmopen(). > > The services db is created as a tempo

Re: svn commit: r289421 - in head/etc: . mtree ntp

2016-01-02 Thread David Malone
On Wed, Dec 30, 2015 at 04:50:45AM -0800, Colin Percival wrote: > So... is someone going to be keeping this file up to date? We seem to have > the same information in contrib/tzdata/leapseconds (which is being kept up > to date -- thank you edwin and delphij!) but having this file in /etc/ntp/ > b

Re: svn commit: r289421 - in head/etc: . mtree ntp

2015-10-18 Thread David Malone
On Sat, Oct 17, 2015 at 05:48:19PM -0600, Warner Losh wrote: > It should be very easy to try to fetch it once a day in June and December > until you succeed from each of the URLs in a list, with the default > list being the two canonical (for the US at least) sources. Shouldn’t > be more than a doz

Re: svn commit: r289421 - in head/etc: . mtree ntp

2015-10-18 Thread David Malone
Hi Warner, I was trying to check Ian's specific concern, that a valid source of leap seconds might be ignored if a expired leapseconds file was present. It seems that this is not the case, at lease based on my reading of the code and comments. I included the references to the code, so others could

Re: svn commit: r289421 - in head/etc: . mtree ntp

2015-10-17 Thread David Malone
On Sat, Oct 17, 2015 at 12:25:50PM -0600, Ian Lepore wrote: > If the leapseconds file is present, the leap bits for reference > clocks and downstratum servers are ignored. > > I can't determine from casual code examination (and I don't have time > to experiment now) whether that is true ev

svn commit: r268004 - head/usr.sbin/rwhod

2014-06-28 Thread David Malone
Author: dwmalone Date: Sat Jun 28 15:53:28 2014 New Revision: 268004 URL: http://svnweb.freebsd.org/changeset/base/268004 Log: Don't accidently skip every second line when calculating the idle time. MFC after:2 weeks Modified: head/usr.sbin/rwhod/rwhod.c Modified: head/usr.sbin/rw

Re: svn commit: r263198 - in head/sys: amd64/conf conf net netinet netinet6 sys

2014-03-17 Thread David Malone
> (1) Merge a software implementation of the Toeplitz hash specified in > RSS implemented by David Malone. This is used to allow suitable > pcbgroup placement of connections before the first packet is > received from the NIC. Software hashing is gener

svn commit: r262742 - head/usr.sbin/lpr/lpr

2014-03-04 Thread David Malone
Author: dwmalone Date: Tue Mar 4 15:09:57 2014 New Revision: 262742 URL: http://svnweb.freebsd.org/changeset/base/262742 Log: Add missing description of du (daemon.user) printcap capability. Modified: head/usr.sbin/lpr/lpr/printcap.5 Modified: head/usr.sbin/lpr/lpr/printcap.5 ==

svn commit: r261555 - head/usr.bin/units

2014-02-06 Thread David Malone
Author: dwmalone Date: Thu Feb 6 15:55:29 2014 New Revision: 261555 URL: http://svnweb.freebsd.org/changeset/base/261555 Log: Let units deal with Gas Mark and Stufe. Modified: head/usr.bin/units/units.lib Modified: head/usr.bin/units/units.lib ===

svn commit: r253988 - head/share/man/man4

2013-08-06 Thread David Malone
Author: dwmalone Date: Tue Aug 6 11:00:56 2013 New Revision: 253988 URL: http://svnweb.freebsd.org/changeset/base/253988 Log: Make section headings for different quirk types consistent. Modified: head/share/man/man4/usb_quirk.4 Modified: head/share/man/man4/usb_quirk.4 =

Re: svn commit: r247871 - head/usr.sbin/bhyve

2013-03-07 Thread David Malone
> Any suggestions for better wording ? I submitted the comment block unchanged I think you could probably replace it with "Z(2^16)" or "mod 65536". In the code, it might be worth checking with bde@ to see what is the least amount of casting required to get the right answer. David. _

Re: svn commit: r247871 - head/usr.sbin/bhyve

2013-03-06 Thread David Malone
> + /* > + * We're just computing (a-b) in GF(216). > + ndesc = (unsigned)*hq->hq_avail_idx - (unsigned)hq->hq_cur_aidx; I think the comment here is wrong? Subtraction (and addition) in GF(2^16) is just xor of 16 bit numbers. You seem to actually be working in Z(2^16), where subtract

svn commit: r247730 - head/usr.bin/find

2013-03-03 Thread David Malone
Author: dwmalone Date: Sun Mar 3 20:10:56 2013 New Revision: 247730 URL: http://svnweb.freebsd.org/changeset/base/247730 Log: Add an option for finding sparse files. Reviewed by: iedowse MFC after:3 weeks Modified: head/usr.bin/find/extern.h head/usr.bin/find/find.1 head/usr.

svn commit: r225596 - head/usr.bin/units

2011-09-15 Thread David Malone
Author: dwmalone Date: Thu Sep 15 19:52:43 2011 New Revision: 225596 URL: http://svn.freebsd.org/changeset/base/225596 Log: It seems when I added code for affine unit changes to units, I forgot to tell the man page we could now convert Celsius to Fahrenheit. Approved by: re (kib) MFC a

Re: svn commit: r219676 - head/sys/x86/x86

2011-03-24 Thread David Malone
> If atomic 64-bit read/write is possible and it is absolutely > necessary, it has to be set via machdep.foo_freq, not > kern.timecounter.foo.frequency. A number of people have asked me about adjusting the frequency of other time counters - it would seem to make sense to allow this at the timeco

Re: svn commit: r219676 - head/sys/x86/x86

2011-03-24 Thread David Malone
> No new ones. Just the old ones of updating the frequency and all related > variables without races. Is something simple, line an atomic write, an option for this? I guess we don't have 64-bit atomic writes on all platforms, but we could support it on some platforms. David.

Re: svn commit: r219676 - head/sys/x86/x86

2011-03-20 Thread David Malone
On Wed, Mar 16, 2011 at 04:34:10PM +1100, Bruce Evans wrote: > Please revert. I use this for setting timecounters from userland. The > sysctl is not a hack, but the primary user interface for managing the > TSC frequency. The kern.timecounter.tc.TSC.frequency sysctl is > secondary, and is readon

Re: svn commit: r217589 - head/usr.sbin/syslogd

2011-01-20 Thread David Malone
> snprintf(buf, 2, "%*s%*s%*s", INT_MAX, "223", INT_MAX, "", 3, "bar"); Ah - good example. Would it be worth adding some clarification to our man page? The paragraphs discussing return values suggest that *printf() functions can only fail because of output or malloc errors. I guess two other

svn commit: r217589 - head/usr.sbin/syslogd

2011-01-19 Thread David Malone
Author: dwmalone Date: Wed Jan 19 17:17:37 2011 New Revision: 217589 URL: http://svn.freebsd.org/changeset/base/217589 Log: Here v->iov_len has been assigned the return value from snprintf. Checking if it is > 0 doesn't make sense, because snprintf returns how much space is needed if the buf

svn commit: r211082 - in head/sys: amd64/amd64 i386/i386

2010-08-08 Thread David Malone
Author: dwmalone Date: Sun Aug 8 20:34:53 2010 New Revision: 211082 URL: http://svn.freebsd.org/changeset/base/211082 Log: Don't pass sizeof(u_int) to an argument of SYSCLT_PROC that ends up not being used. Modified: head/sys/amd64/amd64/tsc.c head/sys/i386/i386/tsc.c Modified: head/sys

svn commit: r201784 - head/usr.bin/ctags

2010-01-08 Thread David Malone
Author: dwmalone Date: Fri Jan 8 11:16:58 2010 New Revision: 201784 URL: http://svn.freebsd.org/changeset/base/201784 Log: This now passes a make universe with WARNS=6. Modified: head/usr.bin/ctags/Makefile Modified: head/usr.bin/ctags/Makefile ==

svn commit: r201727 - head/usr.bin/w

2010-01-07 Thread David Malone
Author: dwmalone Date: Thu Jan 7 09:47:05 2010 New Revision: 201727 URL: http://svn.freebsd.org/changeset/base/201727 Log: This now passes a make universe with WARNS=6. Modified: head/usr.bin/w/Makefile Modified: head/usr.bin/w/Makefile ==

svn commit: r201725 - head/usr.bin/xlint/xlint

2010-01-07 Thread David Malone
Author: dwmalone Date: Thu Jan 7 09:45:15 2010 New Revision: 201725 URL: http://svn.freebsd.org/changeset/base/201725 Log: This now passes a make universe with WARNS=6. Modified: head/usr.bin/xlint/xlint/Makefile Modified: head/usr.bin/xlint/xlint/Makefile ==

svn commit: r201724 - head/usr.sbin/cdcontrol

2010-01-07 Thread David Malone
Author: dwmalone Date: Thu Jan 7 09:40:34 2010 New Revision: 201724 URL: http://svn.freebsd.org/changeset/base/201724 Log: This now passes a make universe with WARNS=6. Modified: head/usr.sbin/cdcontrol/Makefile Modified: head/usr.sbin/cdcontrol/Makefile

svn commit: r201612 - head/usr.bin/tcopy

2010-01-05 Thread David Malone
Author: dwmalone Date: Tue Jan 5 21:09:59 2010 New Revision: 201612 URL: http://svn.freebsd.org/changeset/base/201612 Log: 1) Mark usage as dead2. 2) Deregister. 3) New style function definitions. Some WARNS still remain here - some printf format warning on some arches and the compil

svn commit: r201611 - head/usr.bin/w

2010-01-05 Thread David Malone
Author: dwmalone Date: Tue Jan 5 21:00:23 2010 New Revision: 201611 URL: http://svn.freebsd.org/changeset/base/201611 Log: Shuffle parens to avoid type-punning warning. Modified: head/usr.bin/w/w.c Modified: head/usr.bin/w/w.c

svn commit: r201610 - head/usr.bin/xlint/xlint

2010-01-05 Thread David Malone
Author: dwmalone Date: Tue Jan 5 20:53:55 2010 New Revision: 201610 URL: http://svn.freebsd.org/changeset/base/201610 Log: 1) Make usage() as dead2 - it helps the compiler know that some vars are not used uninitialised. 2) Fix some constness problems. 3) Avoid a signedness problem by cast

svn commit: r201608 - head/usr.sbin/cdcontrol

2010-01-05 Thread David Malone
Author: dwmalone Date: Tue Jan 5 20:40:40 2010 New Revision: 201608 URL: http://svn.freebsd.org/changeset/base/201608 Log: New style function definitions. Fix constness problem - don't know that pstatus won't change a string with no whitespace. Modified: head/usr.sbin/cdcontrol/cdcontrol

svn commit: r201606 - head/usr.bin/ctags

2010-01-05 Thread David Malone
Author: dwmalone Date: Tue Jan 5 20:32:08 2010 New Revision: 201606 URL: http://svn.freebsd.org/changeset/base/201606 Log: Change a char that is used as an index into an array into an unisgned char. Add a missing new style function definition. Modified: head/usr.bin/ctags/ctags.c head/us

Re: svn commit: r198706 - head/sys/sys

2009-11-02 Thread David Malone
On Sun, Nov 01, 2009 at 02:12:12AM +0100, Ed Schouten wrote: > No, we don't. All these fields are not used by drivers, just some old > version of the devfs code. I made sure struct cdevsw didn't change in > size, so there should be no API nor ABI conflicts. Surely it is an API change, but not an A

Re: svn commit: r195652 - head/etc

2009-07-14 Thread David Malone
> The above sentence seems very clumsy to me. How about: ># If you wish to choose which country's public server you want ># to sync against, ... Looks reasonable to me. I might collect up some suggestions like this and commit them at a later date. As it stands, I think we have a reasonab

svn commit: r195652 - head/etc

2009-07-12 Thread David Malone
Author: dwmalone Date: Mon Jul 13 05:51:33 2009 New Revision: 195652 URL: http://svn.freebsd.org/changeset/base/195652 Log: 1) Use our vendor domain at the pool. 2) Point people at the pool website and encourage people to provide a server in the pool (as a courtesy to the pool guys).

svn commit: r191808 - svnadmin/conf

2009-05-05 Thread David Malone
Author: dwmalone Date: Tue May 5 08:30:38 2009 New Revision: 191808 URL: http://svn.freebsd.org/changeset/base/191808 Log: chmod u+c snb Nick will be working on improving the memory allocation code in dirhash. He's already implemented and tested a set of changes on last year's summer

svn commit: r189936 - head/release/picobsd/tinyware/simple_httpd

2009-03-17 Thread David Malone
Author: dwmalone Date: Tue Mar 17 19:51:04 2009 New Revision: 189936 URL: http://svn.freebsd.org/changeset/base/189936 Log: Warns fixes: use putenv rather than setenv to avoid constness problems, when we want to print an off_t cast to intmax_t and use %jd. Up WARNS to 6. Modified: head

svn commit: r189934 - head/usr.bin/ministat

2009-03-17 Thread David Malone
Author: dwmalone Date: Tue Mar 17 19:37:47 2009 New Revision: 189934 URL: http://svn.freebsd.org/changeset/base/189934 Log: Fix some warns - mainly signedness and unused variables. Modified: head/usr.bin/ministat/ministat.c Modified: head/usr.bin/ministat/ministat.c =

svn commit: r185234 - head/sys/kern

2008-11-23 Thread David Malone
Author: dwmalone Date: Sun Nov 23 21:05:22 2008 New Revision: 185234 URL: http://svn.freebsd.org/changeset/base/185234 Log: It's possible that the dump device has gone away after it was configured, change the message to let people know this is a possibility. I've slightly changed the message

svn commit: r185233 - head/sys/sys

2008-11-23 Thread David Malone
Author: dwmalone Date: Sun Nov 23 21:01:28 2008 New Revision: 185233 URL: http://svn.freebsd.org/changeset/base/185233 Log: Make the new CCEQ macro a little more like the old one - first do the comparison between c and val and then compare val to _POSIX_VDISABLE. This avoids comparing c (whi

svn commit: r183893 - in stable/7/sys: . dev/twa net

2008-10-14 Thread David Malone
Author: dwmalone Date: Tue Oct 14 19:48:58 2008 New Revision: 183893 URL: http://svn.freebsd.org/changeset/base/183893 Log: Some people's 6to4 routers seem to have been blowing up because of the unlocked route caching in if_stf. Add a mutex that protects access to cached route. Various versi