Re: svn commit: r185363 - in head: lib/libpmc sys/amd64/include sys/conf sys/dev/hwpmc sys/i386/include sys/modules/hwpmc sys/sys

2008-11-27 Thread Pegasus Mc Cleaft
On Thursday 27 November 2008 09:00:47 Joseph Koshy wrote: > Author: jkoshy > Date: Thu Nov 27 09:00:47 2008 > New Revision: 185363 > URL: http://svn.freebsd.org/changeset/base/185363 > > Log: > - Add support for PMCs in Intel CPUs of Family 6, model 0xE (Core Solo > and Core Duo), models 0xF

svn commit: r185376 - head/sys/dev/aac

2008-11-27 Thread Ed Maste
Author: emaste Date: Thu Nov 27 20:26:02 2008 New Revision: 185376 URL: http://svn.freebsd.org/changeset/base/185376 Log: Remove duplicate 2610SA entry. Submitted by: jkim Modified: head/sys/dev/aac/aac_pci.c Modified: head/sys/dev/aac/aac_pci.c =

Re: svn commit: r185362 - head/share/man/man9

2008-11-27 Thread Giorgos Keramidas
On 2008-11-27 08:42, Robert Watson <[EMAIL PROTECTED]> wrote: > Author: rwatson > Date: Thu Nov 27 08:42:58 2008 > New Revision: 185362 > URL: http://svn.freebsd.org/changeset/base/185362 > > Log: > Revert r184509: don't encourage the use of sysexits.h with err() and > errx(),, as there seems

Re: svn commit: r185356 - head/sys/dev/ixgbe

2008-11-27 Thread Dag-Erling Smørgrav
Sam Leffler <[EMAIL PROTECTED]> writes: > Repeat after me: "style is a guideline and not a contract". Hmm, they must have forgotten to send you the paperwork when you joined up :) DES -- Dag-Erling Smørgrav - [EMAIL PROTECTED] ___ svn-src-all@freebsd.o

Re: svn commit: r185356 - head/sys/dev/ixgbe

2008-11-27 Thread Sam Leffler
Ivan Voras wrote: 2008/11/27 Dag-Erling Smørgrav <[EMAIL PROTECTED]>: "Ivan Voras" <[EMAIL PROTECTED]> writes: And at least the newer GEOM code also uses c99 variable declarations (not only for initializers - they were c99 from the start). I'm curious about what you mean with "

Re: svn commit: r185356 - head/sys/dev/ixgbe

2008-11-27 Thread Dag-Erling Smørgrav
"M. Warner Losh" <[EMAIL PROTECTED]> writes: > This is a K&R level C construct. > > It is discouraged in style(9) because it makes it hard to find > declarations. However, it is used in the kernel in a number of > places. > > I personally really dislike the style (and yes, I know all the > argumen

Re: svn commit: r185356 - head/sys/dev/ixgbe

2008-11-27 Thread M. Warner Losh
In message: <[EMAIL PROTECTED]> "Ivan Voras" <[EMAIL PROTECTED]> writes: : 2008/11/27 Dag-Erling Smørgrav <[EMAIL PROTECTED]>: : > "Ivan Voras" <[EMAIL PROTECTED]> writes: : >> And at least the newer GEOM code also uses c99 variable declarations : >> (not only for initializers - they we

svn commit: r185375 - head/sys/boot/arm/uboot

2008-11-27 Thread Rafal Jaworowski
Author: raj Date: Thu Nov 27 16:53:01 2008 New Revision: 185375 URL: http://svn.freebsd.org/changeset/base/185375 Log: Let ARM loader(8) build with the man page. Modified: head/sys/boot/arm/uboot/Makefile Modified: head/sys/boot/arm/uboot/Makefile

svn commit: r185374 - head/share/man/man4/man4.arm

2008-11-27 Thread Rafal Jaworowski
Author: raj Date: Thu Nov 27 16:50:23 2008 New Revision: 185374 URL: http://svn.freebsd.org/changeset/base/185374 Log: Provide manual page for the mge(4) device driver. Added: head/share/man/man4/man4.arm/mge.4 (contents, props changed) Modified: head/share/man/man4/man4.arm/Makefile Mod

svn commit: r185373 - head/sys/kern

2008-11-27 Thread Konstantin Belousov
Author: kib Date: Thu Nov 27 16:47:25 2008 New Revision: 185373 URL: http://svn.freebsd.org/changeset/base/185373 Log: Explicitely note that destroy_dev() sleeps. Requested by: ed (some time ago), Jaakko Heinonen Modified: head/sys/kern/kern_conf.c Modified: head/sys/kern/kern_conf.c =

svn commit: r185372 - in releng/7.1/sys: . netinet6

2008-11-27 Thread Bjoern A. Zeeb
Author: bz Date: Thu Nov 27 16:41:46 2008 New Revision: 185372 URL: http://svn.freebsd.org/changeset/base/185372 Log: MFC: r185332 Plug a credential leak in case the inpcb is freed by in6_pcbfree() instead of in_pcbfree(); missed in r183606. Discussed with: re (kib) Approved

svn commit: r185371 - head/sys/netinet

2008-11-27 Thread Bjoern A. Zeeb
Author: bz Date: Thu Nov 27 13:19:42 2008 New Revision: 185371 URL: http://svn.freebsd.org/changeset/base/185371 Log: Replace most INP_CHECK_SOCKAF() uses checking if it is an IPv6 socket by comparing a constant inp vflag. This is expected to help to reduce extra locking. Suggested by:

svn commit: r185370 - in head/sys: netinet netinet6

2008-11-27 Thread Bjoern A. Zeeb
Author: bz Date: Thu Nov 27 12:04:35 2008 New Revision: 185370 URL: http://svn.freebsd.org/changeset/base/185370 Log: Merge in6_pcbfree() into in_pcbfree() which after the previous IPsec change in r185366 only differed in two additonal IPv6 lines. Rather than splattering conditional code eve

Re: svn commit: r185369 - in head: lib/libc/gen lib/libthr/thread libexec/rtld-elf

2008-11-27 Thread Rink Springer
On Thu, Nov 27, 2008 at 11:28:00AM +, Konstantin Belousov wrote: > Author: kib > Date: Thu Nov 27 11:27:59 2008 > New Revision: 185369 > URL: http://svn.freebsd.org/changeset/base/185369 > > Log: > Add two rtld exported symbols, _rtld_atfork_pre and _rtld_atfork_post. > Threading library c

svn commit: r185369 - in head: lib/libc/gen lib/libthr/thread libexec/rtld-elf

2008-11-27 Thread Konstantin Belousov
Author: kib Date: Thu Nov 27 11:27:59 2008 New Revision: 185369 URL: http://svn.freebsd.org/changeset/base/185369 Log: Add two rtld exported symbols, _rtld_atfork_pre and _rtld_atfork_post. Threading library calls _pre before the fork, allowing the rtld to lock itself to ensure that other th

Re: svn commit: r185356 - head/sys/dev/ixgbe

2008-11-27 Thread Erik Trulsson
On Thu, Nov 27, 2008 at 11:38:05AM +0100, Ivan Voras wrote: > 2008/11/27 Dag-Erling Smørgrav <[EMAIL PROTECTED]>: > > "Ivan Voras" <[EMAIL PROTECTED]> writes: > >> And at least the newer GEOM code also uses c99 variable declarations > >> (not only for initializers - they were c99 from the start). >

Re: svn commit: r185362 - head/share/man/man9

2008-11-27 Thread Bruce Evans
On Thu, 27 Nov 2008, Robert Watson wrote: Author: rwatson Date: Thu Nov 27 08:42:58 2008 New Revision: 185362 URL: http://svn.freebsd.org/changeset/base/185362 Log: Revert r184509: don't encourage the use of sysexits.h with err() and errx(),, as there seems to be a general preference against

Re: svn commit: r185356 - head/sys/dev/ixgbe

2008-11-27 Thread Dag-Erling Smørgrav
"Ivan Voras" <[EMAIL PROTECTED]> writes: > Dag-Erling Smørgrav <[EMAIL PROTECTED]> writes: > > I'm curious about what you mean with "c99 variable declarations". [...] > [...] I mean things like: > > if () { > struct *something abc; > int y; > ... > } C has always allowed declaring variable

Re: svn commit: r185356 - head/sys/dev/ixgbe

2008-11-27 Thread Ivan Voras
2008/11/27 Erik Trulsson <[EMAIL PROTECTED]>: > On Thu, Nov 27, 2008 at 11:38:05AM +0100, Ivan Voras wrote: >> if () { >> struct *something abc; >> int y; >> ... >> } >> >> You'll probably find my code is one the biggest users of this style >> but I've only started using it when I saw it alr

svn commit: r185366 - in head/sys: netinet netinet6 netipsec

2008-11-27 Thread Bjoern A. Zeeb
Author: bz Date: Thu Nov 27 10:43:08 2008 New Revision: 185366 URL: http://svn.freebsd.org/changeset/base/185366 Log: Unify ipsec[46]_delete_pcbpolicy in ipsec_delete_pcbpolicy. Ignoring different names because of macros (in6pcb, in6p_sp) and inp vs. in6p variable name both functions were en

Re: svn commit: r185356 - head/sys/dev/ixgbe

2008-11-27 Thread Ivan Voras
2008/11/27 Dag-Erling Smørgrav <[EMAIL PROTECTED]>: > "Ivan Voras" <[EMAIL PROTECTED]> writes: >> And at least the newer GEOM code also uses c99 variable declarations >> (not only for initializers - they were c99 from the start). > > I'm curious about what you mean with "c99 variable declarations".

Re: svn commit: r185356 - head/sys/dev/ixgbe

2008-11-27 Thread Dag-Erling Smørgrav
"Ivan Voras" <[EMAIL PROTECTED]> writes: > And at least the newer GEOM code also uses c99 variable declarations > (not only for initializers - they were c99 from the start). I'm curious about what you mean with "c99 variable declarations". If you are referring to loop variable declarations, I can

Re: svn commit: r185356 - head/sys/dev/ixgbe

2008-11-27 Thread Ivan Voras
2008/11/27 M. Warner Losh <[EMAIL PROTECTED]>: > In message: <[EMAIL PROTECTED]> >Alexander Kabaev <[EMAIL PROTECTED]> writes: > : Is C99 construct here intentional? If so, when did we agree on using > : only C99 compilers on our code base? > > I'm not sure about *THIS* c99 construct,

Re: svn commit: r185029 - in head: cddl/compat/opensolaris/include cddl/compat/opensolaris/misc cddl/contrib/opensolaris/cmd/zdb cddl/contrib/opensolaris/cmd/zfs cddl/contrib/opensolaris/cmd/zinject c

2008-11-27 Thread Dmitry Morozovsky
On Wed, 26 Nov 2008, Pawel Jakub Dawidek wrote: PJD> > > Update ZFS from version 6 to 13 and bring some FreeBSD-specific changes. PJD> > > PJD> > This, and other changes stabilized ZFS by a great level in HEAD. PJD> > Do you plan to MFC these to 7-STABLE? PJD> PJD> Yes, but ETA yet. Great! W

svn commit: r185364 - head/lib/libpmc

2008-11-27 Thread Joseph Koshy
Author: jkoshy Date: Thu Nov 27 09:21:37 2008 New Revision: 185364 URL: http://svn.freebsd.org/changeset/base/185364 Log: Update description of an event. Submitted by: "Verplanke, Edwin" Modified: head/lib/libpmc/pmc.atom.3 Modified: head/lib/libpmc/pmc.atom.3 =

svn commit: r185363 - in head: lib/libpmc sys/amd64/include sys/conf sys/dev/hwpmc sys/i386/include sys/modules/hwpmc sys/sys

2008-11-27 Thread Joseph Koshy
Author: jkoshy Date: Thu Nov 27 09:00:47 2008 New Revision: 185363 URL: http://svn.freebsd.org/changeset/base/185363 Log: - Add support for PMCs in Intel CPUs of Family 6, model 0xE (Core Solo and Core Duo), models 0xF (Core2), model 0x17 (Core2Extreme) and model 0x1C (Atom). In t

Re: svn commit: r185356 - head/sys/dev/ixgbe

2008-11-27 Thread Dag-Erling Smørgrav
Jack F Vogel <[EMAIL PROTECTED]> writes: > Log: > Small nit I just noticed, a pre-decrement should be post. Why? It makes absolutely no difference. (s/decrement/increment/, btw) Personally, I always use pre-{inc,dec}rement when I don't care about the value of the expression, but I guess it's

svn commit: r185362 - head/share/man/man9

2008-11-27 Thread Robert Watson
Author: rwatson Date: Thu Nov 27 08:42:58 2008 New Revision: 185362 URL: http://svn.freebsd.org/changeset/base/185362 Log: Revert r184509: don't encourage the use of sysexits.h with err() and errx(),, as there seems to be a general preference against this practice. Suggested by: bde, de

Re: svn commit: r185356 - head/sys/dev/ixgbe

2008-11-27 Thread Roman Divacky
On Wed, Nov 26, 2008 at 09:32:04PM -0500, Alexander Kabaev wrote: > On Thu, 27 Nov 2008 02:19:44 + (UTC) > Jack F Vogel <[EMAIL PROTECTED]> wrote: > > > Author: jfv > > Date: Thu Nov 27 02:19:44 2008 > > New Revision: 185356 > > URL: http://svn.freebsd.org/changeset/base/185356 > > > > Log: >

Re: svn commit: r185344 - in head/sys: netinet netinet6

2008-11-27 Thread Robert Watson
On Wed, 26 Nov 2008, Max Laier wrote: On Wednesday 26 November 2008 21:52:27 Bjoern A. Zeeb wrote: Author: bz Date: Wed Nov 26 20:52:26 2008 New Revision: 185344 URL: http://svn.freebsd.org/changeset/base/185344 Log: Remove in6_pcbdetach() as it is exactly the same function as in_pcbdetac