Re: svn commit: r184645 - head/usr.bin/vmstat

2008-11-04 Thread Diomidis Spinellis
Giorgos Keramidas wrote: On Tue, 4 Nov 2008 22:30:07 +0200, Diomidis Spinellis <[EMAIL PROTECTED]> wrote: On Nov 4, 2008, at 8:02 PM, Giorgos Keramidas wrote: Author: keramida (doc committer) Date: Tue Nov 4 18:02:35 2008 New Revision: 184645 URL: http://svn.freebsd.org/changeset/base/184645

Re: svn commit: r184668 - head/usr.bin/tar/test

2008-11-04 Thread Tim Kientzle
Xin LI wrote: Author: kientzle Date: Wed Nov 5 05:26:11 2008 New Revision: 184668 URL: http://svn.freebsd.org/changeset/base/184668 [...] @@ -494,7 +494,8 @@ test_assert_empty_file(const char *f1fmt if (fd < 0) { fprintf(stderr, "Unable to open %s\n", f1);

svn commit: r184669 - head/usr.bin/tar/test

2008-11-04 Thread Tim Kientzle
Author: kientzle Date: Wed Nov 5 06:40:53 2008 New Revision: 184669 URL: http://svn.freebsd.org/changeset/base/184669 Log: When comparing, cast to the larger size, off_t in this case. Once we know which one is smaller, then we cast to the smaller size. Thanks to Xin Li (delphij@) Point

Re: svn commit: r184668 - head/usr.bin/tar/test

2008-11-04 Thread Xin LI
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Tim Kientzle wrote: > Author: kientzle > Date: Wed Nov 5 05:26:11 2008 > New Revision: 184668 > URL: http://svn.freebsd.org/changeset/base/184668 > > Log: > Fix compile warnings building on amd64. This is modified slightly > from Jaakko's origin

svn commit: r184668 - head/usr.bin/tar/test

2008-11-04 Thread Tim Kientzle
Author: kientzle Date: Wed Nov 5 05:26:11 2008 New Revision: 184668 URL: http://svn.freebsd.org/changeset/base/184668 Log: Fix compile warnings building on amd64. This is modified slightly from Jaakko's original patch: I have misgivings about the portability of the 'z' printf modifier so o

Re: svn commit: r184625 - in head: etc sys/dev/acpi_support

2008-11-04 Thread M. Warner Losh
In message: <[EMAIL PROTECTED]> Andrew Thompson <[EMAIL PROTECTED]> writes: : On Tue, Nov 04, 2008 at 11:52:50AM +, Rui Paulo wrote: : > Author: rpaulo : > Date: Tue Nov 4 11:52:50 2008 : > New Revision: 184625 : > URL: http://svn.freebsd.org/changeset/base/184625 : > : > Log: : >

Re: svn commit: r184605 - head/sys/dev/usb

2008-11-04 Thread Carlos A. M. dos Santos
On Mon, Nov 3, 2008 at 8:54 PM, Joerg Sonnenberger <[EMAIL PROTECTED]> wrote: > On Mon, Nov 03, 2008 at 11:49:50PM +0100, Christoph Mallon wrote: >> You may want to make cmd[] static and/or const, so the compiler really >> just puts the bytes in the data section instead of generating code, >> which

svn commit: r184667 - in head/sys: kern sys

2008-11-04 Thread David Xu
Author: davidxu Date: Wed Nov 5 03:01:23 2008 New Revision: 184667 URL: http://svn.freebsd.org/changeset/base/184667 Log: Revert rev 184216 and 184199, due to the way the thread_lock works, it may cause a lockup. Noticed by: peter, jhb Modified: head/sys/kern/kern_sig.c head/sys/ker

Re: svn commit: r184645 - head/usr.bin/vmstat

2008-11-04 Thread Giorgos Keramidas
On Tue, 4 Nov 2008 23:16:39 +0100, "Ivan Voras" <[EMAIL PROTECTED]> wrote: > 2008/11/4 Diomidis Spinellis <[EMAIL PROTECTED]>: >> On Nov 4, 2008, at 8:02 PM, Giorgos Keramidas wrote: >> >>> Author: keramida (doc committer) >>> Date: Tue Nov 4 18:02:35 2008 >>> New Revision: 184645 >>> URL: http://

Re: svn commit: r184645 - head/usr.bin/vmstat

2008-11-04 Thread Giorgos Keramidas
On Tue, 4 Nov 2008 22:30:07 +0200, Diomidis Spinellis <[EMAIL PROTECTED]> wrote: >On Nov 4, 2008, at 8:02 PM, Giorgos Keramidas wrote: >> Author: keramida (doc committer) >> Date: Tue Nov 4 18:02:35 2008 >> New Revision: 184645 >> URL: http://svn.freebsd.org/changeset/base/184645 >> >> Log: >> R

Re: svn commit: r184217 - head/sys/kern

2008-11-04 Thread David Xu
John Baldwin wrote: On Thursday 23 October 2008 09:09:25 pm David Xu wrote: Author: davidxu Date: Fri Oct 24 01:09:24 2008 New Revision: 184217 URL: http://svn.freebsd.org/changeset/base/184217 Log: Don't rearm callout if the process is exiting, it may leak a callout because callout_drain()

Re: svn commit: r184652 - in head/sys: dev/hwpmc fs/procfs kern

2008-11-04 Thread John Baldwin
On Tuesday 04 November 2008 05:22:47 pm Ivan Voras wrote: > 2008/11/4 John Baldwin <[EMAIL PROTECTED]>: > > Author: jhb > > Date: Tue Nov 4 19:04:01 2008 > > New Revision: 184652 > > URL: http://svn.freebsd.org/changeset/base/184652 > > > > Log: > > Remove unnecessary locking around vn_fullpath()

svn commit: r184663 - head/etc

2008-11-04 Thread Xin LI
Author: delphij Date: Tue Nov 4 23:03:36 2008 New Revision: 184663 URL: http://svn.freebsd.org/changeset/base/184663 Log: Correct a typo that prevented my laptop from starting devd. Modified: head/etc/devd.conf Modified: head/etc/devd.conf =

Re: svn commit: r184216 - head/sys/kern

2008-11-04 Thread Peter Wemm
On Tue, Nov 4, 2008 at 2:07 PM, John Baldwin <[EMAIL PROTECTED]> wrote: > On Thursday 23 October 2008 09:03:31 pm David Xu wrote: >> Author: davidxu >> Date: Fri Oct 24 01:03:31 2008 >> New Revision: 184216 >> URL: http://svn.freebsd.org/changeset/base/184216 >> >> Log: >> partly revert revision

svn commit: r184662 - stable/7/lib/libcam

2008-11-04 Thread Marius Strobl
Author: marius Date: Tue Nov 4 22:51:56 2008 New Revision: 184662 URL: http://svn.freebsd.org/changeset/base/184662 Log: MFC: r184379 Supply a valid Connect ID when issuing XPT_DEV_MATCH, which according to my reading of the CAM draft is mandatory for all CCB function calls and enforce

svn commit: r184661 - in head/sys: kern security/audit

2008-11-04 Thread John Baldwin
Author: jhb Date: Tue Nov 4 22:31:04 2008 New Revision: 184661 URL: http://svn.freebsd.org/changeset/base/184661 Log: Use shared vnode locks for auditing vnode arguments as auditing only does a VOP_GETATTR() which does not require an exclusive lock. Reviewed by: csjp, rwatson Modified:

svn commit: r184660 - head/sys/security/audit

2008-11-04 Thread John Baldwin
Author: jhb Date: Tue Nov 4 22:30:24 2008 New Revision: 184660 URL: http://svn.freebsd.org/changeset/base/184660 Log: Don't lock the vnode around calls to vn_fullpath(). Reviewed by: csjp, rwatson Modified: head/sys/security/audit/audit_bsm_klib.c Modified: head/sys/security/audit/aud

Re: svn commit: r184652 - in head/sys: dev/hwpmc fs/procfs kern

2008-11-04 Thread Ivan Voras
2008/11/4 John Baldwin <[EMAIL PROTECTED]>: > Author: jhb > Date: Tue Nov 4 19:04:01 2008 > New Revision: 184652 > URL: http://svn.freebsd.org/changeset/base/184652 > > Log: > Remove unnecessary locking around vn_fullpath(). The vnode lock for the Does this affect realpath(3)? (whose non-scalab

Re: svn commit: r184645 - head/usr.bin/vmstat

2008-11-04 Thread Ivan Voras
2008/11/4 Diomidis Spinellis <[EMAIL PROTECTED]>: > On Nov 4, 2008, at 8:02 PM, Giorgos Keramidas wrote: > >> Author: keramida (doc committer) >> Date: Tue Nov 4 18:02:35 2008 >> New Revision: 184645 >> URL: http://svn.freebsd.org/changeset/base/184645 >> >> Log: >> Repeat vmstat header after win

Re: svn commit: r184216 - head/sys/kern

2008-11-04 Thread John Baldwin
On Thursday 23 October 2008 09:03:31 pm David Xu wrote: > Author: davidxu > Date: Fri Oct 24 01:03:31 2008 > New Revision: 184216 > URL: http://svn.freebsd.org/changeset/base/184216 > > Log: > partly revert revision 184199, because TDF_NEEDSIGCHK is persitent > when thread is in kernel mode, i

Re: svn commit: r184199 - in head/sys: kern sys

2008-11-04 Thread John Baldwin
On Thursday 23 October 2008 03:55:38 am David Xu wrote: > Author: davidxu > Date: Thu Oct 23 07:55:38 2008 > New Revision: 184199 > URL: http://svn.freebsd.org/changeset/base/184199 > > Log: > Actually, for signal and thread suspension, extra process spin lock is > unnecessary, the normal proc

Re: svn commit: r184217 - head/sys/kern

2008-11-04 Thread John Baldwin
On Thursday 23 October 2008 09:09:25 pm David Xu wrote: > Author: davidxu > Date: Fri Oct 24 01:09:24 2008 > New Revision: 184217 > URL: http://svn.freebsd.org/changeset/base/184217 > > Log: > Don't rearm callout if the process is exiting, it may leak a callout > because callout_drain() only w

Re: svn commit: r184645 - head/usr.bin/vmstat

2008-11-04 Thread Diomidis Spinellis
On Nov 4, 2008, at 8:02 PM, Giorgos Keramidas wrote: Author: keramida (doc committer) Date: Tue Nov 4 18:02:35 2008 New Revision: 184645 URL: http://svn.freebsd.org/changeset/base/184645 Log: Repeat vmstat header after window.rows instead of a hardcoded 20. Use ioctl() to get the window s

svn commit: r184659 - head/sys/dev/usb2/wlan

2008-11-04 Thread Rink Springer
Author: rink Date: Tue Nov 4 20:57:39 2008 New Revision: 184659 URL: http://svn.freebsd.org/changeset/base/184659 Log: Even though the previous commit was functionally equivalent with the code it replaced, it was wrong: le16toh should have been used. Note that these changes will not make

Re: svn commit: r184625 - in head: etc sys/dev/acpi_support

2008-11-04 Thread Renato Botelho
On Tue, Nov 4, 2008 at 9:52 AM, Rui Paulo <[EMAIL PROTECTED]> wrote: > Author: rpaulo > Date: Tue Nov 4 11:52:50 2008 > New Revision: 184625 > URL: http://svn.freebsd.org/changeset/base/184625 > > Log: > Add support for Asus A8Sr notebooks. > > PR: 128553 > Submitted by: Eygene Ryabin

svn commit: r184651 - head/sys/ufs/ufs

2008-11-04 Thread John Baldwin
Author: jhb Date: Tue Nov 4 18:56:12 2008 New Revision: 184651 URL: http://svn.freebsd.org/changeset/base/184651 Log: Quiet a WITNESS warning with the dirhash sx locks by setting the DUPOK flag. Specifically, if two threads race to create a dirhash for a directory, then one might already h

svn commit: r184654 - head/usr.bin/du

2008-11-04 Thread Max Laier
Author: mlaier Date: Tue Nov 4 19:17:32 2008 New Revision: 184654 URL: http://svn.freebsd.org/changeset/base/184654 Log: style(9): mostly avoiding line wrap by not indenting cases. No obj change. Modified: head/usr.bin/du/du.c Modified: head/usr.bin/du/du.c

svn commit: r184655 - head/share/misc

2008-11-04 Thread Remko Lodder
Author: remko Date: Tue Nov 4 19:20:19 2008 New Revision: 184655 URL: http://svn.freebsd.org/changeset/base/184655 Log: Add Rene Ladan, as well as my relationship towards Rene. Modified: head/share/misc/committers-doc.dot Modified: head/share/misc/committers-doc.dot

svn commit: r184658 - head/sys/dev/usb2/wlan

2008-11-04 Thread Rink Springer
Author: rink Date: Tue Nov 4 19:28:19 2008 New Revision: 184658 URL: http://svn.freebsd.org/changeset/base/184658 Log: Fix the build (on at least powerpc) by moving the htole16() from the case(x) expression directly to the switch(x) itself. Reviewed by: imp@ Modified: head/sys/dev/usb

svn commit: r184656 - head/usr.bin/du

2008-11-04 Thread Max Laier
Author: mlaier Date: Tue Nov 4 19:23:48 2008 New Revision: 184656 URL: http://svn.freebsd.org/changeset/base/184656 Log: Declare functions and variables static and save a few byte. This is a style(9)-change, too. Separate commit as it changes the object. Modified: head/usr.bin/du/du.c M

svn commit: r184653 - head/sys/kern

2008-11-04 Thread John Baldwin
Author: jhb Date: Tue Nov 4 19:13:53 2008 New Revision: 184653 URL: http://svn.freebsd.org/changeset/base/184653 Log: Don't bother calling setrunnable() and clearing the sleeping flag in sleepq_resume_thread() if the thread isn't asleep. Modified: head/sys/kern/subr_sleepqueue.c Modified:

svn commit: r184650 - head/sys/fs/unionfs

2008-11-04 Thread John Baldwin
Author: jhb Date: Tue Nov 4 18:54:44 2008 New Revision: 184650 URL: http://svn.freebsd.org/changeset/base/184650 Log: Don't pass WANTPARENT to the pathname lookup of the mount point for a unionfs mount just so we can immediately drop the reference on the parent directory vnode without using

svn commit: r184649 - head/sys/compat/linprocfs

2008-11-04 Thread John Baldwin
Author: jhb Date: Tue Nov 4 18:53:33 2008 New Revision: 184649 URL: http://svn.freebsd.org/changeset/base/184649 Log: Don't leak a reference on the /compat/linux vnode everytime the linprocfs 'mtab' file is read. MFC after:1 month Modified: head/sys/compat/linprocfs/linprocfs.c M

svn commit: r184652 - in head/sys: dev/hwpmc fs/procfs kern

2008-11-04 Thread John Baldwin
Author: jhb Date: Tue Nov 4 19:04:01 2008 New Revision: 184652 URL: http://svn.freebsd.org/changeset/base/184652 Log: Remove unnecessary locking around vn_fullpath(). The vnode lock for the vnode in question does not need to be held. All the data structures used during the name lookup are

svn commit: r184646 - head/usr.bin/vmstat

2008-11-04 Thread Giorgos Keramidas
Author: keramida (doc committer) Date: Tue Nov 4 18:20:54 2008 New Revision: 184646 URL: http://svn.freebsd.org/changeset/base/184646 Log: Fix comment typo that managed to sneak in when I copy pasted some comments & code from iostat. Modified: head/usr.bin/vmstat/vmstat.c Modified: head/u

svn commit: r184645 - head/usr.bin/vmstat

2008-11-04 Thread Giorgos Keramidas
Author: keramida (doc committer) Date: Tue Nov 4 18:02:35 2008 New Revision: 184645 URL: http://svn.freebsd.org/changeset/base/184645 Log: Repeat vmstat header after window.rows instead of a hardcoded 20. Use ioctl() to get the window size in vmstat(8), and force a new header to be prepe

Re: svn commit: r184251 - in head/sys: conf dev/cfi sys

2008-11-04 Thread John Baldwin
On Tuesday 04 November 2008 04:15:15 am Dag-Erling Smørgrav wrote: > John Baldwin <[EMAIL PROTECTED]> writes: > > M. Warner Losh <[EMAIL PROTECTED]> writes: > > > Whose name is in the disclaimer? > > If the problem is "AUTHOR" vs "AUTHOR AND CONTRIBUTORS" then it would perhaps > > be more useful

Re: svn commit: r184625 - in head: etc sys/dev/acpi_support

2008-11-04 Thread Nikolay Denev
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 4 Nov, 2008, at 18:08 , Andrew Thompson wrote: On Tue, Nov 04, 2008 at 11:52:50AM +, Rui Paulo wrote: Author: rpaulo Date: Tue Nov 4 11:52:50 2008 New Revision: 184625 URL: http://svn.freebsd.org/changeset/base/184625 Log: Add support fo

Re: svn commit: r184641 - in stable/7/sys: . kern

2008-11-04 Thread Kostik Belousov
On Tue, Nov 04, 2008 at 09:03:32AM -0700, Scott Long wrote: > In stable branches, and especially during release cycles, would it be > possible to annotate whether changes like this fix known panics or > user-visible bugs? I thought that description of the change made it obvious. Access to the par

svn commit: r184643 - head/sys/nfsserver

2008-11-04 Thread Doug Rabson
Author: dfr Date: Tue Nov 4 16:43:02 2008 New Revision: 184643 URL: http://svn.freebsd.org/changeset/base/184643 Log: Include . Modified: head/sys/nfsserver/nfs_srvkrpc.c Modified: head/sys/nfsserver/nfs_srvkrpc.c =

Re: svn commit: r184625 - in head: etc sys/dev/acpi_support

2008-11-04 Thread Andrew Thompson
On Tue, Nov 04, 2008 at 11:52:50AM +, Rui Paulo wrote: > Author: rpaulo > Date: Tue Nov 4 11:52:50 2008 > New Revision: 184625 > URL: http://svn.freebsd.org/changeset/base/184625 > > Log: > Add support for Asus A8Sr notebooks. > > PR: 128553 > Submitted by: Eygene Ryabi

Re: svn commit: r184641 - in stable/7/sys: . kern

2008-11-04 Thread Scott Long
In stable branches, and especially during release cycles, would it be possible to annotate whether changes like this fix known panics or user-visible bugs? Scott Konstantin Belousov wrote: Author: kib Date: Tue Nov 4 15:56:44 2008 New Revision: 184641 URL: http://svn.freebsd.org/changeset/b

svn commit: r184641 - in stable/7/sys: . kern

2008-11-04 Thread Konstantin Belousov
Author: kib Date: Tue Nov 4 15:56:44 2008 New Revision: 184641 URL: http://svn.freebsd.org/changeset/base/184641 Log: MFC r184409: Protect check for v_pollinfo == NULL and assignment of the newly allocated vpollinfo with vnode interlock. Fully initialize vpollinfo before putting pointer t

svn commit: r184638 - head/libexec/rpc.rquotad

2008-11-04 Thread Dag-Erling Smorgrav
Author: des Date: Tue Nov 4 14:17:49 2008 New Revision: 184638 URL: http://svn.freebsd.org/changeset/base/184638 Log: Whitespace and style fixes, build at WARNS level 6. MFC after:3 weeks Modified: head/libexec/rpc.rquotad/Makefile head/libexec/rpc.rquotad/rquotad.c Modified: hea

svn commit: r184635 - head/lib/libutil

2008-11-04 Thread Dag-Erling Smorgrav
Author: des Date: Tue Nov 4 13:51:15 2008 New Revision: 184635 URL: http://svn.freebsd.org/changeset/base/184635 Log: libutil now builds at WARNS level 6. MFC after:3 weeks Modified: head/lib/libutil/Makefile Modified: head/lib/libutil/Makefile =

svn commit: r184634 - head/lib/libutil

2008-11-04 Thread Dag-Erling Smorgrav
Author: des Date: Tue Nov 4 13:50:50 2008 New Revision: 184634 URL: http://svn.freebsd.org/changeset/base/184634 Log: Add missing header. Modified: head/lib/libutil/pty.c Modified: head/lib/libutil/pty.c == --- head

svn commit: r184633 - head/lib/libutil

2008-11-04 Thread Dag-Erling Smorgrav
Author: des Date: Tue Nov 4 13:49:53 2008 New Revision: 184633 URL: http://svn.freebsd.org/changeset/base/184633 Log: Avoid assigning a const char * to a char *. MFC after:3 weeks Modified: head/lib/libutil/login_cap.c head/lib/libutil/login_class.c Modified: head/lib/libutil/log

svn commit: r184629 - head/sys/ufs/ufs

2008-11-04 Thread Edward Tomasz Napierala
Author: trasz Date: Tue Nov 4 12:30:31 2008 New Revision: 184629 URL: http://svn.freebsd.org/changeset/base/184629 Log: In UFS, when reading EA that contains ACL fails for some reason, include inode number and filesystem name, so the administrator can fix the problem. Approved by: rwats

svn commit: r184625 - in head: etc sys/dev/acpi_support

2008-11-04 Thread Rui Paulo
Author: rpaulo Date: Tue Nov 4 11:52:50 2008 New Revision: 184625 URL: http://svn.freebsd.org/changeset/base/184625 Log: Add support for Asus A8Sr notebooks. PR: 128553 Submitted by: Eygene Ryabinkin Reviewed by: philip MFC after:2 months Modified: head/etc/devd.co

svn commit: r184621 - head/sys/kern

2008-11-04 Thread Ed Schouten
Author: ed Date: Tue Nov 4 10:58:02 2008 New Revision: 184621 URL: http://svn.freebsd.org/changeset/base/184621 Log: Remove redundant return value tests. There is no need to test whether the return value is non-zero here. Just return the error number directly. Modified: head/sys/kern/

Re: svn commit: r184610 - in head: lib/libusb20 share/man/man4 sys/conf sys/dev/sound/pcm sys/dev/usb2 sys/dev/usb2/bluetooth sys/dev/usb2/controller sys/dev/usb2/core sys/dev/usb2/ethernet sys/dev/us

2008-11-04 Thread Giorgos Keramidas
On Tue, 4 Nov 2008 02:31:04 + (UTC), Alfred Perlstein <[EMAIL PROTECTED]> wrote: > Author: alfred > Date: Tue Nov 4 02:31:03 2008 > New Revision: 184610 > URL: http://svn.freebsd.org/changeset/base/184610 > > Log: > Bring in USB4BSD, Hans Petter Selasky rework of the USB stack > that incl

Re: svn commit: r184605 - head/sys/dev/usb

2008-11-04 Thread Christoph Mallon
Joerg Sonnenberger wrote: On Mon, Nov 03, 2008 at 11:49:50PM +0100, Christoph Mallon wrote: You may want to make cmd[] static and/or const, so the compiler really just puts the bytes in the data section instead of generating code, which pretty much is the same as the assignments you just remo

Re: svn commit: r184251 - in head/sys: conf dev/cfi sys

2008-11-04 Thread Dag-Erling Smørgrav
John Baldwin <[EMAIL PROTECTED]> writes: > M. Warner Losh <[EMAIL PROTECTED]> writes: > > Whose name is in the disclaimer? > If the problem is "AUTHOR" vs "AUTHOR AND CONTRIBUTORS" then it would perhaps > be more useful to all involved to actually state one's concerns instead of > vague hand-wavi