Author: jhb
Date: Tue Nov  4 18:53:33 2008
New Revision: 184649
URL: http://svn.freebsd.org/changeset/base/184649

Log:
  Don't leak a reference on the /compat/linux vnode everytime
  the linprocfs 'mtab' file is read.
  
  MFC after:    1 month

Modified:
  head/sys/compat/linprocfs/linprocfs.c

Modified: head/sys/compat/linprocfs/linprocfs.c
==============================================================================
--- head/sys/compat/linprocfs/linprocfs.c       Tue Nov  4 18:38:48 2008        
(r184648)
+++ head/sys/compat/linprocfs/linprocfs.c       Tue Nov  4 18:53:33 2008        
(r184649)
@@ -318,11 +318,13 @@ linprocfs_domtab(PFS_FILL_ARGS)
        NDINIT(&nd, LOOKUP, FOLLOW | MPSAFE, UIO_SYSSPACE, linux_emul_path, td);
        flep = NULL;
        error = namei(&nd);
-       VFS_UNLOCK_GIANT(NDHASGIANT(&nd));
-       if (error != 0 || vn_fullpath(td, nd.ni_vp, &dlep, &flep) != 0)
-               lep = linux_emul_path;
-       else
-               lep = dlep;
+       lep = linux_emul_path;
+       if (error == 0) {
+               if (vn_fullpath(td, nd.ni_vp, &dlep, &flep) != 0)
+                       lep = dlep;
+               vrele(nd.ni_vp);
+               VFS_UNLOCK_GIANT(NDHASGIANT(&nd));
+       }
        lep_len = strlen(lep);
 
        mtx_lock(&mountlist_mtx);
_______________________________________________
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "[EMAIL PROTECTED]"

Reply via email to