[sr-dev] Re: [kamailio/kamailio] core: local TCP socket is bound on listening address (PR #3925)

2024-07-18 Thread Ivanuschak Nikolay via sr-dev
@miconda regarding this change: ``` - *from = &si->su; + memcpy(*from, &si->su, sockaddru_len(si->su)); ``` At [this line](https://github.com/kamailio/kamailio/pull/3925/files#diff-aee8567648ae9f54eaf1f7a0feb3302d981966a749b16710e2b457da7c22c412R1306)

[sr-dev] Re: [kamailio/kamailio] core: local TCP socket is bound on listening address (PR #3925)

2024-08-01 Thread Ivanuschak Nikolay via sr-dev
@miconda regarding to this change ``` - *from = &si->su; + memcpy(*from, &si->su, sockaddru_len(si->su)); ``` This change is made within the function `find_listening_sock_info`. The function declaration looks as follows: ``` inline static int find_liste

[sr-dev] Re: [kamailio/kamailio] extented haproxy protocol support (PR #3731)

2024-01-30 Thread Ivanuschak Nikolay via sr-dev
@ivanuschak commented on this pull request. > @@ -204,6 +204,10 @@ static inline int msg_send_buffer( goto error; } + if(!dst->id) { + dst->id = con->id; + } + This change is needed for siptrace. Below i

[sr-dev] Re: [kamailio/kamailio] extented haproxy protocol support (PR #3731)

2024-01-30 Thread Ivanuschak Nikolay via sr-dev
@ivanuschak commented on this pull request. > @@ -2845,6 +2876,47 @@ int branch_builder(unsigned int hash_index, return size; } +static int is_haproxy(struct dest_info *send_info, struct receive_info *haproxy_rcv) { The function goal is as follows: 1. it retrieves the tcp_connetion_

[sr-dev] Re: [kamailio/kamailio] extented haproxy protocol support (PR #3731)

2024-01-30 Thread Ivanuschak Nikolay via sr-dev
@ivanuschak commented on this pull request. > @@ -396,6 +396,7 @@ typedef struct sip_msg char *unparsed; /*!< here we stopped parsing*/ struct receive_info rcv; /*!< source & dest ip, ports, proto a.s.o*/ + struct receive_info haproxy_rcv; /*!< source & dest ip, ports, pr

[sr-dev] Re: [kamailio/kamailio] extented haproxy protocol support (PR #3731)

2024-01-30 Thread Ivanuschak Nikolay via sr-dev
@ivanuschak commented on this pull request. > @@ -1843,13 +1843,17 @@ inline static int handle_io(struct fd_map *fm, short > events, int idx) * handle_io might decide to del. the new connection => * must be in the list */

[sr-dev] Re: [kamailio/kamailio] http_async_client: fixed crash on curl callback (PR #4020)

2024-11-12 Thread Ivanuschak Nikolay via sr-dev
@grumvalski yes, I will deploy and test the changes you suggested. It looks more correct than the current pull-request, because it just retrieves the `cell` object from the corresponding CURL descriptor. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/

[sr-dev] Re: [kamailio/kamailio] Kamailio crash on http_async_client module callback invocation (Issue #4019)

2024-11-07 Thread Ivanuschak Nikolay via sr-dev
The same crash happens on kamailio 5.8.2 ``` [centos@esrp-0a ~]$ cat /etc/centos-release CentOS Stream release 8 [centos@esrp-0a ~]$ uname -a Linux esrp-0a.fl.nga911.com 4.18.0-536.el8.aarch64 #1 SMP Thu Jan 18 15:21:54 UTC 2024 aarch64 aarch64 aarch64 GNU/Linux [centos@esrp-0a coredump]# sudo

[sr-dev] [kamailio/kamailio] http_async_client: fixed crash on curl callback (PR #4020)

2024-11-07 Thread Ivanuschak Nikolay via sr-dev