[sr-dev] Re: topos module with storage "shm"

2024-10-21 Thread Henning Westerholt via sr-dev
Hi Stefan, certainly, a new storage mode “shared memory” could be added, to avoid any additional dependencies for topos. This sounds useful. I personally don’t see a large case for adding also DMQ synchronisation capabilities for it. The DMQ synchronisation is not 100% reliable in all corner c

[sr-dev] [kamailio/kamailio] [JWT Module] Failed to decode JWT value (Issue #4003)

2024-10-21 Thread Lyuboslav Alexandrov via sr-dev
### Description Tried to verify a dubious JWT, but I get a token decoding error. I tried different variations of the key, such as `.pem`, `.key` extensions, `PKCS1`, `PKCS8` formats, reading the key from a variable or file. ### Troubleshooting Reproduction Have the following Kamailio

[sr-dev] Re: [kamailio/kamailio] Fixed segfault when using kazoo_query in kazoo mod (PR #4002)

2024-10-21 Thread Remco van Vugt via sr-dev
@linuxmaniac Thanks, fixed the commit message -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4002#issuecomment-2425976247 You are receiving this because you are subscribed to this thread. Message ID: ___

[sr-dev] rtpengine module: Question about re-enabling nodes

2024-10-21 Thread Christian Berger via sr-dev
Hi, we had strange behavior with kamailio when some rtpengines were unreachable, so we looked into the the source code and found this in select_rtpp_node_new(): 3323 /* Try to enable if it's time to try. */ 3324 if(node->rn_disabled && node->rn_recheck_ticks <= get_ticks()) { 3325node->rn

[sr-dev] Re: rtpengine module: Question about re-enabling nodes

2024-10-21 Thread Stefan Mititelu via sr-dev
Hi, Yes this is how currently rtpengine module re-detect rtpengines: during SIP routing processing. (e.g. rtpengine_manage()) Yes, lowering "rtpengine_tout_ms" will make rtpp_test() C code function take shorter time => rtpengine_manage() will take shorter time. Also disabling "aggressive_re

[sr-dev] Re: [kamailio/kamailio] Fixed segfault when using kazoo_query in kazoo mod (PR #4002)

2024-10-21 Thread Remco van Vugt via sr-dev
@remcovanvugt pushed 1 commit. 3c8126974f03c9a297e10e5db5d9b5fcbfd797aa kazoo: fixed segfault when using kazoo_query -- View it on GitHub: https://github.com/kamailio/kamailio/pull/4002/files/38c8cc862d5cd4b441d7ab8de55fd339b41cd1c1..3c8126974f03c9a297e10e5db5d9b5fcbfd797aa You are receiving t

[sr-dev] Re: [kamailio/kamailio] Fixed segfault when using kazoo_query in kazoo mod (PR #4002)

2024-10-21 Thread Remco van Vugt via sr-dev
@remcovanvugt commented on this pull request. > @@ -846,17 +846,17 @@ void kz_amqp_channel_close(kz_amqp_conn_ptr rmq, > amqp_channel_t channel) kz_amqp_error("closing channel", amqp_channel_close(rmq->conn, channel, AMQP_REPLY_SUCCESS)); } -#if AMQP_VERSION_MA

[sr-dev] Re: [kamailio/kamailio] Fixed segfault when using kazoo_query in kazoo mod (PR #4002)

2024-10-21 Thread Victor Seva via sr-dev
@linuxmaniac commented on this pull request. > @@ -846,17 +846,17 @@ void kz_amqp_channel_close(kz_amqp_conn_ptr rmq, > amqp_channel_t channel) kz_amqp_error("closing channel", amqp_channel_close(rmq->conn, channel, AMQP_REPLY_SUCCESS)); } -#if AMQP_VERSION_MAJ

[sr-dev] Re: [kamailio/kamailio] Fixed segfault when using kazoo_query in kazoo mod (PR #4002)

2024-10-21 Thread Remco van Vugt via sr-dev
@remcovanvugt commented on this pull request. > @@ -846,17 +846,17 @@ void kz_amqp_channel_close(kz_amqp_conn_ptr rmq, > amqp_channel_t channel) kz_amqp_error("closing channel", amqp_channel_close(rmq->conn, channel, AMQP_REPLY_SUCCESS)); } -#if AMQP_VERSION_MA

[sr-dev] Re: [kamailio/kamailio] Fixed segfault when using kazoo_query in kazoo mod (PR #4002)

2024-10-21 Thread Remco van Vugt via sr-dev
> you need to format the code with clang-format and amend Done -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4002#issuecomment-2426078366 You are receiving this because you are subscribed to this thread. Message ID: _

[sr-dev] Re: [kamailio/kamailio] Fixed segfault when using kazoo_query in kazoo mod (PR #4002)

2024-10-21 Thread Victor Seva via sr-dev
@linuxmaniac commented on this pull request. > @@ -888,8 +888,8 @@ int kz_amqp_connection_open_ssl(kz_amqp_conn_ptr rmq) amqp_ssl_socket_set_verify( rmq->socket, kz_amqps_verify_peer | kz_amqps_verify_hostname); #else - amqp_ssl_socket_set_verify_peer(rmq-

[sr-dev] Re: [kamailio/kamailio] Fixed segfault when using kazoo_query in kazoo mod (PR #4002)

2024-10-21 Thread Victor Seva via sr-dev
@linuxmaniac requested changes on this pull request. you need to format the code with clang-format and amend > @@ -846,17 +846,17 @@ void kz_amqp_channel_close(kz_amqp_conn_ptr rmq, > amqp_channel_t channel) kz_amqp_error("closing channel", amqp_channel_close(rmq-

[sr-dev] Re: [kamailio/kamailio] Fixed segfault when using kazoo_query in kazoo mod (PR #4002)

2024-10-21 Thread Remco van Vugt via sr-dev
@remcovanvugt pushed 1 commit. f8a1d2e86b2fe59c8d02a239dc7b893a4b92ee85 kazoo: fixed segfault when using kazoo_query -- View it on GitHub: https://github.com/kamailio/kamailio/pull/4002/files/61fcd7d73a8fd2ed68435f81f18dad9c5a941928..f8a1d2e86b2fe59c8d02a239dc7b893a4b92ee85 You are receiving t

[sr-dev] Re: [kamailio/kamailio] Fixed segfault when using kazoo_query in kazoo mod (PR #4002)

2024-10-21 Thread Remco van Vugt via sr-dev
@remcovanvugt commented on this pull request. > @@ -888,8 +888,8 @@ int kz_amqp_connection_open_ssl(kz_amqp_conn_ptr rmq) amqp_ssl_socket_set_verify( rmq->socket, kz_amqps_verify_peer | kz_amqps_verify_hostname); #else - amqp_ssl_socket_set_verify_peer(rmq

[sr-dev] Re: [kamailio/kamailio] Fixed segfault when using kazoo_query in kazoo mod (PR #4002)

2024-10-21 Thread Remco van Vugt via sr-dev
@remcovanvugt pushed 1 commit. 61fcd7d73a8fd2ed68435f81f18dad9c5a941928 kazoo: fixed segfault when using kazoo_query -- View it on GitHub: https://github.com/kamailio/kamailio/pull/4002/files/940293a8e53868aca618075bfa5c32baef948fa8..61fcd7d73a8fd2ed68435f81f18dad9c5a941928 You are receiving t

[sr-dev] Re: [kamailio/kamailio] Fixed segfault when using kazoo_query in kazoo mod (PR #4002)

2024-10-21 Thread Victor Seva via sr-dev
@linuxmaniac approved this pull request. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4002#pullrequestreview-2381582991 You are receiving this because you are subscribed to this thread. Message ID: ___

[sr-dev] git:master:b1aae565: rtpengine: disable aggressive redetection by default (#3992)

2024-10-21 Thread GitHub via sr-dev
Module: kamailio Branch: master Commit: b1aae5658e84453ce5849a627832efbbb6c20117 URL: https://github.com/kamailio/kamailio/commit/b1aae5658e84453ce5849a627832efbbb6c20117 Author: Stefan Mititelu Committer: GitHub Date: 2024-10-21T08:53:39-04:00 rtpengine: disable aggressive redetection by defa

[sr-dev] Re: [kamailio/kamailio] rtpengine: disable aggressive redetection by default (PR #3992)

2024-10-21 Thread Richard Fuchs via sr-dev
Merged #3992 into master. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3992#event-14764287142 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Developm

[sr-dev] Re: [kamailio/kamailio] rtpengine: disable aggressive redetection by default (PR #3992)

2024-10-21 Thread Richard Fuchs via sr-dev
> I will double check that part of the code, since I don't think a lock get is > necessary. It only updates a value inside a node, inside the list of nodes, > but not changes the list links at all. (this in another PR) I think you're right. However, you would need a memory fence to safely access

[sr-dev] git:master:6b7894d6: modules: readme files regenerated - rtpengine ... [skip ci]

2024-10-21 Thread Kamailio Dev via sr-dev
Module: kamailio Branch: master Commit: 6b7894d66ca65ca99b5987ddc35a7f28c7a88949 URL: https://github.com/kamailio/kamailio/commit/6b7894d66ca65ca99b5987ddc35a7f28c7a88949 Author: Kamailio Dev Committer: Kamailio Dev Date: 2024-10-21T15:01:11+02:00 modules: readme files regenerated - rtpengine

[sr-dev] Re: [kamailio/kamailio] Fixed segfault when using kazoo_query in kazoo mod (PR #4002)

2024-10-21 Thread Victor Seva via sr-dev
waiting for comments from @lazedo for a bit -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4002#issuecomment-2426254753 You are receiving this because you are subscribed to this thread. Message ID: ___ K

[sr-dev] Re: [kamailio/kamailio] Segmentation fault when sending ACK for 487 to duplicate URI using siptrace module (Issue #3970)

2024-10-21 Thread github-actions[bot] via sr-dev
This issue is stale because it has been open 6 weeks with no activity. Remove stale label or comment or this will be closed in 2 weeks. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3970#issuecomment-2428112757 You are receiving this because yo

[sr-dev] Re: topos module with storage "shm"

2024-10-21 Thread Stefan Mititelu via sr-dev
Hi, Thanks for the feedback for this. My motivation is related to an active-active scenario and supposing that redis db becomes unavailable => topology info will then become unavailable. Now that I am double thinking about DMQ sync, I think you are right. If DMQ does not sync fast enough, there w

[sr-dev] Re: topos module with storage "shm"

2024-10-21 Thread Stefan Mititelu via sr-dev
So far I've been thinking of this topos SHM htable stuff as a replacement for existing storages (redis/mysql). Now, I am thinking of this topos SHM htable as a cache between kama procs and existing storages. So this should happen: 1. on store, always keep in shm htable and write in storage db 2. o

[sr-dev] Re: [kamailio/kamailio] [JWT Module] Failed to decode JWT value (Issue #4003)

2024-10-21 Thread Daniel-Constantin Mierla via sr-dev
What you set in `$var(authorization_header_value)` does not look like a complete JWT, your C example code has a larger value in `jwt_test`. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4003#issuecomment-2428302062 You are receiving this becaus

[sr-dev] git:master:0cbb2eb0: jwt: print decode result in error log message

2024-10-21 Thread Daniel-Constantin Mierla via sr-dev
Module: kamailio Branch: master Commit: 0cbb2eb035c7d2a29ae707cde94a2c0573e0ffd5 URL: https://github.com/kamailio/kamailio/commit/0cbb2eb035c7d2a29ae707cde94a2c0573e0ffd5 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2024-10-22T07:34:29+02:00 jwt: print decode resu

[sr-dev] git:master:c823f413: core: parser sdp - check length for rtpmap extract

2024-10-21 Thread Daniel-Constantin Mierla via sr-dev
Module: kamailio Branch: master Commit: c823f41350ab9186a323707e9be32e31922bec17 URL: https://github.com/kamailio/kamailio/commit/c823f41350ab9186a323707e9be32e31922bec17 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2024-10-22T07:41:08+02:00 core: parser sdp - che