[sr-dev] Re: [kamailio/kamailio] Python exception handling fixes (PR #4044)

2024-12-09 Thread Matthias Urlichs via sr-dev
Thank you. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4044#issuecomment-2527736144 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio - Development Mailing Lis

[sr-dev] Re: [kamailio/kamailio] Python exception handling fixes (PR #4044)

2024-12-09 Thread Daniel-Constantin Mierla via sr-dev
Merged #4044 into master. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4044#event-15581527175 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio - Development Ma

[sr-dev] Re: [kamailio/kamailio] Python exception handling fixes (PR #4044)

2024-12-05 Thread Daniel-Constantin Mierla via sr-dev
OK, thanks for explaining further -- as a not much expert in python, it looked like hiding it by not providing the right parameter, so if I got it wrong, then it is fine to merge. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4044#issuecomment-2

[sr-dev] Re: [kamailio/kamailio] Python exception handling fixes (PR #4044)

2024-12-03 Thread Henning Westerholt via sr-dev
Reopened #4044. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4044#event-15507223709 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio - Development Mailing List

[sr-dev] Re: [kamailio/kamailio] Python exception handling fixes (PR #4044)

2024-12-03 Thread Henning Westerholt via sr-dev
Re-opened, as there seems to be still discussions necessary if the python KEMI interface should be adapted to the interface documentation. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4044#issuecomment-2514147024 You are receiving this because y

[sr-dev] Re: [kamailio/kamailio] Python exception handling fixes (PR #4044)

2024-11-30 Thread Matthias Urlichs via sr-dev
NB: Two years ago I found another example of this problem which was fixed in b7911b6. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4044#issuecomment-2508916716 You are receiving this because you are subscribed to this thread. Message ID: __

[sr-dev] Re: [kamailio/kamailio] Python exception handling fixes (PR #4044)

2024-11-30 Thread Matthias Urlichs via sr-dev
You seem to have misunderstood me here. I am **not** trying to suppress the exception. I am trying to make sure that the programmer gets the **correct** exception (`TypeError`) handed to them. The Python C interface documentation is pretty clear on this point. You MUST return NULL instead of a

[sr-dev] Re: [kamailio/kamailio] Python exception handling fixes (PR #4044)

2024-11-30 Thread Daniel-Constantin Mierla via sr-dev
I think the code is better how it is because the second parameter of the function you gave as example in the issue has to be a valid string. In the current form, it indicates there is a problem with the parameter, rather than having it silently not doing anything when it was expected to be a cha

[sr-dev] Re: [kamailio/kamailio] Python exception handling fixes (PR #4044)

2024-11-30 Thread Daniel-Constantin Mierla via sr-dev
Closed #4044. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4044#event-15480681866 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio - Development Mailing List -