Signed-off-by: Jeremy White
---
src/dfps.c |3 +++
1 file changed, 3 insertions(+)
diff --git a/src/dfps.c b/src/dfps.c
index 5cc1890..4ab20a8 100644
--- a/src/dfps.c
+++ b/src/dfps.c
@@ -169,6 +169,7 @@ static void dfps_solid (PixmapPtr pixmap, int x_1, int y_1,
int x_2, int y_2
When we are in the second situation, having 48000 in the public header
will actually cause issues as spice-server will know QEMU does not
support Opus, so internally spice-server will be using a 44100 rate for
audio. However, QEMU will be using SPICE_INTERFACE_.*_FREQ and think it
should use a 480
Signed-off-by: Jeremy White
---
src/qxl_ums_mode.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/qxl_ums_mode.c b/src/qxl_ums_mode.c
index 8959242..e4a7edc 100644
--- a/src/qxl_ums_mode.c
+++ b/src/qxl_ums_mode.c
@@ -430,10 +430,10 @@ qxl_initialize_x_modes
Also adjust the mode selection to fit, and add a few larger modes.
Signed-off-by: Jeremy White
---
examples/spiceqxl.xorg.conf.example | 13 +
src/qxl.h |3 +++
src/qxl_driver.c| 19 +++
src/spiceqxl_driver.c
On 08/22/2014 06:55 AM, Marc-André Lureau wrote:
Hi Jeremy
I wish we could have dynamic allocation for Xspice, avoiding those parameters,
but this could be improved later.
Yes; I looked into that, and am willing to do that work. For example, I
considered simply replacing qxl_mem.c with an X
On 08/22/2014 07:52 AM, Alon Levy wrote:
With agent running we do.
?? I'm sorry, I don't follow. Can you explain what you mean?
Cheers,
Jeremy
On August 22, 2014 7:55:19 AM EDT, "Marc-André Lureau"
wrote:
Hi Jeremy
I wish we could have dynamic allocation for Xspice, avoiding t
On 08/22/2014 08:07 AM, Alon Levy wrote:
Sorry for top posting. I was replying to Marc-Andre's assertion. If the
subject isnt arbitrary resolution, aka dynamic, continuous, then I
missed it. If it is, since agent support for Xspice this feature works
per my memory.
Ah, okay. Yes, my patch brok
Actually no excuse for the top post. I see. I like the idea of making sane
memory allocation. When I ''fused'' Xspice I took what I thought was was
simplest. I think you can replace mspace with malloc. There is no api to
disable the address translation we do (i.e. memslots) but it's already
eq
Signed-off-by: Jeremy White
---
src/qxl_driver.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/qxl_driver.c b/src/qxl_driver.c
index d9bf447..7436a62 100644
--- a/src/qxl_driver.c
+++ b/src/qxl_driver.c
@@ -384,7 +384,7 @@ qxl_map_memory (qxl_screen_t *qxl, int
Also adjust the mode selection to fit, and add a few larger modes.
Signed-off-by: Jeremy White
---
examples/spiceqxl.xorg.conf.example | 30 ++
src/qxl.h |3 ++
src/qxl_driver.c| 19 ---
src/spiceqxl_driver.c
I'm hoping to ask for some advice on the spice server.
Background:
I've hit a bug with Xspice. The current implementation uses a separate
thread to grab pcm data from a fifo. That same thread creates and
drives the playback channel, and then pushes that data out using
spice_server_playback_p
2. Surgically modify the snd_worker.c calls that handle the Playback
channel to introduce a mutex; lock and release that mutex around
operations. This is the direction I'm leaning, but I don't see a lot of
evidence that this is commonly done.
Now, with patch that solves my problem. Stop me
Signed-off-by: Jeremy White
---
cursor.js | 14
display.js |5 +--
enums.js| 24 -
main.js | 112 ---
spice.css | 28 ---
spicemsg.js | 77
Hi,
On 09/05/2014 02:00 PM, Gianni Pirozzi wrote:
Hello,
I tried this patch and observed a great improvement in cursor positioning,
thanks!
But I'm confused about dynamic resizing of the guest screen, it seems too tied
to the presentation.
I'm using spice-html5 in a web application which has i
I think there actually is the same issue when running within QEMU: sound
is emitted from a QEMU thread:
Is there a bug or someone that is working on that issue? I'd be curious
to see if my patch resolves the problem for them.
Cheers,
Jeremy
___
Sp
This version shifts the window resizing code to the front end logic.
Signed-off-by: Jeremy White
---
cursor.js | 14 ++
display.js |5 ++--
enums.js| 24 -
main.js | 76 +-
resize.js
On 09/05/2014 02:00 PM, Gianni Pirozzi wrote:
Hello,
I tried this patch and observed a great improvement in cursor positioning,
thanks!
But I'm confused about dynamic resizing of the guest screen, it seems too tied
to the presentation.
I've respun this and sent a v2 that should not tie the re
On Sat, Sep 06, 2014 at 08:59:47AM -0500, Jeremy White wrote:
I think there actually is the same issue when running within QEMU: sound
is emitted from a QEMU thread:
Is there a bug or someone that is working on that issue? I'd be curious to
see if my patch resolves the problem for
Hi Nicolas,
On 09/08/2014 12:56 PM, nicolas prochazka wrote:
Hello,
I've done differents tests, with the differents combinaisons between
qemu X and spice-server,
I can say that is since video adaptative streaming, the video
streaming is bad compare to the old version (spice 0.12.3 / qemu 1.7
On 09/08/2014 03:33 PM, nicolas prochazka wrote:
sorry,
nothing , a lot of video frames seems to be drop.
The issue that my patch would solve, if you had encountered this
problem, would be random crashes and hangs. There was some sense that
you lost sound after a few minutes. Is that proble
On 09/09/2014 03:44 PM, Gianni Pirozzi wrote:
On Tuesday, September 09, 2014 at 4:06 PM, I wrote:
I know, vertical sizing relative to the viewport is a pain.
Have you considered to style the body as a positioned element and update its
height at resize? If you do that, elements with a percentage
rectangles inside
a region; once it reaches the cap, we collapse the update_region
to just transmit the bounding rectangle instead.
Signed-off-by: Jeremy White
---
src/dfps.c | 75 +++-
1 file changed, 44 insertions(+), 31 deletions(-)
diff
Kind of. I don't think anyone would object to trivial patches being
pushed under such a rule. However, as is usually done, the patches
should be sent to the spice-devel mailing list with a note indicating
they were already pushed so that it's obvious to others what's going on.
+1.
I really appr
Signed-off-by: Jeremy White
---
src/dfps.c | 14 ++
1 file changed, 14 insertions(+)
diff --git a/src/dfps.c b/src/dfps.c
index 5db34dc..568ba5e 100644
--- a/src/dfps.c
+++ b/src/dfps.c
@@ -312,6 +312,17 @@ static void dfps_set_screen_pixmap (PixmapPtr pixmap)
pixmap
a crash.
Signed-off-by: Jeremy White
---
src/qxl_image.c |2 ++
src/qxl_surface.c |9 ++---
2 files changed, 8 insertions(+), 3 deletions(-)
diff --git a/src/qxl_image.c b/src/qxl_image.c
index 8927fd4..53212de 100644
--- a/src/qxl_image.c
+++ b/src/qxl_image.c
@@ -62,6 +62,8
I don't know about performance issues but I would suggest to calculate the
pointer position relative to the canvas like this:
var rect =
sc.display.surfaces[sc.display.primary_surface].canvas.getBoundingClientRect();
this.x = e.clientX - rect.left;
this.y = e.clientY - rect.top;
I do
Signed-off-by: Jeremy White
---
src/spiceqxl_audio.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/spiceqxl_audio.c b/src/spiceqxl_audio.c
index 7afc089..02859ee 100644
--- a/src/spiceqxl_audio.c
+++ b/src/spiceqxl_audio.c
@@ -195,10 +195,10 @@ audio_thread_main
Hey Christophe,
Thanks for the patch review.
+memset(&data, 0, sizeof(data));
Could this be written as struct audio_data data = { 0, }; or something
like that?
Sure.
Note, though, that afaict, memset(...0...) seems more prevalent in the
spice code than the universal zero initializer.
ri, Sep 12, 2014 at 02:20:36PM -0500, Jeremy White wrote:
Signed-off-by: Jeremy White
---
src/dfps.c | 14 ++
1 file changed, 14 insertions(+)
diff --git a/src/dfps.c b/src/dfps.c
index 5db34dc..568ba5e 100644
--- a/src/dfps.c
+++ b/src/dfps.c
@@ -312,6 +312,17 @@ s
This thread veered; I'd like to bring it back, if I can.
I've got a clear case of thread unsafety in XSpice.
spice_server_playback_put_samples is called from a different thread than
the main thread. If the main thread calls
main_dispatcher_handle_mm_time_latency while we're putting samples, v
On 09/19/2014 06:32 AM, Christophe Fergeau wrote:
Hey,
Looks good, ACK.
I would have split it one patch introducing dfps_update_{box,region}
with no functional change, and one patch adding the
DFPS_MAX_UPDATE_REGION limit.
Yeah, you're right. Resending.
Cheers,
Jeremy
__
rectangles inside
a region; once it reaches the cap, we collapse the update_region
to just transmit the bounding rectangle instead.
Signed-off-by: Jeremy White
---
src/dfps.c | 17 +
1 file changed, 17 insertions(+)
diff --git a/src/dfps.c b/src/dfps.c
index a57523b..5db34dc 100644
Signed-off-by: Jeremy White
---
src/dfps.c | 58 +++---
1 file changed, 27 insertions(+), 31 deletions(-)
diff --git a/src/dfps.c b/src/dfps.c
index 4ab20a8..a57523b 100644
--- a/src/dfps.c
+++ b/src/dfps.c
@@ -128,6 +128,28 @@ static Bool
a crash.
Signed-off-by: Jeremy White
---
src/qxl_image.c |2 ++
src/qxl_surface.c |9 ++---
2 files changed, 8 insertions(+), 3 deletions(-)
diff --git a/src/qxl_image.c b/src/qxl_image.c
index 8927fd4..1975df6 100644
--- a/src/qxl_image.c
+++ b/src/qxl_image.c
@@ -62,6 +62,8
diff --git a/src/qxl_image.c b/src/qxl_image.c
index 8927fd4..53212de 100644
--- a/src/qxl_image.c
+++ b/src/qxl_image.c
@@ -62,6 +62,8 @@ hash_and_copy (const uint8_t *src, int src_stride,
const uint8_t *src_line = src + i * src_stride;
uint8_t *dest_line = dest + i * dest_stride;
memset is fine with me. I'm also a bit curious about the warnings you
got, but I guess you no longer have these around.
I recall that one of the was the inodes array. Arguably, that was a
bug, not just a warning silence. (Just a bug with a very low
probability of triggering a problem).
[snip]
> So we should be good with that code here.
Thanks for doing that analysis; that is interesting. I guess it's good
news that the bug I found affects only Xspice audio users. I have to
admit I find the overall structure of the code somewhat troubling.
I'll go ahead and submit my patc
leads to unpleasant
side effects. The predominant side effect I noticed was an infinite loop
in snd_send_data.
This patch uses a mutex to prevent such collisions.
Signed-off-by: Jeremy White
---
server/snd_worker.c | 30 --
1 file changed, 28 insertions(+), 2
Hey guys,
Now that the Wiki is in theory usable, I would like to propose that we
shift the bulk of spice-space.org content to the Wiki.
I'm willing to do a bit of work in the Wiki to help tidy some of this
up, but I think that would only be satisfying if I felt that it was
actually improving
I am happy to announce that version 0.1.5 of the spice-html5 client has
been published.
You can download the code here:
http://people.freedesktop.org/~jwhite/spice-html5/spice-html5-0.1.5.tar.gz
This version features audio support, if your spice server has Opus
support, along with dynamic res
If the idea seems sensible, then I'd propose that we work on the Wiki until
we feel it stands mostly on it's own, and when we hit that point, we shift
the main pages to reflect that.
The website/wiki content needs some reorganization for sure, and the
manual editing of the static website content
On 09/29/2014 08:09 AM, Christophe Fergeau wrote:
On Mon, Sep 29, 2014 at 07:30:02AM -0500, Jeremy White wrote:
If we do keep a static component, I'd suggest we establish a git tree with
git hooks that auto update (ala Github sites).
I suspect this means the git server must be close/o
Alright, so I'm starting in on this.
The plan is, as we discussed, for the spiceqxl_drv to create a fifo and
relay the smart card messages through that.
A new program, spice-ccid, will read those messages, and exchange the
appropriate protocol with pcscd, which should provide it through to
w
Hi Peter,
Do you have any profiling or any evidence that suggests that this is a
cause for a slow down? When I wrote that FIXME, it was a theoretical,
possible problem, not a certain one. I don't know that it would be
worth changing without evidence of a problem.
As far as understanding th
I've become largely inactive on Spice (due to my semi retirement), and
the Fedora folks are thinking I should no be a packager [1].
I agree :-/.
Anyone want the job?
Cheers,
Jeremy
[1] https://pagure.io/find-inactive-packagers/issue/1840
This patch series is a set of minor patches for XSpice around vdagent support.
It improves the documentation of the options, corrects and option that did
not work as expected, allows multiple agent connections, and handles
an agent disconnection more intelligently.
In-Reply-To:
Also refine an error message slightly.
Signed-off-by: Jeremy White
---
src/spiceqxl_vdagent.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/spiceqxl_vdagent.c b/src/spiceqxl_vdagent.c
index 4208233..398c600 100644
--- a/src/spiceqxl_vdagent.c
+++ b/src
Signed-off-by: Jeremy White
---
examples/spiceqxl.xorg.conf.example | 24
1 file changed, 24 insertions(+)
diff --git a/examples/spiceqxl.xorg.conf.example
b/examples/spiceqxl.xorg.conf.example
index 9b223c8..e709e6d 100644
--- a/examples/spiceqxl.xorg.conf.example
This should allow multiple vdagents; one can disconnect,
and a different one can connect, and XSpice will continue
to function correctly.
Signed-off-by: Jeremy White
---
src/spiceqxl_uinput.c | 31 +--
src/spiceqxl_uinput.h | 1 +
2 files changed, 26 insertions
where
we enable agent mouse mode to the point that we have
a connected agent.
It also shifts the default; that matches qemu, and effectively
preserves the current default behavior.
Signed-off-by: Jeremy White
---
examples/spiceqxl.xorg.conf.example | 6 +++---
src/qxl_driver.c| 2
Fixes 'make check' on Debian.
Signed-off-by: Jeremy White
---
Makefile.am | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Makefile.am b/Makefile.am
index 605e96e..fb1c00b 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -65,7 +65,7 @@ endif
include $(srcdir)/buil
Add an optional args parameter to the --spice-smartcard which
will be passed to vcard_emul_options.
This allows us to deprecate the --smartcard-db and
--smartcard-certificates options as well.
Signed-off-by: Jeremy White
---
Changes since v3:
* Retested with new libcacard
* Updated version
Signed-off-by: Jeremy White
---
git.mk | 3 +++
1 file changed, 3 insertions(+)
diff --git a/git.mk b/git.mk
index 9d4bf25..1b2edbd 100644
--- a/git.mk
+++ b/git.mk
@@ -118,6 +118,9 @@ GITIGNORE_MAINTAINERCLEANFILES_M4_LIBTOOL = \
ltsugar.m4
Signed-off-by: Jeremy White
---
m4/ax_append_link_flags.m4 | 63 +++
m4/ax_check_link_flag.m4 | 74 ++
2 files changed, 137 insertions(+)
create mode 100644 m4/ax_append_link_flags.m4
create mode 100644 m4
This gets it into the .gitignore, and gets it cleaned
by a maintainer-clean.
Signed-off-by: Jeremy White
---
Makefile.am | 3 +++
1 file changed, 3 insertions(+)
diff --git a/Makefile.am b/Makefile.am
index fb1c00b..07df869 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -92,6 +92,9
Signed-off-by: Jeremy White
---
src/spiceccid/Makefile.am | 4 ++--
src/spiceccid/spiceccid.c | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/spiceccid/Makefile.am b/src/spiceccid/Makefile.am
index 437e992..2fbf6e0 100644
--- a/src/spiceccid/Makefile.am
+++ b/src
On 10/02/2015 11:20 AM, Jeremy White wrote:
> This patch series is a set of minor patches for XSpice around vdagent support.
Bump? I know we're low on people that care about XSpice, but this
should be an easy review .
Cheers,
Jeremy
>
> It improves the documentation of the opt
Signed-off-by: Jeremy White
---
.gitignore | 2 ++
server/.gitignore | 1 +
server/tests/.gitignore | 4
3 files changed, 7 insertions(+)
diff --git a/.gitignore b/.gitignore
index 8e73162..eb35f4b 100644
--- a/.gitignore
+++ b/.gitignore
@@ -30,3 +30,5 @@ stamp-h1
rigger
for connections that do not send the SPICE_MAGIC bytes on connection.
I would appreciate comments on the general approach.
The code does work, although I have only does the most basic tests.
Signed-off-by: Jeremy White
---
server/Makefile.am | 2 +
server/reds.c| 6
Also shift to libspiceccid_la_CFLAGS.
Signed-off-by: Jeremy White
---
src/spiceccid/Makefile.am | 4 ++--
src/spiceccid/spiceccid.c | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/spiceccid/Makefile.am b/src/spiceccid/Makefile.am
index 437e992..2fbf6e0 100644
--- a
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
>>
>> -AM_CFLAGS = $(LIBPCSCLITE_CFLAGS) +AM_CFLAGS =
>> $(LIBPCSCLITE_CFLAGS) $(LIBCACARD_CFLAGS)
>
> A bit surprised that this is not libspiceccid_la_CFLAGS
Yeah, I'm afraid I'm at least one level of auto foo behind the times.
Sending a v2.
Che
Also shift to libspiceccid_la_CFLAGS.
Signed-off-by: Jeremy White
---
src/spiceccid/Makefile.am | 5 ++---
src/spiceccid/spiceccid.c | 2 +-
2 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/src/spiceccid/Makefile.am b/src/spiceccid/Makefile.am
index 437e992..7f662fe 100644
--- a
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
>>
>> static void spiceqxl_uinput_read_cb(int fd, int event, void
>> *opaque) { @@ -30,14 +31,20 @@ static void
>> spiceqxl_uinput_read_cb(int fd, int event, void *opaque) static
>> int y = -1; static int buttons_state = 0; int button = -1; +
>> qxl_
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 10/16/2015 11:04 AM, Christophe Fergeau wrote:
> On Fri, Oct 02, 2015 at 11:21:03AM -0500, Jeremy White wrote:
>> Signed-off-by: Jeremy White ---
>> examples/spiceqxl.xorg.conf.example | 24
>> ++
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
> The code changes correspond to what this log describes, but why is
> it better to defer enabling the agent to on_connect()?
I've done more digging, and I think I missed the larger flaw on this
issue. That is, rather than enabling/disabling the mous
Also revise the expression of the default value to be consistent.
Signed-off-by: Jeremy White
---
examples/spiceqxl.xorg.conf.example | 61 ++---
1 file changed, 43 insertions(+), 18 deletions(-)
diff --git a/examples/spiceqxl.xorg.conf.example
b/examples
Otherwise, you constantly spin loop, getting a return code of 0,
and pegging CPU usage at 100%.
Signed-off-by: Jeremy White
---
src/spiceqxl_uinput.c | 13 -
src/spiceqxl_uinput.h | 1 +
src/spiceqxl_vdagent.c | 2 ++
3 files changed, 15 insertions(+), 1 deletion(-)
diff --git
This means that we do not attempt to use agent mouse
mode if there is no connected agent.
It fixes a bug which would occur if an agent disconnected
after session startup which would result in having no
useful mouse.
Signed-off-by: Jeremy White
---
src/spiceqxl_vdagent.c | 7 +--
1 file
This patch series is a set of minor patches for XSpice around vdagent support.
It improves the documentation of the options, corrects an option that did
not work as expected, and handles an agent disconnection more intelligently.
The code changes in this second version are substantially different
default; that matches qemu, and effectively
preserves the current default behavior.
Signed-off-by: Jeremy White
---
examples/spiceqxl.xorg.conf.example | 6 +++---
src/qxl_driver.c| 3 +--
src/spiceqxl_uinput.c | 1 -
3 files changed, 4 insertions(+), 6 deletions
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 10/20/2015 07:14 AM, Christophe Fergeau wrote:
> On Mon, Oct 19, 2015 at 02:33:56PM -0500, Jeremy White wrote:
>> Otherwise, you constantly spin loop, getting a return code of 0,
>> and pegging CPU usage at 100%.
>>
>>
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
>> # A unix domain name for a unix domain socket # to communicate
>> with a spiceccid smartcard driver +# Default is not to use a
>> smartcard driver. #Option "SpiceSmartCardFile"
>> "/tmp/spice.pcsc.comm"
>
> This one is not default: xxx, dunno
Otherwise, you constantly spin loop, getting a return code of 0,
and pegging CPU usage at 100%.
Signed-off-by: Jeremy White
---
This differs from v2 in that it groups the static handle with the
other static variables in the file. It also now always disables
any existing watch, even if a new
Signed-off-by: Jeremy White
---
scripts/Xspice | 11 +--
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/scripts/Xspice b/scripts/Xspice
index a6913a8..33f02d1 100755
--- a/scripts/Xspice
+++ b/scripts/Xspice
@@ -92,6 +92,7 @@ add_boolean('--ipv6-only')
parser.ad
Signed-off-by: Jeremy White
---
scripts/Xspice | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/scripts/Xspice b/scripts/Xspice
index 52b1b16..a6913a8 100755
--- a/scripts/Xspice
+++ b/scripts/Xspice
@@ -61,6 +61,7 @@ parser.add_argument('--config'
Signed-off-by: Jeremy White
---
scripts/Xspice | 26 +++---
1 file changed, 23 insertions(+), 3 deletions(-)
diff --git a/scripts/Xspice b/scripts/Xspice
index 33f02d1..644887c 100755
--- a/scripts/Xspice
+++ b/scripts/Xspice
@@ -90,9 +90,9 @@ parser.add_argument
The work Pavel did on spice.html did not get fully transferred
into spice_auto.html; in particular, we need to append the xfer
div to the main area in order for file transfer to work.
This fixes that, and now drag + drop works in spice_auto.html.
Signed-off-by: Jeremy White
---
spice_auto.html
On 10/29/2015 06:38 AM, j...@eyeos.com wrote:
> Hi,
>
> We are very glad to announce that today we have released under AGPL3
> license our full featured (audio, video, clipboard, qxl advanced
> graphics, etc) spice web client.
>
> The github of the project:
>
> https://github.com/eyeos/spice-web
This fixes a bug where Xspice had to listen on two ports, even in an
SSL only configuration.
Signed-off-by: Jeremy White
---
examples/spiceqxl.xorg.conf.example | 1 +
src/spiceqxl_spice_server.c | 1 -
2 files changed, 1 insertion(+), 1 deletion(-)
diff --git a/examples
o the SASL implemented.
This includes a limited implementation of the WebSocket protocol,
sufficient for our purposes.
Signed-off-by: Jeremy White
---
server/Makefile.am | 2 +
server/reds.c| 6 +
server/reds_stream.c | 98
server/reds_stream.h | 2 +
server/websocket
On 10/30/2015 07:24 AM, j...@eyeos.com wrote:
>> Wow! That is astonishing, and well done, congratulations.
>>
>>
>> I've played with it a bit; I had some issues with keyboard problems, and
>> it wasn't immediately obvious how to use passwords or ssl. Of course, I
>> suspect those are issues that
On 11/01/2015 09:55 AM, Uri Lublin wrote:
> On 10/30/2015 05:45 PM, Jeremy White wrote:
>> This fixes a bug where Xspice had to listen on two ports, even in an
>> SSL only configuration.
>>
>> Signed-off-by: Jeremy White
>
> Ack.
Thanks. Pushed, with typo s/di
e exercised if
we've found the Sec-WebSocket-Key already.
>
>> +sprintf(outbuf, "HTTP/1.1 101 Switching Protocols\r\n"
>> + "Upgrade: websocket\r\n"
>> +"Connection: Upgrade\r\n"
>> +
Signed-off-by: Jeremy White
---
scripts/Xspice | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/Xspice b/scripts/Xspice
index 52b1b16..46c5c1e 100755
--- a/scripts/Xspice
+++ b/scripts/Xspice
@@ -256,7 +256,7 @@ var_args = ['port', 'tls_port'
On 11/03/2015 04:32 AM, Daniel P. Berrange wrote:
> On Fri, Oct 30, 2015 at 03:52:56PM -0500, Jeremy White wrote:
>> We do this by auto detecting the inbound http(s) 'GET' and probing
>> for a well formulated WebSocket binary connection, such as used
>> by the spice
As of commit f73ca7e4cc090772652611a4e2b8b95ae64319bc, you can now
disable the regular port by specifying 0. This change to the Xspice
script permits us to take advantage of that change.
Signed-off-by: Jeremy White
---
Since v1: Commit message expanded to explain why this is useful
This patch causes my v0.30-9-g17a6b8a vintage spice-gtk client stop
having a cursor in an Xspice session.
The spice-html5 client cursor continues to work fine.
I've bisected it, but not really explored further; if there are
easy/obvious things for me to check, let me know.
Cheers,
Jeremy
On 11
o the SASL implemented.
This includes a limited implementation of the WebSocket protocol,
sufficient for our purposes.
Signed-off-by: Jeremy White
---
Changes since v1 (discussed):
- Added comments around the invocation of reds_stream_is_websocket
to explain the rationale for reading the SpiceLinkHe
Gah, missed a potential problem.
> +int websocket_write(void *opaque, const guchar *buf, int len, guint64
> *remainder,
> + websocket_write_cb_t write_cb)
> +{
> +guint8 header[WEBSOCKET_MAX_HEADER_SIZE];
> +int rc;
> +int header_len;
> +
> +memset(header, 0, sizeof(header
o the SASL implementation.
This includes a limited implementation of the WebSocket protocol,
sufficient for our purposes.
Signed-off-by: Jeremy White
---
Changes since v2:
- Handle a prior partial write in our cover function more correctly
- Fix a slight typo in the commit comment s/implemented/impl
On 11/04/2015 11:37 AM, Gianni Pirozzi wrote:
> Hello,
> thanks for open sourcing spice web client, I just tried it and it solves most
> of our problems :)
>
> In my tests there is always a rectangular area at the top-left of the screen
> (866x78px), inside of which the pointer has a "text selec
>> +if args.vdagent_enabled:
>> +for f in [args.vdagent_udcs_path, args.vdagent_virtio_path,
>> args.vdagent_uinput_path]:
>> +if f and os.path.exists(f):
>> +os.unlink(f)
>> +
>> +if not cf:
>> +cf = tempfile.NamedTemporaryFile(prefix="Xspice-vdagent-",
>> del
Signed-off-by: Jeremy White
---
Changes since v1:
- Use a temporary directory, not merely extending the name of
a single temporary file.
---
scripts/Xspice | 25 ++---
1 file changed, 22 insertions(+), 3 deletions(-)
diff --git a/scripts/Xspice b/scripts/Xspice
index
We will put auto session related items in that directory.
Signed-off-by: Jeremy White
---
scripts/Xspice | 19 +++
1 file changed, 15 insertions(+), 4 deletions(-)
diff --git a/scripts/Xspice b/scripts/Xspice
index 7414721..5941f4f 100755
--- a/scripts/Xspice
+++ b/scripts
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 11/16/2015 10:32 AM, Christophe Fergeau wrote:
> On Mon, Nov 16, 2015 at 05:27:01PM +0100, Christophe Fergeau
> wrote:
>> Looks good, ACK.
>
> I have pushed these 2 patches as I had them locally applied
> anyway.
Great, thanks.
Funny story: you
nahamu on #spice asked for some pointers to getting XSpice audio working.
Making this automatic in the XSpice script itself is still on my todo
list. I'm afraid it is fiddly. The easy part is getting Xspice to send
audio placed in a file across the wire; the hard part is getting
pulseaudio to pu
We don't need to update the screen when we use a temporary or
offscreen pixmap.
Signed-off-by: Jeremy White
---
src/dfps.c | 20
1 file changed, 16 insertions(+), 4 deletions(-)
diff --git a/src/dfps.c b/src/dfps.c
index f113f27..fe0f09e 100644
--- a/src/dfps.c
+++
This prevents the fallback from calling prepare_access
against the whole screen, which in turn keeps us from
transmitting the whole screen more than necessary.
Signed-off-by: Jeremy White
---
src/dfps.c | 13 ++---
1 file changed, 10 insertions(+), 3 deletions(-)
diff --git a/src
I've spent another week doing some analysis of XSpice performance. This
is probably interesting mostly to me, but I thought I'd share the
results for posterity.
I was primarily concerned with performance connecting to a distant
server and spent some energy optimizing for that case.
I've used a m
>> I'm trying to build an 0.12.6 spice server and I'd like to fix this
>> issue, so I can't use this patch as it is.
>>
>> I spent some time trying to identify what change seems to help, and the
>> attached patch seems to solve the problem.
>>
>> I'm hoping that someone smarter than me can kibitz o
701 - 800 of 840 matches
Mail list logo
