On Fri, Dec 6, 2019 at 12:06 PM Frediano Ziglio wrote:
> >
> > From: Alexander Nezhinsky
> > +rc = spice_usb_device_manager_create_shared_cd_device(m,
> > *name, &err);
> > +if (!rc) {
> > +
On Fri, Dec 6, 2019 at 12:12 PM Frediano Ziglio wrote:
>
> In the title I would say "Factor out" instead of "Implement
OK
> +static void spice_usb_device_widget_add_err_msg(SpiceUsbDeviceWidget
> *self,
> > +gchar *new_err_msg)
>
> Why not spice_
On Fri, Dec 6, 2019 at 12:18 PM Frediano Ziglio wrote:
> >
> > +
> > +if (gtk_toggle_button_get_active(toggle))
> > +gtk_toggle_button_set_active(toggle, FALSE);
>
> style: always use brackets, here and below
>
> OK
> > +else
> > +return;
>
> I would handle the return in
On Fri, Dec 6, 2019 at 12:32 PM Frediano Ziglio wrote:
> >
> > From: Alexander Nezhinsky
> >
> > Some corner error scenarios may leave dangling not connected shared CD
> > devices.
> > As the current flow precludes maintenance of such devices, it may be
>
On Fri, Dec 6, 2019 at 12:04 PM Frediano Ziglio wrote:
>
> > +gboolean
> > +spice_usb_device_manager_create_shared_cd_device(
> > + SpiceUsbDeviceManager *self,
> > + gchar
> *filename,
> > +
On Fri, Dec 6, 2019 at 12:30 PM Frediano Ziglio wrote:
>
> > > By default command line devices are added using 'redirect-on-connect'
> filter,
> > > which do not fit the shard CD connecting requirements.
>
> > Can you describe the requirements here?
>
> On Fri, Dec 6, 2019 at 1:57 PM Yuri Bendit
On Sat, Dec 7, 2019 at 12:20 PM Alexander Nezhinsky
wrote:
>
> On Fri, Dec 6, 2019 at 12:04 PM Frediano Ziglio
> wrote:
>
> > +bdev = spice_usb_device_manager_device_to_bdev(self, device);
>>
>> see below
>>
>> > +#ifdef USE_USBREDIR
>> >
