On Fri, Dec 6, 2019 at 12:06 PM Frediano Ziglio <fzig...@redhat.com> wrote:
> > > > From: Alexander Nezhinsky <anezh...@redhat.com> > > + rc = spice_usb_device_manager_create_shared_cd_device(m, > > *name, &err); > > + if (!rc) { > > + if (!err) > > minor: err == NULL > OK > > > + g_warning("Failed to create shared CD device > %s", > > + else > > + g_warning("Failed to create shared CD device %s: > > style: always brackets > Sure > > as you check for err above you can include in the else. > OK
_______________________________________________ Spice-devel mailing list Spice-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/spice-devel