Signed-off-by: Frediano Ziglio
---
server/dcc.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/server/dcc.c b/server/dcc.c
index a5a1b40..3d3ac8e 100644
--- a/server/dcc.c
+++ b/server/dcc.c
@@ -593,7 +593,8 @@ RedPipeItem *dcc_gl_draw_item_new(RedChannelClient *rcc,
void
>
> ---
> server/Makefile.am| 2 +
> server/smartcard-channel-client.c | 300 +++
> server/smartcard-channel-client.h | 96 ++
> server/smartcard.c| 360
> ++
> server/smartcard.h
Isn't this already tested somewhere else before reaching this place? Not
really opposed to the patch, but knowing how this can be hit would
probably be useful.
Christophe
On Tue, Sep 27, 2016 at 09:44:16AM +0100, Frediano Ziglio wrote:
> Signed-off-by: Frediano Ziglio
> ---
> server/dcc.c | 3 +
Hey,
A huge part of this patch is adding +__declspec(code_seg("PAGE")) (and
removing #pragma code_seg()), which are probably related to this macro,
but which are added with no rationale.
The shortlog should probably be something different than "code analysis
fix", but more somethnig like "Use PAG
>
> Convert the RedChannelClient heirarchy into GObjects. Since the existing
> constructors could fail and return NULL, I inherited the base channel
> client from GInitable, which introduces a dependency on gio.
>
> When using private structs with GObject, there's a maximum size of (I
> think) 64
On Mon, Sep 26, 2016 at 04:00:05PM +0300, Sameeh Jubran wrote:
> Disable execution bit on mapping improving security.
>
> MmMapIoSpaceEx is available only in Windows 10 thus
> the macros are used.
Hey, looks good to me. Just one question, by default if this is built on
a Windows 10 system, I gues
> On 27 Sep 2016, at 12:51 PM, Christophe Fergeau wrote:
>
> On Mon, Sep 26, 2016 at 04:00:05PM +0300, Sameeh Jubran wrote:
>> Disable execution bit on mapping improving security.
>>
>> MmMapIoSpaceEx is available only in Windows 10 thus
>> the macros are used.
>
> Hey, looks good to me. Just
Hey,
On Tue, Sep 27, 2016 at 12:57:33PM +0300, Dmitry Fleytman wrote:
>
> > On 27 Sep 2016, at 12:51 PM, Christophe Fergeau wrote:
> >
> > On Mon, Sep 26, 2016 at 04:00:05PM +0300, Sameeh Jubran wrote:
> >> Disable execution bit on mapping improving security.
> >>
> >> MmMapIoSpaceEx is availa
>
> Isn't this already tested somewhere else before reaching this place? Not
> really opposed to the patch, but knowing how this can be hit would
> probably be useful.
>
> Christophe
>
Currently this is simply avoided by the fact that Virgl with 3d means
Unix socket. Once you enable (in Qemu) t
> On 27 Sep 2016, at 12:35 PM, Christophe Fergeau wrote:
>
> Hey,
>
> A huge part of this patch is adding +__declspec(code_seg("PAGE")) (and
> removing #pragma code_seg()), which are probably related to this macro,
> but which are added with no rationale.
> The shortlog should probably be some
> On 27 Sep 2016, at 13:00 PM, Christophe Fergeau wrote:
>
> Hey,
>
> On Tue, Sep 27, 2016 at 12:57:33PM +0300, Dmitry Fleytman wrote:
>>
>>> On 27 Sep 2016, at 12:51 PM, Christophe Fergeau wrote:
>>>
>>> On Mon, Sep 26, 2016 at 04:00:05PM +0300, Sameeh Jubran wrote:
Disable execution b
> > On 27 Sep 2016, at 13:00 PM, Christophe Fergeau < cferg...@redhat.com >
> > wrote:
>
> > Hey,
>
> > On Tue, Sep 27, 2016 at 12:57:33PM +0300, Dmitry Fleytman wrote:
>
> > > > On 27 Sep 2016, at 12:51 PM, Christophe Fergeau < cferg...@redhat.com >
> > > > wrote:
> > >
> >
>
> > > > On
On Tue, Sep 27, 2016 at 06:01:28AM -0400, Frediano Ziglio wrote:
> >
> > Isn't this already tested somewhere else before reaching this place? Not
> > really opposed to the patch, but knowing how this can be hit would
> > probably be useful.
> >
> > Christophe
> >
>
> Currently this is simply av
On Tue, Sep 27, 2016 at 01:01:22PM +0300, Dmitry Fleytman wrote:
>
> > On 27 Sep 2016, at 12:35 PM, Christophe Fergeau wrote:
> >
> > Hey,
> >
> > A huge part of this patch is adding +__declspec(code_seg("PAGE")) (and
> > removing #pragma code_seg()), which are probably related to this macro,
On Tue, Sep 27, 2016 at 06:07:46AM -0400, Frediano Ziglio wrote:
> > > On 27 Sep 2016, at 13:00 PM, Christophe Fergeau < cferg...@redhat.com >
> > > wrote:
> > > On Tue, Sep 27, 2016 at 12:57:33PM +0300, Dmitry Fleytman wrote:
> > > > > On 27 Sep 2016, at 12:51 PM, Christophe Fergeau < cferg...@red
On Mon, Sep 19, 2016 at 10:02:33AM -0500, Jonathon Jongsma wrote:
> The GType will be useful to allow these enums to be used as GObject
> properties.
Acked-by: Christophe Fergeau
Christophe
signature.asc
Description: PGP signature
___
Spice-devel mai
On Mon, Sep 26, 2016 at 09:12:36AM +0100, Frediano Ziglio wrote:
> Signed-off-by: Frediano Ziglio
> ---
> server/stream.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/server/stream.c b/server/stream.c
> index 9d878c8..95ff015 100644
> --- a/server/stream.c
> +++ b/server/stream.c
On Mon, Sep 26, 2016 at 09:12:39AM +0100, Frediano Ziglio wrote:
> Attempt to use consistent naming.
> Usually we use surface name for RedSurface so make sure
> code reader do not get confused using a different name
> for RedSurfaceCmd.
Yup, definitely. Or alternatively just "cmd", I'm not sure ho
>
> On Mon, Sep 26, 2016 at 09:12:39AM +0100, Frediano Ziglio wrote:
> > Attempt to use consistent naming.
> > Usually we use surface name for RedSurface so make sure
> > code reader do not get confused using a different name
> > for RedSurfaceCmd.
>
> Yup, definitely. Or alternatively just "cmd"
On Tue, Sep 27, 2016 at 06:42:24AM -0400, Frediano Ziglio wrote:
> >
> > On Mon, Sep 26, 2016 at 09:12:39AM +0100, Frediano Ziglio wrote:
> > > Attempt to use consistent naming.
> > > Usually we use surface name for RedSurface so make sure
> > > code reader do not get confused using a different na
On Mon, Sep 26, 2016 at 09:12:42AM +0100, Frediano Ziglio wrote:
> vdi_port_read_buf_release is registered passing data as
> RedVDIReadBuf*, not RedPipeItem*. Cast opaque to proper
> pointer type to avoid the assumption that first field of
> RedVDIReadBuf is a RedPipeItem.
Well, the idea is that V
On Mon, Sep 26, 2016 at 09:12:41AM +0100, Frediano Ziglio wrote:
> Signed-off-by: Frediano Ziglio
> ---
> server/red-channel-client-private.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/server/red-channel-client-private.h
> b/server/red-channel-client-private.h
> index 46d4fca..804
Acked-by: Christophe Fergeau
though I'd use enum value, named constant, ... in the log rather than
mnemonic.
On Mon, Sep 26, 2016 at 09:12:44AM +0100, Frediano Ziglio wrote:
> Signed-off-by: Frediano Ziglio
> ---
> server/spice-bitmap-utils.c | 2 +-
> 1 file changed, 1 insertion(+), 1 delet
Commit log could mention that this can now be used because of the
previous commit which did s/surface/surface_cmd (but it's also ok
unchanged).
Acked-by: Christophe Fergeau
On Mon, Sep 26, 2016 at 09:12:40AM +0100, Frediano Ziglio wrote:
> Attempt to use consistent naming.
> Usually we use surfa
Disable execution bit on mapping improving security.
MmMapIoSpaceEx is available only in Windows 10 thus
the macros are used.
Based on a patch by Sandy Stutsman
Signed-off-by: Sameeh Jubran
---
qxldod/QxlDod.cpp | 16 +++--
qxldod/compat.cpp | 52 ++
>
> On Mon, Sep 26, 2016 at 09:12:41AM +0100, Frediano Ziglio wrote:
> > Signed-off-by: Frediano Ziglio
> > ---
> > server/red-channel-client-private.h | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/server/red-channel-client-private.h
> > b/server/red-channel-client-private.h
>
On Mon, Sep 26, 2016 at 09:12:48AM +0100, Frediano Ziglio wrote:
> This could have happened if mremap failed.
If mremap fails, reds_stat will be set to MAP_FAILED, so munmap will
not be called.
Christophe
>
> Signed-off-by: Frediano Ziglio
> ---
> tools/reds_stat.c | 8
> 1 file cha
>
> On Mon, Sep 26, 2016 at 09:12:42AM +0100, Frediano Ziglio wrote:
> > vdi_port_read_buf_release is registered passing data as
> > RedVDIReadBuf*, not RedPipeItem*. Cast opaque to proper
> > pointer type to avoid the assumption that first field of
> > RedVDIReadBuf is a RedPipeItem.
>
> Well, t
>
> On Tue, Sep 27, 2016 at 06:42:24AM -0400, Frediano Ziglio wrote:
> > >
> > > On Mon, Sep 26, 2016 at 09:12:39AM +0100, Frediano Ziglio wrote:
> > > > Attempt to use consistent naming.
> > > > Usually we use surface name for RedSurface so make sure
> > > > code reader do not get confused using
>
> On Mon, Sep 26, 2016 at 09:12:36AM +0100, Frediano Ziglio wrote:
> > Signed-off-by: Frediano Ziglio
> > ---
> > server/stream.c | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/server/stream.c b/server/stream.c
> > index 9d878c8..95ff015 100644
> > --- a/server/stream.c
> >
This function deal only with Stream.
Also the name was misleading and was not clear if it detached the stream
from the DisplayChannel.
Signed-off-by: Frediano Ziglio
---
server/display-channel.c | 2 +-
server/stream.c | 14 +++---
server/stream.h | 2 +-
3 files chan
On Mon, Sep 26, 2016 at 09:12:46AM +0100, Frediano Ziglio wrote:
> Signed-off-by: Frediano Ziglio
> ---
> Makefile.am | 2 +-
> configure.ac | 1 +
> tools/Makefile.am | 19 +++
> 3 files changed, 21 insertions(+), 1 deletion(-)
> create mode 100644 tools/Makefile.am
On Mon, Sep 26, 2016 at 09:12:45AM +0100, Frediano Ziglio wrote:
> Signed-off-by: Frediano Ziglio
> ---
> tools/reds_stat.c | 13 -
> 1 file changed, 8 insertions(+), 5 deletions(-)
>
> diff --git a/tools/reds_stat.c b/tools/reds_stat.c
> index 5e9705c..07fd732 100644
> --- a/tools/r
On Tue, 2016-09-27 at 14:49 +0200, Christophe Fergeau wrote:
> On Mon, Sep 26, 2016 at 09:12:45AM +0100, Frediano Ziglio wrote:
> > Signed-off-by: Frediano Ziglio
> > ---
> > tools/reds_stat.c | 13 -
> > 1 file changed, 8 insertions(+), 5 deletions(-)
> >
> > diff --git a/tools/reds
On Mon, Sep 26, 2016 at 09:12:50AM +0100, Frediano Ziglio wrote:
> Signed-off-by: Frediano Ziglio
> ---
> server/main-channel-client.c | 3 ---
> server/reds-private.h| 1 -
> server/reds.c| 13 -
> server/stat.h| 1 -
> 4 files changed, 18 d
On Tue, Sep 27, 2016 at 08:34:51AM -0400, Frediano Ziglio wrote:
> >
> > On Tue, Sep 27, 2016 at 06:42:24AM -0400, Frediano Ziglio wrote:
> > > >
> > > > On Mon, Sep 26, 2016 at 09:12:39AM +0100, Frediano Ziglio wrote:
> > > > > Attempt to use consistent naming.
> > > > > Usually we use surface n
On Tue, Sep 27, 2016 at 02:56:44PM +0200, Pavel Grunt wrote:
> On Tue, 2016-09-27 at 14:49 +0200, Christophe Fergeau wrote:
> > On Mon, Sep 26, 2016 at 09:12:45AM +0100, Frediano Ziglio wrote:
> > > while (1) {
> > > -system("clear");
> > > +ignore_result(system("clear"));
> >
Acked-by: Christophe Fergeau
On Mon, Sep 26, 2016 at 09:12:49AM +0100, Frediano Ziglio wrote:
> Signed-off-by: Frediano Ziglio
> ---
> server/cursor-channel.c | 4
> 1 file changed, 4 deletions(-)
>
> diff --git a/server/cursor-channel.c b/server/cursor-channel.c
> index 05b8942..3e1e9f2
Acked-by: Christophe Fergeau
On Tue, Sep 27, 2016 at 01:42:04PM +0100, Frediano Ziglio wrote:
> This function deal only with Stream.
> Also the name was misleading and was not clear if it detached the stream
> from the DisplayChannel.
>
> Signed-off-by: Frediano Ziglio
> ---
> server/display-
>
> On Tue, Sep 27, 2016 at 02:56:44PM +0200, Pavel Grunt wrote:
> > On Tue, 2016-09-27 at 14:49 +0200, Christophe Fergeau wrote:
> > > On Mon, Sep 26, 2016 at 09:12:45AM +0100, Frediano Ziglio wrote:
> > > > while (1) {
> > > > -system("clear");
> > > > +ignore_result(system(
Signed-off-by: Frediano Ziglio
---
tools/reds_stat.c | 11 ++-
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/tools/reds_stat.c b/tools/reds_stat.c
index 9aca1ad..3e966d4 100644
--- a/tools/reds_stat.c
+++ b/tools/reds_stat.c
@@ -24,6 +24,7 @@
#include
#include
#includ
>
> On Mon, Sep 26, 2016 at 09:12:48AM +0100, Frediano Ziglio wrote:
> > This could have happened if mremap failed.
>
> If mremap fails, reds_stat will be set to MAP_FAILED, so munmap will
> not be called.
>
> Christophe
>
You are right, dropped
Frediano
> >
> > Signed-off-by: Frediano Zig
Ok. Sending.
On Mon, Sep 26, 2016 at 2:54 PM, Frediano Ziglio wrote:
> >
> > ---
> > enums.js| 11 +++-
> > main.js | 5 +++-
> > port.js | 85
> > +
> > spice.html | 50 +++--
---
README | 4 ++--
TODO| 2 +-
cursor.js | 2 +-
display.js | 36 ++--
enums.js| 2 +-
main.js | 2 +-
playback.js | 2 +-
simulatecursor.js | 6 +++---
spice.css |
---
enums.js| 9 ++
main.js | 3 ++
port.js | 85 +
spice.html | 10 +++
spice_auto.html | 10 +++
spicemsg.js | 18
utils.js| 7 +
7 files changed, 142 insertions(+)
c
45 matches
Mail list logo
