> On 27 Sep 2016, at 13:00 PM, Christophe Fergeau <cferg...@redhat.com> wrote: > > Hey, > > On Tue, Sep 27, 2016 at 12:57:33PM +0300, Dmitry Fleytman wrote: >> >>> On 27 Sep 2016, at 12:51 PM, Christophe Fergeau <cferg...@redhat.com> wrote: >>> >>> On Mon, Sep 26, 2016 at 04:00:05PM +0300, Sameeh Jubran wrote: >>>> Disable execution bit on mapping improving security. >>>> >>>> MmMapIoSpaceEx is available only in Windows 10 thus >>>> the macros are used. >>> >>> Hey, looks good to me. Just one question, by default if this is built on >>> a Windows 10 system, I guess MmMapIoSpaceEx is going to be used. However >>> we can override NTDDI_VERSION to WIN8 if we want to build a driver which >>> is going to work on both win8 and win10? Or is this working differently? >> >> Hi Christophe, >> >> Driver is built using WDK toolset for a specific OS. >> There are WDK toolsets for windows 10, Windows 8.1, Windows 8 etc. >> NTDDI_VERSION defined by the toolset in accordance to target OS. >> >> Currently we build with Windows 10 toolset only, but in future we may >> decide to build with Windows 8 or 8.1 toolset as well. > > Ah ok, so no "universal" driver, we'll need to have distinct 8, 8.1 and > 10 drivers if we wan tto support all 3 versions?
There is backward compatibility, so one may use windows 8 driver for all systems, but it is preferable to use separate “natively compiled” binaries. > > Christophe
_______________________________________________ Spice-devel mailing list Spice-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/spice-devel
