Re: [Spice-devel] [PATCH RFC EXP] remote Virgl support

2016-06-29 Thread Dave Airlie
On 29 June 2016 at 00:46, Frediano Ziglio wrote: > This patch is really hacky and mainly intended to try to use the > current spice-protocol to make Virgl remote. > It does in a fast (as code lines) way: > - extract the images from scanouts; > - fed these images to normal flow (using display_chann

Re: [Spice-devel] [PATCH RFC EXP] remote Virgl support

2016-06-29 Thread Gerd Hoffmann
Hi, > Yes you want to use EGL here, I think we could probably put more code in qemu > to help with this case. Sure, if anything is needed we'll get that sorted ;) I suspect spice-server needs access to the gl context helpers (dpy_gl_ctx_*) if it wants use opengl. Possibly it also wasn't the m

Re: [Spice-devel] [PATCH v2 2/2] Add some debugging for GlzDictItem structure

2016-06-29 Thread Pavel Grunt
Hi Frediano, On Wed, 2016-06-22 at 16:19 +0100, Frediano Ziglio wrote: > Signed-off-by: Frediano Ziglio > --- >  server/image-encoders.c | 29 - >  1 file changed, 28 insertions(+), 1 deletion(-) > > diff --git a/server/image-encoders.c b/server/image-encoders.c > inde

[Spice-devel] [spice-gtk 1/3] usbredir: Fix GTask leak

2016-06-29 Thread Christophe Fergeau
spice_usbredir_channel_disconnect_device_async() creates a GTask and then calls g_task_run_in_thread(). This method will take the reference it needs on the GTask, it does not take ownership of the passed-in GTask. This means we need to unref the GTask we created after calling g_task_run_in_thread()

[Spice-devel] [spice-gtk 3/3] usb-device-manager: Fix USB event thread leak

2016-06-29 Thread Christophe Fergeau
When using USB redirection, it's fairly easy to leak the thread handling USB events, which will eventually cause problems in long lived apps. In particular, in virt-manager, one can: - start a VM - connect to it with SPICE - open the USB redirection window - redirect a device - close the SPICE wind

[Spice-devel] [spice-gtk 2/3] usbredir: Use atomic for UsbDeviceManager::event_thread_run

2016-06-29 Thread Christophe Fergeau
This variable is accessed from 2 different threads (main thread and USB event thread), so some care must be taken to read/write it. --- src/usb-device-manager.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/usb-device-manager.c b/src/usb-device-manager.c index 1fc8f

Re: [Spice-devel] [PATCH v2 2/2] Add some debugging for GlzDictItem structure

2016-06-29 Thread Frediano Ziglio
> > Hi Frediano, > > On Wed, 2016-06-22 at 16:19 +0100, Frediano Ziglio wrote: > > Signed-off-by: Frediano Ziglio > > --- > >  server/image-encoders.c | 29 - > >  1 file changed, 28 insertions(+), 1 deletion(-) > > > > diff --git a/server/image-encoders.c b/server/im

Re: [Spice-devel] [spice-gtk 1/3] usbredir: Fix GTask leak

2016-06-29 Thread Marc-André Lureau
ack - Original Message - > spice_usbredir_channel_disconnect_device_async() creates a GTask and > then calls g_task_run_in_thread(). This method will take the reference > it needs on the GTask, it does not take ownership of the passed-in > GTask. This means we need to unref the GTask we cr

[Spice-devel] [PATCH spice-gtk] usbredir: mark some functions as internal

2016-06-29 Thread marcandre . lureau
From: Marc-André Lureau For the sake of making clear those are not exported. Signed-off-by: Marc-André Lureau --- src/channel-usbredir.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/channel-usbredir.c b/src/channel-usbredir.c index 2c5feae..74e8df0 100644 --- a/src/channel-usbred

Re: [Spice-devel] [spice-gtk 2/3] usbredir: Use atomic for UsbDeviceManager::event_thread_run

2016-06-29 Thread Marc-André Lureau
Hi - Original Message - > This variable is accessed from 2 different threads (main thread and USB > event thread), so some care must be taken to read/write it. > --- event_thread_run is a bool, you should make it a gint, probably even volatile. > src/usb-device-manager.c | 6 +++--- >

Re: [Spice-devel] [spice-gtk v4 06/24] file-xfer: introduce functions to read file async

2016-06-29 Thread Jonathon Jongsma
On Sat, 2016-06-25 at 10:56 +0200, Victor Toso wrote: > > > + > > > +/* The progress here means the amount of data we have _read_ and not > what > > > + * was actually sent to the agent. On the next "progress", the > previous > > > data > > > + * read was sent. This means that when user

Re: [Spice-devel] [spice-gtk v4 08/24] main: let channel-main handle file-xfer messages

2016-06-29 Thread Jonathon Jongsma
On Sat, 2016-06-25 at 12:14 +0200, Victor Toso wrote: > > > > +static void file_xfer_handle_status(SpiceMainChannel *channel, > > > > +VDAgentFileXferStatusMessage *msg) > > >  > > > since it's moving back to a channel function. perhaps a name like > > >  > > > m

Re: [Spice-devel] [spice-gtk v4 14/24] file-xfer: call progress_callback per FileTransferOperation

2016-06-29 Thread Jonathon Jongsma
On Tue, 2016-06-28 at 14:39 +0200, Victor Toso wrote: > Hi, > > On Mon, Jun 27, 2016 at 11:27:38AM -0500, Jonathon Jongsma wrote: > > > > On Thu, 2016-06-23 at 19:37 +0200, Victor Toso wrote: > > > > > > Before this patch, the progress_callback is being called from > > > SpiceFileTransferTask ea

Re: [Spice-devel] [spice-gtk 2/3] usbredir: Use atomic for UsbDeviceManager::event_thread_run

2016-06-29 Thread Hans de Goede
Hi, On 29-06-16 17:42, Christophe Fergeau wrote: This variable is accessed from 2 different threads (main thread and USB event thread), so some care must be taken to read/write it. The event-thread only reads it, so I believe there is no need for this. Regards, Hans --- src/usb-device-ma

Re: [Spice-devel] [spice-gtk 3/3] usb-device-manager: Fix USB event thread leak

2016-06-29 Thread Hans de Goede
Hi, On 29-06-16 17:42, Christophe Fergeau wrote: When using USB redirection, it's fairly easy to leak the thread handling USB events, which will eventually cause problems in long lived apps. In particular, in virt-manager, one can: - start a VM - connect to it with SPICE - open the USB redirecti

Re: [Spice-devel] [spice-gtk v4 14/24] file-xfer: call progress_callback per FileTransferOperation

2016-06-29 Thread Victor Toso
Hi, On Wed, Jun 29, 2016 at 11:41:15AM -0500, Jonathon Jongsma wrote: > On Tue, 2016-06-28 at 14:39 +0200, Victor Toso wrote: > > I'm thinking about it more carefully now and I think I got what you > > mean. It really depends on how read_bytes and transfer_size will be > > used by the API user so,

Re: [Spice-devel] [PATCH spice-gtk] usbredir: mark some functions as internal

2016-06-29 Thread Pavel Grunt
Ack, Pavel On Wed, 2016-06-29 at 17:59 +0200, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > For the sake of making clear those are not exported. > > Signed-off-by: Marc-André Lureau > --- >  src/channel-usbredir.c | 3 +++ >  1 file changed, 3 insertions(+) > > diff --git a/

Re: [Spice-devel] Help :Build error of "You must run autogen.sh or configure --enable vala"

2016-06-29 Thread 小泉
Hi I appreciate your answer! I could not solve my configure error when I did "dnf builddep mingw-spice-gtk" only. But I solved my error after I did "mingw32-configure --prefix=$INST_ROOT --disable-vala --disable-controller"too. So I am trying to build vi

[Spice-devel] Help :Build error of "At least one of spice or vnc must be used"

2016-06-29 Thread 小泉
Hi all, I am sorry to post many questions into this ML. I am not familiar with developing on Linux. So I need your professional help. In this mail, I would like to know about error when I build virt-viewer for Windows on my fedora based on following instruction.