On Sat, 2016-06-25 at 12:14 +0200, Victor Toso wrote: > > > > +static void file_xfer_handle_status(SpiceMainChannel *channel, > > > > + VDAgentFileXferStatusMessage *msg) > > > > > > since it's moving back to a channel function. perhaps a name like > > > > > > main_channel_handle_xfer_status()?? > > > > Indeed, file_xfer_ namespace and handling VDAgent messages are not > > exactly compatible. > > > > main_handle_ is used for channel-main messages with > > main_agent_handle_msg being a helper for a helper for > > main_agent_handle_msg. > > I mean: > main_handle_ -> namespace for channel-main msg handler > main_agent_handle_msg() -> helper for main_handle_agent_data() > > > > > file_xfer_handle_status is a helper of main_agent_handle_msg so I would > > go for main_agent_handle_xfer_status() ? > > main_agent_handle_xfer_status() -> helper for main_agent_handle_msg()
Sounds good _______________________________________________ Spice-devel mailing list Spice-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/spice-devel
